This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
sorry - i've been in the midst of releasing TinkerPop so i haven't had a chance
to take a look at this yet. i can probably get to this by the end of the week.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1029 ]
This message was relayed via gitbox.apache.org for dev@tinker
https://issues.apache.org/jira/browse/TINKERPOP-2124
Fixed the bug, added a test case.
`docker/build.sh -t -i -n` passed.
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1030 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
We only deserialize those types as a dict. Also, this should probably target
tp34 when created.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1031 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
https://issues.apache.org/jira/browse/TINKERPOP-2124
Fixed the bug, added a test case.
docker/build.sh -t -i -n passed.
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1032 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
`ThreadLocal.withInitial(ArrayDeque::new)` to follow the previous patterns.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1029 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
`ThreadLocal.withInitial(ArrayList::new)`
[ Full content available at: https://github.com/apache/tinkerpop/pull/1029 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
Thank you, fixed.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1029 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
Thank you, fixed.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1029 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
retest this please
[ Full content available at: https://github.com/apache/tinkerpop/pull/1029 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
> retest this please
I just triggered a new build on Travis.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1029 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
If we have to make these sorts of changes, I think that this PR should target
the `tp33` branch so that both of our release branches have the same consistent
look to them.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1029 ]
This message was relayed via gitbox.apache.org
@spmallette to review
[ Full content available at: https://github.com/apache/tinkerpop/pull/1031 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[ Full content available at: https://github.com/apache/tinkerpop/pull/1033 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[ Full content available at: https://github.com/apache/tinkerpop/pull/1034 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
https://issues.apache.org/jira/browse/TINKERPOP-2126
This PR replaces the `LinkedHashMap` used by `TraverserSet` with a
`SynchronizedMap`. I haven't added a test case, cause I really don't know how
to consistently provoke a `ConcurrentModificationException`; however, a
`ConcurrentModificationEx
This is ready for review. `explain()` doesn't exist in gremlinpython, so
g:TraversalExplanation hasn't been added. I've created
https://issues.apache.org/jira/browse/TINKERPOP-2128 for the purpose of the
missing explain() and check back when it's done.
[ Full content available at: https://githu
https://issues.apache.org/jira/browse/TINKERPOP-2129
NOT READY FOR REVIEW - still testing
[ Full content available at: https://github.com/apache/tinkerpop/pull/1036 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
closed in favor of #1036
[ Full content available at: https://github.com/apache/tinkerpop/pull/1033 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[ pull request closed by spmallette ]
[ Full content available at: https://github.com/apache/tinkerpop/pull/1033 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
closed in favor of #1036
[ Full content available at: https://github.com/apache/tinkerpop/pull/1034 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[ pull request closed by spmallette ]
[ Full content available at: https://github.com/apache/tinkerpop/pull/1034 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
The rendering was off due to the `|` characters in the table.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1037 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1036 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1036 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
Nice test, VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1030 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1035 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[ pull request closed by spmallette ]
[ Full content available at: https://github.com/apache/tinkerpop/pull/1036 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[ pull request closed by spmallette ]
[ Full content available at: https://github.com/apache/tinkerpop/pull/1037 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
thanks - we have so many bad formatting errors in the docs on this 3.4.0
release - stinks
[ Full content available at: https://github.com/apache/tinkerpop/pull/1037 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1032 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
added entry on the wrong version? should be for 3.3.6 i imagine
[ Full content available at: https://github.com/apache/tinkerpop/pull/1035 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
Aside from my comment about the CHANAGELOG entry - VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1035 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[ Full content available at: https://github.com/apache/tinkerpop/pull/1038 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
Ha, this time you actually got it right. I was about to answer "no, you get
this wrong after every release" :)
[ Full content available at: https://github.com/apache/tinkerpop/pull/1035 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[ pull request closed by asfgit ]
[ Full content available at: https://github.com/apache/tinkerpop/pull/1035 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
hahaha - i checked and checked and checked to make sure i wasn't false alarming
again! :tada:
[ Full content available at: https://github.com/apache/tinkerpop/pull/1035 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1030 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
lgtm! VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1032 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[ pull request closed by dkuppitz ]
[ Full content available at: https://github.com/apache/tinkerpop/pull/1032 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[ pull request closed by dkuppitz ]
[ Full content available at: https://github.com/apache/tinkerpop/pull/1030 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
Any reason not to target the `tp33` branch with this? `g:TraversalMetrics` is
on the 3.3.x line as well i think.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1031 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
I think tp33 doesn't have graphson3 so I will need to do another PR
[ Full content available at: https://github.com/apache/tinkerpop/pull/1031 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
GraphSON 3 was initially released on the 3.3.x line:
http://tinkerpop.apache.org/docs/3.3.5/dev/io/#_traversalmetrics_2
[ Full content available at: https://github.com/apache/tinkerpop/pull/1031 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
ah. I will update.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1031 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
https://issues.apache.org/jira/browse/TINKERPOP-2131
Two new exception classes are added to better reveal the reason for a
`NoConnectionAvailableException`:
* The pool is empty because the server is unavailable
-> `ServerUnavailableException`
* All connections have reached the max in-flight r
just peeking in on this PR - I'll let @jorgebay make the final word on this,
but I guess the reason we needed to add this line was so that calls further
down that use `options` and not `this.options` will work properly? shouldn't we
just consistently use `this.options` rather than try to interch
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1039 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
VOTE +1 - though a CHANGELOG entry would be good
[ Full content available at: https://github.com/apache/tinkerpop/pull/1039 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
I think the safest bet would be to use double assignment, that way is concise
and less error prone, dwyt @nivsherf ?
```javascript
this.options = options = options || {};
```
[ Full content available at: https://github.com/apache/tinkerpop/pull/1038 ]
This message was relayed via gitbox.apache.o
> though a CHANGELOG entry would be good
Right, I just added an entry.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1039 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
Makes sense @jorgebay. I updated the code accordingly.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1038 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
Thanks for the fix @nivsherf, VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1038 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
Rebased for tp33
[ Full content available at: https://github.com/apache/tinkerpop/pull/1031 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
https://issues.apache.org/jira/browse/TINKERPOP-1882
`docker/build.sh -t -i -n` passed.
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1040 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1039 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1038 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
https://issues.apache.org/jira/browse/TINKERPOP-2125
Added source file check in release validation script.
VOTE +/-0
At this point, the validation does not pass. We need to make a decision on what
to do with the following files:
```
./docs/static/images/gremlin-characters.pdf
./docs/static/ima
[ pull request closed by jorgebay ]
[ Full content available at: https://github.com/apache/tinkerpop/pull/1038 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
Nice, as soon it is merged we can work in a cherry-pick :)
[ Full content available at: https://github.com/apache/tinkerpop/pull/1029 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
I hate to be a bother but our git workflow goes from `tp33 --> master`. we
typically don't make it a habit of cherrypicking commits backwards in the flow
as it makes the git history messy.
i'd much prefer a rebase on tp33 with a squash of all these commits into one.
we can then merge forward t
Use index lookup for Text predicates (startingWith,endingWith,containing) in
Neo4jGraphStep to improve evaluation performance.
See: https://issues.apache.org/jira/browse/TINKERPOP-2133
[ Full content available at: https://github.com/apache/tinkerpop/pull/1042 ]
This message was relayed via gitbo
perhaps your IDE did this automatically, but could you please avoid the use of
the wildcard import (that's not our code style)?
[ Full content available at: https://github.com/apache/tinkerpop/pull/1042 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
thanks for orchestrating this pull request as i know you likely needed changes
from neo4j-contrib. i think it's ok to bump to this new version of neo4j for
TinkerPop 3.4.1 but since it's a major dependency change I will[ email the dev
list](https://lists.apache.org/thread.html/7e96fee99fe6ce2539
fixed
[ Full content available at: https://github.com/apache/tinkerpop/pull/1042 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
I'm not sure what those are.i assume they are just high-res
versions of the png files of the same name? i guess i would just whitelist them
since they've been there forever at this point. i assume we can allow *.pdf
(we're really trying to mostly avoid compiled code like `.exe`, `.dl
@spmallette Thanks! You were right, I did not run `mvn clean install` with
`-DincludeNeo4j`; sorry for that. I will address the issues and update the pull
request.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1042 ]
This message was relayed via gitbox.apache.org for dev@
PDFs are now whitelisted and the validation passes.
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1041 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
@skorikov Please include any Neo4j upgrade notes, like we did on [TinkerPop
3.3.1](http://tinkerpop.apache.org/docs/3.4.0/upgrade/#_upgrade_neo4j), in
`docs/src/upgrade/release-3.4.x.asciidoc`
[ Full content available at: https://github.com/apache/tinkerpop/pull/1042 ]
This message was relayed
@skorikov Please include any Neo4j upgrade notes, like we did on [TinkerPop
3.3.1](http://tinkerpop.apache.org/docs/3.4.0/upgrade/#_upgrade_neo4j), in
`docs/src/upgrade/release-3.4.x.asciidoc`
Also, ensure that:
- all configuration properties in TinkerPop reference are current or note those
re
@skorikov I took a quick look at the change and I'm concerned about the choice
of using Neo4j version 3.4.0. Let alone that the latest point release for that
series is 3.4.11 (12/2018), why not just go to the latest and greatest 3.5.1
(12/2018)?
[ Full content available at: https://github.com
This PR removes the redundant `Objects.nonNull(id);` call for `setId` method.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1043 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1041 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
please give me a little extra time to review this one - i had my head in other
things last week.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1040 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1031 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[ pull request closed by FlorianHockmann ]
[ Full content available at: https://github.com/apache/tinkerpop/pull/1039 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[ pull request closed by FlorianHockmann ]
[ Full content available at: https://github.com/apache/tinkerpop/pull/1026 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
VOTE +1 :shipit:
[ Full content available at: https://github.com/apache/tinkerpop/pull/1031 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
Could you please explain this change a bit further? In what way is this null
check redundant? where else is a non-null ensured to make this check
unnecessary?
[ Full content available at: https://github.com/apache/tinkerpop/pull/1043 ]
This message was relayed via gitbox.apache.org for dev@tinke
i think @skorikov already had to place some effort into changes in
neo4j-contrib to get this to even 3.4.11, so i'm inclined to be content with
that version especially since it hasn't been upgraded in a while. I am merely
curious though about 3.5.1 since @robertdale mentions it @skorikov
The Docker builds seem to be broken now. After deleting the existing docker
images, I get the following error when `docker.build.sh` tries to rebuild the
images:
```
...
Updating certificates in /etc/ssl/certs... 0 added, 0 removed; done.
Running hooks in /etc/ca-certificates/update.ddone.
P
@spmallette this check returns either `true` of `false`. The returned value
isn't used (i.e. the call is redundant). `Objects.nonNull(id);` doesn't throw
an exception if the `id` is null.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1043 ]
This message was relayed via gi
Perhaps it should be replaced with `Objects.requireNonNull(...)` then.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1043 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
That's strange. It still works fine for me. I used this to delete any existing
images and then start the build:
```bash
docker system prune -af
docker/build.sh
```
We could in general add another Travis job to run `docker/build.sh` to ensure
that we don't accidentally break the Docker build. I
So weird. Failed for me 3 times in a row now. Also, I found this message a bit
higher in the log:
```
Selecting previously unselected package dotnet-runtime-2.2.
Preparing to unpack .../dotnet-runtime-2.2_2.2.1-1_amd64.deb ...
Unpacking dotnet-runtime-2.2 (2.2.1-1) ...
dpkg-deb: error: archive
'
```
has premature member 'control.tar.xz' before 'control.tar.gz', giving up
```
Wait, I got exactly the same error in this PR with Travis and added this line
to the `.travis.yml` which fixed it there:
```
- sudo apt-get install -y dpkg # workaround for travis-ci/travis-ci#9361
```
and as the co
ah - i was thinking of the exception throwing version when i looked at it. then
the @dkuppitz suggestion is probably what we want here.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1043 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
@dkuppitz @spmallette Thank you for the clarification. I've replaced it with
`Objects.requireNonNull`.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1043 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
Yep, nice, that solved it!
[ Full content available at: https://github.com/apache/tinkerpop/pull/1026 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
Well, the images build fine now, but `gremlin-dotnet-source` doesn't.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1026 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
Do you get an exception?
[ Full content available at: https://github.com/apache/tinkerpop/pull/1026 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
Do you get an exception?
edit: I created
[TINKERPOP-2140](https://issues.apache.org/jira/browse/TINKERPOP-2140) to add
the Docker build to our Travis build.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1026 ]
This message was relayed via gitbox.apache.org for dev@tinker
See: https://gist.github.com/dkuppitz/1b912747180b07ab08d4eb98175c119b
I'm really wondering how you're able to get a clean build using the same docker
images, so confusing...
[ Full content available at: https://github.com/apache/tinkerpop/pull/1026 ]
This message was relayed via gitbox.apache.o
```
[echo] docfx already downloaded.
[exec] [19-01-23 03:56:27.186]Info:Config file docfx.json found, start
generating metadata...
[...]
[exec] [19-01-23 03:56:35.566]Error:System.AggregateException: One or more
errors occurred.
(/projects/apache/tinkerpop/gremlin-dotnet/src/obj/.cache/build/ysb
wonder if that's related to nugetwe still have some odd build problems
around clean repos that don't have nuget present i think. i have that on my
list of things to review.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1026 ]
This message was relayed via gitbox.apache
It finally worked! I'll add `git -fxd` in our Docker build script.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1026 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
It finally worked! I'll add `git -fxd` in our Docker build script.
EDIT: Dah, no, I won't do that. I tend to run `docker/build.sh -t -i` before I
commit my changes (including new files and directories). Thus, this cleanup
should be something we should just keep in mind; I don't think we'll need
https://issues.apache.org/jira/browse/TINKERPOP-2126
So, apparently, Spark 2.4.0 has some background logging going on, where it
takes objects out of memory and dumps their `toString()` into the log. I don't
think we can control when Spark is going to do that, so we have to work around
it by mak
i guess it is somewhat complicated. neo4j-contrib is not very active,
currently, as fas as I know there is only one developer contributing to and
maintaining it. the latest neo4j version used in
[neo4j-tinkerpop-api-impl](https://github.com/neo4j-contrib/neo4j-tinkerpop-api-impl)
was updated to
[ Full content available at: https://github.com/apache/tinkerpop/pull/1045 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
1 - 100 of 9475 matches
Mail list logo
