Comet API incompatibility between TC 6 and TC 7

2010-04-29 Thread Konstantin Kolinko
There is a difference in Comet API that will require all TC6 Comet applications to be patched and recompiled before deploying them to TC7: Comet classes were moved from "org.apache.catalina" to "org.apache.catalina.comet". What do you think, is this change acceptable for us? IIRC, the cause behi

DO NOT REPLY [Bug 48218] Comet example chat.ChatServlet fails to start when running with SecurityManager

2010-04-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48218 Konstantin Kolinko changed: What|Removed |Added CC||alexis.hass...@sewatech.fr --

DO NOT REPLY [Bug 49212] Example application lacks a permission in -security mode

2010-04-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49212 Konstantin Kolinko changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 48218] Comet example chat.ChatServlet fails to start when running with SecurityManager

2010-04-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48218 --- Comment #3 from Konstantin Kolinko 2010-04-30 01:41:27 EDT --- Created an attachment (id=25379) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25379) 2010-04-30_tc6_bug48218.patch - patch for catalina.policy Attaching a pa

DO NOT REPLY [Bug 49234] New: JMX Descriptor Modifications

2010-04-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49234 Summary: JMX Descriptor Modifications Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Linux Status: NEW Severity: normal Priority: P2 Compo

svn commit: r939554 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-04-29 Thread kkolinko
Author: kkolinko Date: Fri Apr 30 04:08:00 2010 New Revision: 939554 URL: http://svn.apache.org/viewvc?rev=939554&view=rev Log: clarify my vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.t

svn commit: r939553 - /tomcat/trunk/test/org/apache/catalina/core/TestStandardContextResources.java

2010-04-29 Thread kkolinko
Author: kkolinko Date: Fri Apr 30 04:00:01 2010 New Revision: 939553 URL: http://svn.apache.org/viewvc?rev=939553&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49218 The test runs successfully if JreMemoryLeakPreventionListener is present. Modified: tomcat/trunk/test/or

svn commit: r939552 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-04-29 Thread kkolinko
Author: kkolinko Date: Fri Apr 30 03:52:43 2010 New Revision: 939552 URL: http://svn.apache.org/viewvc?rev=939552&view=rev Log: proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=

svn commit: r939551 - in /tomcat/trunk/java/org/apache/catalina/core: ApplicationContext.java LocalStrings.properties

2010-04-29 Thread kkolinko
Author: kkolinko Date: Fri Apr 30 03:49:40 2010 New Revision: 939551 URL: http://svn.apache.org/viewvc?rev=939551&view=rev Log: Log unexpected runtima and IO errors in ApplicationContext#getResource() and ApplicationContext#getResourceAsStream(). This is inspired by BZ 49218. Modified: tomca

DO NOT REPLY [Bug 49218] Fix support for META-INF/resources

2010-04-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49218 --- Comment #1 from Konstantin Kolinko 2010-04-29 23:45:59 EDT --- Re: "zip file closed" Thanks to Peter Roßbach, I found that webapp-3.0-fragments webapp fails only when it is run in a testcase. If it is deployed on a standalone Tomcat

Re: svn commit: r939221 - in /tomcat/trunk/test/org/apache/catalina/startup: DuplicateMappingParamServlet.java NoMappingParamServlet.java ParamServlet.java TestContextConfigAnnotation.java

2010-04-29 Thread Konstantin Kolinko
2010/4/29 Konstantin Kolinko : > 2010/4/29 Peter Roßbach : >> A lot of tomcat classes has this problem. I found 861 java files at tomcat 7 >> with token "Revision"! >> > > $Revision$ keyword is OK. It is $Date$ that is faulty > I replaced all occurrences of $Date$ keyword with $Id$ in trunk. > > I'

Re: svn commit: r939320 - in /tomcat/trunk/modules: jdbc-pool/doc/ tomcat-lite/java/org/apache/tomcat/lite/servlet/ tomcat-lite/java/org/apache/tomcat/lite/util/

2010-04-29 Thread Konstantin Kolinko
2010/4/29 sebb : > On 29/04/2010, Konstantin Kolinko wrote: >> 2010/4/29 sebb : >>  > >>  > Just a thought - could perhaps remove the Date keyword to stop it being >> used? >>  > >> >> >> True, but >>  a) I do not see a fast and easy way to do it in my environment. > > I have a Perl script that I

svn commit: r939543 - /tomcat/tc5.5.x/trunk/connectors/jni/java/org/apache/tomcat/jni/Buffer.java

2010-04-29 Thread kkolinko
Author: kkolinko Date: Fri Apr 30 02:00:29 2010 New Revision: 939543 URL: http://svn.apache.org/viewvc?rev=939543&view=rev Log: CTR Set svn:keywords=Id where there is unexpanded $Id$ keyword in the files Modified: tomcat/tc5.5.x/trunk/connectors/jni/java/org/apache/tomcat/jni/Buffer.java (

svn commit: r939541 - in /tomcat/tc5.5.x/trunk/servletapi: jsr152/examples/WEB-INF/classes/compressionFilters/ jsr152/examples/WEB-INF/classes/filters/ jsr152/examples/WEB-INF/classes/listeners/ jsr15

2010-04-29 Thread kkolinko
Author: kkolinko Date: Fri Apr 30 01:43:56 2010 New Revision: 939541 URL: http://svn.apache.org/viewvc?rev=939541&view=rev Log: CTR Replace $Date$ keyword with $Id$ in JavaDoc comments, because of its i18n and timezone issues (http://subversion.tigris.org/issues/show_bug.cgi?id=2332) Modified:

svn commit: r939540 - in /tomcat/tc5.5.x/trunk/jasper/src/share/org/apache/jasper/xmlparser: ParserUtils.java TreeNode.java

2010-04-29 Thread kkolinko
Author: kkolinko Date: Fri Apr 30 01:40:42 2010 New Revision: 939540 URL: http://svn.apache.org/viewvc?rev=939540&view=rev Log: CTR Replace $Date$ keyword with $Id$ in JavaDoc comments, because of its i18n and timezone issues (http://subversion.tigris.org/issues/show_bug.cgi?id=2332) Modified:

svn commit: r939539 [2/2] - in /tomcat/tc5.5.x/trunk/container/modules: cluster/src/share/org/apache/catalina/cluster/ cluster/src/share/org/apache/catalina/cluster/authenticator/ cluster/src/share/or

2010-04-29 Thread kkolinko
Modified: tomcat/tc5.5.x/trunk/container/modules/groupcom/src/share/org/apache/catalina/tribes/transport/Constants.java URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/container/modules/groupcom/src/share/org/apache/catalina/tribes/transport/Constants.java?rev=939539&r1=939538&r2=939539&vi

svn commit: r939537 - in /tomcat/tc5.5.x/trunk/container/webapps: host-manager/WEB-INF/classes/org/apache/catalina/hostmanager/ manager/WEB-INF/classes/org/apache/catalina/manager/

2010-04-29 Thread kkolinko
Author: kkolinko Date: Fri Apr 30 01:22:48 2010 New Revision: 939537 URL: http://svn.apache.org/viewvc?rev=939537&view=rev Log: CTR Replace $Date$ keyword with $Id$ in JavaDoc comments, because of its i18n and timezone issues (http://subversion.tigris.org/issues/show_bug.cgi?id=2332) Modified:

svn commit: r939536 [2/2] - in /tomcat/tc5.5.x/trunk/container/webapps/admin/WEB-INF/classes/org/apache/webapp/admin: ./ connector/ context/ filters/ host/ realm/ resources/ server/ service/ users/ va

2010-04-29 Thread kkolinko
Modified: tomcat/tc5.5.x/trunk/container/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/resources/MailSessionForm.java URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/container/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/resources/MailSessionForm.java?rev=939536&r1=939535&

svn commit: r939535 [2/2] - in /tomcat/tc5.5.x/trunk/container/tester/src/tester/org/apache/tester: ./ shared/ unpshared/ unshared/

2010-04-29 Thread kkolinko
Modified: tomcat/tc5.5.x/trunk/container/tester/src/tester/org/apache/tester/Session01.java URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/container/tester/src/tester/org/apache/tester/Session01.java?rev=939535&r1=939534&r2=939535&view=diff

svn commit: r939533 - in /tomcat/tc5.5.x/trunk/container/catalina/src/share/org/apache/naming: ./ factory/ java/ resources/

2010-04-29 Thread kkolinko
Author: kkolinko Date: Fri Apr 30 00:56:48 2010 New Revision: 939533 URL: http://svn.apache.org/viewvc?rev=939533&view=rev Log: CTR Replace $Date$ keyword with $Id$ in JavaDoc comments, because of its i18n and timezone issues (http://subversion.tigris.org/issues/show_bug.cgi?id=2332) Modified:

svn commit: r939532 - in /tomcat/tc5.5.x/trunk/container/catalina/src/test/org/apache: catalina/util/ naming/resources/

2010-04-29 Thread kkolinko
Author: kkolinko Date: Fri Apr 30 00:55:18 2010 New Revision: 939532 URL: http://svn.apache.org/viewvc?rev=939532&view=rev Log: CTR Replace $Date$ keyword with $Id$ in JavaDoc comments, because of its i18n and timezone issues (http://subversion.tigris.org/issues/show_bug.cgi?id=2332) Modified:

svn commit: r939531 - /tomcat/tc5.5.x/trunk/container/catalina/src/share/org/apache/catalina/

2010-04-29 Thread kkolinko
Author: kkolinko Date: Fri Apr 30 00:54:41 2010 New Revision: 939531 URL: http://svn.apache.org/viewvc?rev=939531&view=rev Log: CTR Replace $Date$ keyword with $Id$ in JavaDoc comments, because of its i18n and timezone issues (http://subversion.tigris.org/issues/show_bug.cgi?id=2332) Modified:

svn commit: r939527 - in /tomcat/tc5.5.x/trunk/container/catalina/src/share/org/apache/catalina: deploy/ loader/ mbeans/

2010-04-29 Thread kkolinko
Author: kkolinko Date: Fri Apr 30 00:43:48 2010 New Revision: 939527 URL: http://svn.apache.org/viewvc?rev=939527&view=rev Log: CTR Replace $Date$ keyword with $Id$ in JavaDoc comments, because of its i18n and timezone issues (http://subversion.tigris.org/issues/show_bug.cgi?id=2332) Modified:

svn commit: r939526 - in /tomcat/tc5.5.x/trunk/container/catalina/src/share/org/apache/catalina: util/ valves/

2010-04-29 Thread kkolinko
Author: kkolinko Date: Fri Apr 30 00:39:28 2010 New Revision: 939526 URL: http://svn.apache.org/viewvc?rev=939526&view=rev Log: CTR Replace $Date$ keyword with $Id$ in JavaDoc comments, because of its i18n and timezone issues (http://subversion.tigris.org/issues/show_bug.cgi?id=2332) Modified:

svn commit: r939525 - in /tomcat/tc5.5.x/trunk/container/catalina/src/share/org/apache/catalina: connector/ core/

2010-04-29 Thread kkolinko
Author: kkolinko Date: Fri Apr 30 00:36:35 2010 New Revision: 939525 URL: http://svn.apache.org/viewvc?rev=939525&view=rev Log: CTR Replace $Date$ keyword with $Id$ in JavaDoc comments, because of its i18n and timezone issues (http://subversion.tigris.org/issues/show_bug.cgi?id=2332) Modified:

svn commit: r939524 - in /tomcat/tc5.5.x/trunk/connectors: juli/src/java/org/apache/juli/ util/java/org/apache/tomcat/util/buf/ util/java/org/apache/tomcat/util/net/ util/java/org/apache/tomcat/util/r

2010-04-29 Thread kkolinko
Author: kkolinko Date: Fri Apr 30 00:29:29 2010 New Revision: 939524 URL: http://svn.apache.org/viewvc?rev=939524&view=rev Log: CTR Replace $Date$ keyword with $Id$ in JavaDoc comments, because of its i18n and timezone issues (http://subversion.tigris.org/issues/show_bug.cgi?id=2332) Modified:

svn commit: r939523 - in /tomcat/tc5.5.x/trunk/container/catalina/src/share/org/apache/catalina: ant/ ant/jmx/ authenticator/

2010-04-29 Thread kkolinko
Author: kkolinko Date: Fri Apr 30 00:28:42 2010 New Revision: 939523 URL: http://svn.apache.org/viewvc?rev=939523&view=rev Log: CTR Replace $Date$ keyword with $Id$ in JavaDoc comments, because of its i18n and timezone issues (http://subversion.tigris.org/issues/show_bug.cgi?id=2332) Modified:

svn commit: r939522 - in /tomcat/tc5.5.x/trunk/connectors: coyote/src/java/org/apache/coyote/tomcat4/ jk/java/org/apache/ajp/tomcat4/ jni/java/org/apache/tomcat/jni/

2010-04-29 Thread kkolinko
Author: kkolinko Date: Fri Apr 30 00:26:15 2010 New Revision: 939522 URL: http://svn.apache.org/viewvc?rev=939522&view=rev Log: CTR Replace $Date$ keyword with $Id$ in JavaDoc comments, because of its i18n and timezone issues (http://subversion.tigris.org/issues/show_bug.cgi?id=2332) Modified:

svn commit: r939521 - in /tomcat/tc6.0.x/trunk/webapps/examples/WEB-INF/classes: compressionFilters/ filters/ listeners/ util/ validators/

2010-04-29 Thread kkolinko
Author: kkolinko Date: Fri Apr 30 00:16:33 2010 New Revision: 939521 URL: http://svn.apache.org/viewvc?rev=939521&view=rev Log: CTR Replace $Date$ keyword with $Id$ in JavaDoc comments, because of its i18n and timezone issues (http://subversion.tigris.org/issues/show_bug.cgi?id=2332) Modified:

svn commit: r939520 - in /tomcat/tc6.0.x/trunk/java/org/apache: jasper/runtime/ jasper/util/ jasper/xmlparser/ juli/ juli/logging/

2010-04-29 Thread kkolinko
Author: kkolinko Date: Fri Apr 30 00:14:14 2010 New Revision: 939520 URL: http://svn.apache.org/viewvc?rev=939520&view=rev Log: CTR Replace $Date$ keyword with $Id$ in JavaDoc comments, because of its i18n and timezone issues (http://subversion.tigris.org/issues/show_bug.cgi?id=2332) Modified:

svn commit: r939519 - in /tomcat/tc6.0.x/trunk/java/org/apache/el: ./ lang/ parser/ util/

2010-04-29 Thread kkolinko
Author: kkolinko Date: Fri Apr 30 00:12:23 2010 New Revision: 939519 URL: http://svn.apache.org/viewvc?rev=939519&view=rev Log: CTR Replace $Date$ keyword with $Id$ in JavaDoc comments, because of its i18n and timezone issues (http://subversion.tigris.org/issues/show_bug.cgi?id=2332) Modified:

svn commit: r939515 - in /tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes: ./ group/ io/ membership/ transport/ transport/bio/ transport/bio/util/ transport/nio/

2010-04-29 Thread kkolinko
Author: kkolinko Date: Thu Apr 29 23:59:49 2010 New Revision: 939515 URL: http://svn.apache.org/viewvc?rev=939515&view=rev Log: CTR Replace $Date$ keyword with $Id$ in JavaDoc comments, because of its i18n and timezone issues (http://subversion.tigris.org/issues/show_bug.cgi?id=2332) Modified:

svn commit: r939514 - in /tomcat/tc6.0.x/trunk/java/org/apache/catalina/ha: ./ session/ tcp/ util/

2010-04-29 Thread kkolinko
Author: kkolinko Date: Thu Apr 29 23:55:14 2010 New Revision: 939514 URL: http://svn.apache.org/viewvc?rev=939514&view=rev Log: CTR Replace $Date$ keyword with $Id$ in JavaDoc comments, because of its i18n and timezone issues (http://subversion.tigris.org/issues/show_bug.cgi?id=2332) Corrected Jav

svn commit: r939511 - in /tomcat/tc6.0.x/trunk/java/org/apache/naming: ./ factory/ java/ resources/

2010-04-29 Thread kkolinko
Author: kkolinko Date: Thu Apr 29 23:48:20 2010 New Revision: 939511 URL: http://svn.apache.org/viewvc?rev=939511&view=rev Log: CTR Replace $Date$ keyword with $Id$ in JavaDoc comments, because of its i18n and timezone issues (http://subversion.tigris.org/issues/show_bug.cgi?id=2332) Modified:

DO NOT REPLY [Bug 48817] Skip validation query and use JDBC API for validation

2010-04-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48817 --- Comment #3 from Matt Passell 2010-04-29 19:32:27 EDT --- (In reply to comment #2) > > There should be plugaable Validator which could be configured in the > > poolProperties. e.g > > why not just an interceptor if you want custom val

DO NOT REPLY [Bug 49224] NullPointerException in PooledConnection when username or password are null

2010-04-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49224 --- Comment #3 from Matt Passell 2010-04-29 18:24:28 EDT --- (In reply to comment #2) > "" is not the same as null, my guess is that the property should not even be > set of the value is null Good point. That's even better, as long as yo

DO NOT REPLY [Bug 49224] NullPointerException in PooledConnection when username or password are null

2010-04-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49224 --- Comment #2 from Filip Hanik 2010-04-29 18:19:28 EDT --- (In reply to comment #1) > I'm guessing that the solution is as simple as changing lines 215 and 216 of > PooledConnection to the following: > > poolProperties.getDbProperties().s

svn commit: r939494 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-04-29 Thread fhanik
Author: fhanik Date: Thu Apr 29 22:09:21 2010 New Revision: 939494 URL: http://svn.apache.org/viewvc?rev=939494&view=rev Log: proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=93

Re: Need advice to notify StandardExecutor when a webapp is stopped

2010-04-29 Thread Pid
On 29/04/2010 21:50, Sylvain Laurent wrote: > If I understand you and your comment here > https://issues.apache.org/bugzilla/show_bug.cgi?id=49159#c2 you propose to > clean only thread locals loaded by a web app. But how do you recognize them ? > If the value bound to a threadlocal is an ArrayLi

svn commit: r939491 - /tomcat/trunk/java/org/apache/catalina/connector/CoyotePrincipal.java

2010-04-29 Thread fhanik
Author: fhanik Date: Thu Apr 29 22:00:17 2010 New Revision: 939491 URL: http://svn.apache.org/viewvc?rev=939491&view=rev Log: Per documentation: http://java.sun.com/javase/6/docs/api/javax/security/auth/Subject.html Therefore all concrete Principal implementations associated with Subjects must i

RE: Need advice to notify StandardExecutor when a webapp is stopped

2010-04-29 Thread Caldarale, Charles R
> From: Caldarale, Charles R > Subject: RE: Need advice to notify StandardExecutor when a webapp is > stopped > > This is an area where some byte code modification might be appropriate > in a container environment, so that the ThreadLocal behavior could be > modified to be "ContextLocal" instead.

Re: Need advice to notify StandardExecutor when a webapp is stopped

2010-04-29 Thread Pid
On 29/04/2010 22:52, Sylvain Laurent wrote: > While experimenting with clearing threadlocal in afterExecute, I found out > that tomcat itself use ThreadLocal in hope of improving performance : > - org.apache.catalina.util.DateTool > - org.apache.catalina.valves.AccessLogValve > - org.apache.tomca

Re: Need advice to notify StandardExecutor when a webapp is stopped

2010-04-29 Thread Sylvain Laurent
While experimenting with clearing threadlocal in afterExecute, I found out that tomcat itself use ThreadLocal in hope of improving performance : - org.apache.catalina.util.DateTool - org.apache.catalina.valves.AccessLogValve - org.apache.tomcat.util.http.ServerCookie - ... this is mainly to cach

Re: Access logging for requests rejected by CoyoteAdaptor

2010-04-29 Thread Konstantin Kolinko
2010/4/29 Mark Thomas : > This was prompted by [1]. For a number of mal-formed requests, the > CoyoteAdaptor will reject them before they reach the access log valve. There > is currently no means of logging these rejected requests in Tomcat. Some requests are rejected by a connector, if it cannot

RE: Need advice to notify StandardExecutor when a webapp is stopped

2010-04-29 Thread Caldarale, Charles R
> From: Sylvain Laurent [mailto:sylvain.laur...@gmail.com] On Behalf Of > Sylvain Laurent > Subject: Re: Need advice to notify StandardExecutor when a webapp is > stopped > > Furthermore, there is probably some frameworks out there that > do save things in ThreadLocals in a manner that does not c

Re: Need advice to notify StandardExecutor when a webapp is stopped

2010-04-29 Thread Sylvain Laurent
If I understand you and your comment here https://issues.apache.org/bugzilla/show_bug.cgi?id=49159#c2 you propose to clean only thread locals loaded by a web app. But how do you recognize them ? If the value bound to a threadlocal is an ArrayList, you won't be able to tell that it was loaded by

Re: svn commit: r939253 - in /tomcat/trunk/test: org/apache/catalina/core/ webapp-3.0-fragments/ webapp-3.0-fragments/WEB-INF/ webapp-3.0-fragments/WEB-INF/lib/ webapp-3.0-fragments/folder/

2010-04-29 Thread Peter Roßbach
Hi, I have debug the problem and it seams very strange. Why zip file is closed? I have build a standalone example with other files from scratch and I got my resource from bundled jar:/META-INF/resource/hello.jsp. But as I use the resource.jar it not work and also my jar don't work with the

Re: Tomcat 7, Valve -> Filter conversion, and container-managed authentication/authorization

2010-04-29 Thread David Jencks
On Apr 29, 2010, at 9:48 AM, Caldarale, Charles R wrote: >> From: Christopher Schultz [mailto:ch...@christopherschultz.net] >> Subject: Re: Tomcat 7, Valve -> Filter conversion, and container- >> managed authentication/authorization >> >> I guess my question would be "how much of servlet 3 has b

RE: Tomcat 7, Valve -> Filter conversion, and container-managed authentication/authorization

2010-04-29 Thread Caldarale, Charles R
> From: Christopher Schultz [mailto:ch...@christopherschultz.net] > Subject: Re: Tomcat 7, Valve -> Filter conversion, and container- > managed authentication/authorization > > I guess my question would be "how much of servlet 3 has been > implemented in TC7 at this point"? Similarly, what's the

Re: Tomcat 7, Valve -> Filter conversion, and container-managed authentication/authorization

2010-04-29 Thread Christopher Schultz
David, On 4/28/2010 6:40 PM, David Jencks wrote: > I'd be curious how many of the features in securityfilter can be done > with servlet 3 (which includes the ability for an app to > programatically force a login) and jaspic (jsr 196) which provides > for pluggable authentication dialogs between cl

DO NOT REPLY [Bug 49230] New: sun.net.www.http.KeepAliveCache preventing classloader from being garbage collected

2010-04-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49230 Summary: sun.net.www.http.KeepAliveCache preventing classloader from being garbage collected Product: Tomcat 6 Version: unspecified Platform: PC OS/Version: All

svn commit: r939353 - in /tomcat/tc6.0.x/trunk/java/org/apache/catalina: startup/ users/ util/ valves/

2010-04-29 Thread kkolinko
Author: kkolinko Date: Thu Apr 29 15:50:43 2010 New Revision: 939353 URL: http://svn.apache.org/viewvc?rev=939353&view=rev Log: CTR Replace $Date$ keyword with $Id$ in JavaDoc comments, because of its i18n and timezone issues (http://subversion.tigris.org/issues/show_bug.cgi?id=2332) Modified:

svn commit: r939351 - in /tomcat/tc6.0.x/trunk/java/org/apache/tomcat: jni/ util/buf/ util/modeler/ util/net/ util/res/

2010-04-29 Thread kkolinko
Author: kkolinko Date: Thu Apr 29 15:41:54 2010 New Revision: 939351 URL: http://svn.apache.org/viewvc?rev=939351&view=rev Log: CTR Replace $Date$ keyword with $Id$ in JavaDoc comments, because of its i18n and timezone issues (http://subversion.tigris.org/issues/show_bug.cgi?id=2332) Modified:

svn commit: r939350 - in /tomcat/tc6.0.x/trunk/java/org/apache/catalina: ./ deploy/

2010-04-29 Thread kkolinko
Author: kkolinko Date: Thu Apr 29 15:36:29 2010 New Revision: 939350 URL: http://svn.apache.org/viewvc?rev=939350&view=rev Log: CTR Replace $Date$ keyword with $Id$ in JavaDoc comments, because of its i18n and timezone issues (http://subversion.tigris.org/issues/show_bug.cgi?id=2332) Modified:

DO NOT REPLY [Bug 49226] toLowerCase()/toUpperCase() may not work OK in all Locales

2010-04-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49226 --- Comment #1 from Sebb 2010-04-29 11:33:23 EDT --- Created an attachment (id=25376) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25376) Patch to use Locale.ENGLISH for case conversions (part 2) -- Configure bugmail: https:

DO NOT REPLY [Bug 49228] New: toLowerCase()/toUpperCase() may not work OK in all Locales

2010-04-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49228 Summary: toLowerCase()/toUpperCase() may not work OK in all Locales Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows XP Status: NEW

DO NOT REPLY [Bug 49227] New: toLowerCase()/toUpperCase() may not work OK in all Locales

2010-04-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49227 Summary: toLowerCase()/toUpperCase() may not work OK in all Locales Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows XP Status: NEW

DO NOT REPLY [Bug 49226] New: toLowerCase()/toUpperCase() may not work OK in all Locales

2010-04-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49226 Summary: toLowerCase()/toUpperCase() may not work OK in all Locales Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows XP Status: NEW

svn commit: r939342 - /tomcat/trunk/java/org/apache/catalina/startup/ContextRuleSet.java

2010-04-29 Thread pero
Author: pero Date: Thu Apr 29 15:21:54 2010 New Revision: 939342 URL: http://svn.apache.org/viewvc?rev=939342&view=rev Log: Fix to correct JarScanner (StandardJarScanner) default! Modified: tomcat/trunk/java/org/apache/catalina/startup/ContextRuleSet.java Modified: tomcat/trunk/java/org/apac

DO NOT REPLY [Bug 49224] NullPointerException in PooledConnection when username or password are null

2010-04-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49224 --- Comment #1 from Matt Passell 2010-04-29 11:18:10 EDT --- I'm guessing that the solution is as simple as changing lines 215 and 216 of PooledConnection to the following: poolProperties.getDbProperties().setProperty("user", usr != null

DO NOT REPLY [Bug 49224] New: NullPointerException in PooledConnection when username or password are null

2010-04-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49224 Summary: NullPointerException in PooledConnection when username or password are null Product: Tomcat 7 Version: unspecified Platform: All OS/Version: All Stat

Re: svn commit: r939320 - in /tomcat/trunk/modules: jdbc-pool/doc/ tomcat-lite/java/org/apache/tomcat/lite/servlet/ tomcat-lite/java/org/apache/tomcat/lite/util/

2010-04-29 Thread sebb
On 29/04/2010, Konstantin Kolinko wrote: > 2010/4/29 sebb : > > > On 29/04/2010, kkoli...@apache.org wrote: > >> Author: kkolinko > >> Date: Thu Apr 29 14:23:46 2010 > >> New Revision: 939320 > >> > >> URL: http://svn.apache.org/viewvc?rev=939320&view=rev > >> Log: > >> Set svn:keywor

svn commit: r939336 - in /tomcat/tc6.0.x/trunk/java/org/apache/catalina: ant/ ant/jmx/ authenticator/ connector/ core/

2010-04-29 Thread kkolinko
Author: kkolinko Date: Thu Apr 29 15:00:41 2010 New Revision: 939336 URL: http://svn.apache.org/viewvc?rev=939336&view=rev Log: CTR Replace $Date$ keyword with $Id$ in JavaDoc comments, because of its i18n and timezone issues (http://subversion.tigris.org/issues/show_bug.cgi?id=2332) Modified:

Re: svn commit: r939320 - in /tomcat/trunk/modules: jdbc-pool/doc/ tomcat-lite/java/org/apache/tomcat/lite/servlet/ tomcat-lite/java/org/apache/tomcat/lite/util/

2010-04-29 Thread Konstantin Kolinko
2010/4/29 sebb : > On 29/04/2010, kkoli...@apache.org wrote: >> Author: kkolinko >>  Date: Thu Apr 29 14:23:46 2010 >>  New Revision: 939320 >> >>  URL: http://svn.apache.org/viewvc?rev=939320&view=rev >>  Log: >>  Set svn:keywords=Id where there is unexpanded $Id$ keyword in the files > > Just a

Re: svn commit: r939221 - in /tomcat/trunk/test/org/apache/catalina/startup: DuplicateMappingParamServlet.java NoMappingParamServlet.java ParamServlet.java TestContextConfigAnnotation.java

2010-04-29 Thread Konstantin Kolinko
2010/4/29 Peter Roßbach : > OK, I change my default. > > A lot of tomcat classes has this problem. I found 861 java files at tomcat 7 > with token "Revision"! > $Revision$ keyword is OK. It is $Date$ that is faulty, because it a) uses i18n for the month and day of week names, b) uses local timez

Re: svn commit: r939320 - in /tomcat/trunk/modules: jdbc-pool/doc/ tomcat-lite/java/org/apache/tomcat/lite/servlet/ tomcat-lite/java/org/apache/tomcat/lite/util/

2010-04-29 Thread sebb
On 29/04/2010, kkoli...@apache.org wrote: > Author: kkolinko > Date: Thu Apr 29 14:23:46 2010 > New Revision: 939320 > > URL: http://svn.apache.org/viewvc?rev=939320&view=rev > Log: > Set svn:keywords=Id where there is unexpanded $Id$ keyword in the files Just a thought - could perhaps remov

svn commit: r939320 - in /tomcat/trunk/modules: jdbc-pool/doc/ tomcat-lite/java/org/apache/tomcat/lite/servlet/ tomcat-lite/java/org/apache/tomcat/lite/util/

2010-04-29 Thread kkolinko
Author: kkolinko Date: Thu Apr 29 14:23:46 2010 New Revision: 939320 URL: http://svn.apache.org/viewvc?rev=939320&view=rev Log: Set svn:keywords=Id where there is unexpanded $Id$ keyword in the files Modified: tomcat/trunk/modules/jdbc-pool/doc/package.xsl (props changed) tomcat/trunk/

svn commit: r939315 - in /tomcat/trunk: ./ webapps/examples/WEB-INF/classes/compressionFilters/ webapps/examples/WEB-INF/classes/filters/ webapps/examples/WEB-INF/classes/listeners/ webapps/examples/W

2010-04-29 Thread kkolinko
Author: kkolinko Date: Thu Apr 29 14:11:01 2010 New Revision: 939315 URL: http://svn.apache.org/viewvc?rev=939315&view=rev Log: Replace $Date$ with $Id$ because of its i18n and timezone issues (http://subversion.tigris.org/issues/show_bug.cgi?id=2332) Modified: tomcat/trunk/PROPOSALS.txt

Re: Access logging for requests rejected by CoyoteAdaptor

2010-04-29 Thread Filip Hanik - Dev Lists
1. We shouldn't dilute the access logs which is supposed to log valid HTTP requests with blah. Many companies run funky port scanners as part of their audit, these would all end up in the access log if you used two. The access log and its usage is pretty clear, and its not to log incomplete HT

svn commit: r939312 - in /tomcat/trunk/modules/tomcat-lite/java/org/apache/tomcat: lite/servlet/ServletContextImpl.java lite/servlet/ServletResponseImpl.java lite/util/Base64.java servlets/util/Reques

2010-04-29 Thread kkolinko
Author: kkolinko Date: Thu Apr 29 14:02:25 2010 New Revision: 939312 URL: http://svn.apache.org/viewvc?rev=939312&view=rev Log: Replace $Date$ with $Id$ because of its i18n and timezone issues (http://subversion.tigris.org/issues/show_bug.cgi?id=2332) Modified: tomcat/trunk/modules/tomcat-li

svn commit: r939309 - in /tomcat/trunk/java/org/apache/tomcat: ./ jni/ util/modeler/ util/net/ util/res/

2010-04-29 Thread kkolinko
Author: kkolinko Date: Thu Apr 29 13:54:26 2010 New Revision: 939309 URL: http://svn.apache.org/viewvc?rev=939309&view=rev Log: Replace $Date$ with $Id$ because of its i18n and timezone issues (http://subversion.tigris.org/issues/show_bug.cgi?id=2332) Modified: tomcat/trunk/java/org/apache/to

svn commit: r939305 [3/3] - in /tomcat/trunk/java/org/apache/catalina: ./ ant/ ant/jmx/ authenticator/ connector/ core/ deploy/ filters/ ha/ ha/session/ ha/tcp/ ha/util/ loader/ manager/ manager/host/

2010-04-29 Thread kkolinko
Modified: tomcat/trunk/java/org/apache/catalina/startup/TldRuleSet.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/startup/TldRuleSet.java?rev=939305&r1=939304&r2=939305&view=diff == --- tomcat

DO NOT REPLY [Bug 49221] New: javax.servlet.http.Cookie.setDomain uses default charset

2010-04-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49221 Summary: javax.servlet.http.Cookie.setDomain uses default charset Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows XP Status: NEW S

DO NOT REPLY [Bug 49092] util.IntrospectionUtils.PATH_SEPARATOR should be final

2010-04-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49092 Sebb changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED

svn commit: r939299 - in /tomcat/trunk/java/org/apache/tomcat/util/collections: MultiMap.java MultiMapNamesEnumeration.java MultiMapValuesEnumeration.java

2010-04-29 Thread kkolinko
Author: kkolinko Date: Thu Apr 29 12:52:36 2010 New Revision: 939299 URL: http://svn.apache.org/viewvc?rev=939299&view=rev Log: Remove MultiMap class. It is never used. Note, that its implementation was incomplete, e.g. MultiMap.Field#name and #value fields are never assigned. Removed: tomca

svn commit: r939287 - in /tomcat/trunk/test/org/apache: catalina/core/TestStandardContextAliases.java naming/resources/TestBaseDirContext.java

2010-04-29 Thread kkolinko
Author: kkolinko Date: Thu Apr 29 11:48:38 2010 New Revision: 939287 URL: http://svn.apache.org/viewvc?rev=939287&view=rev Log: Move and rename the aliases support test. Added: tomcat/trunk/test/org/apache/catalina/core/TestStandardContextAliases.java - copied, changed from r939217, to

Re: Access logging for requests rejected by CoyoteAdaptor

2010-04-29 Thread Tim Funk
I like case 2. In the case of the malformed request. We might not be able to determine the host or the path (and therefore the appropriate webapp (or host)) In the common case (admin), I would hope that there is an AccessLog at the EngineLevel. So we might be able to do the following ... - C

DO NOT REPLY [Bug 49218] New: Fix support for META-INF/resources

2010-04-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49218 Summary: Fix support for META-INF/resources Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Priority: P2

Re: GSOC 2010

2010-04-29 Thread Mark Thomas
On 28/04/2010 23:05, buddhika chamith wrote: Hi Mark, Just wanted some suggestions on the approach I would take. Currently I am examining mbean details by the plan which is based on Tomcat pacakages. What I normally do is to look at the mbeans descriptor and check in the described mbeans whether

svn commit: r939253 - in /tomcat/trunk/test: org/apache/catalina/core/ webapp-3.0-fragments/ webapp-3.0-fragments/WEB-INF/ webapp-3.0-fragments/WEB-INF/lib/ webapp-3.0-fragments/folder/

2010-04-29 Thread kkolinko
Author: kkolinko Date: Thu Apr 29 10:24:14 2010 New Revision: 939253 URL: http://svn.apache.org/viewvc?rev=939253&view=rev Log: Tests for Servlet 3.0 support of bundling static resources in META-INF/resources subdirectory of a jar file. It is a separate web application, because the old "webapp-3.

DO NOT REPLY [Bug 49217] New: Accepting java keyword in EL

2010-04-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49217 Summary: Accepting java keyword in EL Product: Tomcat 5 Version: 5.5.17 Platform: PC OS/Version: Windows XP Status: NEW Severity: minor Priority: P2

Re: svn commit: r939221 - in /tomcat/trunk/test/org/apache/catalina/startup: DuplicateMappingParamServlet.java NoMappingParamServlet.java ParamServlet.java TestContextConfigAnnotation.java

2010-04-29 Thread Peter Roßbach
OK, I change my default. A lot of tomcat classes has this problem. I found 861 java files at tomcat 7 with token "Revision"! Peter Am 29.04.2010 um 09:30 schrieb kkoli...@apache.org: Author: kkolinko Date: Thu Apr 29 07:30:29 2010 New Revision: 939221 URL: http://svn.apache.org/viewvc?rev

svn commit: r939221 - in /tomcat/trunk/test/org/apache/catalina/startup: DuplicateMappingParamServlet.java NoMappingParamServlet.java ParamServlet.java TestContextConfigAnnotation.java

2010-04-29 Thread kkolinko
Author: kkolinko Date: Thu Apr 29 07:30:29 2010 New Revision: 939221 URL: http://svn.apache.org/viewvc?rev=939221&view=rev Log: $Date$ was wrapped and thus broken in r939212 Replacing with $Id$ because of i18n and timezone issues that $Date$ has (http://subversion.tigris.org/issues/show_bug.cgi?i