Re: Catching up

2014-12-02 Thread Nick Williams
Huh. Amazing how fast that went. I'm caught up on everything since May 7 (last time I checked my email in this folder). Good job, everyone involved, on releasing 8.0.x stable, beginning 9.0.x, and addressing many bugs. Kudos! Nick On Dec 2, 2014, at 1:20 PM, Nick Williams wrote: &

Re: [PROPOSAL] Drop comet support in Tomcat 9 onwards

2014-12-02 Thread Nick Williams
On Jun 19, 2014, at 10:45 AM, Rémy Maucherat wrote: > 2014-06-18 23:40 GMT+02:00 Mark Thomas : > >> I have been thinking about connector refactoring for Tomcat 9. Currently >> BIO is planned to be dropped due to the number of features in the >> servlet spec that rely on non-blocking IO. >> >> I

Catching up

2014-12-02 Thread Nick Williams
Guys, For a myriad of personal, professional, and health reasons, I've been out of pocket for many months. I'm finally starting to catch up today on 9200 Tomcat developer and user list messages. It will take me many days. I just wanted to let y'all know that I'm still alive, and head off any "w

Re: [VOTE] Release Apache Tomcat 8.0.3

2014-02-10 Thread Nick Williams
On Feb 7, 2014, at 12:16 PM, Mark Thomas wrote: > The proposed Apache Tomcat 8.0.3 release is now available for voting. > > > > The proposed 8.0.3 release is: > [ ] Broken - do not release > [ ] Alpha - go ahead and release as 8.0.3 (alpha) > [X] Beta - go ahead and release as 8.0.3 (beta)

Re: support for salted passwords

2014-02-01 Thread Nick Williams
On Feb 2, 2014, at 1:23 AM, Gabriel E. Sánchez Martínez wrote: > Hi developers, > > I am very new to Tomcat but am already getting my feet wet with a web > application. A requirement for this application is form-based password > authentication, and I would like to store passwords in a databas

Re: [VOTE] Release Apache Tomcat 8.0.1

2014-02-01 Thread Nick Williams
Looks good! On Jan 29, 2014, at 5:43 PM, Mark Thomas wrote: > > > [X ] Beta - go ahead and release as 8.0.1 (beta) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.

Re: svn commit: r1542836 - /tomcat/trunk/java/org/apache/jasper/compiler/TagLibraryInfoImpl.java

2013-11-17 Thread Nick Williams
On Nov 17, 2013, at 4:10 PM, Jeremy Boynes wrote: > On Nov 17, 2013, at 1:42 PM, ma...@apache.org wrote: > >> Author: markt >> Date: Sun Nov 17 21:42:26 2013 >> New Revision: 1542836 >> >> URL: http://svn.apache.org/r1542836 >> Log: >> Revert part of r1542565 which added rather than removed an

Re: svn commit: r1539036 - in /tomcat/trunk: java/org/apache/catalina/loader/WebappLoader.java test/org/apache/catalina/loader/TestVirtualWebappLoader.java test/org/apache/catalina/loader/TestWebappCl

2013-11-05 Thread Nick Williams
On Nov 5, 2013, at 9:41 AM, ma...@apache.org wrote: > Author: markt > Date: Tue Nov 5 15:41:53 2013 > New Revision: 1539036 > > URL: http://svn.apache.org/r1539036 > Log: > Fix remainder of failing tests and a related TODO spotted in the tests as > well. > > > > Modified: > tomcat/trunk/te

Re: [VOTE] Release Apache Tomcat 7.0.44

2013-09-24 Thread Nick Williams
On Sep 24, 2013, at 11:00 AM, Rossen Stoyanchev wrote: > On Tue, Sep 24, 2013 at 11:40 AM, Mark Thomas wrote: > >> The necessary update to the script that uploads those JARs to the Maven >> repo was missed. I think I have fixed it locally but need to test it >> from somewhere with connectivity.

OT: Adding Filters and odd WebLogic Behavior

2013-09-23 Thread Nick Williams
This is very off topic, and for that I apologize. I'm working on fixing a bug in Log4j 2, and we've discovered something that just doesn't make any sense to me. I /believe/ it's a problem with WebLogic's implementation of the Servlet 3.0 specification, but I could be wrong, and based on my previ

Re: [VOTE] Release Apache Tomcat 7.0.43

2013-09-21 Thread Nick Williams
On Sep 21, 2013, at 6:07 AM, Konstantin Kolinko wrote: > 2013/9/21 Mark Thomas : >> On 20/09/2013 08:38, Violeta Georgieva wrote: >>> The proposed Apache Tomcat 7.0.43 release is now available for voting. >>> This release candidate contains JSR-356 Java WebSocket 1.0 implementation. >>> Note that

Re: SCI discovery ordering

2013-09-20 Thread Nick Williams
On Sep 20, 2013, at 4:33 PM, Jeremy Boynes wrote: > On Fri, Sep 20, 2013 at 8:50 AM, Mark Thomas wrote: > >> On 20/09/2013 16:02, Jeremy Boynes wrote: >>> The only ordering concern for SCIs in the spec is that they are >>> "discovered" following the classloader delegation model. This will >>> t

Re: SCI discovery ordering

2013-09-19 Thread Nick Williams
On Sep 19, 2013, at 11:32 AM, Jeremy Boynes wrote: > On Sep 19, 2013, at 8:36 AM, Mark Thomas wrote: > >> On 19/09/2013 16:31, Jeremy Boynes wrote: >>> On Sep 19, 2013, at 6:07 AM, ma...@apache.org wrote: >>> Author: markt Date: Thu Sep 19 13:07:02 2013 New Revision: 1524727 >>

Re: [Bug 55317] Facilitate weaving by allowing ClassFileTransformer to be added to WebppClassLoader

2013-09-12 Thread Nick Williams
On Aug 29, 2013, at 4:28 AM, bugzi...@apache.org wrote: > https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 > > --- Comment #16 from Mark Thomas --- > (In reply to Nick Williams from comment #15) >> Created attachment 30749 [details] >> Proposed implementatio

Re: Where to put a helper class for test?

2013-09-12 Thread Nick Williams
On Sep 12, 2013, at 1:03 PM, Mark Thomas wrote: > On 12/09/2013 18:31, Nick Williams wrote: >> Mark, >> >> I'm working on revisions to my patch for BZ 55317 based on your >> feedback. In this feedback you said: >> >>> 5. I'm not a fan of t

Where to put a helper class for test?

2013-09-12 Thread Nick Williams
Mark, I'm working on revisions to my patch for BZ 55317 based on your feedback. In this feedback you said: > 5. I'm not a fan of the org.apache.tomcat.unittest package unless the classes > concerned are going to be used by multiple tests across multiple packages. I put org.apache.tomcat.unitte

Re: svn commit: r1521817 - /tomcat/tc6.0.x/trunk/STATUS.txt

2013-09-11 Thread Nick Williams
On Sep 11, 2013, at 9:22 AM, Konstantin Kolinko wrote: > 2013/9/11 Mark Thomas : >> On 11/09/2013 14:44, Konstantin Kolinko wrote: >>> 2013/9/11 : Author: markt Date: Wed Sep 11 11:59:37 2013 New Revision: 1521817 URL: http://svn.apache.org/r1521817 Log: Comme

Re: svn commit: r1521594 [1/16] - in /tomcat/site/trunk: docs/ docs/images/ docs/stylesheets/ xdocs/images/ xdocs/stylesheets/

2013-09-10 Thread Nick Williams
On Sep 10, 2013, at 4:34 PM, Christopher Schultz wrote: > Mark, > > On 9/10/13 3:21 PM, ma...@apache.org wrote: >> Author: markt >> Date: Tue Sep 10 19:21:22 2013 >> New Revision: 1521594 > > It's amazing how a relatively small number of changes can take a page > from 1996 to ... well, at least

Re: svn commit: r1521023 - in /tomcat/trunk/java: javax/annotation/Generated.java javax/annotation/Resource.java org/apache/catalina/startup/WebAnnotationSet.java

2013-09-09 Thread Nick Williams
On Sep 9, 2013, at 5:24 AM, Mark Thomas wrote: > On 09/09/2013 11:20, Mark Thomas wrote: >> On 09/09/2013 11:09, ma...@apache.org wrote: >>> Author: markt >>> Date: Mon Sep 9 10:09:36 2013 >>> New Revision: 1521023 >>> >>> URL: http://svn.apache.org/r1521023 >>> Log: >>> Fix wrongly named annot

Re: [Bug 55317] Facilitate weaving by allowing ClassFileTransformer to be added to WebppClassLoader

2013-08-28 Thread Nick Williams
On Aug 28, 2013, at 9:07 AM, Mark Thomas wrote: > On 28/08/2013 13:36, Nick Williams wrote: >> >> On Aug 21, 2013, at 6:21 PM, bugzi...@apache.org wrote: >> >>> https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 >>> >>> Nick Willi

Re: [Bug 55317] Facilitate weaving by allowing ClassFileTransformer to be added to WebppClassLoader

2013-08-28 Thread Nick Williams
On Aug 21, 2013, at 6:21 PM, bugzi...@apache.org wrote: > https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 > > Nick Williams changed: > > What|Removed |Added >

Re: Can't build from trunk anymore -- problems with DBCP2

2013-08-21 Thread Nick Williams
On Aug 21, 2013, at 5:32 PM, Nick Williams wrote: > I have latest-ish from trunk (< 2 days old) and compiled without issue. When > I tried to run it, however, console output indicates a serious issue creating > DataSource resources: > > 21-Aug-2013 17:18:30.800 WARNING [loc

Can't build from trunk anymore -- problems with DBCP2

2013-08-21 Thread Nick Williams
I have latest-ish from trunk (< 2 days old) and compiled without issue. When I tried to run it, however, console output indicates a serious issue creating DataSource resources: 21-Aug-2013 17:18:30.800 WARNING [localhost-startStop-1] org.apache.catalina.core.NamingContextListener.addResource Fa

Re: Need guidance for writing unit tests for 55317

2013-08-21 Thread Nick Williams
On Aug 21, 2013, at 12:46 PM, sebb wrote: > On 21 August 2013 14:48, Christopher Schultz > wrote: >> Nick, >> >> On 8/20/13 8:24 PM, Nick Williams wrote: >>> I ran in to a roadblock with this idea. Part of the byte code of a >>> class includes the

Re: [GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2013-08-21 Thread Nick Williams
On Aug 21, 2013, at 6:14 AM, Mark Thomas wrote: > I'm not exactly sure what the problem is. It looks like the WebSocket > SCI is being registered twice or is running twice but I can't reproduce > the problem. Anyone got any ideas? > > Currently, my plan is to add some logging to the SCI registra

Re: Need guidance for writing unit tests for 55317

2013-08-21 Thread Nick Williams
On Aug 21, 2013, at 2:58 AM, Mark Thomas wrote: > On 21/08/2013 01:24, Nick Williams wrote: > >> My backup idea is slightly less clean but, IMO, still more clean than adding >> ASM as a test-time dependency and trying to figure all of that out. I >> locally compiled f

Re: Need guidance for writing unit tests for 55317

2013-08-20 Thread Nick Williams
On Aug 20, 2013, at 1:10 PM, Mark Thomas wrote: > On 20/08/2013 18:47, Nick Williams wrote: >> My remaining original concern was the best approach for weaving byte >> code in Tomcat's unit tests, which I detailed in an earlier message. > > Use the Weaver to completel

Re: Need guidance for writing unit tests for 55317

2013-08-20 Thread Nick Williams
On Aug 20, 2013, at 12:41 PM, Christopher Schultz wrote: > Nick, > > On 8/20/13 1:25 PM, Christopher Schultz wrote: >> tcnative can be built on Max OS X like this: >> >> $ cd $CATALINA_HOME/bin >> $ tar xzf tomcat-native.tar.gz >> $ cd tomcat-native-*-src/jni/native >> $ ./configure --with-apr=

Re: Need guidance for writing unit tests for 55317

2013-08-20 Thread Nick Williams
On Aug 20, 2013, at 10:12 AM, Christopher Schultz wrote: > Mark, > > On 8/20/13 9:25 AM, Mark Thomas wrote: >> On 20/08/2013 14:13, Nick Williams wrote: >>> I'm working on implementing bugzilla 55317. It's a pretty important >>> change (weaving) to a

Re: Need guidance for writing unit tests for 55317

2013-08-20 Thread Nick Williams
On Aug 20, 2013, at 8:25 AM, Mark Thomas wrote: > On 20/08/2013 14:13, Nick Williams wrote: >> I'm working on implementing bugzilla 55317. It's a pretty important >> change (weaving) to a pretty import class (WebappClassLoader), so it >> obviously needs some u

Need guidance for writing unit tests for 55317

2013-08-20 Thread Nick Williams
I'm working on implementing bugzilla 55317. It's a pretty important change (weaving) to a pretty import class (WebappClassLoader), so it obviously needs some unit tests. However, I need some guidance: 1) I've never gotten all the existing tests to pass on my machine. Last time I ran them it too

Re: svn commit: r1515779 - /tomcat/trunk/test/org/apache/tomcat/websocket/pojo/TestEncodingDecoding.java

2013-08-20 Thread Nick Williams
On Aug 20, 2013, at 7:59 AM, Mark Thomas wrote: > On 20/08/2013 13:45, Nick Williams wrote: >> >> On Aug 20, 2013, at 6:14 AM, ma...@apache.org wrote: >> >>> Author: markt >>> Date: Tue Aug 20 11:14:39 2013 >>> New Revision: 1515779 >>>

Re: svn commit: r1515779 - /tomcat/trunk/test/org/apache/tomcat/websocket/pojo/TestEncodingDecoding.java

2013-08-20 Thread Nick Williams
On Aug 20, 2013, at 6:14 AM, ma...@apache.org wrote: > Author: markt > Date: Tue Aug 20 11:14:39 2013 > New Revision: 1515779 > > URL: http://svn.apache.org/r1515779 > Log: > Add the rather crucial missing i++ in the wait loop Lol. Don't you hate when you do that?

Re: Using log4j under a security manager

2013-08-17 Thread Nick Williams
On Aug 17, 2013, at 7:36 AM, Christopher Schultz wrote: > All, > > See this SO thread: > http://stackoverflow.com/questions/18147885/use-log4j-in-a-tomcat-with-security-manager > > ...and refer to the Tomcat 7 log4j instructions: > > http://tomcat.apache.org/tomcat-7.0-doc/logging.html#Using_L

Re: Back-porting JSR-356 implementation to 7.0.x

2013-08-15 Thread Nick Williams
On Aug 15, 2013, at 5:47 PM, Mark Thomas wrote: > This isn't going to be quite as simple as I first thought. > > The WebSocket client API requires Java SE 7 or later. > The WebSocket server API requires Java EE 6 or later. > Java EE 6 requires Java 6 or later. > The WebSocket server API depends

Re: Code style rules: Line length

2013-08-08 Thread Nick Williams
On Aug 8, 2013, at 12:50 PM, Mark Thomas wrote: > Currently, Tomcat has an 'guide' of a maximum of 80 characters for line > length. It has been a while since we reviewed this and as we are looking > at style rules... > > As a starting point what do folks think of the following options: > > Line

Re: Use (or not) of @SuppressWarnings

2013-08-07 Thread Nick Williams
On Aug 7, 2013, at 2:41 AM, Mark Thomas wrote: > For trunk we have been running a policy of zero warnings in the code. > This has helped to highlight issues as code is edited as any warnings > are immediately clear. Obviously, this depends on what warnings are enabled. > > Currently, we use Ecli

Re: [VOTE][RESULT] Release Apache Tomcat 8.0.0-RC1

2013-08-06 Thread Nick Williams
On Aug 6, 2013, at 9:53 AM, Mark Thomas wrote: > On 06/08/2013 16:30, Nick Williams wrote: >> >> On Aug 6, 2013, at 9:27 AM, Mark Thomas wrote: >> >>> On 06/08/2013 12:57, Nick Williams wrote: >>> >>>> The migration guide says Tomcat 8 suppor

Re: [VOTE][RESULT] Release Apache Tomcat 8.0.0-RC1

2013-08-06 Thread Nick Williams
On Aug 6, 2013, at 9:27 AM, Mark Thomas wrote: > On 06/08/2013 12:57, Nick Williams wrote: > >> The migration guide says Tomcat 8 supports Expression Language 2.3. >> Should be 3.0. You (might) also want to call it Java Unified >> Expression Language. That'

Re: [VOTE][RESULT] Release Apache Tomcat 8.0.0-RC1

2013-08-06 Thread Nick Williams
On Aug 6, 2013, at 4:22 AM, Ognjen Blagojevic wrote: > Mark, > > On 5.8.2013 22:56, Mark Thomas wrote: >> The site has been updated with the various parts required for a new >> major release (security, migration, download, docs, navigation, which >> version etc.) but I haven't posted the release

Re: svn commit: r1510665 [26/26] - in /tomcat/site/trunk/docs/tomcat-8.0-doc/servletapi: ./ javax/ javax/servlet/ javax/servlet/annotation/ javax/servlet/descriptor/ javax/servlet/http/ resources/

2013-08-05 Thread Nick Williams
On Aug 5, 2013, at 2:10 PM, ma...@apache.org wrote: > Added: tomcat/site/trunk/docs/tomcat-8.0-doc/servletapi/serialized-form.html > URL: > http://svn.apache.org/viewvc/tomcat/site/trunk/docs/tomcat-8.0-doc/servletapi/serialized-form.html?rev=1510665&view=auto > =

Re: svn commit: r1510210 - /tomcat/trunk/build.xml

2013-08-04 Thread Nick Williams
On Aug 4, 2013, at 2:40 PM, Mark Thomas wrote: > On 04/08/2013 21:31, Nick Williams wrote: >> >> On Aug 4, 2013, at 2:27 PM, Mark Thomas wrote: >> >>> On 04/08/2013 21:02, Jeremy Boynes wrote: >>>> On Aug 4, 2013, at 8:37 AM, ma..

Re: svn commit: r1510210 - /tomcat/trunk/build.xml

2013-08-04 Thread Nick Williams
On Aug 4, 2013, at 2:27 PM, Mark Thomas wrote: > On 04/08/2013 21:02, Jeremy Boynes wrote: >> On Aug 4, 2013, at 8:37 AM, ma...@apache.org wrote: >>> Log: >>> Treat javax.servlet.ServletContainerInitializer files as text in source >>> >>> >>> + >>> >> >> Would this work to catch

Re: [VOTE] Release Apache Tomcat 8.0.0-RC1

2013-08-03 Thread Nick Williams
On Aug 1, 2013, at 3:53 PM, Mark Thomas wrote: > The proposed 8.0.0-RC1 release is: > [ ] Broken - do not release > [ X] Alpha - go ahead and release as 8.0.0-RC1 alpha (Non-binding) Tested the .zip distribution on Windows 7 SP1 64-bit. Everything seems to be functioning properly.

Re: Using a mock framework for testing?

2013-07-31 Thread Nick Williams
On Jul 31, 2013, at 11:09 AM, Jeremy Boynes wrote: > Any objection to adding a dependency on a mocking framework to aid unit > testing? > The one I have used most is EasyMock which is Apache License 2.0. > > Cheers > Jeremy EasyMock is fantastic. I use it for everything I do, and we're using i

Re: svn commit: r1508171 - /tomcat/trunk/java/org/apache/catalina/startup/WebappServiceLoader.java

2013-07-29 Thread Nick Williams
r (Object o : orderedLibs) { > +String lib = (String) o; > URL jarUrl = context.getResource(LIB + lib); > if (jarUrl == null) { > // should not happen, just ignore > > > > On Mon, Jul 29, 2013 at 12:40 PM, Mark

Re: svn commit: r1508171 - /tomcat/trunk/java/org/apache/catalina/startup/WebappServiceLoader.java

2013-07-29 Thread Nick Williams
On Jul 29, 2013, at 3:02 PM, Mark Thomas wrote: > On 29/07/2013 21:45, Nick Williams wrote: >> >> On Jul 29, 2013, at 2:40 PM, Mark Thomas wrote: >> >>> On 29/07/2013 21:04, Nick Williams wrote: >>>> On Jul 29, 2013, at 2:02 PM, Jeremy Boynes wrote:

Re: svn commit: r1508171 - /tomcat/trunk/java/org/apache/catalina/startup/WebappServiceLoader.java

2013-07-29 Thread Nick Williams
On Jul 29, 2013, at 2:40 PM, Mark Thomas wrote: > On 29/07/2013 21:04, Nick Williams wrote: >> On Jul 29, 2013, at 2:02 PM, Jeremy Boynes wrote: >> >>> This flags as a warning for me in IDEA without the suppression. Isn't this >>> an unchecked cast (Object

Re: svn commit: r1508171 - /tomcat/trunk/java/org/apache/catalina/startup/WebappServiceLoader.java

2013-07-29 Thread Nick Williams
On Jul 29, 2013, at 2:02 PM, Jeremy Boynes wrote: > This flags as a warning for me in IDEA without the suppression. Isn't this > an unchecked cast (Object to List)? Yes, that's an unchecked cast. The @SuppressWarnings was not unnecessary. N > > > On Mon, Jul 29, 2013 at 11:38 AM, wrote: > >

Re: 8.0.0 (was: 8.0-SNAPSHOT updated)

2013-07-25 Thread Nick Williams
On Jul 25, 2013, at 6:49 PM, Rainer Jung wrote: > On 26.07.2013 00:34, Mark Thomas wrote: >> On 21/07/2013 09:10, Mark Thomas wrote: >>> On 20/07/2013 17:42, Konstantin Kolinko wrote: 2013/7/18 Mark Thomas : >> >> >> > Any objections to starting the 8.0.0 release process? W

Re: 8.0-SNAPSHOT updated

2013-07-18 Thread Nick Williams
No objection here. Things seem to be working well. I'm rather excited about it. :-) Nick On Jul 18, 2013, at 11:11 AM, Mark Thomas wrote: > Given recent progress, I have uploaded a snapshot of the current state > of trunk to the Maven snapshot repository. Note that our Maven builds > include fu

Re: svn commit: r1504148 - in /tomcat/trunk: java/org/apache/jasper/compiler/ java/org/apache/jasper/el/ java/org/apache/jasper/runtime/ test/javax/el/ test/org/apache/el/ test/org/apache/el/parser/ t

2013-07-17 Thread Nick Williams
On Jul 17, 2013, at 9:21 AM, Caldarale, Charles R wrote: >> From: ma...@apache.org [mailto:ma...@apache.org] >> Subject: svn commit: r1504148 > >> URL: http://svn.apache.org/r1504148 >> Log: >> Add the two new resolver types (stream and static) to Jasper in the correct >> order and modify Jasp

Re: svn commit: r1497670 - /tomcat/trunk/java/org/apache/tomcat/websocket/server/WsFilter.java

2013-06-28 Thread Nick Williams
On Jun 28, 2013, at 11:27 AM, Mark Thomas wrote: > On 28/06/2013 17:00, Nick Williams wrote: >> >> On Jun 28, 2013, at 2:35 AM, ma...@apache.org wrote: >> >>> Author: markt Date: Fri Jun 28 07:35:49 2013 New Revision: 1497670 >>> >>> URL: h

Re: svn commit: r1497670 - /tomcat/trunk/java/org/apache/tomcat/websocket/server/WsFilter.java

2013-06-28 Thread Nick Williams
On Jun 28, 2013, at 2:35 AM, ma...@apache.org wrote: > Author: markt > Date: Fri Jun 28 07:35:49 2013 > New Revision: 1497670 > > URL: http://svn.apache.org/r1497670 > Log: > WebSocket 1.0, section 8.2 > There is an implied restriction that any initial upgrade request must use > HTTP GET. > >

Re: svn commit: r1497552 - /tomcat/trunk/test/org/apache/tomcat/websocket/pojo/TestEncodingDecoding.java

2013-06-27 Thread Nick Williams
On Jun 27, 2013, at 6:14 PM, Konstantin Kolinko wrote: > 2013/6/28 : >> Author: markt >> Date: Thu Jun 27 20:10:40 2013 >> New Revision: 1497552 >> >> URL: http://svn.apache.org/r1497552 >> Log: >> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55151 >> Fix bugs in test >> >> Modified:

Re: svn commit: r1497569 - /tomcat/trunk/java/org/apache/tomcat/websocket/server/WsServerContainer.java

2013-06-27 Thread Nick Williams
On Jun 27, 2013, at 4:32 PM, ma...@apache.org wrote: > Author: markt > Date: Thu Jun 27 21:32:39 2013 > New Revision: 1497569 > > URL: http://svn.apache.org/r1497569 > Log: > With an eye to the future, First phrase of your new novel? :-) ---

Re: svn commit: r1497299 - /tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java

2013-06-27 Thread Nick Williams
On Jun 27, 2013, at 9:42 AM, Mark Thomas wrote: > On 27/06/2013 15:29, Nick Williams wrote: >> >> On Jun 27, 2013, at 6:08 AM, ma...@apache.org wrote: >> >>> Author: markt >>> Date: Thu Jun 27 11:08:03 2013 >>> New Revision: 1497299 >

Re: svn commit: r1497299 - /tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java

2013-06-27 Thread Nick Williams
On Jun 27, 2013, at 6:08 AM, ma...@apache.org wrote: > Author: markt > Date: Thu Jun 27 11:08:03 2013 > New Revision: 1497299 > > URL: http://svn.apache.org/r1497299 > Log: > WebSocket 1.0, Section 4.8 > Don't look for annotations on inherited methods. > > Modified: >tomcat/trunk/java/org/a

Re: Jasper improvements

2013-06-26 Thread Nick Williams
On Jun 26, 2013, at 1:57 PM, Jeremy Boynes wrote: > On Jun 26, 2013, at 7:49 AM, Christopher Schultz > wrote: > >> Jeremy, >> >> On 6/26/13 1:44 AM, Jeremy Boynes wrote: >>> On Jun 11, 2013, at 1:50 PM, Nick Williams >>> wrote: >>>>

Re: CVE-2013-1571, VU#225657

2013-06-19 Thread Nick Williams
On Jun 19, 2013, at 3:15 AM, Mark Thomas wrote: > On 19/06/2013 00:42, Nick Williams wrote: >> Oracle has announced a Javadoc vulnerability (CVE-2013-1571 [1], >> VU#225657 [2]) whereby Javadoc generated with Java 5, Java 6, or Java >> 7 < 7u25 is vulnerable to a frame

CVE-2013-1571, VU#225657

2013-06-18 Thread Nick Williams
Oracle has announced a Javadoc vulnerability (CVE-2013-1571 [1], VU#225657 [2]) whereby Javadoc generated with Java 5, Java 6, or Java 7 < 7u25 is vulnerable to a frame injection attack. Oracle has provided a repair-in-place tool for Javadoc that cannot be easily regenerated, but is urging devel

Re: svn commit: r1493584 - in /tomcat/trunk: res/findbugs/filter-false-positives.xml test/org/apache/catalina/core/TestApplicationSessionCookieConfig.java

2013-06-16 Thread Nick Williams
On Jun 16, 2013, at 4:14 PM, ma...@apache.org wrote: > Author: markt > Date: Sun Jun 16 21:14:37 2013 > New Revision: 1493584 > > URL: http://svn.apache.org/r1493584 > Log: > Fix FindBugs warnings in test code > > Modified: >tomcat/trunk/res/findbugs/filter-false-positives.xml > > tomca

Re: Jar scanning, SCI scanning, fragment scanning

2013-06-13 Thread Nick Williams
On Jun 13, 2013, at 11:23 AM, Mark Thomas wrote: > As I make my way through the Servlet 3.1 spec reviewing all the changes to > make sure they have all been implemented, I have reached section 8.2. There > are a number of related issues here. > > 1. Three known issues with the current SCI / fr

Re: Timeline for beginning EL 3.0 implementation?

2013-06-11 Thread Nick Williams
On Jun 11, 2013, at 3:36 PM, Mark Thomas wrote: > On 11/06/2013 21:29, Nick Williams wrote: >> I was looking through EE 7 and the changes to trunk in the last six >> months or so and realized that no work had yet been done to implement >> EL 3.0. Does anyone know what the an

Re: svn commit: r1491940 - in /tomcat/trunk: java/org/apache/catalina/core/AsyncContextImpl.java java/org/apache/catalina/core/LocalStrings.properties test/org/apache/catalina/core/TestAsyncContextImp

2013-06-11 Thread Nick Williams
On Jun 11, 2013, at 3:28 PM, Mark Thomas wrote: > On 11/06/2013 21:25, Konstantin Kolinko wrote: >> 2013/6/12 : >>> Author: markt >>> Date: Tue Jun 11 20:18:10 2013 >>> New Revision: 1491940 >>> >>> URL: http://svn.apache.org/r1491940 >>> Log: >>> Servlet 3.1 requires an ISE if getRequest() or

Timeline for beginning EL 3.0 implementation?

2013-06-11 Thread Nick Williams
I was looking through EE 7 and the changes to trunk in the last six months or so and realized that no work had yet been done to implement EL 3.0. Does anyone know what the anticipated timeline is for beginning work on EL 3.0? I don't even know who the EL expert(s) on the Tomcat project is(are).

LOG4J2-223: IllegalStateException thrown during Tomcat shutdown (memory leak, it looks like)

2013-05-18 Thread Nick Williams
Can one of the very knowledgeable developers that have been discussing memory leaks in the last few days (re: Possible false-postive with JreMemoryLeakPreventionListener and Tomcat's JDBC Pool and OracleTimeoutPollingThread) chime in on this Log4j 2 bug [1]? Log4j 2 appears to be registering a

OT: How do I subscribe to the Tomcat Dev/User lists with my @apache.org address?

2013-05-14 Thread Nick Williams
I recently became a committer on the Logging project and thus I now have an @apache.org address. Since it's a forwarding address, I'm having it forward to my Google Apps email address (the address I'm sending from now). I'd like to subscribe to the Tomcat Dev and User lists with my @apache.org

Re: svn commit: r1480974 [1/4] - in /tomcat/trunk: ./ java/javax/servlet/jsp/resources/ java/javax/servlet/resources/ res/META-INF/

2013-05-10 Thread Nick Williams
On May 10, 2013, at 8:35 AM, Mark Thomas wrote: > On 10/05/2013 14:22, Nick Williams wrote: >> >> On May 10, 2013, at 5:07 AM, ma...@apache.org wrote: >> >>> Author: markt >>> Date: Fri May 10 10:07:21 2013 >>> New Revision: 1480974 >>>

Re: svn commit: r1480974 [1/4] - in /tomcat/trunk: ./ java/javax/servlet/jsp/resources/ java/javax/servlet/resources/ res/META-INF/

2013-05-10 Thread Nick Williams
On May 10, 2013, at 5:07 AM, ma...@apache.org wrote: > Author: markt > Date: Fri May 10 10:07:21 2013 > New Revision: 1480974 > > URL: http://svn.apache.org/r1480974 > Log: > Add the Java EE 7 XSDs. Mark, were these hand-coded or copied from some other source? If copied, could you let me know

Re: svn commit: r1479179 - in /tomcat/trunk: java/org/apache/coyote/http11/AbstractHttp11Processor.java webapps/examples/WEB-INF/web.xml

2013-05-04 Thread Nick Williams
On May 4, 2013, at 4:20 PM, ma...@apache.org wrote: > Author: markt > Date: Sat May 4 21:20:27 2013 > New Revision: 1479179 > > URL: http://svn.apache.org/r1479179 > Log: > 204 responses are permitted entity headers > > Modified: >tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Pr

Re: Java 7 support on Tomcat 5.5

2013-04-01 Thread Nick Williams
On Apr 1, 2013, at 3:44 PM, Satheesh Babu wrote: > Good Evening! > > We're running our production applications in Tomcat 5.5/JRE 1.5, and there is > a need for us to migrate our applications to Java 7(JRE 1.7). There is no > information available either on java or on Apace Tomcat site regradin

Re: JarScanning

2013-03-29 Thread Nick Williams
On Mar 29, 2013, at 12:57 PM, Konstantin Kolinko wrote: > 2013/3/29 Nick Williams : >> >> >> (..) Note that Log4j2 is going to have a log4j-taglib artifact that >> (naturally) will have a TLD in its META-INF. Since Tomcat by default >> excludes log4j*

Re: JarScanning

2013-03-28 Thread Nick Williams
On Feb 26, 2013, at 11:21 AM, Christopher Schultz wrote: > Mark, > > On 2/21/13 8:34 AM, Mark Thomas wrote: >> JRE JARs. >> I think scanning of these should be made optional and disabled by >> default. This will reduce the list of JARs we have to maintain in >> jarsToSkip. I intend to implement

Re: My recent contributions and my ICLA

2013-03-27 Thread Nick Williams
On Mar 27, 2013, at 9:41 AM, Mark Thomas wrote: > On 27/03/2013 14:35, Nick Williams wrote: >> I have made several contributions to Tomcat recently. Upon beginning >> some work on implementing a log4j-taglib module for Log4j 2, it came >> to my attention that I need

Re: My recent contributions and my ICLA

2013-03-27 Thread Nick Williams
I have made several contributions to Tomcat recently. Upon beginning some work on implementing a log4j-taglib module for Log4j 2, it came to my attention that I need to have an Individual Contributor License Agreement on file with the ASF Secretary. This has been done now, and my ICLA has been a

Re: svn commit: r1460700 - /tomcat/trunk/java/org/apache/tomcat/websocket/server/WsSci.java

2013-03-25 Thread Nick Williams
On Mar 25, 2013, at 10:01 AM, ma...@apache.org wrote: > Author: markt > Date: Mon Mar 25 15:01:41 2013 > New Revision: 1460700 > > URL: http://svn.apache.org/r1460700 > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54740 > Update SCI scan to reflect changes in spec > > Modified:

Re: Getting my head around NIO 'simulated' blocking (trying to)

2013-03-23 Thread Nick Williams
On Mar 23, 2013, at 10:05 AM, igaz wrote: > So I won't bury the lede: what exactly (and why) is Tomcat doing 'simulated' > read blocking when using the NIO connector? > > I've done some due diligence including downloading the latest source > (7.0.37) and searching the tomcat mailing lists. > Fi

Re: Missing Classes in latest tomcat-embed-logging-log4j snapshot

2013-03-22 Thread Nick Williams
On Mar 22, 2013, at 11:28 AM, Nick Williams wrote: > In the latest snapshot (3/21) of tomcat-embed-logging-log4j, all of the > classes in org.apache.juli.logging.* are missing. They are there in the 3/14 > snapshot, and they are there in the 3/21 SOURCES snapshot, but they are not &

Missing Classes in latest tomcat-embed-logging-log4j snapshot

2013-03-22 Thread Nick Williams
In the latest snapshot (3/21) of tomcat-embed-logging-log4j, all of the classes in org.apache.juli.logging.* are missing. They are there in the 3/14 snapshot, and they are there in the 3/21 SOURCES snapshot, but they are not there in the 3/21 binaries snapshot. Something foobar happened here. Th

Re: Can we get another Maven 8.0.0.SNAPSHOT?

2013-03-21 Thread Nick Williams
On Mar 21, 2013, at 5:49 PM, Mark Thomas wrote: > On 21/03/2013 18:06, Nick Williams wrote: >> Been a week since the last snapshot. LOTS of big WebSocket changes since >> then, including a fix for a problem with the core artifact JAR. Can we get >> another snapshot

Can we get another Maven 8.0.0.SNAPSHOT?

2013-03-21 Thread Nick Williams
Been a week since the last snapshot. LOTS of big WebSocket changes since then, including a fix for a problem with the core artifact JAR. Can we get another snapshot build sometime today? Thanks! - To unsubscribe, e-mail: dev-uns

Re: svn commit: r1459389 - /tomcat/trunk/java/org/apache/tomcat/util/codec/binary/BaseNCodec.java

2013-03-21 Thread Nick Williams
On Mar 21, 2013, at 11:37 AM, ma...@apache.org wrote: > Author: markt > Date: Thu Mar 21 16:37:49 2013 > New Revision: 1459389 > > URL: http://svn.apache.org/r1459389 > Log: > Improve performance for typical use cases by roughly an order of magnitude > > Modified: >tomcat/trunk/java/org/apa

Re: WebServlets and HttpSessions (again) ... How to update last accessed time?

2013-03-21 Thread Nick Williams
On Mar 20, 2013, at 5:24 PM, Nick Williams wrote: > Reading through the expert mailing list for the WebSocket spec, I gather that > the experts did not feel it appropriate to update the last access time for > HttpSession objects when messages are received. I DO agree with this; ther

Re: [Bug 54721] New: RemoteEndpoint blocks indefinitely if sendObject called with BinaryStream of TextStream encoders

2013-03-21 Thread Nick Williams
On Mar 21, 2013, at 9:07 AM, Christopher Schultz wrote: > Nick, > > On 3/18/13 6:03 PM, Nick Williams wrote: >> >> I've been busy fleshing out all kinds of problems. :-) > > Careful: you might inadvertently become the babysitter of Tomcat's > Websocke

Re: OT: Will web containers be required to implement WebSockets

2013-03-21 Thread Nick Williams
On Mar 21, 2013, at 9:54 AM, Christopher Schultz wrote: > Nick, > > On 3/21/13 10:17 AM, Nicholas Williams wrote: >> I know that WebSockets will be a part of the Java EE 7 specification >> for full application servers. But will web containers also be required >> to implement this? Or will it be

Re: Use of JAXB api to process Base64 in Tomcat 7 and 8

2013-03-20 Thread Nick Williams
On Mar 21, 2013, at 12:35 AM, Konstantin Kolinko wrote: > Hi! > > Recent Mark's commits in Tomcat 7, 8 replaced custom > implementations(*) of base64 > with use of the following class from JAXB: > > javax.xml.bind.DatatypeConverter > > This affects base64 processing in our own classes and in o

Re: svn commit: r1459043 - /tomcat/trunk/test/org/apache/catalina/core/TesterContext.java

2013-03-20 Thread Nick Williams
On Mar 20, 2013, at 6:45 PM, Mark Thomas wrote: > On 20/03/2013 22:50, Nick Williams wrote: >> >> On Mar 20, 2013, at 5:48 PM, Mark Thomas wrote: >> >>> On 20/03/2013 21:35, Nick Williams wrote: > > > >>>> Also agreed. However, r1459028

Re: svn commit: r1459043 - /tomcat/trunk/test/org/apache/catalina/core/TesterContext.java

2013-03-20 Thread Nick Williams
On Mar 20, 2013, at 5:48 PM, Mark Thomas wrote: > On 20/03/2013 21:35, Nick Williams wrote: >> >> On Mar 20, 2013, at 3:53 PM, Mark Thomas wrote: >> >>> On 20/03/2013 20:50, Remy Maucherat wrote: >>>> On Wed, 2013-03-20 at 20:46 +, ma...@apache

WebServlets and HttpSessions (again) ... How to update last accessed time?

2013-03-20 Thread Nick Williams
Reading through the expert mailing list for the WebSocket spec, I gather that the experts did not feel it appropriate to update the last access time for HttpSession objects when messages are received. I DO agree with this; there's no way to know what the user really wants here, and it could be a

Re: svn commit: r1459043 - /tomcat/trunk/test/org/apache/catalina/core/TesterContext.java

2013-03-20 Thread Nick Williams
On Mar 20, 2013, at 3:53 PM, Mark Thomas wrote: > On 20/03/2013 20:50, Remy Maucherat wrote: >> On Wed, 2013-03-20 at 20:46 +, ma...@apache.org wrote: >>> Author: markt >>> Date: Wed Mar 20 20:46:04 2013 >>> New Revision: 1459043 >>> >>> URL: http://svn.apache.org/r1459043 >>> Log: >>> Add n

Re: Time for 7.0.39

2013-03-20 Thread Nick Williams
On Mar 20, 2013, at 3:55 PM, Mark Thomas wrote: > I plan to get the most recent FileUpload changes (if any), run the unit > tests, run the TCKs and then tag 7.0.39 so that should happen some time > early tomorrow if all goes well. > > Mark In 54734 I propose a patch that needs to also be back-p

Re: Servlet 3.1 Request Upgrade

2013-03-19 Thread Nick Williams
On Mar 11, 2013, at 3:37 PM, Mark Thomas wrote: > On 09/03/2013 23:03, Nick Williams wrote: >> Mark, >> >> I noticed the HttpServletRequest upgrade method still had the >> signature void upgrade(HttpUpgradeHandler) when it should be > extends HttpUpgradeHandler>

AJP + WebSockets

2013-03-19 Thread Nick Williams
I was working on the recent change in the Servlet 3.1 spec for HttpServletRequest#upgrade(...) and noticed that the AbstractAjpProcessor doesn't support HTTP Upgrade (and, by extension, doesn't support WebSockets). Only the AbstractHttp11Processor does. Is there a plan for AJP to support Upgrad

Changelog has training whitespace

2013-03-19 Thread Nick Williams
validate: [mkdir] Created dir: C:\Tomcat-Build\Source\output\res\checkstyle [checkstyle] Running Checkstyle 5.6 on 2516 files [checkstyle] C:\Tomcat-Build\Source\webapps\docs\changelog.xml:128: Line matches the illegal pattern '\s+$'. BUILD FAILED C:\Tomcat-Build\Source\build.xml:485: Got 1 e

WebSockets: Automatic closure on HttpSession invalidation?

2013-03-18 Thread Nick Williams
Mark, I was reading on the expert mailing list the other day a discussion about containers automatically closing WebSocket sessions when the corresponding HttpSession instance is invalidate. I have a strange race condition going on that I think could be caused by that. Is Tomcat automatically c

Re: [Bug 54721] New: RemoteEndpoint blocks indefinitely if sendObject called with BinaryStream of TextStream encoders

2013-03-18 Thread Nick Williams
On Mar 18, 2013, at 5:01 PM, bugzi...@apache.org wrote: > https://issues.apache.org/bugzilla/show_bug.cgi?id=54721 > >Bug ID: 54721 > Summary: RemoteEndpoint blocks indefinitely if sendObject >called with BinaryStream of TextStream encoders > P

Re: Autobahn test results for Tomcat 8's web socket implementation

2013-03-13 Thread Nick Williams
On Mar 13, 2013, at 6:46 PM, Mark Thomas wrote: > FYI > > http://people.apache.org/~markt/dev/autobahn-tomcat-8/ > > I'll post updates periodically. > > Mark Updates? Looks like you're done. :-) - To unsubscribe, e-mail: dev

Re: Question on SERVLET_SPEC-57 (getSubmittedFileName)

2013-03-09 Thread Nick Williams
On Mar 9, 2013, at 4:57 PM, Mark Thomas wrote: > Nick Williams wrote: > >> >> On Mar 9, 2013, at 3:49 PM, Mark Thomas wrote: >> >>> Renaming the method is fine. >>> >>> We don't change the API for the sake of it but if there is a need

Servlet 3.1 Request Upgrade

2013-03-09 Thread Nick Williams
Mark, I noticed the HttpServletRequest upgrade method still had the signature void upgrade(HttpUpgradeHandler) when it should be T upgrade(Class) per the latest spec. What's your status on getting this changed? I started to try to clean this up a bit (I can email you a partial patch that has

  1   2   >