Regarding question b), I vote yes, whatever the organization of the development
Regarding a), for my part I rather see something between A and B. I think of
the following questions that should be answered first :
- will there be 1 repo per major version like the current SVN setup ? or only
branc
Hello,
Back in january/february there was a thread on moving to git with many +1 for
it. Are there any concrete plans for this ?
I'm looking forward to it as using SVN from Europe is so slow... or maybe I'm
now too accustomed to git's speed ;-)
I was wondering what the workflow would be for to
On 23 mai 2014, at 22:04, Mark Thomas wrote:
> On 23/05/2014 21:00, Sylvain Laurent wrote:
>>
>> Would it be possible to have assertion failures in stdio too ?
>
> No need.
why not ? this would avoid having to jump to different files to find the
culprit of a failed bu
Hello all,
In the last couple of days, several buildbot runs failed because of
intermittent failures in TestStuckThreadDetectionValve.
By following links provided in buildbot emails or the ones in
http://ci.apache.org/builders/tomcat-trunk , I arrived in the large stdio file
of the failing buil
om that, I cannot see where it failed.
I also tried to look in
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-nio/gump_file/TEST-org.apache.catalina.valves.TestStuckThreadDetectionValve.NIO.txt.html
but it's now a later (passing) build...
any ideas on why it would fail witho
ok, I reverted (r1596664). Sorry, I had not checked the README, everything was
explained...
who can fix the buildbot config now ?
Sylvain
On 21 mai 2014, at 00:18, Konstantin Kolinko wrote:
> 2014-05-21 1:41 GMT+04:00 Sylvain Laurent :
>> so, I just have to fix /xdocs/ci.xml
so, I just have to fix /xdocs/ci.xml ? and the buildbot generates ci.html and
commits it ?
On 20 mai 2014, at 23:14, Konstantin Kolinko wrote:
> 2014-05-21 0:58 GMT+04:00 :
>> Author: slaurent
>> Date: Tue May 20 20:58:55 2014
>> New Revision: 1596415
>>
>> URL: http://svn.apache.org/r15964
returned...
I hope this will be ok with the next build...
Sylvain
On 20 mai 2014, at 21:14, Sylvain Laurent wrote:
> I'll have a look at this right now.
>
>
> On 19 mai 2014, at 23:28, Konstantin Kolinko wrote:
>
>> 2014-05-19 23:30 GMT+04:00 :
>>> The Bui
I'll have a look at this right now.
On 19 mai 2014, at 23:28, Konstantin Kolinko wrote:
> 2014-05-19 23:30 GMT+04:00 :
>> The Buildbot has detected a new failure on builder tomcat-trunk while
>> building ASF Buildbot.
>> Full details are available at:
>> http://ci.apache.org/builders/tomcat-t
On 16 janv. 2012, at 10:44, Rainer Jung wrote:
>
> 1) Unit test failure due to missing target directory in src dist
>
>
> I noticed that test/webapp-3.0-virtual-library/target is missing from the src
> dist. So when rebuilding fro
On 20 déc. 2011, at 12:22, Mark Thomas wrote:
>
> Where I disagree is on whether a switch to Maven lowers that barrier to
> entry. I agree it lowers it for folks that already know Maven but don't
> know Ant but that it raises it for folks that know Ant but don't know Maven.
Knowing ant does not
On 20 déc. 2011, at 12:22, Mark Thomas wrote:
>
> Where I disagree is on whether a switch to Maven lowers that barrier to
> entry. I agree it lowers it for folks that already know Maven but don't
> know Ant but that it raises it for folks that know Ant but don't know Maven.
Knowing ant does not
should be fixed with r1209731
On 2 déc. 2011, at 22:19, build...@apache.org wrote:
> The Buildbot has detected a new failure on builder tomcat-trunk while
> building ASF Buildbot.
> Full details are available at:
> http://ci.apache.org/builders/tomcat-trunk/builds/2564
>
> Buildbot URL: http://
good catch. Actually I did perform a ant test to check that all tests pass, but
the "validate" target is not run by default. Why isn't it enabled by default ?
Sylvain
On 2 déc. 2011, at 22:08, Mark Thomas wrote:
> On 02/12/2011 20:49, slaur...@apache.org wrote:
>> Author: slaurent
>> Date: Fri
I did as you advised and the code has been granted :
https://issues.apache.org/bugzilla/show_bug.cgi?id=51741#c9
Thanks for your help,
Sylvain
On 17 nov. 2011, at 13:28, Tim Funk wrote:
> IIRC: this came into existence via
> https://issues.apache.org/bugzilla/show_bug.cgi?id=41260 - it was dona
On 16 nov. 2011, at 21:34, Mark Thomas wrote:
> On 16/11/2011 20:31, Sylvain Laurent wrote:
>> Hello,
>>
>> To fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51741
>> (Eclipse WTP "Serve modules without publishing" broken with tc7)
Hello,
To fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51741 (Eclipse WTP
"Serve modules without publishing" broken with tc7), I'd like to enhance the
existing org.apache.naming.resources.VirtualDirContext with some features very
much like in org.eclipse.jst.server.tomcat.loader.WtpDi
Hello,
I'm working on https://issues.apache.org/bugzilla/show_bug.cgi?id=51741
(Eclipse WTP "Serve modules without publishing" broken with tc7, needs patch in
tomcat) and though the modifications I'm bringing are small, I'm spending some
time creating a junit test that checks that it is possibl
On 1 sept. 2011, at 12:11, Konstantin Kolinko wrote:
> 1. What happens when someone creates a tag (aka svn copy) in another
> svn client? Should one remove the value, or leave it as is?
The value should be left as is. The next person that uses subclipse may update
the value to include the referen
Would it really hurt to keep those properties?
Le 1 sept. 2011 à 00:45, kkoli...@apache.org a écrit :
> Author: kkolinko
> Date: Wed Aug 31 22:45:23 2011
> New Revision: 1163855
>
> URL: http://svn.apache.org/viewvc?rev=1163855&view=rev
> Log:
> Revert r1163807:
> Remove subclipse:tags property
I'm using subclipse which contains a 1.6 svn client. I'm not an svn expert,
I'll try to do as Mark recommends, I see the point of performing the merge
after so that svn can keep track of things.
Sylvain
Le 1 sept. 2011 à 00:34, Konstantin Kolinko a écrit :
> 2011/9/1 Mark Thomas :
>> On 31/08
Le 31 août 2011 à 23:13, Mark Thomas a écrit :
> On 31/08/2011 21:38, slaur...@apache.org wrote:
>> --- subclipse:tags (added)
>> +++ subclipse:tags Wed Aug 31 20:38:53 2011
>> @@ -0,0 +1,2 @@
>> +932358,branches,/tomcat/tc7.0.x/branches,branch
>> +1162976,TOMCAT_7_0_21,/tomcat/tc7.0.x/tags/TOM
Le 31 août 2011 à 23:12, Mark Thomas a écrit :
> On 31/08/2011 21:37, slaur...@apache.org wrote:
>> +
>
> You left out the (markt)
>
I thought it represented the person who finalized the release, so I left it out.
>> +
>> +
>> +
>> +51744: Prevent application code from cl
On 8 avr. 2011, at 22:58, Konstantin Kolinko wrote:
>
>> +
>> +50306: New StuckThreadDetectionValve to detect requests
>> that take a
>> +long time to process, which might indicate that their processing
>> threads are
>> +stuck. (slaurent)
>
> "Based on a patch pr
On 7 avr. 2011, at 23:54, Konstantin Kolinko wrote:
>
> What content will be in your version of the file?
mostly what we ave already ignored with svn props : eclipse-sepcific files, the
logs, work, temp directories...
Otherwise, one can also run
git svn show-ignore >> .git/info/exclude
which
I just did my first commit on tomcat using git, it seems to work.
does it bother anyone if I add a .gitignore file in the SVN repository ?
Sylvain
On 7 avr. 2011, at 22:57, Rainer Jung wrote:
> On 07.04.2011 22:35, Sylvain Laurent wrote:
>> Hello,
>>
>> I'm trying
Hello,
I'm trying out git at the moment and found this page
http://wiki.apache.org/general/GitAtApache
Is anyone here using git in front of svn ? any problem, advice ?
Sylvain
On 5 avr. 2011, at 11:50, Tim Whittington wrote:
>
> HTTP: use maxConnections. For keep alive situations, reduce
> maxConnections to something closer to maxThreads (the default config
> is 10,000 keepalive connections serviced by 200 threads with a 60
> second keepalive timeout, which could lead
On 11 déc. 2010, at 23:21, ma...@apache.org wrote:
> Author: markt
> Date: Sat Dec 11 22:21:02 2010
> New Revision: 1044731
>
> URL: http://svn.apache.org/viewvc?rev=1044731&view=rev
> Log:
> TRy and sync up the deps in the POMs with what Checkstyle validates
>
> Removed:
>tomcat/trunk/test
Which ant file to use to run junit tests for tc6 ?
BUILDING.TXT says that "ant -f dist.xml release" should run tests, but it
doesn't seem to.
I tried "ant -f test/build.xml" but it's buggy (incorrect path to
build.properties) and runs only one test...
Sylvain
oops, I just forgot a dot and a new line... fixed in rev 1044747.
On 12 déc. 2010, at 01:13, Mark Thomas wrote:
> On 12/12/2010 00:10, slaur...@apache.org wrote:
>> Author: slaurent
>> Date: Sun Dec 12 00:10:39 2010
>> New Revision: 1044746
>>
>> @@ -4862,10 +4862,10 @@ public class StandardCont
Good catch!
Actually I think my commit revealed a current bug in tc 6 & 7 :
https://issues.apache.org/bugzilla/show_bug.cgi?id=50459
I fixed it with http://svn.apache.org/viewvc?rev=1044746&view=rev . Now all
tests pass (checked with "ant clean test").
Sylvain
On 11 déc. 2010, at 21:34, Mark
On 7 déc. 2010, at 17:35, Mark Thomas wrote:
> +1. Line length is an area I am becoming increasingly happy to be
> flexible. Aim for 80 but if 81 or 82 (or anything < ~90) makes the code
> more readable then I'd be fine with it.
As a rookie, I did not want to start bothering you with this, but si
On 7 déc. 2010, at 09:41, Rainer Jung wrote:
>>
>
> Just in case Mark's remark a) wasn't clear: after building Tomcat you can
> debug inside the sub directory output/build which contains a full
> installation.
I had understood Mark, but it's not practical for debugging... I prefer to
debug t
I fixed most of your points except one, see below.
On 6 déc. 2010, at 01:09, Mark Thomas wrote:
> On 05/12/2010 22:54, slaur...@apache.org wrote:
>> Author: slaurent
>> Date: Sun Dec 5 22:54:05 2010
>> New Revision: 1042482
>>
>> URL: http://svn.apache.org/viewvc?rev=1042482&view=rev
>
> Gener
Thanks, and sorry for the incorrect svn properties and formatting.
I'll try to compile a list of things to take care of for new committers and put
it into the wiki.
On 6 déc. 2010, at 12:00, Rainer Jung wrote:
> There's the useful
>
> http://www.apache.org/dev/svn-eol-style.txt
>
> to configu
Are you using an automatic formatter ? if yes, which one ? Can you share its
settings?
On 6 déc. 2010, at 01:17, ma...@apache.org wrote:
> Author: markt
> Date: Mon Dec 6 00:17:43 2010
> New Revision: 1042495
>
> URL: http://svn.apache.org/viewvc?rev=1042495&view=rev
> Log:
> Line-length
>
>
On 5 déc. 2010, at 18:58, Mark Thomas wrote:
> We haven't been good at this historically for debug messages but we
> should really use a StringManager here for i18n support.
Though i can understand that i18n is useful for information and error message,
is it really useful for debug level messag
ok, thanks for having added them for me.
Sylvain
On 4 déc. 2010, at 06:21, Konstantin Kolinko wrote:
> 2010/12/4 :
>> Author: slaurent
>> Date: Fri Dec 3 22:19:11 2010
>> New Revision: 1042029
>>
>> URL: http://svn.apache.org/viewvc?rev=1042029&view=rev
>> Log:
>> bug 50282 : Load javax.secu
Is it OK to change the subject field of bugzilla issues ?
For instance the subject of
https://issues.apache.org/bugzilla/show_bug.cgi?id=48837 is currently "Memory
leaks protection does not cure leaks triggered by JSP pages code"
After Mark applied the patch, I'd prefer to have the following sub
Hello,
I'm working on https://issues.apache.org/bugzilla/show_bug.cgi?id=46350 to
backport what has been done for tc7 to tc6. In doing so I noticed that there's
no artifact for catalina-ant . Is it a mistake or is it on purpose ?
Sylvain
-
ooding wrote:
>
>> Not to step on anyones toes, but JIRA costs serious $$ after the initial 10
>> users. It gets expensive fast. Trac is good too though. I set up an
>> awesome Trac system at work.
>>
>> - Josh
>>
>>
>> On Fri, Oct 22, 2010 at 6
oct. 2010, at 00:25, Konstantin Kolinko wrote:
> 2010/10/23 Sylvain Laurent :
>> How can you create a filter for bugs that are fixed in trunk, proposed to be
>> fixed in tomcat 6, and waiting to be backported ? Do you use some special
>> bug attribute ?
>
> What do you
How can you create a filter for bugs that are fixed in trunk, proposed to be
fixed in tomcat 6, and waiting to be backported ? Do you use some special bug
attribute ?
Sylvain
PS : Why not use JIRA ? It has many advantages over this aging bugzilla...
-
I discovered this feature a while ago in Weblogic and I found this interesting.
But as I always had classloader leaks, I had to restart the JVM anyway so that
it defeated the purpose of the feature and I gave up dreaming of zero-downtime
deployments.
Now with tomcat memory leak protection featur
Actually Glassfish does not differentiate between implicit and explicit
mappings. There's just a test on the servlet-name : When determining the
wrapper to use for a welcome file, if the physical file is not found, it checks
for servlet mappings. If there's such a match, it also checks that the
When requesting the root of the context, tomcat 7 dispatches to MyDummyServlet
whereas jetty and glassfish use MyDefaultServlet. On this one I'd say tomcat is
right...
A clarification of the Expert Group on the servlet spec would be welcome !
Sylvain
On 17 oct. 2010, at 17:04, Sylvai
instead...
Sylvain
On 16 oct. 2010, at 21:36, Mark Thomas wrote:
> On 15/10/2010 22:01, Sylvain Laurent wrote:
>> I just played with a Roo application and I get a 404 with 7.0.4 whereas the
>> very same application works OK with 6.0.29.
>> I'll try to investigate this we
I just played with a Roo application and I get a 404 with 7.0.4 whereas the
very same application works OK with 6.0.29.
I'll try to investigate this week-end.
Sylvain
On 15 oct. 2010, at 10:47, Mark Thomas wrote:
> The proposed Apache Tomcat 7.0.4 release is now available for voting.
>
> It ca
Hello,
I contributed a patch (actually 2, for tc6&7) for
https://issues.apache.org/bugzilla/show_bug.cgi?id=49159 to renew threads when
an application is stopped. This allows to avoid some types of memory leak that
were not cured by tomcat until now (or in an unsafe way and thus disabled by
de
This commit broke all default webapps (ROOT, examples, docs). a 404 is returned
instead...
On 8 oct. 2010, at 23:37, ma...@apache.org wrote:
> Author: markt
> Date: Fri Oct 8 21:37:19 2010
> New Revision: 1006033
>
> URL: http://svn.apache.org/viewvc?rev=1006033&view=rev
> Log:
> Fix https://
I think I now have a nice improvement to the memory leak protection (see BZ
49159). If you have time to review it, it would be a nice addition to this
release...
Sylvain
On 30 sept. 2010, at 19:38, Mark Thomas wrote:
> I'm done with the async re-factoring. I want to run through a complete
> se
you could add a word on persistence of the JMX configuration. As far as I
understand, the modifications done through JMX are not persisted, is that
correct ?
Sylvain
On 15 sept. 2010, at 17:07, Mark Thomas wrote:
> As I mention recently, JMX is now looking pretty good. I have drafted a
> blog
I see 2 options for your case :
- either use JRebel which allows to reload classes even in jars that would be
the common or shared classloaded (I use it all the times, it's fabulous and
pays for itself very quickly)
- or try JBoss which has a Unified Class Loader, and as far as I understood it,
IMHO, clearing threadlocals is a bad idea, it has even been disabled by default
because of concurrency issues.
Furthermore, the solution you propose would be limited to some type of classes
(Map in your case).
https://issues.apache.org/bugzilla/show_bug.cgi?id=49159 is still pending but
the sol
On 25 mai 2010, at 21:58, Mark Thomas wrote:
> On 25/05/2010 19:55, Sylvain Laurent wrote:
>> Hello,
>>
>> how should one file bug reports for this RC3 ? in bugzilla or in the mailing
>> list ? in BZ the only versions are "trunk" and "unspecified&quo
Hello,
how should one file bug reports for this RC3 ? in bugzilla or in the mailing
list ? in BZ the only versions are "trunk" and "unspecified"...
On 24 mai 2010, at 00:38, Mark Thomas wrote:
> All,
>
> The next Tomcat 7.0.0 release candiate is ready for testing. 7.0.0-RC3
> can be obtained f
When you analyzed the heap dump, what path to GC roots was retaining the
classloader in memory ?
On 6 mai 2010, at 20:51, Rainer Jung wrote:
> While doing some testing with 6.0.26 I noticed, that when shutting it down it
> logs an error about thread "Poller SunPKCS11-Solaris" not being stopped
I finally proposed a patch for trunk in
https://issues.apache.org/bugzilla/show_bug.cgi?id=49159 for this. Thanks for
reviewing it...
Sylvain
On 30 avr. 2010, at 18:27, Sylvain Laurent wrote:
>
> On 30 avr. 2010, at 00:01, Pid wrote:
>>
>> Are you saying that you want
I think that this commit broke the ability to stop and start a context. When I
start it after having stopped it, I get a
LifecycleException: An invalid Lifecycle transition was attempted
([before_start]) for component [WebappLoader[/testWeb]] in state [DESTROYED]
Sylvain
On 1 mai 2010, at 19:
On 30 avr. 2010, at 00:01, Pid wrote:
>
> Are you saying that you want to stop processing requests each time a
> webapp gets restarted, or that the thread pool is refreshed by
> sequentially killing each thread and recreating it?
Something in between : I create a new pool with the same character
Interesting idea, really ! But I suspect it might break some things in some
cases. I'm thinking about cross-context requests (where the requestDispatcher
calls another web application in the same JVM with the same thread). If the
context-specific table changes when dispatching the request to the
cache Date formatter or parsers...
Sylvain
On 29 avr. 2010, at 23:17, Caldarale, Charles R wrote:
>> From: Sylvain Laurent [mailto:sylvain.laur...@gmail.com] On Behalf Of
>> Sylvain Laurent
>> Subject: Re: Need advice to notify StandardExecutor when a webapp is
>> stopped
&
de ;-)
Sylvain
On 29 avr. 2010, at 01:36, Mark Thomas wrote:
> On 27/04/2010 15:57, Sylvain Laurent wrote:
>> Do you mean one declared in server.xml ? or have the StandardThreadExecutor
>> register itself as a LifeCycleListener ? In the latter case, my problem is
>> how do
wrote:
> 2010/4/27 Sylvain Laurent :
>> Hello,
>>
>> In order to provide a protection agains this type of memory leak
>> http://wiki.apache.org/tomcat/MemoryLeakProtection#webappClassInstanceAsThreadLocalIndirectValue
>> , I experimented with renew
Hello,
In order to provide a protection agains this type of memory leak
http://wiki.apache.org/tomcat/MemoryLeakProtection#webappClassInstanceAsThreadLocalIndirectValue
, I experimented with renewing the ThreadPoolExecutor in the
org.apache.catalina.core.StandardThreadExecutor. It works when I
I don't understand what would be the purpose of this feature. Is it in order to
really force a GC when clicking on the "Find leaks" button of the manager ? If
it's for that, I don't think it's worth the trouble. People really interested
in fixing their leaking webapps should take a snapshot of t
Hello all,
I wrote a wiki page to try and explain all the causes of webapp classloader
leaks one might encounter : http://wiki.apache.org/tomcat/MemoryLeakProtection
I'd be glad to have your feedback on it !
While creating the page, I thought about 2 things to improve the protection :
1) to fix
> On 03/03/2010 21:12, Sylvain Laurent wrote:
>
> > 3) a couple of months ago I had proposed on this very list a kind of memory
> > leak protection
> for those leaks caused by threads with incorrect CCL. I called this the
> ExpendableClassLoader.
> Please have
Hello,
After reading Mark Thomas's interview at DZone
http://java.dzone.com/articles/memory-leak-protection-tomcat and having
experimented with classloader leaks issues, I'd like to share my thoughts with
you :
1) first of all THANK YOU for providing some solutions to those problems. It's
not
webapp's classloader
(and thus the
* context classloader), such dangling threads only keep a reference
to a very
* light classloader, drastically reducing the leak.
*
*
* NOTE: the class has to be in the same package as {...@link
WebappClassLoader} in
* order to override package-pr
thus the * context classloader), such dangling threads only keep a reference to a very * light classloader, drastically reducing the leak. * * * NOTE: the class has to be in the same package as {...@link WebappClassLoader} in * order to override package-protected methods. * * * @author Sylvain LAUREN
72 matches
Mail list logo
