Re: JASPIC Implementation pointers

2015-07-03 Thread Mark Thomas
On 03/07/2015 18:55, Fjodor Vershinin wrote: >> On 03/07/2015 15:42, Fjodor Vershinin wrote: >>> I am working on polishing FORM authentication module code. I will >> continue >>> with that this evening. >> >> OK. I'm commenting on commits as I apply them. Some of them have >> suggestions for furthe

JASPIC Implementation pointers

2015-07-03 Thread Fjodor Vershinin
> On 03/07/2015 15:42, Fjodor Vershinin wrote: > > I am working on polishing FORM authentication module code. I will > continue > > with that this evening. > > OK. I'm commenting on commits as I apply them. Some of them have > suggestions for further improvements. These improvements don't need to >

Re: JASPIC Implementation pointers

2015-07-03 Thread Mark Thomas
On 03/07/2015 15:42, Fjodor Vershinin wrote: > I am working on polishing FORM authentication module code. I will continue > with that this evening. OK. I'm commenting on commits as I apply them. Some of them have suggestions for further improvements. These improvements don't need to be implemented

Re: JASPIC Implementation pointers

2015-07-03 Thread Fjodor Vershinin
I am working on polishing FORM authentication module code. I will continue with that this evening. JASPIC modules configuration looks more like architectural stuff, so we need to make some decisions how to proceed forward. I think it can be task for next week together SPNEGO authentication module.

Re: JASPIC Implementation pointers

2015-07-03 Thread Fjodor Vershinin
> > > Another option would be to define a jaspic element for server.xml / > context.xml that is nested in a Context and if present takes precedence > for JASPIC config. For that to work modules would have to: > - have zero arg constructors > - be fully configurable via setters > - use simple types

Re: JASPIC Implementation pointers

2015-07-03 Thread Mark Thomas
On 03/07/2015 13:56, Fjodor Vershinin wrote: > 2015-07-03 15:31 GMT+03:00 Mark Thomas : > >> On 03/07/2015 07:37, Fjodor Vershinin wrote: >>> Hi! >>> Unfortunately, commit rearrangement requires some more effort from me, >> so I >>> haven't finished it yesterday. >>> I need some more time to fix c

Re: JASPIC Implementation pointers

2015-07-03 Thread Fjodor Vershinin
2015-07-03 15:31 GMT+03:00 Mark Thomas : > On 03/07/2015 07:37, Fjodor Vershinin wrote: > > Hi! > > Unfortunately, commit rearrangement requires some more effort from me, > so I > > haven't finished it yesterday. > > I need some more time to fix checkstyle errors and so on. > > OK. I have prepare

Re: JASPIC Implementation pointers

2015-07-03 Thread Mark Thomas
On 03/07/2015 07:37, Fjodor Vershinin wrote: > Hi! > Unfortunately, commit rearrangement requires some more effort from me, so I > haven't finished it yesterday. > I need some more time to fix checkstyle errors and so on. OK. >> We can change the way users have to configure it. For example, we co

Re: JASPIC Implementation pointers

2015-07-02 Thread Fjodor Vershinin
Hi! Unfortunately, commit rearrangement requires some more effort from me, so I haven't finished it yesterday. I need some more time to fix checkstyle errors and so on. We can change the way users have to configure it. For example, we could > say they have to use programmatic configuration via the

Re: JASPIC Implementation pointers

2015-07-02 Thread Mark Thomas
On 02/07/2015 17:23, Fjodor Vershinin wrote: > Hi, all! > Some update on JASPIC state. > Yesterday and today I was working on FORM authentication module > implementation. > I've ported old code to new module, got it to work, and then ported > integration test to ensure, that my refactoring's will n

Re: JASPIC Implementation pointers

2015-07-02 Thread Fjodor Vershinin
Hi, all! Some update on JASPIC state. Yesterday and today I was working on FORM authentication module implementation. I've ported old code to new module, got it to work, and then ported integration test to ensure, that my refactoring's will not broke something. Then I have split huge method into sm

Re: JASPIC Implementation pointers

2015-06-29 Thread Mark Thomas
On 29/06/2015 22:46, Fjodor Vershinin wrote: > Hi, all! > My update for previous week: > 1) Some JASPIC architecture refactoring > 2) Implemented both BASIC and DIGEST authentication modules > 3) Added integration test for DIGEST module > 4) Fixed some small bugs and issues > 5) Updated javadocs >

Re: JASPIC Implementation pointers

2015-06-29 Thread Fjodor Vershinin
Hi, all! My update for previous week: 1) Some JASPIC architecture refactoring 2) Implemented both BASIC and DIGEST authentication modules 3) Added integration test for DIGEST module 4) Fixed some small bugs and issues 5) Updated javadocs What about current status, I started working on FORM authent

Re: JASPIC Implementation pointers

2015-06-26 Thread Mark Thomas
On 25/06/2015 20:50, Fjodor Vershinin wrote: > Hi! > Fresh set of patches is ready. > What has been done: > 1) Added engine name to getVirtualServerName() > 2) Implemented method for getting roles directly from Realm, > 3) Authentication provider uses LoginConfig now, which gives us ability to > g

Re: JASPIC Implementation pointers

2015-06-25 Thread Fjodor Vershinin
Hi! Fresh set of patches is ready. What has been done: 1) Added engine name to getVirtualServerName() 2) Implemented method for getting roles directly from Realm, 3) Authentication provider uses LoginConfig now, which gives us ability to get different options directly from there. 4) Added test for

Re: JASPIC Implementation pointers

2015-06-23 Thread Mark Thomas
On 23/06/2015 16:50, Fjodor Vershinin wrote: > Hi there! > > >> You still need to address the issue of a unique name for the JASPIC app >> context. > > I see your point. However, tomcat's implementation of uniqueness is against > JASPIC 1.1 specification. We must somehow document this feature.

Re: JASPIC Implementation pointers

2015-06-23 Thread Fjodor Vershinin
Hi there! > You still need to address the issue of a unique name for the JASPIC app > context. I see your point. However, tomcat's implementation of uniqueness is against JASPIC 1.1 specification. We must somehow document this feature. > > 1) I have prepared mechanism for registration embedded

Re: JASPIC Implementation pointers

2015-06-23 Thread Mark Thomas
On 22/06/2015 20:57, Fjodor Vershinin wrote: > Hi! > There are new bunch of patches ready in my github repo: > https://github.com/fjodorver/tomcat/commits/feature/jaspic-implementation Thanks. Patches applied. I've added comments to some of the patches. > My report for previous week + today: You

Re: JASPIC Implementation pointers

2015-06-22 Thread Fjodor Vershinin
Hi! There are new bunch of patches ready in my github repo: https://github.com/fjodorver/tomcat/commits/feature/jaspic-implementation My report for previous week + today: 1) I have prepared mechanism for registration embedded JASPIC modules 2) Callback handler is singleton now 3) Implemented JAAS

Re: JASPIC Implementation pointers

2015-06-17 Thread Mark Thomas
On 17/06/2015 08:32, Fjodor Vershinin wrote: > Could you provide me your eclipse config files for this project? I think it > would be most convenient way to fix such kind issues. This is something that would have been covered during community bonding. http://svn.apache.org/viewvc/tomcat/trunk/res

Re: JASPIC Implementation pointers

2015-06-17 Thread Fjodor Vershinin
Hi, Mark! I'd updated my jaspic-implementation branch, where I have updated version. Thank you for your comments, almost all of this issues has been fixed. > The patch triggered a number of basic IDE warnings that should have been already fixed (use of <> and@Override) Could you provide me your e

Re: JASPIC Implementation pointers

2015-06-15 Thread Mark Thomas
On 15/06/2015 16:42, Fjodor Vershinin wrote: > 2015-06-15 17:53 GMT+03:00 Mark Thomas : > >> On 15/06/2015 12:14, Fjodor Vershinin wrote: >>> Hi, all! >>> Here is my report for previous week. I'd ported JASPIC api classes and >>> implemented skeleton for JASPIC support. The skeleton was implemente

Re: JASPIC Implementation pointers

2015-06-15 Thread Fjodor Vershinin
2015-06-15 17:53 GMT+03:00 Mark Thomas : > On 15/06/2015 12:14, Fjodor Vershinin wrote: > > Hi, all! > > Here is my report for previous week. I'd ported JASPIC api classes and > > implemented skeleton for JASPIC support. The skeleton was implemented > using > > plan proposed by Mark. It contains v

Re: JASPIC Implementation pointers

2015-06-15 Thread Mark Thomas
On 15/06/2015 12:14, Fjodor Vershinin wrote: > Hi, all! > Here is my report for previous week. I'd ported JASPIC api classes and > implemented skeleton for JASPIC support. The skeleton was implemented using > plan proposed by Mark. It contains very basic AuthConfigFactory, callback > handler's, and

Re: JASPIC Implementation pointers

2015-06-15 Thread Fjodor Vershinin
Hi, all! Here is my report for previous week. I'd ported JASPIC api classes and implemented skeleton for JASPIC support. The skeleton was implemented using plan proposed by Mark. It contains very basic AuthConfigFactory, callback handler's, and JaspicAuthenticator. I did some hacking on weekend wit

JASPIC Implementation pointers

2015-06-11 Thread Mark Thomas
(primarily for Fjodor but feel free to comment as you see fit) Consensus to date is that a Valve will be the best integration point. Given that the implementation will need access to Tomcat's internals, I'd suggest either use the existing org.apache.catalina.authenticator package or create a new