Re: svn commit: r1650280 - /tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java

2015-01-08 14:11 GMT+01:00 ma...@apache.org: Author: markt Date: Thu Jan 8 13:10:59 2015 New Revision: 1650280 URL: http://svn.apache.org/r1650280 Log: Fix failing unit test testMessagesBlocking(org.apache.coyote.http11.upgrade.TestUpgrade) Modified:

Re: svn commit: r1650277 - in /tomcat/trunk/java/org/apache: coyote/http11/ tomcat/util/net/

2015-01-08 14:50 GMT+01:00 Mark Thomas ma...@apache.org: There's a big deadlock risk if the recursion if incomplete and error processing are inside the sync. I came across some of those while doing the refactoring. I think - as of r1650289 - they are addressed but it is possible I missed

Re: svn commit: r1650268 - /tomcat/trunk/java/org/apache/coyote/http11/InternalNio2OutputBuffer.java

2015-01-08 14:46 GMT+01:00 Mark Thomas ma...@apache.org: On 08/01/2015 13:30, Rémy Maucherat wrote: 2015-01-08 14:09 GMT+01:00 ma...@apache.org: Author: markt Date: Thu Jan 8 13:09:47 2015 New Revision: 1650268 URL: http://svn.apache.org/r1650268 Log: DequeByteBufferHolder

Re: svn commit: r1650277 - in /tomcat/trunk/java/org/apache: coyote/http11/ tomcat/util/net/

2015-01-08 14:58 GMT+01:00 Mark Thomas ma...@apache.org: On 08/01/2015 13:54, Rémy Maucherat wrote: 2015-01-08 14:50 GMT+01:00 Mark Thomas ma...@apache.org: There's a big deadlock risk if the recursion if incomplete and error processing are inside the sync. I came across some

Re: Currently ignored WebSocket tests

2015-01-08 16:56 GMT+01:00 Mark Thomas ma...@apache.org: There are a couple of WebSocket tests that are currently commented out in org.apache.tomcat.websocket.pojo.TestEncodingDecoding I've been looking into why the currently fail. Failing test 1: testMessagesEndPoints() First of all,

Re: svn commit: r1650280 - /tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java

2015-01-08 15:48 GMT+01:00 Mark Thomas ma...@apache.org: The reason I only saw the issue with NIO2 is that only NIO2 was buffering the ServletOutputStream for upgraded connections. The patch above aligned NIO2 with NIO and APR - neither of which buffer upgraded connections. I took a look at

Re: Buildbot slave changes

2015-03-19 14:43 GMT+01:00 Mark Thomas ma...@apache.org: tomcat-trunk: probably ok A couple of test failures (UTF-8) caused by building with on old JDK version. I've updated to the latest Java 8 JDK and am re-running the build. Twice as fast ? Not bad ! Rémy

Scatter / gather

Hi (Mark - nobody else will care I suppose), Since the SocketWrapperBase has been neatly factored away, I think scatter gather NIO2 style calls should be added to it for future use. - public A void write(ByteBuffer[] srcs, int offset, int length, long timeout, TimeUnit unit, A

Re: svn commit: r1665736 - in /tomcat/trunk/java/org/apache/tomcat/util/net: AprEndpoint.java Nio2Endpoint.java NioEndpoint.java SocketWrapperBase.java

2015-03-10 23:35 GMT+01:00 ma...@apache.org: Author: markt Date: Tue Mar 10 22:35:19 2015 New Revision: 1665736 URL: http://svn.apache.org/r1665736 Log: Stop re-using the SocketWrapper With the introduction of upgrade and non-blocking, I/O can occur on non-container threads. This makes

Re: [VOTE] Release Apache Tomcat 8.0.21

2015-03-23 15:59 GMT+01:00 Mark Thomas ma...@apache.org: The proposed 8.0.21 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 8.0.21 Rémy

Re: svn commit: r1669838 - /tomcat/trunk/java/org/apache/tomcat/websocket/WsFrameClient.java

2015-03-28 22:47 GMT+01:00 ma...@apache.org: Author: markt Date: Sat Mar 28 21:47:55 2015 New Revision: 1669838 URL: http://svn.apache.org/r1669838 Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=57762 Dropped connections are reported as a success with EOF rather than as a

Re: Stabilizing the trunk (9.0.x) build

2015-02-27 13:00 GMT+01:00 Mark Thomas ma...@apache.org: Another update. I think I am getting close to being able to commit these changes[1]. The current status is: - NIO appears to pass on Windows, OSX and Linux - APR appears to pass on OSX and Linux - APR unknown on Windows - NIO2

Re: Stabilizing the trunk (9.0.x) build

2015-02-23 10:16 GMT+01:00 Mark Thomas ma...@apache.org: Given that it is my changes that have triggered the problems I think I have a responsibility to fix them (and intend to do so over) but I'm not going to say no if anyone wants to pitch in. Therefore, I'm starting this thread so that we

Re: svn commit: r1661642 - /tomcat/trunk/java/org/apache/coyote/http11/upgrade/UpgradeProcessor.java

2015-02-23 13:32 GMT+01:00 Mark Thomas ma...@apache.org: I'm not sure if that is fixing the symptom or the cause. I'm still seeing something going wrong with what should be a clean shutdown in TestWsWebSocketContainer.testMaxMessageSize04(). I took a look at the source for

Re: svn commit: r1661642 - /tomcat/trunk/java/org/apache/coyote/http11/upgrade/UpgradeProcessor.java

2015-02-23 12:26 GMT+01:00 ma...@apache.org: Author: markt Date: Mon Feb 23 11:26:56 2015 New Revision: 1661642 URL: http://svn.apache.org/r1661642 Log: Don't default to an infinite timeout for write. Generally, writes should happen (fairly) quickly. This is messing up some tests for

Re: Stabilizing the trunk (9.0.x) build

2015-02-24 16:33 GMT+01:00 Mark Thomas ma...@apache.org: On 24/02/2015 13:10, Rémy Maucherat wrote: I'm having issues with the write timeout tests in TestWsWebSocketContainer, which made me do some changes since there are still things I don't understand: These appear to be OK for me

Re: svn commit: r1662226 - /tomcat/trunk/java/org/apache/tomcat/websocket/server/WsRemoteEndpointImplServer.java

2015-02-25 16:07 GMT+01:00 Felix Schumacher felix.schumac...@internetallee.de: Am 25.02.2015 15:34, schrieb r...@apache.org: +first = false; This is not really threadsafe. What happens when more than one thread call this method while first==false? They could (probably really

Re: Stabilizing the trunk (9.0.x) build

2015-02-25 19:36 GMT+01:00 Mark Thomas ma...@apache.org: I was planning on waiting until the build was stable but given that: - read/write concurrency is at the root of a lot of these issues - only WebSocket should be using it now in trunk - the plan is to refactor WebSocket to remove it

Re: Two serious issues have been introduced in Tomcat 7 and Tomcat 8...

2015-02-23 20:32 GMT+01:00 Konstantin Kolinko knst.koli...@gmail.com: If ServletContext.getContext(String) is actually supposed to perform prefix-mapping, then it explains why getContext(/ROOT) worked for you. getContext(/ROOT) worked just because getContext(/foobar) returns the ROOT

Re: Stabilizing the trunk (9.0.x) build

2015-02-24 10:01 GMT+01:00 Mark Thomas ma...@apache.org: Progress is being made. TestWsWebSocketContainer.testMaxMessageSize04() is fixed. I do want to come back to exactly how/if flushing is performed on ServletOutputStream.close() but I plan on parking that until the other failures are

Re: Stabilizing the trunk (9.0.x) build

2015-02-26 17:40 GMT+01:00 Mark Thomas ma...@apache.org: Better, certainly. NIO tests pass on Windows, Linux and OSX. Very good ! I've found a bug in NIO2 + SSL that is fairly common on Linux/OSX that I have fixed and am re-running the tests. Aw, *another* one ? I haven't really

Re: Stabilizing the trunk (9.0.x) build

2015-02-26 11:42 GMT+01:00 Mark Thomas ma...@apache.org: What I have at the moment is at: https://github.com/markt-asf/tomcat/tree/markt-trunk I'm currently running the unit tests. Looking good. Rémy

Re: svn commit: r1662014 - /tomcat/trunk/java/org/apache/tomcat/websocket/server/WsHttpUpgradeHandler.java

2015-02-24 21:26 GMT+01:00 Christopher Schultz ch...@christopherschultz.net : Rémy, On 2/24/15 11:44 AM, r...@apache.org wrote: Author: remm Date: Tue Feb 24 16:44:05 2015 New Revision: 1662014 URL: http://svn.apache.org/r1662014 Log: Catch ISE thrown by the closed IS for a rare

Re: [VOTE] Release Apache Tomcat 8.0.18

2015-01-23 14:09 GMT+01:00 Mark Thomas ma...@apache.org: The proposed 8.0.18 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 8.0.18 Rémy

Re: svn commit: r1676864 - in /tomcat/native/trunk/native: include/ssl_private.h src/sslcontext.c

2015-04-29 23:34 GMT+02:00 Mark Thomas ma...@apache.org: I have some tidying up of this that I'll do tomorrow (docs, comments, i18n etc.) and then I plan to get on with the HTTP/2 implementation. I'll gladly help you. The new IO calls I added (only in NIO2 so far) are supposed to be well

Re: [VOTE] Release Apache Tomcat 8.0.22

2015-04-29 18:41 GMT+02:00 Mark Thomas ma...@apache.org: The proposed Apache Tomcat 8.0.22 release is now available for voting. The proposed 8.0.22 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 8.0.22 Rémy

Re: Tomcat 9 connector refactoring: NIO vs NIO2

2015-05-01 19:28 GMT+02:00 Mark Thomas ma...@apache.org: On 01/05/2015 15:03, Rémy Maucherat wrote: 2015-05-01 11:55 GMT+02:00 Mark Thomas ma...@apache.org: So, should we drop one of NIO or NIO2 in Tomcat 9? If not, why not? If yes, which one? I volunteer to help maintain NIO2

Re: Tomcat 9 connector refactoring: NIO vs NIO2

2015-05-01 11:55 GMT+02:00 Mark Thomas ma...@apache.org: Next up on my list is the NIO2 connector. NIO and APR/native both use a polling approach to non-blocking I/O. You add the socket to the poller, tell it what operation (read/write) you want to perform and then you wait for the poller to

Re: Tomcat 9 connector refactoring: NIO vs NIO2

2015-05-04 21:54 GMT+02:00 Mark Thomas ma...@apache.org: Looking some time further ahead where NIO2 is as stable as NIO and there is an OpenSSL option for SSL/TLS with NIO2 I don't see any advantages of NIO or APR/native over NIO2 which raises the possibility - at that point - of just having

Re: [VOTE] Release Apache Tomcat 8.0.22

2015-05-03 12:32 GMT+02:00 Felix Schumacher felix.schumac...@internetallee.de: The problem apears to be caused by this part of the patch: diff --git a/java/org/apache/tomcat/util/net/SecureNio2Channel.java b/java/org/apache/tomcat/util/net/SecureNio2Channel.java index ba16492..bbc18b0

Re: svn commit: r1678169 - in /tomcat/trunk/java/org/apache/tomcat/util/net: AprEndpoint.java SSLHostConfig.java jsse/JSSESocketFactory.java

2015-05-07 13:24 GMT+02:00 ma...@apache.org: Author: markt Date: Thu May 7 11:24:05 2015 New Revision: 1678169 URL: http://svn.apache.org/r1678169 Log: Retain the original configuration settings and use separate getters the absolute value for all file/path attributes Usually

Re: svn commit: r1678169 - in /tomcat/trunk/java/org/apache/tomcat/util/net: AprEndpoint.java SSLHostConfig.java jsse/JSSESocketFactory.java

2015-05-07 15:09 GMT+02:00 Mark Thomas ma...@apache.org: On 07/05/2015 13:47, Rémy Maucherat wrote: 2015-05-07 13:24 GMT+02:00 ma...@apache.org: Author: markt Date: Thu May 7 11:24:05 2015 New Revision: 1678169 URL: http://svn.apache.org/r1678169 Log: Retain the original

Re: svn commit: r1678210 - /tomcat/trunk/java/org/apache/tomcat/util/net/SSLContext.java

2015-05-07 16:14 GMT+02:00 Martin Grigorov mgrigo...@apache.org: You can remove 'public' too. Yes, it's useless but I usually leave that in [unlike abstract]. I'm not alone since all the interfaces of the package do the same thing. Rémy

Re: Back-porting the new HttpHeaderSecurityFilter

2015-05-11 14:28 GMT+02:00 Mark Thomas ma...@apache.org: Which features are you thinking of and are you suggesting they should be enabled as well? I vote not enabled :) I'm not a big fan of these security features usually (just like when my browser decides I am stupid and must reject fake

Re: Back-porting the new HttpHeaderSecurityFilter

2015-05-11 10:56 GMT+02:00 Mark Thomas ma...@apache.org: The catalyst for work this was reading RFC 7525 [1]. That got me thinking about similar headers. In [1] HSTS support is a MUST and using it is a SHOULD. On that basis I think 9.0.x should use it by default unless there is a really good

Re: [VOTE] Release Apache Tomcat 8.0.22

2015-05-03 18:28 GMT+02:00 Felix Schumacher felix.schumac...@internetallee.de: In my test case position() will be either 0 or 341 (complete request). They seem to happen at about the same rate. r1672626 fixed a loop issue, but oversimplified. So I am going back to the previous code, with an

Re: [VOTE] Release Apache Tomcat 8.0.22

2015-05-05 2:32 GMT+02:00 Christopher Schultz ch...@christopherschultz.net : Hmm... I thought that NIO2 was listed as experimental in Tomcat 8.0.x, but the configuration guide doesn't say anything to that effect. How much *more* broken in 8.0.22 is it than 8.0.21? I would say that failing

Re: [VOTE] Release Apache Tomcat 8.0.22

2015-05-04 21:58 GMT+02:00 Mark Thomas ma...@apache.org: They are both broken, it is just more obvious with 8.0.22. I'll make my mind up finally tomorrow but I am leaning towards releasing 8.0.22 making it clear that there is a known issue with NIO2 + TLS and then looking at 8.0.23 almost

Re: Tomcat Grid

2015-05-05 19:55 GMT+02:00 Alarcón Vladimir vladimiralar...@yahoo.com.invalid: Hi, for a few months I was wondering about an extension for Tomcat but I'm not sure if there would be interest from the part of the Tomcat team. It's about managing multiple Tomcat servers across multiple

Re: Back-porting the new HttpHeaderSecurityFilter

2015-05-08 21:14 GMT+02:00 Mark Thomas ma...@apache.org: I'd like to back-port this but before I do I'd like to hear other people's views on the following? - Should it be back-ported to 8.0.x - Should it be enabled by default - Should it be back-ported to 7.0.x - Should it be enabled

Re: svn commit: r1678169 - in /tomcat/trunk/java/org/apache/tomcat/util/net: AprEndpoint.java SSLHostConfig.java jsse/JSSESocketFactory.java

2015-05-07 16:34 GMT+02:00 Mark Thomas ma...@apache.org: I'm wondering about a 9.0.0 M1 (milestone 1) release to give folks a chance to play with the SNI support. Good idea, the main downside is that it wouldn't have most of the new features. Rémy

Re: [VOTE] Release Apache Tomcat 8.0.22

2015-05-03 12:32 GMT+02:00 Felix Schumacher felix.schumac...@internetallee.de: The rest of the patch will not influence the jmeter test. Ping to get feedback on the fix, if possible. Rémy

Re: svn commit: r1679116 - in /tomcat/trunk/java/org/apache/coyote/http2: Http2Exception.java Http2UpgradeHandler.java

2015-05-13 0:29 GMT+02:00 ma...@apache.org: Author: markt Date: Tue May 12 22:29:45 2015 New Revision: 1679116 URL: http://svn.apache.org/r1679116 Log: Start to process the initial settings frame sent by the client. +private boolean processFrame() throws IOException { +//

Re: [VOTE] Release Apache Tomcat 6.0.44

2015-05-08 16:24 GMT+02:00 jean-frederic clere jfcl...@gmail.com: The proposed 6.0.44 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 6.0.44 Stable Rémy

OpenSSL JSSE SSLEngine implementation

Hi, As part of a university project, Numa de Montmollin, a student interning @redhat, has worked on adapting to Tomcat some code I discovered inside the Netty project, which implements a SSL engine using OpenSSL. Normally, this sort of thing is supposed to be done using JCE, as was attempted

Re: OpenSSL JSSE SSLEngine implementation

2015-05-18 21:42 GMT+02:00 Mark Thomas ma...@apache.org: Very, very nice. On the native side, I'm all for taking as much as we can. No reason not to aim for something that the Netty folks can just use without having to patch locally. Thanks. I'm continuing to work on it in trunk now (

Re: HTTP/2 progress report

2015-05-13 22:57 GMT+02:00 Mark Thomas ma...@apache.org: Just a quick overview to save folks digging through the commit messages. If you want to play with this you'll need: - APR + tc-native build from *trunk* (to get ALPN support). - an EC based cert or set the FireFox option

Re: HTTP/2 progress report

2015-04-08 23:56 GMT+02:00 Mark Thomas ma...@apache.org: As of r1672190 we now have the following: - ALPN support in tc-native trunk - The ability to register upgrade protocol implementations that will: - be included in the ALPN negotiation - cause processing to be passed to a protocol

Re: svn commit: r1673408 - in /tomcat/trunk: java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ java/org/apache/tomcat/util/net/jsse/ test/org/apache/tomcat/util/net/jsse/

2015-04-14 13:18 GMT+02:00 Mark Thomas ma...@apache.org: On 14/04/2015 06:07, ma...@apache.org wrote: Author: markt Date: Tue Apr 14 11:07:41 2015 New Revision: 1673408 URL: http://svn.apache.org/r1673408 Log: Move SSLProtocols config to common property for JSSE and APR/native

Re: Time to switch tc-native development to trunk?

2015-04-02 22:33 GMT+02:00 Mark Thomas ma...@apache.org: I've been spending some time thinking about how to plumb in HTTP/2 support into the Tomcat 9 code base. After a couple of failed starts I think I have a good starting point that will be able to support NPN, ALPN and HTTP upgrade without

Re: Scatter / gather

2015-03-06 16:49 GMT+01:00 Mark Thomas ma...@apache.org: I can see how both might be useful. No objections here. So in addition to my initial plan, I added some state information (NIO2 thinks it is a good idea to hide it), as well as flexibility for the completion handler call (NIO2 calls it

Re: HTTP2 parsing and error handling

2015-06-09 11:53 GMT+02:00 Konstantin Kolinko knst.koli...@gmail.com: 2015-06-08 15:37 GMT+03:00 Mark Thomas ma...@apache.org: All, I'm not particularly happy with the current error handling (based around Http2Exception) and as I work my way through the spec in detail I am coming

Re: Merging Netty and Twitter fork of tcnative back

2015-06-05 18:15 GMT+02:00 jean-frederic clere jfcl...@gmail.com: On 06/04/2015 03:13 PM, Rainer Jung wrote: I think we can safely drop NPN as it seems to be a dead end The Netty people are using it in SPDY it would be better to keep it if possible. I'm not sure they will drop the

Re: [PROPOSAL] Remove tomcat-jdbc from Tomcat 9 onwards

2015-06-03 12:08 GMT+02:00 Mark Thomas ma...@apache.org: A connection pooling question on the users list prompted me to write a short history [1] of Tomcat's connection pooling with respect to DBCP 1, DBCP 2 and tomcat-jdbc. That got me thinking. Given the current situation: - DBCP 2 is

Re: svn commit: r1684663 - in /tomcat/trunk/java/org/apache: catalina/security/ tomcat/util/buf/ tomcat/util/net/

2015-06-10 14:45 GMT+02:00 r...@apache.org: Author: remm Date: Wed Jun 10 12:45:26 2015 New Revision: 1684663 URL: http://svn.apache.org/r1684663 Log: Direct buffers need explicit cleanup to ensure complete reliability without OOMs. Rationale: - The NIO JVM code does it, so it's

Re: Merging Netty and Twitter fork of tcnative back

2015-06-04 15:13 GMT+02:00 Rainer Jung rainer.j...@kippdata.de: There are some forks of tcnative. One from twitter named finagle-native: https://github.com/twitter/finagle/tree/master/finagle-native mostly in the form of a big patch:

OpenSSL SSL engine

Hi, I have now committed the initial work for this new feature. Advanced SSL functionality (renegotiation) is disabled since that was like that upstream and I didn't dare trying to hack it yet. Testsuite integration (I have it in my git repository https://github.com/rmaucher/tomcat ) is

Re: OpenSSL SSL engine

2015-06-18 20:16 GMT+02:00 Mark Thomas ma...@apache.org: I assume it only makes sense to run the various SSL tests. We should be able to (possibly with a little renaming) set things up so we can filter test classes by name for *SSL* (or better yet *TLS*) and run them as an additional batch of

Re: removing empty stubs in tc-native trunk

2015-06-15 13:32 GMT+02:00 Mark Thomas ma...@apache.org: On 15/06/2015 12:27, jean-frederic clere wrote: Hi, We have empty stubs in tc-native when openssl isn't detected, are those still needed? Yes, if we want to be able to support the APR/native connector without OpenSSL. With

Re: HTTP/2 progress report

2015-05-29 11:13 GMT+02:00 Mark Thomas ma...@apache.org: On 15/05/2015 19:46, Rémy Maucherat wrote: 2015-05-13 22:57 GMT+02:00 Mark Thomas ma...@apache.org: snip/ The next steps are to get a basic implementation working which means: - figure out how to feed requests into Tomcat's

Re: svn commit: r1682087 - in /tomcat/trunk/java/org/apache: coyote/http11/Http11InputBuffer.java tomcat/util/net/Nio2Endpoint.java tomcat/util/net/SocketWrapperBase.java

2015-05-27 20:22 GMT+02:00 Mark Thomas ma...@apache.org: On 27/05/2015 18:45, r...@apache.org wrote: Author: remm Date: Wed May 27 17:45:31 2015 New Revision: 1682087 URL: http://svn.apache.org/r1682087 Log: Avoid IO peeking with NIO2 to read the request line (introduced in

Re: svn commit: r1682079 - in /tomcat/trunk/java/org/apache: coyote/http11/Http11Nio2Protocol.java tomcat/util/net/Nio2Endpoint.java

2015-05-27 19:11 GMT+02:00 Mark Thomas ma...@apache.org: On 27/05/2015 18:09, ma...@apache.org wrote: Author: markt Date: Wed May 27 17:09:47 2015 New Revision: 1682079 Forgot to add that the NIO2 tests pass consistently on my laptop. We'll see what the CI system thinks in a couple of

Re: svn commit: r1681794 - /tomcat/trunk/java/org/apache/coyote/http11/Http11Nio2Protocol.java

2015-05-27 8:44 GMT+02:00 Mark Thomas ma...@apache.org: On 26/05/2015 19:43, Rémy Maucherat wrote: 2015-05-26 20:37 GMT+02:00 Mark Thomas ma...@apache.org: On 26/05/2015 19:33, Rémy Maucherat wrote: 2015-05-26 20:17 GMT+02:00 Mark Thomas ma...@apache.org: It was a left over from

Re: svn commit: r1681925 - /tomcat/trunk/java/org/apache/coyote/http11/Http11Nio2Protocol.java

2015-05-27 9:52 GMT+02:00 r...@apache.org: Author: remm Date: Wed May 27 07:52:49 2015 New Revision: 1681925 URL: http://svn.apache.org/r1681925 Log: Try reverting r1681794 I'm trying a simple revert because in TestAsyncContextImpl the problem is that there's no pending read to do the

Re: [VOTE] Release Apache Tomcat 7.0.63

2015-06-30 11:01 GMT+02:00 Violeta Georgieva violet...@apache.org: The proposed Apache Tomcat 7.0.63 release is now available for voting. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.63/ The Maven staging repo is:

Re: [VOTE] Release Apache Tomcat 8.0.24

2015-07-01 22:56 GMT+02:00 Mark Thomas ma...@apache.org: The proposed Apache Tomcat 8.0.24 release is now available for voting. The main changes since 8.0.23 are: - Provide path parameters to POJO via per session javax.websocket.server.ServerEndpointConfig as they vary between different

Re: Looking for a good doc place

2015-05-24 15:34 GMT+02:00 Rainer Jung rainer.j...@kippdata.de: I need to add some info to the tcnative docs concerning using a native SSL connector and I'm quite uncertain where to add it. It will roughly be: Starting with version 1.1.34 of the APR/native connector, the strength of

Re: End of life for 6.0.x

2015-05-14 15:14 GMT+02:00 Mark Thomas ma...@apache.org: Option 1: Tomcat 6.0.x EOL as of 30 June 2016 Option 2: Tomcat 6.0.x EOL as of 31 December 2016 It has been around for a very long time (2007) but it is a very significant release, so option 2 is probably better. OTOH, I am not actually

Re: OpenSSL JSSE SSLEngine implementation

2015-05-21 19:48 GMT+02:00 Christopher Schultz ch...@christopherschultz.net : Rémy, On 5/18/15 11:46 AM, Rémy Maucherat wrote: Early performance results show the NIO(2) connector with SSL being equivalent or maybe even slightly faster than the APR connector, with JSSE very far behind

Re: [VOTE] Release Apache Tomcat 8.0.23

2015-05-19 20:43 GMT+02:00 Mark Thomas ma...@apache.org: The proposed 8.0.23 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 8.0.23 Rémy

Re: svn commit: r1680928 - in /tomcat/trunk: java/org/apache/tomcat/util/net/Nio2Endpoint.java webapps/docs/config/http.xml

2015-05-21 19:11 GMT+02:00 r...@apache.org: Author: remm Date: Thu May 21 17:11:49 2015 New Revision: 1680928 URL: http://svn.apache.org/r1680928 Log: Drop useCaches from NIO2 and fix issue in doc. Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java

Re: svn commit: r1681794 - /tomcat/trunk/java/org/apache/coyote/http11/Http11Nio2Protocol.java

2015-05-26 20:17 GMT+02:00 Mark Thomas ma...@apache.org: It was a left over from the attempt to make BIO support more connections than it had threads by not doing an immediate read on a keep-alive connection. It was no longer required. There is another return false in the correct place in the

Re: svn commit: r1681794 - /tomcat/trunk/java/org/apache/coyote/http11/Http11Nio2Protocol.java

2015-05-26 20:37 GMT+02:00 Mark Thomas ma...@apache.org: On 26/05/2015 19:33, Rémy Maucherat wrote: 2015-05-26 20:17 GMT+02:00 Mark Thomas ma...@apache.org: It was a left over from the attempt to make BIO support more connections than it had threads by not doing an immediate read

Re: TC trunk: protocol in SSLHostConfig only for OpenSSL?

2015-05-26 17:40 GMT+02:00 Rainer Jung rainer.j...@kippdata.de: I'm a bit confused: is protocol in SSLHostConfig only for OpenSSL, or also for JSSE? There's also sslProtocol, which seems to be for JSSE but the docs looked like protocol were for both. Or is it work in progress? No, protocols

Re: svn commit: r1681794 - /tomcat/trunk/java/org/apache/coyote/http11/Http11Nio2Protocol.java

2015-05-26 19:20 GMT+02:00 ma...@apache.org: Author: markt Date: Tue May 26 17:20:12 2015 New Revision: 1681794 URL: http://svn.apache.org/r1681794 Log: Fix NIO2 test failures. I don't understand what these failures suddenly come from, but this is likely wrong: it is possible there is no

Re: svn commit: r1681794 - /tomcat/trunk/java/org/apache/coyote/http11/Http11Nio2Protocol.java

2015-05-26 19:32 GMT+02:00 Mark Thomas ma...@apache.org: On 26/05/2015 18:27, Rémy Maucherat wrote: 2015-05-26 19:20 GMT+02:00 ma...@apache.org: Author: markt Date: Tue May 26 17:20:12 2015 New Revision: 1681794 URL: http://svn.apache.org/r1681794 Log: Fix NIO2 test failures

Re: buildbot success in ASF Buildbot on tomcat-trunk

2015-07-15 11:46 GMT+02:00 build...@apache.org: The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/49 Buildbot URL: http://ci.apache.org/ Buildslave for this

Re: [VOTE] Release Apache Tomcat 7.0.64

2015-08-19 20:01 GMT+02:00 Violeta Georgieva violet...@apache.org: The proposed 7.0.64 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 7.0.64 Stable Rémy

Re: Plan for 9.0.0.RC1

2015-10-21 16:14 GMT+02:00 Mark Thomas : > On 20/10/2015 15:30, Mark Thomas wrote: > > > I found the root cause of the Gump failure. It was an error in the > > refactoring when I switched WebSocket from Servlet 3.1 non-blockin I/O > > to goting directly to Tomcat's I/O layer. >

Re: Plan for 9.0.0.RC1

2015-10-23 10:12 GMT+02:00 Mark Thomas : > I've made a little progress. > > I can see in Wireshark that the initial HTTP/2 connection preface is > sent followed by a SETTINGS frame are sent by Chrome. > > Debug logging in Tomcat shows that that data is never processed by the >

Re: [VOTE] Release Apache Tomcat Native 1.2.0

2015-10-22 12:47 GMT+02:00 Mark Thomas : > Version 1.2.0 includes the following changes: > - Windows binaries built with APR 1.5.1 and OpenSSL 1.0.2d > - ALPN support > (most importantly IMO) - Add API methods to access OpenSSL BIO > > The proposed release artefacts can be

Re: svn commit: r1710618 - in /tomcat/trunk/java/org/apache/tomcat/util/net: SecureNio2Channel.java openssl/OpenSSLEngine.java

2015-10-26 20:50 GMT+01:00 Mark Thomas : > On 26/10/2015 08:10, r...@apache.org wrote: > > Author: remm > > Date: Mon Oct 26 15:10:53 2015 > > New Revision: 1710618 > > > > URL: http://svn.apache.org/viewvc?rev=1710618=rev > > Log: > > - Fix capacity check algorithm (overflow

Re: Tomcat 9.0.x, tc-native and itanium support

2015-10-22 12:31 GMT+02:00 Mark Thomas : > I've been having problems building OpenSSL 1.0.2d for Windows Itanium > 64-bit as part of building the tcnative binaries for Windows. > > Given that the last Windows platform to support Itanium is Server 2008 > R2 and that that has

Re: svn commit: r1710835 - in /tomcat/trunk/java/org/apache/tomcat/util/net: Nio2Endpoint.java SocketWrapperBase.java

2015-10-27 16:16 GMT+01:00 : > Author: remm > Date: Tue Oct 27 15:16:04 2015 > New Revision: 1710835 > > URL: http://svn.apache.org/viewvc?rev=1710835=rev > Log: > - Add an extra async IO flag I used for testing. > - Blocking should block. > > It's possible I'll remove this code

Re: Plan for 9.0.0.RC1

2015-10-23 15:12 GMT+02:00 Mark Thomas : > Found it. > > unwrap() only unwraps one TLS Record at a time. If there are multiple > TLS records in the input buffer unwrap reads them all into the engine > but only provides the decrypt for the first. Further calls to unwrap are >

Re: Plan for 9.0.0.RC1

2015-10-22 16:56 GMT+02:00 Mark Thomas : > I've got things up and running on Windows (a good opportunity to test > the tcnative binaries) and I see what looks to be the same problem with > Chrome + NIO2 in that no images are displayed. Even a simple HTTP/2 page > fails. > If

Re: Plan for 9.0.0.RC1

2015-10-22 16:56 GMT+02:00 Mark Thomas <ma...@apache.org>: > On 19/10/2015 13:38, Rémy Maucherat wrote: > > 2015-10-19 14:24 GMT+02:00 Mark Thomas <ma...@apache.org>: > > >> Anything reproducible? > > > > Chrome mostly, Firefox is a bit nicer for me.

Re: [VOTE] Switch 6.0.x from RTC to CTR

2015-10-28 23:42 GMT+01:00 Mark Thomas : > I would therefore like to propose that we switch the 6.0.x release > branch from RTC to CTR and am therefore calling a VOTE to make this change. > > [ ] Continue to use RTC for 6.0.x > [X] Switch 6.0.x to CTR > > Comments: - How close

Re: 9.0.x, HTTP/2, Windows

2015-11-10 22:34 GMT+01:00 Mark Thomas : > Just a quick update on the issues Violeta reported with 9.0.x, HTTP/2 > and Windows. > > I can repeat the Chrome + WebSocket == failure result > What is the expected test result ? If using ALPN, chrome connects using HTTP/2, which then

Re: Time for 9.0.0.RC1

2015-11-12 9:26 GMT+01:00 Mark Thomas : > The announcements, download page, which version etc. will all make it > clear that this a work in progress. > > To make it clearer, I'll label the version M1 (milestone 1) rather than > RC1. > > This naming is new in Tomcat. It could be

Re: [VOTE] Release Apache Tomcat 9.0.0.M1

2015-11-15 16:36 GMT+01:00 Martin Grigorov : > 1) > ERROR - AtmosphereFramework- AtmosphereFramework exception > java.lang.IllegalStateException: A filter or servlet of the current chain > does not support asynchronous operations. > at

Re: 9.0.x, HTTP/2, Windows

2015-11-11 16:25 GMT+01:00 Mark Thomas : > Since I had everything set up, I took a look at the network traffic and > all I was seeing was a single request (over h2) for drawboard.xhtml. > > I did some digging and found the Chrome was reporting errors in that > page because no

Re: svn commit: r1712231 - /tomcat/tc6.0.x/trunk/STATUS.txt

2015-11-03 11:02 GMT+01:00 Mark Thomas : > I missed that there were inner classes. Consider my -1 withdrawn. > > But didn't we just switch to CTR ? Rémy

Re: [VOTE] Release Apache Tomcat Native 1.2.0

2015-10-31 9:10 GMT+01:00 Mark Thomas : > > Essentially, > > > > [junit] Caused by: java.lang.NoSuchMethodError: sniCallBack > > [junit] at org.apache.tomcat.jni.SSLContext.make(Native Method) > > Ah, yes, ok, native 1.2 assumes SNI, and the old Java classes

Re: Tomcat Native 1.2.2

2015-11-04 20:22 GMT+01:00 Christopher Schultz : > At some point, tcnative won't have to exist at all. There have been some > efforts to provide an OpenSSL-based JSSE provider, at which point little > needs to be done to use OpenSSL under the hood, and I think the

Re: svn commit: r1712683 - in /tomcat/trunk/java/org/apache/tomcat/jni: SSLExt.java socket/AprSocket.java socket/AprSocketContext.java socket/HostInfo.java

2015-11-05 0:08 GMT+01:00 : > Author: kkolinko > Date: Wed Nov 4 23:08:35 2015 > New Revision: 1712683 > > URL: http://svn.apache.org/viewvc?rev=1712683=rev > Log: > Remove SSLExt and related classes. > > SSLExt has a lot of native methods that are said to be implemented in

Re: [VOTE] Release Apache Tomcat Native 1.2.1

2015-11-03 21:14 GMT+01:00 Christopher Schultz : > Fixing the APR path allows tcnative to build without warnings or errors. > It even links against libssl, even though the configure script really > wants to have OpenSSL 1.0.2 and I only have 1.0.1. I'm curious to

Re: tomcat timeout handling

2015-11-05 3:29 GMT+01:00 Bernd Eckenfels : > I think this is wrong, it does not only apply to the initial line but > also the output. Maybe this could be clarified, especially in relation > with uploadTimeout and keepAliveTimeout. Especially when does the > connector

Re: svn commit: r1713158 - /tomcat/tc6.0.x/trunk/test/org/apache/catalina/tribes/group/TestGroupChannelSenderConnections.java

2015-11-07 18:17 GMT+01:00 : > Author: kkolinko > Date: Sat Nov 7 17:17:55 2015 > New Revision: 1713158 > > URL: http://svn.apache.org/viewvc?rev=1713158=rev > Log: > Copy test implementation from Tomcat 7. > This a) uses logging instead of System.out, > b) validates result

Re: websocket tomcat listener API?

2015-11-04 14:55 GMT+01:00 Romain Manni-Bucau : > Here is the use case: we make these endpoints go through the javee instance > manager. Being a ee server we support @Inject and in some cases - sadly the > most common one - we need a cleanup hook once the endpoint is no

<    1   2   3   4   5   6   7   8   9   10   >