Re: tomee git commit: removing missing unused package

Thanks Thiago. Intellj was supposed to do that for me lol Thanks Le 2 nov. 2015 06:33, a écrit : > Repository: tomee > Updated Branches: > refs/heads/master 436089b65 -> 58ec24151 > > > removing missing unused package > > > Project:

Re: tomee git commit: removing missing unused package

Yeah, maven caught it, not the IDE. My IDE goes nuts with the project too. I think there are too many files for it to keep track. Configuration issue from my side for sure. :) []s, Thiago. On Mon, Nov 2, 2015 at 9:37 AM, Jean-Louis Monteiro < jlmonte...@tomitribe.com> wrote: > Thanks Thiago. > >

Buildbot

Hi guys, Please ensure you get the build back to green after you apply changes: Release branch: https://ci.apache.org/builders/tomee-1.7.x-ubuntu Dev branch: https://ci.apache.org/builders/tomee-trunk-ubuntu If you feel any of the pmd rules do no apply then please open a discussion. TY Andy.

Re: Buildbot

Hi Andy, You are totally right. That is totally my fault. Forgot to remove an unused header in a Test case and haven't checked in the weekend. Jean-Louis -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Mon, Nov 2, 2015 at 9:32 AM, agumbrecht

Re: Fwd: tomee git commit: TOMEE-1648: The password cipher is called each time the datasource is built even if we already have the clear password

Ok just checked and we didnt expose the setPassword to JMX for dbcp so we are fine, sorry for the noise! Romain Manni-Bucau @rmannibucau | Blog | Github | LinkedIn

Re: Fwd: tomee git commit: TOMEE-1648: The password cipher is called each time the datasource is built even if we already have the clear password

oh that is all perfect feedback -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Mon, Nov 2, 2015 at 11:36 AM, Romain Manni-Bucau wrote: > Ok just checked and we didnt expose the setPassword to JMX for dbcp so we > are fine, sorry for

Fwd: tomee git commit: JDK 6

you changed a test changing jndi names: why removing java:app/jdbc/? Also LocalFileHandler is now broken cause we can't use any dependency for this one (it is likely used before common.loader). Since it is not setup by default it is ok IMO to have to build this part with java 7 since the main

Re: JDK attention

Hope it's not me again, but thanks for that :) -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Mon, Nov 2, 2015 at 3:12 PM, agumbrecht wrote: > Hi Guys, > > Again, just a friendly nudge > > The 1.7.x branch is still JDK 6 > >

Re: Fwd: tomee git commit: JDK 6

2015-11-02 15:59 GMT-08:00 agumbrecht : > Because 'lookup' is endorsed api and not on the buildbot. java:app/jdbc/ > was > not working and needed a quick fix. > > isnt it a "old" test? Why was it working before? If new just ignore my comment then. > The buildbot

JDK attention

Hi Guys, Again, just a friendly nudge The 1.7.x branch is still JDK 6 Only trunk is on JDK 7+ Andy. - -- Andy Gumbrecht http://www.tomitribe.com agumbre...@tomitribe.com https://twitter.com/AndyGeeDe TomEE treibt Tomitribe ! | http://tomee.apache.org --

Re: Fwd: tomee git commit: JDK 6

Because 'lookup' is endorsed api and not on the buildbot. java:app/jdbc/ was not working and needed a quick fix. The buildbot compiles with jdk 6 for 1.7.x. So it needs code that compiles. If LocalFileHandler cannot use deps then it needs a re-write for jdk6 Most users are not using jdk 7/8,

Re: Fwd: tomee git commit: JDK 6

there is java 6 API for these things but got some surprises using them and not j7 one on some UNIx. I would really prefer to go with j7 code even in 1.7 than j6. If we manage to do a 7.x AND 1.7 vote (ie both in the same thread) I'm +1 to remove it from 1.7.x and I can do the extraction in a

Re: Fwd: tomee git commit: JDK 6

So we should maven profile this part of the build as an optional extra that is not included by default, at least for the 1.7.x build. Will have a look at that tomorrow. - -- Andy Gumbrecht http://www.tomitribe.com agumbre...@tomitribe.com https://twitter.com/AndyGeeDe

Re: Fwd: tomee git commit: JDK 6

well not exactly, it should be delivered by default but not configured using it. Alternative is to extract this part in another module on 7.x, then users can import this jar "manually" - but it shouldnt be in tomee-juli cause 1.x and 7.x tomee-juli are not compatible. I have no strong opinion on

Re: Fwd: tomee git commit: JDK 6

Well we just need a JDK6 compatible & green build solution for 1.7.x and TTx, so I'm going to let you work this one out the best way you see fit. All PMCs should be commenting on this and working towards a solution that is backwards compatible and does not break the status quo for any