Re: TomEE MicroProfile Dist with Config

2018-03-06 8:22 GMT+01:00 Mark Struberg : > Did we already solve the Java8 question? > Nop but not a blocker for java 8 > Because if we add MP then you cannot build with Java7 anymore. > We fixed all the java8/7 build time incompatibilities so we can (now, agree we

Re: TomEE MicroProfile Dist with Config

Did we already solve the Java8 question? Because if we add MP then you cannot build with Java7 anymore. Lg strub Mit autocorrect gesendet > Am 05.03.2018 um 22:31 schrieb Romain Manni-Bucau : > > Le 5 mars 2018 22:07, "Jonathan Gallimore" a

Re: TomEE MicroProfile Dist with Config

Le 5 mars 2018 22:07, "Jonathan Gallimore" a écrit : On Mon, Mar 5, 2018 at 9:03 PM, Romain Manni-Bucau wrote: > > > Le 5 mars 2018 21:35, "Jonathan Gallimore" > a écrit : > > The name "MicroProfile" suggests

Re: TomEE MicroProfile Dist with Config

On Mon, Mar 5, 2018 at 9:03 PM, Romain Manni-Bucau wrote: > > > Le 5 mars 2018 21:35, "Jonathan Gallimore" > a écrit : > > The name "MicroProfile" suggests an element of being small, so I'm not > sure why we'd only add this to our biggest

Re: TomEE MicroProfile Dist with Config

Le 5 mars 2018 21:35, "Jonathan Gallimore" a écrit : The name "MicroProfile" suggests an element of being small, so I'm not sure why we'd only add this to our biggest distribution and no where else. I've built the change (thanks for the help Roberto), and it adds

Re: TomEE MicroProfile Dist with Config

The name "MicroProfile" suggests an element of being small, so I'm not sure why we'd only add this to our biggest distribution and no where else. I've built the change (thanks for the help Roberto), and it adds <100KB to the binary. I'd definitely add it to Plus and Plume, but I think we should

Re: TomEE MicroProfile Dist with Config

2018-03-05 18:02 GMT+01:00 Roberto Cortez : > > I'll check Jon. > Regarding profiles, my idea about a MP build was to also allow us to have > a minimal binary with just the MP stuff. This mean removing specs that are > not part of MP specs, like JPA. I guess this

Re: TomEE MicroProfile Dist with Config

I'll check Jon. Regarding profiles, my idea about a MP build was to also allow us to have a minimal binary with just the MP stuff. This mean removing specs that are not part of MP specs, like JPA. I guess this could be controversial, but it would allows us to have a very small footprint

Re: TomEE MicroProfile Dist with Config

Hey Roberto I'm getting a build error on your PR: [ERROR] Failed to execute goal org.codehaus.gmaven:groovy-maven-plugin:2.0:execute (execute-microprofile-installer) on project apache-tomee: Execution execute-microprofile-installer of goal org.codehaus.gmaven:groovy-maven-plugin:2.0:execute

Re: TomEE MicroProfile Dist with Config

I generally agree about not adding a microprofile profile. I'd be tempted to just add it to all the existing profiles. What would the size impact of that be? Also, I think an example showing how config works would be really great. I don't think that has to go in the same PR though. Jon On Mon,

Re: TomEE MicroProfile Dist with Config

Not sure why gmail messed up the formatting so putting my comments/answers here instead of inline: 1. we have forced scan/exclude in the URLClassLoaderfirst, guess it would be the exact same kind of config 2. I got it but there is no spec in MP requiring integration code normally (config doesn't,

Re: TomEE MicroProfile Dist with Config

Hi Romain, Thank you for your quick reply. I did try to make it consistent, following the patterns I was able to identify already in the project. 1 - I'll +1 on configurable way to whitelist, include or exclude jars from scanning. This would take priority over the default.excludes.2 - If 1 is

Re: TomEE MicroProfile Dist with Config

Hi Roberto, looks a very good start. I have a few discussion points - not 100% linked to this PR but since it triggers items we'll need to discuss I'm dumping it here: 1. MPService should probably be replaced to use a lookup from the classloader and not a particular location (should work in split

Re: TomEE MicroProfile Dist with Config

+1 2018-03-05 9:40 GMT-03:00 Roberto Cortez : > Hi all, > I've submitted a PR:https://github.com/apache/tomee/pull/122 > > With some initial work to build a MicroProfile dist of TomEE, starting > with the MicroProfile Config. > Please let me know if this is alright.

TomEE MicroProfile Dist with Config

Hi all, I've submitted a PR:https://github.com/apache/tomee/pull/122 With some initial work to build a MicroProfile dist of TomEE, starting with the MicroProfile Config. Please let me know if this is alright. I plan to add some of the other implementations into it as well. Thanks!