Re: TomEE 8 - Next steps

Probably worth a read: http://tomee-openejb.979440.n4.nabble.com/VOTE-next-tomee-version-targetting-EE-7-td4674650.html http://tomee-openejb.979440.n4.nabble.com/Java-EE-version-Alignment-Troubles-td4674796.html And related if you still feel motivated by reading after these pages ;) Le mar. 20

Re: Microprofile Metrics Example

Hi César, Did you test passing accept header or just in the browser which sends json and text as acceptable value so resolution can be not that deterministic using it - but this is the request so all fine ;). The last side note is prometheus does not support monotonic=false (small glitch in the s

[GitHub] tomee pull request #205: added ignore folder from vscode.

GitHub user cesarhernandezgt opened a pull request: https://github.com/apache/tomee/pull/205 added ignore folder from vscode. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cesarhernandezgt/tomee gitignore-for-vscode Alternativ

[GitHub] tomee pull request #204: fixed cdi-basic-typos

GitHub user cesarhernandezgt opened a pull request: https://github.com/apache/tomee/pull/204 fixed cdi-basic-typos You can merge this pull request into a Git repository by running: $ git pull https://github.com/cesarhernandezgt/tomee cdi-basic-spelling-review Alternatively y

Re: Microprofile Metrics Example

Hi Ivan, nice job with this example. I found another potential issue with the metrics in TomEE, If you remove the `monotonic = true` from the @Counted annotation, then the format of the endpoint: http://localhost:8080/rest-mp-metrics/metrics is no longer Prometheus but JSON instead. Without `mon

Writing presentable examples

I gave this doc a quick review and it looks good. It doesn't have the directory layout or SEO information in there, but it does have a few valid brain hacks. - http://tomee.apache.org/dev/writing-examples.html -- David Blevins http://twitter.com/dblevins http://www.tomitribe.com

Re: Microprofile Metrics Example

Agree with the README comments. Another great reference is the Simple WebService example which has payloads. - https://github.com/apache/tomee/tree/master/examples/simple-webservice#inspecting-the-messages I think people new to MicroProfile metrics will want to see what the metrics look like

[GitHub] tomee pull request #202: Changes to "access-timeout" and "access-timeout-met...

Github user asfgit closed the pull request at: https://github.com/apache/tomee/pull/202 ---

[GitHub] tomee pull request #199: Hacking around with loading CMP modules

Github user asfgit closed the pull request at: https://github.com/apache/tomee/pull/199 ---

[GitHub] tomee pull request #203: TOMEE-2279 - Microprofile Metrics example

Github user asfgit closed the pull request at: https://github.com/apache/tomee/pull/203 ---

Re: Github not syncing?

I've filed a ticket with ASF infra to take a look: https://issues.apache.org/jira/browse/INFRA-17276 Cheers Jon On Mon, Nov 19, 2018 at 11:15 PM Roberto Cortez wrote: > Hi folks, > > It seems that Apache Git is not syncing with Github: > > https://git-wip-us.apache.org/repos/asf?p=tomee.git <

Re: TomEE 8 - Next steps

Nevermind, that was just a discussion because I had the idea that the Jakarta EE version was going to reset. This is not the case, so doesn’t make sense anymore. > On 19 Nov 2018, at 23:08, exabrial12 wrote: > > Roberto, I'd advise to stick to https://semver.org semantics: > > It's worth a r

Github not syncing?

Hi folks, It seems that Apache Git is not syncing with Github: https://git-wip-us.apache.org/repos/asf?p=tomee.git -> We can see commits from today and from 3 days ago. https://github.com/apache/tomee/commits/master

Re: TomEE 8 - Next steps

Roberto, I'd advise to stick to https://semver.org semantics: It's worth a read at the link, but: major.minor.patch * major is API breaking changes, so removing an API or class * minor is adding a new API or feature, or marking a public API as deprecated, in a non-breaking manner * patch is bug

Re: TomEE 8 - Next steps

Very well, sorry for misleading then. At some point, I’ve got the impression it was going to be 1.0 and reset. I should have checked that. > On 19 Nov 2018, at 22:13, Richard Monson-Haefel > wrote: > > Jakarta EE is not going to reset back to 1.0. It's going to carry on from > where Java EE l

Re: TomEE8 RC2: MP Metrics @Counted throws 500

> > Did you clean up your lib folder to kot provide mp libs? No, I didn't clean up the lib folder intentionally but now that I'm looking again this thread. I may have one more chance to test in the project I shared. I'm going to try to specify in arquilliam.xml [1] the microprofile classifier

Re: TomEE 8 - Next steps

Jakarta EE is not going to reset back to 1.0. It's going to carry on from where Java EE left off. In fact, the first release of Jakarta EE will be version 8 and will be identical to Java EE 8. Jakarta will then to go version 9, 10, etc. On Mon, Nov 19, 2018 at 3:56 PM Roberto Cortez wrote: > We

Re: TomEE 8 - Next steps

Well that is the thing. Some time ago, we aligned TomEE version to be the same as EE. Now, Jakarta is going to reset the versions back to 1.0 as far as I know, so we don’t have that link anymore, and we can’t really go back on versions, so I guess we need to do something like: Version x.y.z x

Re: TomEE 8 - Next steps

+1 better to use this versioning scheme - and wait for Jakarta EE9 to jump to TomEE9.x Am Mo., 19. Nov. 2018 um 21:38 Uhr schrieb exabrial12 : > What does everyone think about about small releases (8.0.x, 8.1.x, 8.2.x) > with each Minor (middle) number adds a new API? Once we get to all the > des

Re: TomEE 8 - Next steps

What does everyone think about about small releases (8.0.x, 8.1.x, 8.2.x) with each Minor (middle) number adds a new API? Once we get to all the desired API level we could issue an LTS (so declare that 8.6.x would be like Java11 support, MP, and JEE8, plus it'd be around for awhile). This sort of m

Re: Microprofile Metrics Example

Great stuff! Do checkout these - they're a pretty good format to follow: https://github.com/apache/tomee/blob/master/examples/simple-stateless/README.md . I've merged your PR, and we can continue to iterate on it. Thanks for the contribution, I think its great to see some MicroProfile examples. I

Re: Microprofile Metrics Example

Hi, Yeah the sample is cool. I just push my +1. But, I'm agree with Jon, we can improve de Readme to make it better. Nice work man. :) Em seg, 19 de nov de 2018 5:12 PM, Ivan Junckes Filho Done Jon, I will keep improving it. > > On Mon, Nov 19, 2018 at 6:01 PM Jonathan Gallimore < > jonathan.ga

Re: Microprofile Metrics Example

Done Jon, I will keep improving it. On Mon, Nov 19, 2018 at 6:01 PM Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > Very cool. I'd suggest adding a README like the other examples have, as > that can be linked from the website, and they usually provide great > documentation. > > Jon >

Re: Microprofile Metrics Example

Very cool. I'd suggest adding a README like the other examples have, as that can be linked from the website, and they usually provide great documentation. Jon On Mon, 19 Nov 2018, 19:51 Ivan Junckes Filho Hey guys, just to let you know that I created a Microprofile Metrics > Example under Tomee.

Microprofile Metrics Example

Hey guys, just to let you know that I created a Microprofile Metrics Example under Tomee. I am still working on that and I will provide more test scenarios. Here is the PR if you want to review the work so far: https://github.com/apache/tomee/pull/203 Feel free to merge if you think this can be

[GitHub] tomee pull request #203: TOMEE-2279 - Microprofile Metrics example

GitHub user ivanjunckes opened a pull request: https://github.com/apache/tomee/pull/203 TOMEE-2279 - Microprofile Metrics example You can merge this pull request into a Git repository by running: $ git pull https://github.com/ivanjunckes/tomee metrics-example Alternatively yo

Re: TomEE 8 - Next steps

+1 On Mon, Nov 19, 2018 at 10:40 AM Roberto Cortez wrote: > I’ve got some feedback that people enjoyed having WebProfile + > MicroProfile. If you strictly look just into the MP spec, sure you can > develop an app with that, but most likely you will be requiring other stuff. > > Unless there is a

Re: Richard, thanks for the contribution

Thanks. To be clear I co-founded OpenEJB not TomEE. But its great to be back! On Mon, Nov 19, 2018 at 1:14 PM Jean-Louis Monteiro < jlmonte...@tomitribe.com> wrote: > Yes, but very happy to see the co-founder of the project back and willing > to contribute again. > -- > Jean-Louis Monteiro > htt

Re: Richard, thanks for the contribution

Yes, but very happy to see the co-founder of the project back and willing to contribute again. -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Mon, Nov 19, 2018 at 8:13 PM Richard Monson-Haefel < monsonhae...@gmail.com> wrote: > Thanks! It's a start! > > On

Re: Richard, thanks for the contribution

Thanks! It's a start! On Mon, Nov 19, 2018 at 1:00 PM Jean-Louis Monteiro < jlmonte...@tomitribe.com> wrote: > Thanks Richard and welcome back to the fun. > > Merge it. > [image: image.png] > > -- > Jean-Louis Monteiro > http://twitter.com/jlouismonteiro > http://www.tomitribe.com >

Richard, thanks for the contribution

Thanks Richard and welcome back to the fun. Merge it. [image: image.png] -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com

Re: [3/4] tomee git commit: Merge a82fdd5d10f4d0813cfdcdccc363ce6cf292b292 into 60ef186b31702bafbcb2c0ea73f867ce8b419ec6

Hey Richard, Thanks for the PR. I just merged it. JLouis -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Mon, Nov 19, 2018 at 7:56 PM wrote: > Merge a82fdd5d10f4d0813cfdcdccc363ce6cf292b292 into > 60ef186b31702bafbcb2c0ea73f867ce8b419ec6 > > > Project: htt

[GitHub] tomee pull request #202: Changes to "access-timeout" and "access-timeout-met...

GitHub user monsonhaefel opened a pull request: https://github.com/apache/tomee/pull/202 Changes to "access-timeout" and "access-timeout-meta" I made some grammatical and type changes to the README.md of the "access-timeout" and "access-timeout-meta" examples. The paragraphs fixed

Re: Override bean from library on TomEE

Le lun. 19 nov. 2018 17:58, Bruno Baptista a écrit : > Thanks Romain, > > It's good to know. Where is that configuration? > https://github.com/apache/tomee/blob/master/container/openejb-core/src/main/resources/default.exclusions and https://github.com/apache/tomee/commit/23f44b17e6ab504561f32aa4

Re: Override bean from library on TomEE

Thanks Romain, It's good to know. Where is that configuration? However, the problem is before that... The test with the interceptor, somehow fails to load the alternative, which has me very puzzled. Cheers. Bruno Baptista http://twitter.com/brunobat_ On 19/11/18 16:45, Romain Manni-Bucau w

Re: TOMEE-2253 - tomee.sh -version not working properly with Java 11

Hi Jon, ok. I got it! :) Em seg, 19 de nov de 2018 às 13:49, Jonathan Gallimore < jonathan.gallim...@gmail.com> escreveu: > On Mon, Nov 19, 2018 at 4:30 PM Daniel Cunha wrote: > > > Hi guys, > > > > I updated the PR with some chages: > > 1 - Move BasicURLClassPath.CustomizableURLClassLoader to

Re: Override bean from library on TomEE

Le lun. 19 nov. 2018 à 16:59, Roberto Cortez a écrit : > Hi, > > We had that project before, and we ended up dropping with the > justification that the libs should handle all of that. > > Not saying not to do it and I just don’t want to see code being blocked > again for the same reason :) > > Ch

Re: TOMEE-2253 - tomee.sh -version not working properly with Java 11

On Mon, Nov 19, 2018 at 4:30 PM Daniel Cunha wrote: > Hi guys, > > I updated the PR with some chages: > 1 - Move BasicURLClassPath.CustomizableURLClassLoader to be public. > 2 - I'm using BasicURLClassPath.CustomizableURLClassLoader instead of > DynamicClassLoader (class that I created) > 3- Dyna

Re: TomEE 8 - Next steps

I’ve got some feedback that people enjoyed having WebProfile + MicroProfile. If you strictly look just into the MP spec, sure you can develop an app with that, but most likely you will be requiring other stuff. Unless there is a high demand of having just a MP flavour, I think we are ok. Regard

Re: TomEE 8 - Next steps

No this is a different flavor. It is based on webprofile though -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Mon, Nov 19, 2018 at 5:33 PM exabrial12 wrote: > Is MP support only in a WebProfile release currently? > > > > -- > Sent from: > http://tomee-o

Re: TomEE 8 - Next steps

Is MP support only in a WebProfile release currently? -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: TomEE 8 - Next steps

"Actually, kinda interested. I think we'd need to include MicroProfile in TomEE Plus and TomEE Plume though." I'm totally agree. Do we already have the CI running TomEE build with java 11? Em seg, 19 de nov de 2018 às 13:14, Jonathan Gallimore < jonathan.gallim...@gmail.com> escreveu: > Java 11

Re: TOMEE-2253 - tomee.sh -version not working properly with Java 11

Hi guys, I updated the PR with some chages: 1 - Move BasicURLClassPath.CustomizableURLClassLoader to be public. 2 - I'm using BasicURLClassPath.CustomizableURLClassLoader instead of DynamicClassLoader (class that I created) 3- DynamicClassLoader is not needed anymore. Was removed from the PR. 3 -

Re: TomEE 8 - Next steps

Java 11 is definitely a priority. Personally, I'd rather get a regular milestone releases, rather than waiting for everything Java 11-wise to be in place. Jon On Mon, Nov 19, 2018 at 4:03 PM Thomas Andraschko < andraschko.tho...@gmail.com> wrote: > I'm not a commiter but a full java11 support is

Re: TomEE 8 - Next steps

I'm not a commiter but a full java11 support is very important. But probably all open stories are very important :D Am Mo., 19. Nov. 2018 um 16:46 Uhr schrieb Roberto Cortez : > Hi folks, > > Following up our initial push to have a Milestone Release of TomEE 8, I > think we need to figure out th

Re: TomEE 8 - Next steps

On Mon, Nov 19, 2018 at 3:54 PM Bruno Baptista wrote: > Hi, > > I like the idea of more releases and incrementally add more features in > a planned way. > > Also, what do you guys think of slimming the microprofile flavor by > removing some non microprofile specs from it like JPA and such? > Act

Re: Override bean from library on TomEE

Hi, We had that project before, and we ended up dropping with the justification that the libs should handle all of that. Not saying not to do it and I just don’t want to see code being blocked again for the same reason :) Cheers, Roberto > On 19 Nov 2018, at 15:31, Bruno Baptista wrote: > >

Re: TomEE 8 - Next steps

Hi, I like the idea of more releases and incrementally add more features in a planned way. Also, what do you guys think of slimming the microprofile flavor by removing some non microprofile specs from it like JPA and such? Cheers Bruno Baptista http://twitter.com/brunobat_ On 19/11/18 15

TomEE 8 - Next steps

Hi folks, Following up our initial push to have a Milestone Release of TomEE 8, I think we need to figure out the remaining steps to a final version: - Update MP specs to the latests and support at least MP 2.0 spec. - Provide MP support for other TomEE flavours: Plus, Plume, etc. - Implement J

Re: Override bean from library on TomEE

Hi Romain, In relation to the name of the lib to be /geronimo-safeguard-tomee/ instead of /tomee-microprofile-common/ I would advise against it because we can put other overrides and utility classes on it instead of creating a single lib for every particular spec/need. Feedback is appreciate

Re: [4/5] tomee git commit: keeps the original behavior of the filter

Hey Otavio, This is a great contribution. Thanks and congrats for your first commit. JLouis -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Mon, Nov 19, 2018 at 4:09 PM wrote: > keeps the original behavior of the filter > > > Project: http://git-wip-us.apa

Re: Override bean from library on TomEE

rename the lib geronimo-safeguard-tomee or include the common MP jar in the scanned modules? side note: i mentionned it @geronimo: you likely don't want to hardcode a default name which will either be replaced by another one, not be the default one or not be controllable by the user ( DefaultManag

Re: DISCUSS: Java 11 naming convention for modules

For the moment I have been struggling getting something to work. I have pushed a few modules and I'll continue to do so. We can do a search/replace whenever we want if we find something that goes better. I must say that I'm not so familiar with Java Modules and I'm still learning a lot. Happy to h

Re: DISCUSS: Java 11 naming convention for modules

I believe we could reach out to Sander Mak. He wrote the Java Modularity Book and he was pushing heavily for libraries to update to Java 9 modules. I’m sure we can ask him some recommendations on how to do this. > On 16 Nov 2018, at 06:01, David Blevins wrote: > > I think the natural response

Re: Creates an unmarshal that does not filter to JavaEE namespace

So the issue here is that when ReadDescriptors tries to unmarshal openejb-cmp-orm.xml here: https://github.com/apache/tomee/blob/master/container/openejb-core/src/main/java/org/apache/openejb/config/ReadDescriptors.java#L551 fails, because JaxbJavaee.unmarshalJavaee() forces a http://java.sun.com/

Re: Override bean from library on TomEE

Hi All, I created a PR to make the discussion easier. It's here: https://github.com/apache/tomee/pull/201 There's another problem with the alternative bean implementation. After including the SafeguardInterceptor in the test, the bean, FailsafeContainerExecutionManagerProvider, is never pick

[GitHub] tomee pull request #201: TOMEE-2278 - Use Managed Executor with Safeguard Fa...

GitHub user brunobat opened a pull request: https://github.com/apache/tomee/pull/201 TOMEE-2278 - Use Managed Executor with Safeguard Fault Tolerance lib Well... when we include the SafeguardInterceptor, Our alternative is not picked up on the test. We still need to figure out a

Re: Creates an unmarshal that does not filter to JavaEE namespace

Hey, sorry I missed this email. It isn't related to Java 11. That is an XML unmarshal error around CMP configuration. On Mon, Nov 19, 2018 at 10:09 AM Jean-Louis Monteiro < jlmonte...@tomitribe.com> wrote: > That's why I was asking for the Java version and the version of TomEE > -- > Jean-Louis M

Re: Creates an unmarshal that does not filter to JavaEE namespace

That's why I was asking for the Java version and the version of TomEE -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Mon, Nov 19, 2018 at 12:55 PM Thomas Andraschko < andraschko.tho...@gmail.com> wrote: > Is it related to https://issues.apache.org/jira/brows

Re: Creates an unmarshal that does not filter to JavaEE namespace

Is it related to https://issues.apache.org/jira/browse/TOMEE-2271? Am Mo., 19. Nov. 2018 um 12:38 Uhr schrieb Jonathan Gallimore < jonathan.gallim...@gmail.com>: > Thanks for providing that extra detail here. I did take a look at this one, > and I'm surprised we haven't run into it before. I'll p

Re: Creates an unmarshal that does not filter to JavaEE namespace

Thanks for providing that extra detail here. I did take a look at this one, and I'm surprised we haven't run into it before. I'll pick up your PR and review. Cheers! Jon On Mon, Nov 19, 2018 at 11:33 AM Otávio Gonçalves de Santana < osant...@tomitribe.com> wrote: > Sorry, a sent the first one a

Re: MicroProfile JWT 1.1

I now have the principal injection part of this working - thanks Romain for your help and explanations. Progress is in my fork here: https://github.com/jgallimore/tomee/tree/jwt-1.1 (changes here: https://github.com/apache/tomee/compare/master...jgallimore:jwt-1.1?expand=1). There are still a coupl

Re: Creates an unmarshal that does not filter to JavaEE namespace

Sorry, a sent the first one as an accident. I’ve created a PR: https://github.com/apache/tomee/pull/200 The error class happened at this class JaxbJavaee.java, because of this filter: final JavaeeNamespaceFilter xmlFilter = new JavaeeNamespaceFilter(parser.getXMLReader()); xmlFilter.setContentHa

Re: TomEE8 RC2: MP Metrics @Counted throws 500

Hey guys, I also had the same issue here. The application metrics do not work. Base and Vendor metrics are fine. I am troubleshooting to see if I can find the issue. I will let you know if I find something. Please if you already had the chance to look into this let me know. On Tue, Oct 16, 2018

Re: Creates an unmarshal that does not filter to JavaEE namespace

https://github.com/apache/tomee/pull/200 On Mon, Nov 19, 2018 at 8:44 AM Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > Hey Otavio > > Thanks for posting. At what point do you run into this exception (your > stacktrace shows the unmarshal, but not where its called from). If you > ha

Re: Creates an unmarshal that does not filter to JavaEE namespace

Is it Java 11 related? What version are you running against? Le lun. 19 nov. 2018 à 11:44, Jonathan Gallimore < jonathan.gallim...@gmail.com> a écrit : > Hey Otavio > > Thanks for posting. At what point do you run into this exception (your > stacktrace shows the unmarshal, but not where its calle

Re: Override bean from library on TomEE

Hi Jon, I'm not sure what would be the right way to load that code. But now that you mention it, a CDI extension sounds the proper way to do it. The code now loads properly. Thanks! Will create a PR soon. Bruno Baptista http://twitter.com/brunobat_ On 19/11/18 10:41, Jonathan Gallimore wro

Re: Creates an unmarshal that does not filter to JavaEE namespace

Hey Otavio Thanks for posting. At what point do you run into this exception (your stacktrace shows the unmarshal, but not where its called from). If you have a PR, shoot a link here and I'll be happy to take a look. Jon On Mon, Nov 19, 2018 at 10:31 AM Otávio Gonçalves de Santana < osant...@tom

Re: Override bean from library on TomEE

I haven't seen the code, so its difficult to suggest anything - where would you expect it to be loaded - in a CDI extension? On Mon, Nov 19, 2018 at 10:31 AM Bruno Baptista wrote: > Hi all, > > I've created a jira for this task to properly track the commits: > https://issues.apache.org/jira/brow

Creates an unmarshal that does not filter to JavaEE namespace

Hi all. We found an error when using CMP; when the container starts, it returns an unmarshal error: at com.sun.xml.bind.v2.runtime.unmarshaller.UnmarshallingContext.handleEvent(UnmarshallingContext.java:662) at com.sun.xml.bind.v2.runtime.unmarshaller.Loader.reportError(Loader.java:258

Re: Override bean from library on TomEE

Thanks Jon Bruno Baptista http://twitter.com/brunobat_ On 19/11/18 10:10, Jonathan Gallimore wrote: I say go for it and create your module. Looking forward to reviewing the PR. Jon On Mon, Nov 19, 2018 at 10:08 AM Bruno Baptista wrote: Hi Jon, Well, 2 classes for the module. One doing th

Re: Override bean from library on TomEE

Hi all, I've created a jira for this task to properly track the commits: https://issues.apache.org/jira/browse/TOMEE-2278 Right now I have a problem activating the code... The code is in the lib folder but it's not being loaded into the classpath. Do I need to create some kind of a service

Re: Override bean from library on TomEE

I say go for it and create your module. Looking forward to reviewing the PR. Jon On Mon, Nov 19, 2018 at 10:08 AM Bruno Baptista wrote: > Hi Jon, > > Well, 2 classes for the module. One doing the work and a test. > > We have other modules with just 2 classes, like /tomee-overlay-runner/, > /tom

Re: Override bean from library on TomEE

Hi Jon, Well, 2 classes for the module. One doing the work and a test. We have other modules with just 2 classes, like /tomee-overlay-runner/, /tomee-util/ and other. There's probably margin for consolidating some of them, but that's probably a discussion for another thread. Cheers Bruno

Re: Override bean from library on TomEE

I'd be ok with creating a module to include your class file. We'd probably just want to keep an eye on it so it doesn't become a bucket of random stuff - so I could see it becoming tomee-microprofile-fault-tolerance, or something like that. Is it just one class file for the module? Jon On Sun, No