Re: Building TomEE, openejb-core, crashed test: org.apache.openejb.assembler.DeployerEjbTest

I've tried changing to that version as well, didn't work. If I run the command that broke the test: "C:\Program Files\Java\jdk1.8.0_161\jre\bin\java" -javaagent:C:\Users\Ferdi_S672\Documents\Personal\Projects\tomee\container\openejb-core\target\openejb-javaagent-8.0.0-SNAPSHOT.jar

Re: Feedback as newbie

Hi Frankie, In case you found it useful, there is a video that Ivan created to show how to build and test the website locally: https://youtu.be/P6IM0LDevVU El lun., 26 nov. 2018 a las 14:46, Frankie () escribió: > Thanks for all the helpful input. > I hope I will find time the next days to read,

Re: Feedback as newbie

Thanks for all the helpful input. I hope I will find time the next days to read, learn and play with the site-builder and then hopefully work on its content. -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

PRs and descriptive subjects

Quick note that emails for PRs should have a description of the work in the subject line. Here are some examples and why: - bad: This is an email about PR #451 - bad: See PR #451 - bad: Review PR #451 - bad: Help needed in PR #451 With this style you'll get low participation on the

[GitHub] tomee pull request #221: TOMEE-2279 - Fixing issue with payload format

GitHub user ivanjunckes opened a pull request: https://github.com/apache/tomee/pull/221 TOMEE-2279 - Fixing issue with payload format You can merge this pull request into a Git repository by running: $ git pull https://github.com/ivanjunckes/tomee

Re: Please review PR #214

Hi Romain, Thanks for you feedback. I've pushed changes and added a comment to the PR. Cheers. Bruno Baptista https://twitter.com/brunobat_ On 26/11/18 17:11, Romain Manni-Bucau wrote: Hello Bruno, I put some suggestions on the PR, hope it helps. Romain Manni-Bucau @rmannibucau

[GitHub] tomee issue #214: TOMEE-2283 - Websocket tls basic auth example

Github user brunobat commented on the issue: https://github.com/apache/tomee/pull/214 Hi @rmannibucau , Thanks for your comments. I've performed the following changes: * I've removed the NOTICE/LICENSE files. * Added missing headers to a few files. * I updated the

[GitHub] tomee issue #218: TOMEE-2290 - Metrics timer example

Github user ivanjunckes commented on the issue: https://github.com/apache/tomee/pull/218 @brunobat your branch seems to be old dated. Can you update it and try again? ---

Re: Please review PR #214

Hello Bruno, I put some suggestions on the PR, hope it helps. Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github | LinkedIn

[GitHub] tomee pull request #218: TOMEE-2290 - Metrics timer example

Github user ivanjunckes commented on a diff in the pull request: https://github.com/apache/tomee/pull/218#discussion_r236343729 --- Diff: examples/mp-metrics-timed/src/test/java/WeatherServiceTest.java --- @@ -157,7 +159,10 @@ private void assertJsonFormat(final String metricPath)

[GitHub] tomee pull request #218: TOMEE-2290 - Metrics timer example

Github user ivanjunckes commented on a diff in the pull request: https://github.com/apache/tomee/pull/218#discussion_r236343527 --- Diff: examples/mp-metrics-timed/pom.xml --- @@ -0,0 +1,71 @@ + --- End diff -- Done :) Tks ---

[GitHub] tomee pull request #218: TOMEE-2290 - Metrics timer example

Github user rmannibucau commented on a diff in the pull request: https://github.com/apache/tomee/pull/218#discussion_r236342694 --- Diff: examples/mp-metrics-timed/pom.xml --- @@ -0,0 +1,71 @@ + --- End diff -- header ;) ---

Please review PR #214

Hi, I think the code for this example: TOMEE-2283 New Example: Websocket with TLS and Basic Auth Is ready for review here: https://github.com/apache/tomee/pull/214 Can one of you please take a look? Cheers -- Bruno Baptista

[GitHub] tomee pull request #218: TOMEE-2290 - Metrics timer example

Github user ivanjunckes commented on a diff in the pull request: https://github.com/apache/tomee/pull/218#discussion_r236338450 --- Diff: examples/mp-metrics-timed/src/test/java/WeatherServiceTest.java --- @@ -0,0 +1,151 @@ +/** + * Licensed to the Apache Software

[GitHub] tomee pull request #218: TOMEE-2290 - Metrics timer example

Github user ivanjunckes commented on a diff in the pull request: https://github.com/apache/tomee/pull/218#discussion_r236337920 --- Diff: examples/mp-metrics-timed/src/test/java/WeatherServiceTest.java --- @@ -0,0 +1,151 @@ +/** + * Licensed to the Apache Software

[GitHub] tomee pull request #218: TOMEE-2290 - Metrics timer example

Github user ivanjunckes commented on a diff in the pull request: https://github.com/apache/tomee/pull/218#discussion_r236337860 --- Diff: examples/mp-metrics-timed/src/test/java/WeatherServiceTest.java --- @@ -0,0 +1,151 @@ +/** + * Licensed to the Apache Software

Re: Please review PR #201

@Bruno: note that this is not what we are doing, I'm just mentionning that TomEE does not need that and that there is no need to put any pressure either on TomEE or Geronimo in such situation since everything is good on both side in current state. Romain Manni-Bucau @rmannibucau

Re: Please review PR #201

It's just that I would expect to release 1.0.1 for a mater of principle. I think we shouldn't throw away an already approved valid contribution. Bruno Baptista https://twitter.com/brunobat_ On 26/11/18 13:53, Romain Manni-Bucau wrote: Le lun. 26 nov. 2018 à 14:48, Bruno Baptista a écrit :

[GitHub] tomee pull request #218: TOMEE-2290 - Metrics timer example

Github user rmannibucau commented on a diff in the pull request: https://github.com/apache/tomee/pull/218#discussion_r236314041 --- Diff: examples/mp-metrics-timed/src/test/java/WeatherServiceTest.java --- @@ -0,0 +1,151 @@ +/** + * Licensed to the Apache Software

[GitHub] tomee pull request #218: TOMEE-2290 - Metrics timer example

Github user ivanjunckes commented on a diff in the pull request: https://github.com/apache/tomee/pull/218#discussion_r236312514 --- Diff: examples/mp-metrics-timed/src/test/java/WeatherServiceTest.java --- @@ -0,0 +1,151 @@ +/** + * Licensed to the Apache Software

[GitHub] tomee pull request #208: Fixed a couple CDI Examples

Github user asfgit closed the pull request at: https://github.com/apache/tomee/pull/208 ---

[GitHub] tomee pull request #219: Avoid String in a loop

Github user asfgit closed the pull request at: https://github.com/apache/tomee/pull/219 ---

Re: Avoid String in a loop

I was surprised the figures were as different as they are. I appreciate Romain's feedback - I suspect we won't see dramatic performance increases, but it certainly doesn't do us any harm, so I'll merge this in. Thanks for the patch! Jon On Mon, Nov 26, 2018 at 2:40 PM Romain Manni-Bucau wrote:

[GitHub] tomee pull request #220: [WIP] TOMEE-2292 - Config Microprofile Example

GitHub user danielsoro opened a pull request: https://github.com/apache/tomee/pull/220 [WIP] TOMEE-2292 - Config Microprofile Example You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsoro/tomee mp-config-sample

Re: Avoid String in a loop

+0 (this is only for error cases as far as i saw and a few concatenations so you don't see the diff in practise + the compiler is able to optimize it and even replace string builder when relevant these days) Romain Manni-Bucau @rmannibucau | Blog

[GitHub] tomee pull request #219: Avoid String in a loop

Github user danielsoro commented on a diff in the pull request: https://github.com/apache/tomee/pull/219#discussion_r236279011 --- Diff: container/openejb-core/src/main/java/org/apache/openejb/config/AnnotationDeployer.java --- @@ -2939,12 +2939,14 @@ public EjbModule

[GitHub] tomee issue #208: Fixed a couple CDI Examples

Github user monsonhaefel commented on the issue: https://github.com/apache/tomee/pull/208 More changes to example README.mds ---

Re: Avoid String in a loop

Wowww! Nice catch Otávio! That is really a good improvement! Em seg, 26 de nov de 2018 às 10:47, Otávio Gonçalves de Santana < osant...@tomitribe.com> escreveu: > The reason to prefer StringBuilder is that both + and concat create a new > object every time you call them (provided the right-hand

Re: Please review PR #201

Le lun. 26 nov. 2018 à 14:48, Bruno Baptista a écrit : > Hi Romain, > > We are holding other work with this discussion. > > Can we agree that this is good enough for a 1st version and move on with > a follow up PR?... It's not going to be worse than starting SE tasks > inside the container, like

Re: How Can I Help?

Hi Ivan: OK, great, thanks! Mike. On Mon, Nov 26, 2018 at 6:31 AM Ivan Junckes Filho wrote: > Hello Michael, > > I suggest that you always ask questions to the list and not to me > privately. I may be busy like I was this weekend, and barely had time to > open my computer. A lot of people on

Re: Metrics Gauge Example and Bug

Sure, Will have a look after lunch. Cheers. Bruno Baptista https://twitter.com/brunobat_ On 26/11/18 13:29, Ivan Junckes Filho wrote: Bruno, can you review again please? On Mon, Nov 26, 2018 at 10:46 AM Ivan Junckes Filho wrote: Awesome, thanks Bruno On Mon, Nov 26, 2018 at 10:23 AM

Re: Please review PR #201

Hi Romain, We are holding other work with this discussion. Can we agree that this is good enough for a 1st version and move on with a follow up PR?... It's not going to be worse than starting SE tasks inside the container, like we have now. Also, releasing Safegard 1.0.1 would be nice.

Avoid String in a loop

The reason to prefer StringBuilder is that both + and concat create a new object every time you call them (provided the right-hand side argument is not empty). This can quickly add up to a lot of objects, almost all of which are completely unnecessary. public class Main{ public static void

[GitHub] tomee pull request #219: Avoid String in a loop

GitHub user otaviojava opened a pull request: https://github.com/apache/tomee/pull/219 Avoid String in a loop The reason to prefer StringBuilder is that both + and concat create a new object every time you call them (provided the right-hand side argument is not empty). This can

[GitHub] tomee pull request #218: TOMEE-2290 - Metrics timer example

Github user rmannibucau commented on a diff in the pull request: https://github.com/apache/tomee/pull/218#discussion_r236249672 --- Diff: examples/mp-metrics-timed/src/test/java/WeatherServiceTest.java --- @@ -0,0 +1,151 @@ +/** + * Licensed to the Apache Software

[GitHub] tomee pull request #218: TOMEE-2290 - Metrics timer example

Github user rmannibucau commented on a diff in the pull request: https://github.com/apache/tomee/pull/218#discussion_r236248226 --- Diff: examples/mp-metrics-timed/src/test/java/WeatherServiceTest.java --- @@ -0,0 +1,151 @@ +/** + * Licensed to the Apache Software

[GitHub] tomee pull request #218: TOMEE-2290 - Metrics timer example

Github user rmannibucau commented on a diff in the pull request: https://github.com/apache/tomee/pull/218#discussion_r236248396 --- Diff: examples/mp-metrics-timed/src/test/java/WeatherServiceTest.java --- @@ -0,0 +1,151 @@ +/** + * Licensed to the Apache Software

[GitHub] tomee pull request #218: TOMEE-2290 - Metrics timer example

Github user rmannibucau commented on a diff in the pull request: https://github.com/apache/tomee/pull/218#discussion_r236248868 --- Diff: examples/mp-metrics-timed/src/test/java/WeatherServiceTest.java --- @@ -0,0 +1,151 @@ +/** + * Licensed to the Apache Software

Re: Metrics Gauge Example and Bug

Bruno, can you review again please? On Mon, Nov 26, 2018 at 10:46 AM Ivan Junckes Filho wrote: > Awesome, thanks Bruno > > On Mon, Nov 26, 2018 at 10:23 AM Bruno Baptista > wrote: > >> Hi Ivan, >> >> I've requested some changes. >> >> Cheers >> >> Bruno Baptista >>

Re: Metrics Gauge Example and Bug

Awesome, thanks Bruno On Mon, Nov 26, 2018 at 10:23 AM Bruno Baptista wrote: > Hi Ivan, > > I've requested some changes. > > Cheers > > Bruno Baptista > https://twitter.com/brunobat_ > > > On 26/11/18 11:29, Bruno Baptista wrote: > > Hi, > > > > I can review it. > > > > Bruno Baptista > >

Re: Metrics Gauge Example and Bug

Hi Ivan, I've requested some changes. Cheers Bruno Baptista https://twitter.com/brunobat_ On 26/11/18 11:29, Bruno Baptista wrote: Hi, I can review it. Bruno Baptista https://twitter.com/brunobat_ On 23/11/18 18:27, Ivan Junckes Filho wrote: Hey guys can anyone review and merge this?

Re: Building TomEE, openejb-core, crashed test: org.apache.openejb.assembler.DeployerEjbTest

Hi All, I've also experienced this error a few times. Never tried to change the surefire version, though. Bruno Baptista https://twitter.com/brunobat_ On 26/11/18 07:25, Ferdi wrote: Hi, I've got the latest master from github and was trying to run `mvn clean install`, but I've got this

[GitHub] tomee pull request #218: TOMEE-2290 - Metrics timer example

Github user brunobat commented on a diff in the pull request: https://github.com/apache/tomee/pull/218#discussion_r236229984 --- Diff: pom.xml --- @@ -208,7 +208,7 @@ 1.0 1.0.0 1.1 - 1.0.0 + 1.0.1-SNAPSHOT --- End diff -- Hi

Re: Building TomEE, openejb-core, crashed test: org.apache.openejb.assembler.DeployerEjbTest

Going to fire this off on a Linux and a Windows machine here to see a) if I see the same thing, and b) see if I can give some pointers. I don't have ideas right off the top of my head at the moment. Romain's suggestion is definitely worth a try. For reference, we have a CI build here:

Re: Feedback as newbie

Thanks for the feedback! The most correct out of the pages listed is this one: http://tomee.apache.org/community/sources.html. These pages are out of date: http://tomee.apache.org/dev/source-code.html, and http://tomee.apache.org/dev/git.html. I can't recall if we tried using the "develop" branch

Re: How Can I Help?

Hello Michael, I suggest that you always ask questions to the list and not to me privately. I may be busy like I was this weekend, and barely had time to open my computer. A lot of people on the list are willing to help you with these questions :) You can do a master update periodically if you

Re: Metrics Gauge Example and Bug

Hi, I can review it. Bruno Baptista https://twitter.com/brunobat_ On 23/11/18 18:27, Ivan Junckes Filho wrote: Hey guys can anyone review and merge this? https://github.com/apache/tomee/pull/218 On Fri, Nov 23, 2018 at 2:22 PM Roberto Cortez wrote: And it did cover. The test was

Merging Old and New Websites

Hi All, Our current status with regards to the TomEE website is we have one foot in each world, old and new. The high-level history is more or less this: - 2006-2012 we used Confluence as the "source" and rendered that to html via a plugin maintained by one brave ASF individual, Pier Paolo