Right, thanks Jon :)
On Wed, Nov 28, 2018 at 8:58 PM Jonathan Gallimore <
jonathan.gallim...@gmail.com> wrote:
> Maybe the fix is in this PR: https://github.com/apache/tomee/pull/221, and
> I need to read all my email first? ;)
>
> On Wed, Nov 28, 2018 at 10:56 PM Jonathan Gallimore <
>
Github user asfgit closed the pull request at:
https://github.com/apache/tomee/pull/221
---
Maybe the fix is in this PR: https://github.com/apache/tomee/pull/221, and
I need to read all my email first? ;)
On Wed, Nov 28, 2018 at 10:56 PM Jonathan Gallimore <
jonathan.gallim...@gmail.com> wrote:
> Merged.
>
> I'll run a build locally. On a slightly different topic, I get a test
>
Merged.
I'll run a build locally. On a slightly different topic, I get a test
failure in mp-metrics-counted - could someone take a look? Here's the error
- it looks like a map ordering, so maybe we need to compare the individual
JSON elements here:
Github user asfgit closed the pull request at:
https://github.com/apache/tomee/pull/218
---
+1 on:
"Something like:
TOME-1234 - Commit foo
TOME-1234 - Commit bla
TOME-1234 - Commit xpto
TOME-1234 - Commit aloha"
Bruno Baptista
https://twitter.com/brunobat_
On 28/11/18 18:54, Daniel Cunha wrote:
Hi Cesar,
that's exactly what I like, we can push 1 commit per ticket.
I like to use
Hi,
While working on an issue with MP rest client on current TomEE master, I
invested a couple of hours understanding how the relationship between
MicroProfile boom, rest-client jar and cxf versions worked all together.
>From Tomee pom file [1] I was able to quickly identify how current master
Hey guys, any commiter could help merging this?
It is already appoved.
On Tue, Nov 27, 2018 at 2:07 PM Ivan Junckes Filho
wrote:
> Hey guys, this PR has the goal to provide a @Timed example using
> Microprofile Metrics in TomEE8, could you please review and merge?
>
>
Any feedback on this?
On Tue, Nov 27, 2018 at 4:14 PM Ivan Junckes Filho
wrote:
> Hey guys I did some improvements on this example:
>
>- Fixing payload in test after the fix of a jsonb regression
>- Replace Webclient with WebTarget
>- Fix to use top level properties with versions
>
Hi,
Today I confirmed with Any McCrigth, from CXF project, that this is a bug
in cxf 3.2.7.
I opened https://issues.apache.org/jira/browse/CXF-7912 and he will work on
the fix that I already tested locally building cxf 3.2.8 snapshot.
I updated my PR [1] with the TomEE jira [2] reference in the
Hi Cesar,
that's exactly what I like, we can push 1 commit per ticket.
I like to use this way when PullRequest is not our normal way to work, just
because to track it later to revert (for some reason) will be better than a
revert lot of commits. :)
It is really hard to track when you have a lot
FYI: I'm working on it: https://issues.apache.org/jira/browse/TOMEE-2292
Just need update the README. The PR for it is:
https://github.com/apache/tomee/pull/220
Em qua, 28 de nov de 2018 às 14:13, Weverthon Medeiros
escreveu:
> Hey all,
>
> on https://issues.apache.org/jira/browse/TOMEE-2296,
>
> I'd be against squashing commits, as it hides who the real author is. If
> you work hard on something, and I merge it in, squashing your commits in
> the process, it looks like I authored it and not you. When commits are not
> squashed, you can see you authored it, and I reviewed and merged.
Hey all,
on https://issues.apache.org/jira/browse/TOMEE-2296, if anyone has not
picked it up yet, maybe I could try to start with that?
Thanks,
Weverthon Medeiros
http://linkedin.com/in/weverthon
On Wed, 28 Nov 2018 at 15:48, Ivan Junckes Filho
wrote:
> Cool Bruno, if this is assigned to you
Hey Cesar
Some specific feedback inline. The short version is the project is
technically CTR (commit then review). As a group, we've enjoyed using PRs
for discussion, but we have discussed moving to RTC (review then commit) a
couple of times, and voted against it each time. Currently the ASF Git
Cool Bruno, if this is assigned to you or somebody else, please add a
comment to the ticket.
On Wed, Nov 28, 2018 at 1:22 PM Bruno Baptista wrote:
> Hi
>
> I've added a new example for the Fault Tolerance @Timeout here:
>
> https://issues.apache.org/jira/browse/TOMEE-2296
>
> Cheers
>
> Bruno
Hello Michael,
in prometheus, histograms are not represented directly like their class and
the prometheus representation is done through an endpoint and not a body
writer as per microprofile spec - can likely be enhanced but it is not
needed today since you rarely want a single metrics in the
Hi Michael, could you please push it to a remote branch so I can take a
look?
On Wed, Nov 28, 2018 at 1:26 PM Michael Redlich wrote:
> Hello everyone:
>
> I am making progress implementing a Metrics Histogram example. Please see
> the following code:
>
> @Path("/histogram")
> @GET
>
Hello everyone:
I am making progress implementing a Metrics Histogram example. Please see
the following code:
@Path("/histogram")
@GET
@Produces(MediaType.TEXT_PLAIN)
// @Produces(MediaType.APPLICATION_JSON)
public Histogram histogramStatus() {
Metadata metadata = new Metadata("items",
Hi
I've added a new example for the Fault Tolerance @Timeout here:
https://issues.apache.org/jira/browse/TOMEE-2296
Cheers
Bruno Baptista
https://twitter.com/brunobat_
On 22/11/18 12:17, Ivan Junckes Filho wrote:
Hey guys, there is new people that would like to contribute and I would
like
+1 Cesar.
On Wed, Nov 28, 2018 at 1:08 PM César Hernández Mendoza <
cesargu...@gmail.com> wrote:
> Thanks, Jonathan for the reply.
>
>
> > PRs aren't actually required, committers can commit directly and
> > contributors can send in patches on JIRAs.
>
>
> My two cents is that by having the
Thanks, Jonathan for the reply.
> PRs aren't actually required, committers can commit directly and
> contributors can send in patches on JIRAs.
My two cents is that by having the flexibility of doing just a patch and
direct commits, then the PR and JIRA are not enforced and that leads to
Sounds great!
As said in
(http://tomee-openejb.979440.n4.nabble.com/Feedback-as-newbie-td4685477.html)
I would like to share some experiences with my first steps and Jon pointed
to your work on the website. So probably it would be better to wait until
you finished merging.
BTW: Is there a JIRA
Great. Thanks Jon.
Best Regards,
José Henrique Ventura.
Original Message
On Nov 27, 2018, 8:52 PM, Jonathan Gallimore wrote:
> Go for it! I'll add a note to say you're working on it.
>
> Jon
>
> On Tue, Nov 27, 2018 at 8:30 PM Jose Henrique Ventura
> wrote:
>
>> Hi Guys,
>>
Hi
This continues on from the work that Otavio did on this thread: "Creates an
unmarshal that does not filter to JavaEE namespace".
For those of you who aren't aware, TomEE supports CMP entity beans (which
is quite an old way of doing persistence - it dates back to the EJB 2.1 era
- and possibly
25 matches
Mail list logo
