[GitHub] [tomee] rzo1 commented on pull request #891: Tomee 3955

2022-06-26 Thread GitBox
rzo1 commented on PR #891: URL: https://github.com/apache/tomee/pull/891#issuecomment-1166939296 @tichovz The README files are here https://github.com/apache/tomee/tree/master/examples/arquillian-jpa (basically same level as the POM) -- This is an automated message from the Apache Git Se

[GitHub] [tomee] tichovz commented on pull request #891: Tomee 3955

2022-06-26 Thread GitBox
tichovz commented on PR #891: URL: https://github.com/apache/tomee/pull/891#issuecomment-1166640405 Hi! Do I need to update the README? If so, could anyone help me with where that file is and what should I write in it? Thanks: Zoltán On Sun, Jun 26, 2022 at 10:33 P

[GitHub] [tomee] rzo1 commented on a diff in pull request #891: Tomee 3955

2022-06-26 Thread GitBox
rzo1 commented on code in PR #891: URL: https://github.com/apache/tomee/pull/891#discussion_r906867641 ## examples/arquillian-jpa/src/test/resources/arquillian.xml: ## @@ -25,7 +25,7 @@ openejb:Resource/demoDataSource - + Review Comment: You are right. My bad

[GitHub] [tomee] tichovz commented on a diff in pull request #891: Tomee 3955

2022-06-26 Thread GitBox
tichovz commented on code in PR #891: URL: https://github.com/apache/tomee/pull/891#discussion_r906867220 ## examples/arquillian-jpa/src/test/resources/arquillian.xml: ## @@ -25,7 +25,7 @@ openejb:Resource/demoDataSource - + Review Comment: I may see it wrong,

[GitHub] [tomee] tichovz commented on a diff in pull request #891: Tomee 3955

2022-06-26 Thread GitBox
tichovz commented on code in PR #891: URL: https://github.com/apache/tomee/pull/891#discussion_r906866572 ## examples/arquillian-jpa/pom.xml: ## @@ -28,10 +28,22 @@ language governing permissions and limitations under the License. --> maven-compiler-plugin 3.5

[GitHub] [tomee] tichovz commented on a diff in pull request #891: Tomee 3955

2022-06-26 Thread GitBox
tichovz commented on code in PR #891: URL: https://github.com/apache/tomee/pull/891#discussion_r906866533 ## examples/arquillian-jpa/pom.xml: ## @@ -105,6 +106,33 @@ language governing permissions and limitations under the License. --> + + org.j

Release issue with master

2022-06-26 Thread Jean-Louis Monteiro
Does someone has an idea about this Currently blocking 9.0.0-M8 release [INFO] > > [INFO] BUILD FAILURE > [INFO] > > [INFO] Total time: 15.393 s > [INF

[GitHub] [tomee] rzo1 commented on pull request #852: Could org.apache.tomee:tomee-server-version:9.0.0-M8-SNAPSHOT drop off redundant dependencies?

2022-06-26 Thread GitBox
rzo1 commented on PR #852: URL: https://github.com/apache/tomee/pull/852#issuecomment-1166518838 @Celebrate-future Thanks for the PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [tomee] rzo1 merged pull request #852: Could org.apache.tomee:tomee-server-version:9.0.0-M8-SNAPSHOT drop off redundant dependencies?

2022-06-26 Thread GitBox
rzo1 merged PR #852: URL: https://github.com/apache/tomee/pull/852 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For

[GitHub] [tomee] rzo1 commented on a diff in pull request #891: Tomee 3955

2022-06-26 Thread GitBox
rzo1 commented on code in PR #891: URL: https://github.com/apache/tomee/pull/891#discussion_r906807788 ## examples/arquillian-jpa/pom.xml: ## @@ -28,10 +28,22 @@ language governing permissions and limitations under the License. --> maven-compiler-plugin 3.5.1