Re: ActiveMQ connection wrapper

2015-11-20 Thread Jean-Louis Monteiro
The logging about leaked connections is definitely useful for users so they can fix. Le 20 nov. 2015 13:16, "Jonathan Gallimore" a écrit : > +1 > > Jon > > On Fri, Nov 20, 2015 at 12:15 PM, Andy Gumbrecht > > wrote: > > > The wrapper is

Re: ActiveMQ connection wrapper

2015-11-20 Thread Romain Manni-Bucau
Well while it doesnt use any static map ok. We have all the needed code in geronimo to track it properly without eveven being bound to AMQ and modify injector code at all. Easy alternative is doing the wrapping in the resource defition. This sounds even a good transversal feature for debug

Re: ActiveMQ connection wrapper

2015-11-20 Thread Jonathan Gallimore
+1 Jon On Fri, Nov 20, 2015 at 12:15 PM, Andy Gumbrecht wrote: > The wrapper is passing all tests on 1.7.x. I'd therefore like to keep it > as it only hardens TomEE against connection/session misuse and also > provides valuable logging information if issues exist. > >

Re: ActiveMQ connection wrapper

2015-11-20 Thread Andy Gumbrecht
The wrapper is passing all tests on 1.7.x. I'd therefore like to keep it as it only hardens TomEE against connection/session misuse and also provides valuable logging information if issues exist. I'll wait for feedback from everyone before I forward port the wrapper. Andy. -- Andy

Re: ActiveMQ connection wrapper

2015-11-20 Thread Jean-Louis Monteiro
I like the idea to log at the end where the user leaked connections. If that can be done in the RA, it's also fine for me. -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Fri, Nov 20, 2015 at 4:24 PM, Andy wrote: > Not sure what you mean by

Re: ActiveMQ connection wrapper

2015-11-18 Thread agumbrecht
/AndyGeeDe TomEE treibt Tomitribe ! | http://tomee.apache.org -- View this message in context: http://tomee-openejb.979440.n4.nabble.com/ActiveMQ-connection-wrapper-tp4676832p4676834.html Sent from the TomEE Dev mailing list archive at Nabble.com.

ActiveMQ connection wrapper

2015-11-18 Thread Andy Gumbrecht
Looking for suggestions as to where and how it could be best to wrap any connections from AMQ. We need to do this in order to ensure we can kill connections on a server shutdown. Basically anywhere this gets injected there needs to be a wrapper returned in it's place. public interface

Re: ActiveMQ connection wrapper

2015-11-18 Thread Romain Manni-Bucau
rst. > > Andy. > > > > > > - > -- > Andy Gumbrecht > > http://www.tomitribe.com > agumbre...@tomitribe.com > https://twitter.com/AndyGeeDe > > TomEE treibt Tomitribe ! | http://tomee.apache.org > -- > View this message

Re: ActiveMQ connection wrapper

2015-11-18 Thread agumbrecht
-connection-wrapper-tp4676832p4676854.html Sent from the TomEE Dev mailing list archive at Nabble.com.

Re: ActiveMQ connection wrapper

2015-11-18 Thread Romain Manni-Bucau
echt > > http://www.tomitribe.com > agumbre...@tomitribe.com > https://twitter.com/AndyGeeDe > > TomEE treibt Tomitribe ! | http://tomee.apache.org > -- > View this message in context: > http://tomee-openejb.979440.n4.nabble.com/ActiveMQ-connection