I agree with Romain and Bruno on this.
I'm not a fan of squashing even if from time to time I think it's useful
(See Bruno's example).
Jean-Louis
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com
On Mon, Dec 3, 2018 at 6:49 PM César Hernández Mendoza
wrote:
>
Thanks Bruno, I'm starting to follow your approach.
+1
El lun., 3 dic. 2018 a las 5:24, Bruno Baptista ()
escribió:
> Hi folks,
>
> I'm also not a big fan of squashing...
>
> I do however understand the need to easily find commits from a certain
> PR for portability reasons.
>
> There are 2
Hi folks,
I'm also not a big fan of squashing...
I do however understand the need to easily find commits from a certain
PR for portability reasons.
There are 2 mitigating steps that can be done:
1. Always put the jira issue in the beginning of all comments, like:
"TOMEE-1234 - some
Like in many things in life, we all have different opinions, you can find
in this thread "Why we don't have Jira and Github integration?" why I
prefer to have cleaner branches with squashed commits.
One thing is building something, but another task is troubleshooting
something someone else did
Thanks, Guys! I really don't see the point in squashing commits as you
describe it. Seems like it cooks the books on what is actually being done.
Not sure why anyone would care if a PR has multiple commits. In fact, that
would make it far easier to evaluate the PR, I believe. Anyway, I get it
now
Hi Richard,
if you have 3 commit in your PR you create a single one "squashing" them 3
(or you can select just 2 if you want)
Some people are fan of it, some people hate it cause it break the history
and the "thinking" of the devs so you loose precious information (yes i'm
in this last
Means that your local history of commits for a particular banch will be
squashed (compressed) into just one commit:
Check this video for an example: https://youtu.be/viY1BbKZhSI
This allows your PR to be cleaner since it will contain only 1 commit.
El vie., 30 nov. 2018 a las 8:50, Richard
Hi,
What does "Squashing your PR" mean?
Thank you!
Richard
On Thu, Nov 29, 2018 at 5:00 PM exabrial12 wrote:
> Also, if you don't mind Squashing your PR before submitting the request,
> that
> will help port anything to other branches!
>
>
>
> --
> Sent from:
>
Also, if you don't mind Squashing your PR before submitting the request, that
will help port anything to other branches!
--
Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
Lol. Ok, thank you!
On Thu, Nov 29, 2018 at 2:44 PM Jonathan Gallimore <
jonathan.gallim...@gmail.com> wrote:
> > If I create a branch, will that branch have its own unique PRs separate
> from other PRs?
>
> Yep. Create a branch for each PR you want to open. That reminds me, I
> should probably
> If I create a branch, will that branch have its own unique PRs separate
from other PRs?
Yep. Create a branch for each PR you want to open. That reminds me, I
should probably clean up the 138 branches I have in my fork. :-)
Jon
On Thu, Nov 29, 2018 at 7:59 PM Richard Monson-Haefel <
Hi Guys,
The last several commits I had all went under the same PR. I would like to
be able to create new PRs when working on unrelated stuff, but whenever I
try to create a new PR it always gets added to the one I have open. I was
told that I need a new fork to get my PRs separated but when I
12 matches
Mail list logo
