>> regarding
>>> > the
>>> > > > > spec which I've asked on the github thread, can you please
>>> clarify
>>> > > these?
>>> > > > >
>>> > > > > On Wed 2 Jan, 2019, 6:09 PM Ivan Junckes Filho <
>>>
@gmail.com
>> > > > > wrote:
>> > > > >
>> > > > > > Puneeth, I did some comments here
>> > > > > >
>> > https://github.com/apache/tomee/pull/340#pullrequestreview-188661807
>> > > ,
>> > > > > > please take a look.
>> > > > > >
>> > > > > > On Wed, Jan 2, 2019 at 9:51 AM Ivan Junckes Filho <
>> > > > ivanjunc...@gmail.com
>> > > > > >
>> > > > > > wrote:
>> > > > > >
>> > > > > > > Hi Puneeth, I will review it for you.
>> > > > > > >
>> > > > > > > On Wed, Jan 2, 2019 at 8:39 AM Puneeth PS <
>> puneeth...@gmail.com>
>> > > > > wrote:
>> > > > > > >
>> > > > > > >> Hi,
>> > > > > > >>
>> > > > > > >> I have created a PR (
>> https://github.com/apache/tomee/pull/340
>> > )
>> > > > for
>> > > > > > >> TOMEE-2289. Can someone take a look and help me improve it?
>> > > > > > >>
>> > > > > > >
>> > > > > >
>> > > > >
>> > > >
>> > >
>> >
>>
>>
>> --
>> Atentamente:
>> César Hernández Mendoza.
>>
>
t; > ivanjunc...@gmail.com
> > > > > wrote:
> > > > >
> > > > > > Puneeth, I did some comments here
> > > > > >
> > https://github.com/apache/tomee/pull/340#pullrequestreview-188661807
> > > ,
gt; https://github.com/apache/tomee/pull/340#pullrequestreview-188661807
> > ,
> > > > > please take a look.
> > > > >
> > > > > On Wed, Jan 2, 2019 at 9:51 AM Ivan Junckes Filho <
> > > ivanjunc...@gmail.com
> > > > >
> > > > > wrote:
> > > > >
> > > > > > Hi Puneeth, I will review it for you.
> > > > > >
> > > > > > On Wed, Jan 2, 2019 at 8:39 AM Puneeth PS
> > > > wrote:
> > > > > >
> > > > > >> Hi,
> > > > > >>
> > > > > >> I have created a PR ( https://github.com/apache/tomee/pull/340
> )
> > > for
> > > > > >> TOMEE-2289. Can someone take a look and help me improve it?
> > > > > >>
> > > > > >
> > > > >
> > > >
> > >
> >
>
--
Atentamente:
César Hernández Mendoza.
Filho <
> > ivanjunc...@gmail.com
> > > >
> > > > wrote:
> > > >
> > > > > Hi Puneeth, I will review it for you.
> > > > >
> > > > > On Wed, Jan 2, 2019 at 8:39 AM Puneeth PS
> > > wrote:
> > > > >
> > > > >> Hi,
> > > > >>
> > > > >> I have created a PR ( https://github.com/apache/tomee/pull/340 )
> > for
> > > > >> TOMEE-2289. Can someone take a look and help me improve it?
> > > > >>
> > > > >
> > > >
> > >
> >
>
Filho <
> ivanjunc...@gmail.com
> > >
> > > wrote:
> > >
> > > > Hi Puneeth, I will review it for you.
> > > >
> > > > On Wed, Jan 2, 2019 at 8:39 AM Puneeth PS
> > wrote:
> > > >
> > > >> Hi,
> > > >>
> > > >> I have created a PR ( https://github.com/apache/tomee/pull/340 )
> for
> > > >> TOMEE-2289. Can someone take a look and help me improve it?
> > > >>
> > > >
> > >
> >
>
Ivan Junckes Filho >
> > wrote:
> >
> > > Hi Puneeth, I will review it for you.
> > >
> > > On Wed, Jan 2, 2019 at 8:39 AM Puneeth PS
> wrote:
> > >
> > >> Hi,
> > >>
> > >> I have created a PR ( https://github.com/apache/tomee/pull/340 ) for
> > >> TOMEE-2289. Can someone take a look and help me improve it?
> > >>
> > >
> >
>
t;> I have created a PR ( https://github.com/apache/tomee/pull/340 ) for
> >> TOMEE-2289. Can someone take a look and help me improve it?
> >>
> >
>
Github user puneethps commented on the issue:
https://github.com/apache/tomee/pull/340
I noticed one more difference from the spec and the implementation, what I
understood from the spec was that there is supposed to be a components field in
the yaml or the json if there is a schema
Github user puneethps commented on a diff in the pull request:
https://github.com/apache/tomee/pull/340#discussion_r244777643
--- Diff: examples/mp-openapi/README.adoc ---
@@ -0,0 +1,112 @@
+:index-group: MicroProfile
+:jbake-type: page
+:jbake-status: unpublished
+
t;> Hi,
>>
>> I have created a PR ( https://github.com/apache/tomee/pull/340 ) for
>> TOMEE-2289. Can someone take a look and help me improve it?
>>
>
Github user ivanjunckes commented on a diff in the pull request:
https://github.com/apache/tomee/pull/340#discussion_r244724535
--- Diff: examples/mp-openapi/README.adoc ---
@@ -0,0 +1,112 @@
+:index-group: MicroProfile
+:jbake-type: page
+:jbake-status: unpublished
Github user ivanjunckes commented on a diff in the pull request:
https://github.com/apache/tomee/pull/340#discussion_r244725387
--- Diff:
examples/mp-openapi/src/main/java/org/superbiz/openapi/WeatherService.java ---
@@ -0,0 +1,52 @@
+package org.superbiz.openapi;
+
+
Github user ivanjunckes commented on a diff in the pull request:
https://github.com/apache/tomee/pull/340#discussion_r244725773
--- Diff:
examples/mp-openapi/src/main/java/org/superbiz/openapi/WeatherService.java ---
@@ -0,0 +1,52 @@
+package org.superbiz.openapi;
+
+
Github user ivanjunckes commented on a diff in the pull request:
https://github.com/apache/tomee/pull/340#discussion_r244725584
--- Diff:
examples/mp-openapi/src/main/java/org/superbiz/openapi/Weather.java ---
@@ -0,0 +1,25 @@
+package org.superbiz.openapi;
+
+import
Github user ivanjunckes commented on a diff in the pull request:
https://github.com/apache/tomee/pull/340#discussion_r244723832
--- Diff:
examples/mp-openapi/src/main/java/org/superbiz/openapi/WeatherService.java ---
@@ -0,0 +1,52 @@
+package org.superbiz.openapi;
+
+
Github user ivanjunckes commented on a diff in the pull request:
https://github.com/apache/tomee/pull/340#discussion_r244724385
--- Diff: examples/mp-openapi/README.adoc ---
@@ -0,0 +1,112 @@
+:index-group: MicroProfile
+:jbake-type: page
+:jbake-status: unpublished
Hi Puneeth, I will review it for you.
On Wed, Jan 2, 2019 at 8:39 AM Puneeth PS wrote:
> Hi,
>
> I have created a PR ( https://github.com/apache/tomee/pull/340 ) for
> TOMEE-2289. Can someone take a look and help me improve it?
>
Hi,
I have created a PR ( https://github.com/apache/tomee/pull/340 ) for
TOMEE-2289. Can someone take a look and help me improve it?
GitHub user puneethps opened a pull request:
https://github.com/apache/tomee/pull/340
TOMEE-2289 microprofile openAPI example
The JIRA status for TOMEE-2289 hasn't changed for quite sometime so I felt
I could add a new project for this. Can someone please review the PR
20 matches
Mail list logo
