Re: TomEE 7.1 with MP

2018-08-02 Thread David Blevins
> On Jul 26, 2018, at 3:18 AM, Mark Struberg wrote: > > Yes, the following steps are now up to get done: > > 1.) Move the current master to a tomee-7.0.x branch > 2.) Create a new tomee-7.1.x branch, upgrade to Java8 and add MicroProfile > 2.) Move the tomee-8.x branch to master and get stuff ro

Re: TomEE 7.1 with MP

2018-08-02 Thread David Blevins
> On Jul 29, 2018, at 8:14 AM, Gurkan Erdogdu wrote: > > From my perspective, this is not realistic. You are releasing the first > version for JDK 8, MP 1 after getting 8.0 branch to master, and at the > first release you are saying that this is production ready. At least, we > will need to let u

Re: TomEE 7.1 with MP

2018-07-30 Thread Mark Struberg
About production readiness of TomEE8: I guess what Romain meant is that most parts which make up TomEE8 (Johnzon, CXF, Tomcat, OWB, etc) are already used in production since a year. Even at JavaEE8 level. There are only a few parts (BVal2) which only more recently made the jump to EE8. But eve

Re: TomEE 7.1 with MP

2018-07-29 Thread Romain Manni-Bucau
Le dim. 29 juil. 2018 à 17:39, Gurkan Erdogdu a écrit : > > > > If you accept SNAPSHOTs in that statement then it is since months. > > > > For me, this statement is only valid after you release the 8.0.0-SNAPSHOT. > Some couple of user can internally deploy the SNAPSHOT version in your > projects

Re: TomEE 7.1 with MP

2018-07-29 Thread Gurkan Erdogdu
> > If you accept SNAPSHOTs in that statement then it is since months. > For me, this statement is only valid after you release the 8.0.0-SNAPSHOT. Some couple of user can internally deploy the SNAPSHOT version in your projects, but you can not assume that every user was doing this because the 8.0

Re: TomEE 7.1 with MP

2018-07-29 Thread Romain Manni-Bucau
Le dim. 29 juil. 2018 à 17:30, Gurkan Erdogdu a écrit : > At a minimum, if some users (move from 7.0.x to 8.0.x) are successfully > used it in production systems for a period of time, then I can call it > stable release. If you accept SNAPSHOTs in that statement then it is since months. > At

Re: TomEE 7.1 with MP

2018-07-29 Thread Gurkan Erdogdu
At a minimum, if some users (move from 7.0.x to 8.0.x) are successfully used it in production systems for a period of time, then I can call it stable release. At the first release, when you say that it is production ready, it is somebit unrealistic. But, if you still want to release it as 8.0.0, yo

Re: TomEE 7.1 with MP

2018-07-29 Thread Romain Manni-Bucau
This is actually what we did since the beginning of TomEE. Also keep in mind milestone, alpha, beta = don't even look at the release for all users who don't want to check a SNAPSHOT so at the end the gain of doing a milestone is mainly to loose time in a release process and not to get any feedback

Re: TomEE 7.1 with MP

2018-07-29 Thread Gurkan Erdogdu
>From my perspective, this is not realistic. You are releasing the first version for JDK 8, MP 1 after getting 8.0 branch to master, and at the first release you are saying that this is production ready. At least, we will need to let users some time to try it and give feedbakcs. I don't say that M1

Re: TomEE 7.1 with MP

2018-07-29 Thread Romain Manni-Bucau
Being said all the stack is already in prod and the glue code is too (it is in 7.x for most of it and some users even deploy the snapshot in prod) I really think we should go directly to 8.0.0. Since we already decoralated from the spec and certification for the 7.x then we don't need to use the mi

Re: TomEE 7.1 with MP

2018-07-29 Thread Gurkan Erdogdu
If you release as 8.0.0, you means that it is production ready? Is 8.0.0 production ready at the first release? At least, at the first release you can add some indication that it is not production ready or it is the first release etc such as M1, CR1. This is the general consensus on release process

Re: TomEE 7.1 with MP

2018-07-29 Thread Romain Manni-Bucau
+1, even a 8.0.0, no need of milestones Le dim. 29 juil. 2018 14:27, Gurkan Erdogdu a écrit : > Hi team > Sorry about this question (even discussed before lots of time) but what is > the meaning of creating 7.1 branch? Just MP with JDK 8? > If that's the only reason why not publish TomEE 8 with

Re: TomEE 7.1 with MP

2018-07-29 Thread Gurkan Erdogdu
Hi team Sorry about this question (even discussed before lots of time) but what is the meaning of creating 7.1 branch? Just MP with JDK 8? If that's the only reason why not publish TomEE 8 with a milestone like TomEE 8.0_M1 or something similar including MP? Possible to release TomEE 8.0.M1 using G

Re: TomEE 7.1 with MP

2018-07-26 Thread Jean-Louis Monteiro
Everything should be merged and mistake fixed (wrong branch deleted) -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Thu, Jul 26, 2018 at 1:43 PM, Romain Manni-Bucau wrote: > Ok, > then AFAIK it will not be a "work" branch but just an aggregator branch so >

Re: TomEE 7.1 with MP

2018-07-26 Thread Romain Manni-Bucau
Ok, then AFAIK it will not be a "work" branch but just an aggregator branch so I see two good compromises: 1. use tomee 7.0 (we just add a mp module with tomee-maven-plugin Vn-1 to import MP impls and bundle it), no compile issue, tomee 7.0 stays java 7 and MP is aligned on java 8 2. we make 7.1 d

Re: TomEE 7.1 with MP

2018-07-26 Thread Jonathan Gallimore
No. As far as I'm concerned its supported for as long as someone is willing to support it. I'm willing to support it, and I'm willing to support 1.7.x also. Jon On Thu, Jul 26, 2018 at 11:39 AM, Romain Manni-Bucau wrote: > Ok so means we drop tomee 7.0 support with next release? > > > Le jeu. 2

Re: TomEE 7.1 with MP

2018-07-26 Thread Romain Manni-Bucau
Ok so means we drop tomee 7.0 support with next release? Le jeu. 26 juil. 2018 12:20, Jonathan Gallimore < jonathan.gallim...@gmail.com> a écrit : > On Thu, Jul 26, 2018 at 11:18 AM, Mark Struberg > > wrote: > > > Yes, the following steps are now up to get done: > > > > 1.) Move the current mas

Re: TomEE 7.1 with MP

2018-07-26 Thread Jonathan Gallimore
On Thu, Jul 26, 2018 at 11:18 AM, Mark Struberg wrote: > Yes, the following steps are now up to get done: > > 1.) Move the current master to a tomee-7.0.x branch > Done > 2.) Create a new tomee-7.1.x branch, upgrade to Java8 and add MicroProfile > JL doing > 2.) Move the tomee-8.x branch to

Re: TomEE 7.1 with MP

2018-07-26 Thread Mark Struberg
Yes, the following steps are now up to get done: 1.) Move the current master to a tomee-7.0.x branch 2.) Create a new tomee-7.1.x branch, upgrade to Java8 and add MicroProfile 2.) Move the tomee-8.x branch to master and get stuff rolling here as well. So I propose to upgrade our target to EE8 now

Re: TomEE 7.1 with MP

2018-07-26 Thread Jean-Louis Monteiro
I think the 7.1.x was a proposal to have a stable TomEE with microprofile until we are ready to release something based on TomEE 8 -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Thu, Jul 26, 2018 at 12:07 PM, Romain Manni-Bucau wrote: > Hmm, did we get any

Re: TomEE 7.1 with MP

2018-07-26 Thread Romain Manni-Bucau
Hmm, did we get anything new compared to the thread "TomEE 7.1.x with Microprofile" to justify a 7.1 compared to directly jump to 8.0? Does it mean 7.0 is no more supported if we stick to only supportting 2 main branches? Romain Manni-Bucau @rmannibucau | Blog

Re: TomEE 7.1 with MP

2018-07-26 Thread Jean-Louis Monteiro
Hey Roberto, Thanks for the PR. I have reviewed it and it looks good. So I'll proceed and merge. I'll see if I can throw a vote out for the 7.1.x +1 to switch master to 8.x as discussed. For TomEE 8.x we can try adding all the other microprofile implementations available at apache. Jean-Louis

Re: TomEE 7.1 with MP

2018-07-26 Thread Jonathan Gallimore
On Thu, Jul 26, 2018 at 5:57 AM, Romain Manni-Bucau wrote: > Hi guys > > Didnt we plan to switch master to tomee 8 after the 7.0.5? We did agree that, and I'm happy to do that provided we can keep a branch for 7.0.x to maintain it. Unless anyone throws an objection on that in the next couple of

Re: TomEE 7.1 with MP

2018-07-25 Thread Gurkan Erdogdu
> > Because the Geronimo MP is not fully implements the MP specification > Sorry I mean Geronimo MP *fully implements* the MP specification On Thu, Jul 26, 2018 at 9:13 AM, Gurkan Erdogdu wrote: > Hi Romain > Great news! > I don't see any benefits to replicate the same efforts in two different

Re: TomEE 7.1 with MP

2018-07-25 Thread Gurkan Erdogdu
Hi Romain Great news! I don't see any benefits to replicate the same efforts in two different locations. Because the Geronimo MP is not fully implements the MP specification and attracted more contributors, we should help them instead of implementing the same stuff in here. (I know that there are t

Re: TomEE 7.1 with MP

2018-07-25 Thread Romain Manni-Bucau
Hi guys Didnt we plan to switch master to tomee 8 after the 7.0.5? Also not sure we want the 7.1 (we didnt finish the discussion IIRC). As a side note: geronimo is MP complete (yes I didnt resist to the joke) so maybe time to just import it all? Romain Le jeu. 26 juil. 2018 01:26, Jonathan Gal

Re: TomEE 7.1 with MP

2018-07-25 Thread Jonathan Gallimore
Awesome, thanks Roberto! On Wed, Jul 25, 2018 at 7:16 PM, Roberto Cortez wrote: > Hi everyone, > I've picked up some of the work started by JL on the tomee-7.1.x branch to > have a release with some MP support. > I've updated the branch with the latest 7.0.5 code, plus, fixed some > issues with

TomEE 7.1 with MP

2018-07-25 Thread Roberto Cortez
Hi everyone, I've picked up some of the work started by JL on the tomee-7.1.x branch to have a release with some MP support. I've updated the branch with the latest 7.0.5 code, plus, fixed some issues with the MP Configuration and MP JWT integration. I've opened the following PR:https://github.co