Re: mp-custom-healthcheck example review

2019-07-02 Thread Cesar Hernandez
Hi Jose, The example is great! It was my mistake to not fully navigate the sourcecode to understand that the endpoint as part of the application and not the one from the internet. By looking at the example, I think instead of modifying the existing one, more examples can be created for interesting

Re: mp-custom-healthcheck example review

2019-06-30 Thread Jose Henrique Ventura
Hi guys, Is all good with that example? and yes, I used the openweathermap url just to give an idea of how it can be used. I can help to improved the example if needed. =) Best Regards, José Henrique Ventura. Sent with ProtonMail Secure Email. ‐‐‐ Original Message ‐‐‐ On Friday, Jun

Re: mp-custom-healthcheck example review

2019-06-28 Thread David Salter
Lol. Sounds like someone has already done what we’re talking about :) David. On Fri, 28 Jun 2019 at 18:53, Cesar Hernandez wrote: > Disregard my previous email, looking more closely to the code it seems the > example include a mock version of the real endpoint > > https://github.com/apache/tome

Re: mp-custom-healthcheck example review

2019-06-28 Thread David Salter
Hi Cesar, That sounds a sensible approach to me. It would make the test more predictable and less likely to fail due to external situations. I think writing an included “simple” weather service that just returns 200 or 40x would improve the sample. Thanks David. On Fri, 28 Jun 2019 at 18:47, C

Re: mp-custom-healthcheck example review

2019-06-28 Thread Cesar Hernandez
Disregard my previous email, looking more closely to the code it seems the example include a mock version of the real endpoint https://github.com/apache/tomee/blob/master/examples/mp-custom-healthcheck/src/main/java/org/superbiz/WeatherServiceHealthCheck.java#L39 El vie., 28 jun. 2019 a las 11:47,

mp-custom-healthcheck example review

2019-06-28 Thread Cesar Hernandez
Hi list, Currently, we have a nice example for mp-custom-healthcheck but digging into the tests, it seems the tests depends on an online service from http://api.openweathermap.org/data/2.5/ https://github.com/apache/tomee/blob/master/examples/mp-custom-healthcheck/src/test/java/org/superbiz/test/W