On Mon, Jul 2, 2018 at 8:53 PM, Mark Struberg
wrote:
> Sure, give it a shot!
>
> > If memory serves me correctly, we have released the examples as an
> artifact
>
> Would not be a good idea. They contain some binaries which are not meant
> for distribution (licenses).
> They are also way too big
Sure, give it a shot!
> If memory serves me correctly, we have released the examples as an artifact
Would not be a good idea. They contain some binaries which are not meant for
distribution (licenses).
They are also way too big to deploy them all.
Bundling them in a source zip is fine though.
If memory serves me correctly, we have released the examples as an artifact
in the past, albeit as one large zip with the code in, as opposed to
individual artifacts. After some playing around, I _think_ I have something
where a release:prepare/perform should work. Any objections to me taking a
sho
yes, the local build on my 2600X takes 42 minutes including all the Bean
Validation and CDI TCKs.
But the full EE6 TCK is run on literally 100s of spot instances (donated by
Tomitribe afaik).
The full TCK is only available under NDA so only a handful people have access
to it otoh :(
This is wh
No, full Web Profile Java EE TCK
On Thu, Jun 21, 2018 at 9:24 AM, Romain Manni-Bucau
wrote:
> Hmm, bval and cdi tck right? This is almost nothing of ee tck coverage
> sadly.
>
> Le jeu. 21 juin 2018 08:22, Gurkan Erdogdu a écrit :
>
> > Aha 3 h is ok, assumed 13 h :) Actually I was running the
Hmm, bval and cdi tck right? This is almost nothing of ee tck coverage
sadly.
Le jeu. 21 juin 2018 08:22, Gurkan Erdogdu a écrit :
> Aha 3 h is ok, assumed 13 h :) Actually I was running the TCK in my laptop
> less than 3h
>
> On Thu, Jun 21, 2018 at 9:20 AM, Romain Manni-Bucau >
> wrote:
>
> >
Aha 3 h is ok, assumed 13 h :) Actually I was running the TCK in my laptop
less than 3h
On Thu, Jun 21, 2018 at 9:20 AM, Romain Manni-Bucau
wrote:
> Last time i checked it was 3h of tck - assuming you have the setup - and 3h
> of tomee build (all-adapters profile to ensure we cover all tomee fla
Last time i checked it was 3h of tck - assuming you have the setup - and 3h
of tomee build (all-adapters profile to ensure we cover all tomee flavors
and not only one as in the default build).
However 3h of tck is due to a highly parallel execution (kudo David) and
will not be that few without the
Romain, do you mean that each release running with TCK takes 13h?
On Wed, Jun 20, 2018 at 9:33 AM, Romain Manni-Bucau
wrote:
> Le mer. 20 juin 2018 à 07:59, Mark Struberg a
> écrit :
>
> > A build should work out of the box and not require 2 weeks of first
> fixing
> > sporadically broken unit
++1
I am a big supporter of easy build of the full system with couple of
commands.
What can we do to ease the build?
On Wed, Jun 20, 2018 at 8:59 AM, Mark Struberg
wrote:
> A build should work out of the box and not require 2 weeks of first fixing
> sporadically broken unit tests.
>
> And a rele
Le mer. 20 juin 2018 à 07:59, Mark Struberg a
écrit :
> A build should work out of the box and not require 2 weeks of first fixing
> sporadically broken unit tests.
>
A long time ago we agree the CI was the platform of truth. Indeed the fixes
are welcomed but we cant run the 13h of build locally
A build should work out of the box and not require 2 weeks of first fixing
sporadically broken unit tests.
And a release usually should be
$> mvn release:prepare
$> mvn release:perform
that's it.
Everything else is not really user friendly and will make it harder for any new
committer to get
Dropping the example will require to move their tests in the main chain
since they are part of our coverage.
Also note you probably dont want to use release plugin cause running the
test (with -Pall-adapters if you respect the plugin philosophy) is quite
long (should be ~3h x2). Just tag and deplo
Sure, I'll take a look tomorrow morning.
On Tue, 19 Jun 2018, 21:57 Mark Struberg, wrote:
> it's license is ALv2, so not a biggie.
> Do you put it onto your list, Jon?
> txs and LieGrue,strub
>
> On Tuesday, 19 June 2018, 22:11:23 CEST, Jonathan Gallimore <
> jonathan.gallim...@gmail.com> w
I'm giving up for today. The samples not being in the parent chain somehow is
completely weird.This did never get released with mvn release:prepare +
perform, right?
I suggest to remove all the examples and place them in a dedicated GIT
repo.They also seem to randomly pull in dependencies from
it's license is ALv2, so not a biggie.
Do you put it onto your list, Jon?
txs and LieGrue,strub
On Tuesday, 19 June 2018, 22:11:23 CEST, Jonathan Gallimore
wrote:
Definitely a left over, they should be self contained.
Jon
On Tue, 19 Jun 2018, 21:04 Mark Struberg, wrote:
> while f
Definitely a left over, they should be self contained.
Jon
On Tue, 19 Jun 2018, 21:04 Mark Struberg, wrote:
> while fixing the versions of almost all our examples I found the
> following parent pom
>
> org.tomitribe
> oss-parent
> 2
>
>
>
> do we really want this?I thought our examples
while fixing the versions of almost all our examples I found the following
parent pom
org.tomitribe
oss-parent
2
do we really want this?I thought our examples should be self-contained, isn't?
Guess that's just an oversight and a leftover from a code donation?
txs and LieGrue,strub
And blowing up badly :(
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-release-plugin:2.5.3:prepare (default-cli) on
project tomee-project: The version could not be updated: ${tomee.version} ->
[Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
Rolling a 7.0.5 release now.
Doing this on my linux box, so I hope I didn't forget to setup anything.
LieGrue,strub
20 matches
Mail list logo
