that file is created during creation of the tarball. It only exists
because the build number is calculated from the git history, so can't be
calculated from the tarball
Certainly wouldn't hurt to have that noted as a file weasel should ignore..
On Fri, Feb 21, 2020 at 3:19 PM Chris Lemmons
ut we shouldn't forget the java code when we're talking about
> > > linting. I've used pmd on java in the distant past, to reasonable
> > > effect, but I don't have a super-strong opinion on the matter.
> > >
> > > On Tue, Oct 1, 2019 at 3:1
It really should only be an addition to
`infrastructure/docker/build/docker-compose.yml` as `pkg` just passes its
arguments to `docker-compose`.
-dan
On Tue, Oct 1, 2019 at 10:33 AM Gray, Jonathan
wrote:
> How do you think the linter process would integrate with our existing
> ./pkg wrapper if
Having used golangci-lint a bit, I can tell you that it's configurable to
disable individual checkers via a config file and is quite fast. I'm of
the opinion that having the redundancy might be an issue if it were
inefficient, but it's not and these linters are likely to evolve over a
short time
Yes -- BSD-3 is a category A license:
https://apache.org/legal/resolved.html#category-a
On Mon, Sep 23, 2019 at 10:11 AM ocket wrote:
> For rewriting the /user/reset_password endpoint (PR #3932) I was importing
> the github.com/google/uuid library for generating UUIDs used as temporary
> l
ithub.com/golang/go/wiki/Modules#how-do-i-use-vendoring-with-modules-is-vendoring-going-away
>
> On Thu, Jul 11, 2019 at 2:37 PM Dan Kirkwood wrote:
> >
> > I'd hope that the go build tools would treat the vendor directories as
> they
> > do today -- one of the places
t; out pretty soon, and I don't really know how long it will take. I
> > think it's important that we do it for the sake of having good Go
> > dependency management, but I don't think it's very urgent.
> >
> > - Rawlin
> >
> > On Wed, Jul 10, 2019 a
+1
On Wed, Jul 10, 2019 at 10:26 AM Fieck, Brennan
wrote:
> +1 sounds fantastic to me
>
> From: Rawlin Peters
> Sent: Tuesday, July 9, 2019 1:55 PM
> To: dev@trafficcontrol.apache.org
> Subject: [EXTERNAL] Go dependency management
>
> Hey all,
>
> Now th
Rawlin, we decided to stop using `rat` for license checking in favor of
`weasel`. I disabled the `rat` build jobs, and `weasel` automatically
runs along with the standard build..
The .rat-excludes file needs to be removed completely (I'll file an issue
for that)... At the top level, run `./p
The Traffic Control PMC has invited Jonathan Gray as a committer, and I'm
pleased to say he has accepted!
Jonathan has contributed to a number of discussions on the dev mailing list
and recently introduced 2 major Pull Requests with experimental features to
help drive our automation efforts. He
ED c/o Alter Domus (UK) Limited -OBO at Cisco)
> wrote:
> >
> > Im good to disable RAT
> >
> > > On May 8, 2019, at 11:57 AM, Dan Kirkwood wrote:
> > >
> > > we currently have rat and weasel both scanning for
> inappropriate/incomplete
>
we currently have rat and weasel both scanning for inappropriate/incomplete
license info. weasel has been catching issues pretty well, and both require
some intervention to skip files without an Apache header (vendored files,
mostly), so requires changes in 2 places.
`weasel` runs as part of the s
Hi all.. I've just submitted a PR as a draft -
https://github.com/apache/trafficcontrol/pull/3552 that adds a new field to
a deliveryservice. `consistentHashQueryParams` lists the query parameter
keys that may be used on a deliveryservice to be included in addition to
the url path when the cons
I also like this solution much better than any previously proposed. As for
the extra DB hit, if the client is using the latest minor version, there
would be no extra hit, right? More encouragement for clients to get
up-to-date...
-dan
On Wed, Apr 24, 2019 at 10:53 AM Robert Butts wrote:
>
The Project Management Committee (PMC) for Apache Traffic Control has
invited Shihta Kuan to become a committer and we are pleased to announce
that he has accepted!
Shihta has learned a great deal in a short amount of time and has
contributed multiple PRs to the `cdn-in-a-box` as he's been learnin
+1 on Rawlin's proposal on maintaining major API versions only to help us
get to the point where we have a clean API. We've already spent way too
much time with backward compatibility when we have far too much tech debt
to get through.
-dan
On Wed, Mar 13, 2019 at 10:29 AM Dave Neuman wrote:
Derek beat me to it :-)
On Thu, Mar 14, 2019 at 12:24 PM Holligan, Christine <
christine_holli...@comcast.com> wrote:
> Thanks, Dan!
>
>
> On 3/14/19, 12:15 PM, "Dan Kirkwood" wrote:
>
> Thanks, Dave.. I will take care of this for trafficcontrol.
&
Thanks, Dave.. I will take care of this for trafficcontrol.
-Dan
On Thu, Mar 14, 2019 at 12:01 PM Dave Fisher wrote:
> Hi -
>
> You still have releases in the Incubator’s area of SVN -
> https://dist.apache.org/repos/dist/release/incubator/ <
> https://dist.apache.org/repos/dist/release/incu
+1
I verified:
- RELEASE-6.0.x-RC6 tag present and signed
- all packages build with `./pkg -v` from source tarball
- sha512 matches
- gpg signature verified
- all rpms built above install on CentOS 7.4
- traffic_ops `postinstall -defaults=to.cfg` produces a good template
- (after edits to to.cfg)
+1
Verified the following:
- sha checksum correct
- gpg signature correct
- RELEASE-3.0.0-RC4 tag signed correctly
- BUILD_NUMBER file indicates the correct commit count and hash
- all components build with `./pkg -v`
- saw same problem with `weasel`, but it's pointing out files in `.m2` dir
(from
no objection here...
On Thu, Jan 24, 2019 at 2:35 PM Robert Butts wrote:
> Does anyone object to making the cdn-in-a-box test compose files (e.g.
>
> https://github.com/apache/trafficcontrol/blob/master/infrastructure/cdn-in-a-box/docker-compose.traffic-ops-test.yml
> )
> output JUnit format?
>
Some "copyright comcast" headers snuck in at some point:
```
$ grep -ri comcast * | grep -i copyright
traffic_ops/testing/api/test/http.go: Copyright 2015 Comcast Cable
Communications Management, LLC
traffic_ops/testing/api/v13/fixtures.go: Copyright 2015 Comcast Cable
Communications Management
Hi Brennan.. does that get updated if changed in the TC repo?
-dan
On Tue, Dec 11, 2018 at 10:26 AM Fieck, Brennan
wrote:
> Just a heads up, the current version (from master) of the Python Traffic
> Control client is now available on `pip` as 'Apache-TrafficControl' - PyPi
> page here:
>
> ht
Hi, all.. I think weasel is mature enough that it covers our license
usage well enough. RAT is run as a separate job from the rpm builds and
runs on the source tarball; weasel runs during the build process on the
source cloned from github:they have pretty much the same function, but
use
eliminate an unnecessary dependency? +1 (+1000 if I could...) .
If it's kept around only for testing purposes, the tester should deal
with that separately: perhaps a documentation update is warranted in that
case.
-dan
On Thu, Nov 15, 2018 at 10:40 AM Rivas, Jesse
wrote:
> Hi Traffic Cont
> > > UK BIDCO LIMITED c/o Alter Domus (UK) Limited -OBO at Cisco)
> > > wrote:
> > > >
> > > > I’m only slightly familiar with all the different options for db/
> > > admin.pl.
> > > >
> > > > I’m a big fan of Python, but rel
I've always advocated keeping the main package lean from the start.
+1 on making this change.
-dan
On Wed, Nov 14, 2018 at 10:06 AM Robert Butts wrote:
> Well, when I originally wrote `traffic_ops_golang`, I just put everything
> in the `main` package, with the assumption that we'd move compon
t; I’m a big fan of Python, but reluctant to introduce another language
> into TC without a strong reason.
> >
> > Once the reverse_schema option is removed, what would be the main
> purposes of the script?
> >
> > Looks like this is something that could be easily
+1 on rewriting admin.pl -- Python seems a reasonable choice, esp since we
seem to be gaining a lot of Python expertise recently.
-1 on 2.x compatibility -- writing something new with compatibility for 2
major versions makes no sense to me. It limits the features and libraries
that can be used an
https://github.com/apache/trafficcontrol/pull/2983
On Fri, Nov 2, 2018 at 9:23 AM Dan Kirkwood wrote:
> I'm about to push a PR to fix this in master... -dan
>
> On Thu, Nov 1, 2018 at 12:01 PM Eric Friedrich -X (efriedri - TRITON UK
> BIDCO LIMITED c/o Alter Domus (UK) Limi
9 PM, Dave Neuman wrote:
> >
> > Dan/Eric,
> > If we are -1ing for that, can we create a ticket?
> >
> > Thanks,
> > Dave
> >
> > On Thu, Nov 1, 2018 at 11:40 AM Dan Kirkwood wrote:
> >
> >> Good catch, Eric..
> >>
> >>
Good catch, Eric..
Looks like it wasn't tried with the source tarball previously.. Those
set TC_DIR=$(git rev-parse --show-toplevel),
but the others don't use git because .git isn't available in the tarball.
-1 until that's fixed.
-dan
On Thu, Nov 1, 2018 at 10:59 AM Eric Friedrich -X (e
Agreed -- we need visibility in dev efforts earlier rather than later.
Saying the PR must be complete before submitting may be counter productive.
On Thu, Oct 25, 2018 at 8:33 PM Jeremy Mitchell
wrote:
> Like Dave said, I often request WIP PR's especially when trying to work
> thru requirements
+1
On Thu, Oct 25, 2018 at 6:49 AM Eric Friedrich (efriedri)
wrote:
> +1
>
> I support the goal of making Traffic Control more reliable and think this
> is a step in the right direction.
>
> In some of our other products, we’ve had good luck using a circuit breaker
> as part of the retry process
mine, too.. down to 400 now..
On Thu, Oct 18, 2018 at 9:00 AM Jan van Doorn wrote:
> Thanks Jeremy - Did mine.
>
> Cheers,
> JvD
>
>
> > On Oct 18, 2018, at 07:34, Dave Neuman wrote:
> >
> > Thanks Jeremy,
> > I will take a look at my issues today.
> >
> > On Wed, Oct 17, 2018 at 8:52 PM Jerem
t we need to consider it as an interim step, I think we need to
> also
> > start considering rethinking the API from the top-down (leaving the ID
> > based API's behind where possible).
> >
> > -Dew
> >
> > On Mon, Oct 8, 2018 at 3:44 PM Dan Kirkwo
Hi all..we've discussed the possibility of moving the major version of
the Traffic Ops API at some point in the (hopefully near) future. When
that does happen, I'd like to propose that the change include elimination
of using foreign key ids (from the "id" field) and instead reference using
a
t;
> > > > > > > The difference is that the TO config is used by system
> > > > administrators. As
> > > > > > > Self-Service moves forward, profiles and other API data
> will be
> > > used
> > > > by
&g
> Also +1 on changing them to real booleans (not sure if the api
> > export/import is, they appear to be undocumented). Though we can't break
> > the current API; we could make the POST accept either, but the GET would
> > have to be a new endpoint I think.
> >
&g
+1 on this plan -- remove UID/GID from the db, keep (deprecated) in the API
until the next major version of the API.
Sorry to add to it, but the "confirmLocalPasswd" field (and related db
column) should also be deprecated. Traffic Portal should keep this and
check the fields as now, but only pa
I’d like to propose deprecating the import/export format of profiles. The
current format (Perl-based) is inconsistent with the standard POST
api/x.x/profiles format. Import/Export can/should be done using the same
API. Traffic Portal Import should use the standard API endpoint.
Import/export (sh
Jan, yep -- that's what John did with
https://github.com/apache/trafficcontrol/pull/2781
It's for grove only at this point, but we're considering upgrading
everything else to 1.11.x as well...
-dan
On Wed, Sep 5, 2018 at 8:09 AM Jan van Doorn wrote:
> It looked to me like the RSA problems a
> >
> > > > > > *What's a good way to verify this PR?*
> > > > > >
> > > > > > *Check any that apply:*
> > > > > >
> > > > > > - [ ] This PR does *not* fix a serious security flaw. (Read more:
>
= unassigned
> >
> > ^^ this allows you to easily find resources to assign the proper tenant
> to.
> >
> > Part of me thinks, set all null tenants to unassigned regardless of
> > whether use_tenancy
> > = 0 or 1
> >
> > Jeremy
> >
> >
> >
Along those lines, there are currently no constraints in the db to
enforce that everything has an assigned tenant. I'd like to change that.
Currently, it's possible to have tenancy turned on but still have NULL
tenant_id on a user, deliveryservice, or origin. That leads to ambiguous
situat
On Sat, Jun 23, 2018 at 10:05 AM Robert Butts wrote:
> >as long as we have 100% feature complete with the Go code (which I think
> we're fairly close?)
> We are not close. We are at 108 of 240 endpoints.
>
> >if we do not treat the tests as first class citizens (meaning we implement
> an Go endpo
I'm all for #3. In fact, the `traffic_ops/testing/api` framework that
Dewayne has developed encourages testing from the HTTP calls (which you
suggest in #1). That covers the endpoint no matter how it's implemented.
Removing dead Perl code can be tricky, since the interdependencies are not
alw
Hi all... Dave got the change done to rename our repo from
`incubator-trafficcontrol` to `trafficcontrol`, and now the source code
and docs on master should all reflect that.
Going to https://github.com/apache/incubator-trafficcontrol will
automatically redirect you to the right place, but
btw, not going to act on this right now, so there still is time to
provide your input.
On Fri, Jun 8, 2018 at 11:17 AM Dan Kirkwood wrote:
> Thanks, Dave -- that's where I stand as well -- preferring #1 but knowing
> that #3 is probably the necessary option.. I like the comm
> Sent: Thursday, June 7, 2018 4:53 PM
> > > To: dev@trafficcontrol.apache.org
> > > Subject: Re: [EXTERNAL] go version used in build
> > >
> > > I vote for option 3 since the version of go you compile with is no
> > different than the version of a libra
+1
On Fri, Jun 8, 2018 at 9:19 AM Eric Friedrich (efriedri)
wrote:
> +1
>
> With the caveat that we maintain an upgrade process when we start
> deprecating APIs between components.
>
> —Eric
>
> > On Jun 7, 2018, at 2:11 PM, Dewayne Richardson
> wrote:
> >
> > +1, this will allow us to do a bet
Hey, all.. I just investigated this issue (
https://github.com/apache/incubator-trafficcontrol/issues/2380) and
realized that the `go` version being used in building traffic_stats and
traffic_monitor is different from that of traffic_ops due to the way it's
installed during the rpmbuild phase.
Rob, looks like we have the requisite 3 votes (would be nice to have
more..)..
Can we call it passed?
-dan
On Tue, May 15, 2018 at 3:38 PM Steve Malenfant
wrote:
> +1 based on the ORT changes.
>
> On Fri, May 11, 2018 at 2:22 PM, Robert Butts wrote:
>
> > Hello All,
> >
> > I've prepared a
Nice! +1
On Fri, May 18, 2018 at 9:06 AM Eric Friedrich wrote:
> Hey-
> Based on some feedback from the incubator, we put together a new website
> that doesn’t look like its from Geocities.
>
> I’m providing links to all the pages because some of the internal links are
> broken
> https://tra
54 matches
Mail list logo
