[
https://issues.apache.org/jira/browse/TWILL-190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15429205#comment-15429205
]
ASF GitHub Bot commented on TWILL-190:
--
Github user poornachandra commented on the iss
Github user poornachandra commented on the issue:
https://github.com/apache/twill/pull/2
@chtyim Except for moving the kill loop to `ProcessController.cancel()`
method, I have addressed all other comments.
---
If your project is set up for it, you can reply to this email and have you
[
https://issues.apache.org/jira/browse/TWILL-190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15429204#comment-15429204
]
ASF GitHub Bot commented on TWILL-190:
--
Github user poornachandra commented on a diff
[
https://issues.apache.org/jira/browse/TWILL-190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15429203#comment-15429203
]
ASF GitHub Bot commented on TWILL-190:
--
Github user poornachandra commented on a diff
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/twill/pull/2#discussion_r75572275
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/TwillContainerLauncher.java
---
@@ -225,5 +257,35 @@ public ContainerLiveNodeData getLiveNode
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/twill/pull/2#discussion_r75572272
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/TwillContainerLauncher.java
---
@@ -177,7 +188,24 @@ protected void doStartUp() {
[
https://issues.apache.org/jira/browse/TWILL-190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15429199#comment-15429199
]
ASF GitHub Bot commented on TWILL-190:
--
Github user poornachandra commented on a diff
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/twill/pull/2#discussion_r75572116
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java
---
@@ -846,24 +875,31 @@ private boolean handleResta
[
https://issues.apache.org/jira/browse/TWILL-190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15429178#comment-15429178
]
ASF GitHub Bot commented on TWILL-190:
--
Github user chtyim commented on a diff in the
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/2#discussion_r75571268
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java
---
@@ -846,24 +875,31 @@ private boolean handleRestartRunna
[
https://issues.apache.org/jira/browse/TWILL-190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15429165#comment-15429165
]
ASF GitHub Bot commented on TWILL-190:
--
Github user chtyim commented on a diff in the
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/2#discussion_r75571007
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java
---
@@ -256,20 +261,36 @@ public void acquired(List> launche
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/2#discussion_r75570747
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/TwillContainerLauncher.java
---
@@ -225,5 +257,35 @@ public ContainerLiveNodeData getLiveNodeData()
[
https://issues.apache.org/jira/browse/TWILL-190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15429155#comment-15429155
]
ASF GitHub Bot commented on TWILL-190:
--
Github user chtyim commented on a diff in the
[
https://issues.apache.org/jira/browse/TWILL-190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15429153#comment-15429153
]
ASF GitHub Bot commented on TWILL-190:
--
Github user chtyim commented on a diff in the
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/2#discussion_r75570480
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/TwillContainerLauncher.java
---
@@ -225,5 +257,35 @@ public ContainerLiveNodeData getLiveNodeData()
[
https://issues.apache.org/jira/browse/TWILL-190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15429120#comment-15429120
]
ASF GitHub Bot commented on TWILL-190:
--
Github user chtyim commented on a diff in the
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/2#discussion_r75569082
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/TwillContainerLauncher.java
---
@@ -177,7 +188,24 @@ protected void doStartUp() {
@Ov
[
https://issues.apache.org/jira/browse/TWILL-190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428660#comment-15428660
]
ASF GitHub Bot commented on TWILL-190:
--
Github user poornachandra commented on the iss
Github user poornachandra commented on the issue:
https://github.com/apache/twill/pull/2
@hsaputra The PR is ready for review. I would appreciate a review of the
overall approach and structure. I'm just adding code to better handle
exceptions or adding more test cases now. These commi
[
https://issues.apache.org/jira/browse/TWILL-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428585#comment-15428585
]
ASF GitHub Bot commented on TWILL-182:
--
Github user serranom commented on the issue:
Github user serranom commented on the issue:
https://github.com/apache/twill/pull/1
@chtyim I assume you mean create those jars at runtime? This is what I had
difficulty doing within the test, I think because the classes were getting
loaded incorrectly. I will give that another go.
[
https://issues.apache.org/jira/browse/TWILL-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428579#comment-15428579
]
ASF GitHub Bot commented on TWILL-182:
--
Github user serranom commented on a diff in th
Github user serranom commented on a diff in the pull request:
https://github.com/apache/twill/pull/1#discussion_r75528764
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/ApplicationBundler.java ---
@@ -215,8 +215,19 @@ public boolean accept(String className, URL classU
[
https://issues.apache.org/jira/browse/TWILL-190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428544#comment-15428544
]
ASF GitHub Bot commented on TWILL-190:
--
Github user hsaputra commented on the issue:
Github user hsaputra commented on the issue:
https://github.com/apache/twill/pull/2
Hi @poornachandra , are you still working on the PR for updates, or ready
for review follow up?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
[
https://issues.apache.org/jira/browse/TWILL-190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428529#comment-15428529
]
ASF GitHub Bot commented on TWILL-190:
--
Github user poornachandra commented on a diff
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/twill/pull/2#discussion_r75523615
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/TwillContainerLauncher.java
---
@@ -177,7 +187,22 @@ protected void doStartUp() {
[
https://issues.apache.org/jira/browse/TWILL-190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15427771#comment-15427771
]
ASF GitHub Bot commented on TWILL-190:
--
Github user poornachandra commented on a diff
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/twill/pull/2#discussion_r75439711
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/TwillContainerLauncher.java
---
@@ -153,21 +155,29 @@ public TwillContainerController start(R
30 matches
Mail list logo
