[GitHub] twill pull request #10: TWILL-107 Add payload support for Discoverable

Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/10#discussion_r78250500 --- Diff: twill-discovery-api/src/main/java/org/apache/twill/discovery/Discoverable.java --- @@ -19,19 +19,67 @@ package org.apache.twill.discovery;

[GitHub] twill pull request #10: TWILL-107 Add payload support for Discoverable

Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/10#discussion_r78250557 --- Diff: twill-discovery-api/src/main/java/org/apache/twill/discovery/Discoverable.java --- @@ -19,19 +19,67 @@ package org.apache.twill.discovery;

[jira] [Commented] (TWILL-107) Support payloads for Discoverables

[ https://issues.apache.org/jira/browse/TWILL-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15478274#comment-15478274 ] ASF GitHub Bot commented on TWILL-107: -- Github user chtyim commented on a diff in the

[jira] [Commented] (TWILL-107) Support payloads for Discoverables

[ https://issues.apache.org/jira/browse/TWILL-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15478275#comment-15478275 ] ASF GitHub Bot commented on TWILL-107: -- Github user chtyim commented on a diff in the

[GitHub] twill pull request #10: TWILL-107 Add payload support for Discoverable

Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/10#discussion_r78250733 --- Diff: twill-discovery-api/src/main/java/org/apache/twill/discovery/Discoverable.java --- @@ -19,19 +19,67 @@ package org.apache.twill.discovery;

[GitHub] twill pull request #10: TWILL-107 Add payload support for Discoverable

Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/10#discussion_r78250998 --- Diff: twill-discovery-core/src/main/java/org/apache/twill/discovery/DiscoverableAdapter.java --- @@ -76,18 +78,9 @@ public Discoverable deserialize(JsonElem

[jira] [Commented] (TWILL-107) Support payloads for Discoverables

[ https://issues.apache.org/jira/browse/TWILL-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15478281#comment-15478281 ] ASF GitHub Bot commented on TWILL-107: -- Github user chtyim commented on a diff in the

[jira] [Commented] (TWILL-107) Support payloads for Discoverables

[ https://issues.apache.org/jira/browse/TWILL-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15478285#comment-15478285 ] ASF GitHub Bot commented on TWILL-107: -- Github user chtyim commented on a diff in the

[GitHub] twill issue #10: TWILL-107 Add payload support for Discoverable

Github user chtyim commented on the issue: https://github.com/apache/twill/pull/10 Just couple comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[jira] [Commented] (TWILL-107) Support payloads for Discoverables

[ https://issues.apache.org/jira/browse/TWILL-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15478286#comment-15478286 ] ASF GitHub Bot commented on TWILL-107: -- Github user chtyim commented on the issue:

[GitHub] twill issue #10: TWILL-107 Add payload support for Discoverable

Github user gokulavasan commented on the issue: https://github.com/apache/twill/pull/10 Thanks for the review @chtyim. Addressed comments. Please take a look again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your