Github user asfgit closed the pull request at:
https://github.com/apache/incubator-weex/pull/210
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
I agree with your opinion. So, I add a component named cycleslider, and keep
the original slider component.
>From now on we only maintain cycleslider, no longer maintain slider. All new
>features are only added to cycleslider.
I added an attribute of setting pages to cycle, which is named “infin
Hi,All:
I think it's necessary to describe how you refactor the slidercompnonent in
more detail and which method you used to improve slider.
About compatible,if WXRecycleSliderComponent support all the old slider api and
it can run all the test case successfully . I think it no need to maintain
Hi,All:
I think it's necessary to describe how you refactor the slidercompnonent in
more detail and which method you used to improve slider.
About compatible,if WXRecycleSliderComponent support all the old slider api and
it can run all the test case successfully . I think it no need to maintain
Github user kfeagle commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/210#discussion_r109823455
--- Diff: ios/sdk/WeexSDK/Sources/Component/WXRecycleSliderComponent.m ---
@@ -0,0 +1,528 @@
+/**
+ * Created by Weex.
+ * Copyright (c) 2
I suppose it’s a good start point. “slider” component has too much complicated
and deprecated logic which has made it hard to maintain.
For a clearer code review, we need more detailed information for this PR, for
example, why is the old slider difficult to understand? What is done to make
th
Hi,All:
I wrote a new slider component which is named WXRecycleSliderComponent to
replace the old slider component which is named WXSliderComponent.(PR:
https://github.com/apache/incubator-weex/pull/210)
The logic of old slider component is difficult to understand, and there are a
lot of bugs. T
GitHub user bluebird78999 opened a pull request:
https://github.com/apache/incubator-weex/pull/210
* [ios] the new slider component which is named WXRecycleSliderCompon
[ios] the new slider component which is named WXRecycleSliderComponent to
replace the old slider component which
