Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/253#discussion_r161372957
--- Diff:
wicket-core/src/main/java/org/apache/wicket/markup/head/filter/FilteringHeaderResponse.java
---
@@ -263,14 +262,12 @@ public void markRendered(Obj
Please note that logback is LGPL 2.1/EPL licensed.
LGPL 2.1 cannot be distributed with our code. EPL only as binary, and
properly attributed in the NOTICE file:
https://www.apache.org/legal/resolved.html#category-b
Martijn
On Sat, Jan 13, 2018 at 4:20 AM, solomax wrote:
> GitHub user solomax
Actually it is not being distributed :)
It is in the pom only, It only "distributed" after final project,
generated on client side, is being built
Should I add reference to NOTICE file?
On Sun, Jan 14, 2018 at 4:08 AM, Martijn Dashorst
wrote:
> Please note that logback is LGPL 2.1/EPL licensed.
>
I would also not enforce user to take a LGPL dependency. For Log4j you can use
SLF4J adapter and also logback if you finally want to but you don’t have to.
+1 to revert.
kind regards
Tobias
> Am 14.01.2018 um 04:45 schrieb Maxim Solodovnik :
>
> Actually it is not being distributed :)
> It is
I would support any decision here :)
>From my point of view app with in-build "memory leak" shouldn't be generated.
Generated quick-start project is being owned by the user. And he/she
can choose any license :)
We can add NOTICE to generated project, not sure if this is required .
On Sun, Jan
Just have tried to run local site using this [1] instruction
The result was empty "_site" folder and "directory listing" at
http://127.0.0.1:4000
What am I doing wrong?
[1] http://wicket.apache.org/contribute/write.html
On Fri, Jan 12, 2018 at 7:16 PM, Martijn Dashorst
wrote:
> On Fri, Jan 12, 2
