Re: XmlPullParser parses strings with platform's default charset

2012-06-07 Thread Juergen Donnerstag
IRequestCycleSettings#getResponseRequestEncoding() for the charset but if there is no XML prolog or it has no encoding attr then the test fails. On Tue, Jun 5, 2012 at 11:53 PM, Juergen Donnerstag juergen.donners...@gmail.com wrote: Hi Martin, XmlReader reads the markup file, interprets ?xml encoding

Re: XmlPullParser parses strings with platform's default charset

2012-06-07 Thread Juergen Donnerstag
, HERE) - this is in XmlReader - (the XML prolog maybe be ignored totally) I think this should work. On Thu, Jun 7, 2012 at 10:14 AM, Juergen Donnerstag juergen.donners...@gmail.com wrote: And there is no stable solution, except we create an artificial one (via XML prolog and encoding parameter

Re: XmlPullParser parses strings with platform's default charset

2012-06-05 Thread Juergen Donnerstag
I'll have a look later today. Juergen On Mon, Jun 4, 2012 at 3:37 PM, Martin Grigorov martin.grigo...@gmail.com wrote: Hi, I'm not quite sure but I think there is a bug in org.apache.wicket.markup.parser.XmlPullParser#parse(CharSequence) because it uses string.toString().getBytes() to

Re: XmlPullParser parses strings with platform's default charset

2012-06-05 Thread Juergen Donnerstag
might need change. make sense? Juergen On Tue, Jun 5, 2012 at 9:54 AM, Juergen Donnerstag juergen.donners...@gmail.com wrote: I'll have a look later today. Juergen On Mon, Jun 4, 2012 at 3:37 PM, Martin Grigorov martin.grigo...@gmail.com wrote: Hi, I'm not quite sure but I think

Re: Maven hate (was Re: [VOTE] Release wicket 6.0.0-beta2)

2012-05-29 Thread Juergen Donnerstag
When I built the wicket gradle files I found most aspects quite intuitive. Unfortunately I didn't have much time to improve them and since no one else showed interest, I agreed to remove them again. Gradle has a learning curve and like all frameworks, it requires some reading and research to

Re: [cleanup] gradle build files

2012-05-06 Thread Juergen Donnerstag
me too Juergen On Sun, May 6, 2012 at 12:38 PM, Martin Grigorov mgrigo...@apache.org wrote: I'm OK to remove them. On Fri, May 4, 2012 at 3:48 PM, Martijn Dashorst martijn.dasho...@gmail.com wrote: It looks like we are not going to use the gradle build files. Does anyone object to removing

Re: Re: git commit: WICKET-4484 do not change tag id when resolving component

2012-03-30 Thread Juergen Donnerstag
identified. Sven On 03/29/2012 09:44 PM, Juergen Donnerstag wrote: Hi Sven I double checked with how other filters/resolvers are doing it and I found AutoLabelTextResolver to leave the tag id untouched too. which is a fault as well. Same risk. May be a Component's flag bit can be used

Re: git commit: WICKET-4484 do not change tag id when resolving component

2012-03-30 Thread Juergen Donnerstag
to understand the problem you've identified. Sven On 03/29/2012 09:44 PM, Juergen Donnerstag wrote: Hi Sven I double checked with how other filters/resolvers are doing it and I found AutoLabelTextResolver to leave the tag id untouched too. which is a fault as well. Same risk. May

Re: git commit: WICKET-4484 do not change tag id when resolving component

2012-03-30 Thread Juergen Donnerstag
Meier s...@meiers.net wrote: Javascript ids are session unique anyway - just prefixed with the component id in non-deployment config. Sven On 03/30/2012 04:11 PM, Juergen Donnerstag wrote: On Fri, Mar 30, 2012 at 3:57 PM, Sven Meiers...@meiers.net  wrote: Hi Juergen and Jesse, I've

Re: git commit: WICKET-4484 do not change tag id when resolving component

2012-03-29 Thread Juergen Donnerstag
Hi Sven, the change introduces a theoretical risk of duplicate ids. I don't know how likely it is and I know we have no tests for it. But Filters are created per markup file and modify the markup upon loading, prior to caching. Which also means that the Page is not available. In case of

Re: git commit: WICKET-4484 do not change tag id when resolving component

2012-03-29 Thread Juergen Donnerstag
not tried it but I don't expect it to be too difficult. Knowing there is a potential risk which will be very hard to find by a normal user, makes me belief we should fix it properly, To me the applied patch leaves us with a bigger problem than it fixes. Juergen Sven On 03/29/2012 08:42 PM, Juergen

Re: Release Wicket 6.0 milestone1 ?

2012-03-21 Thread Juergen Donnerstag
+1 Juergen On Wed, Mar 21, 2012 at 11:57 AM, Emond Papegaaij emond.papega...@topicus.nl wrote: +1 for release, +1 for beta On Tuesday 20 March 2012 12:21:38 Igor Vaynberg wrote: +1 for release, +0 for beta vs milestone. -igor On Tue, Mar 20, 2012 at 10:59 AM, Martin Grigorov

Re: Why ComponentTag's behaviors are executed after Component's behaviors ?

2012-01-30 Thread Juergen Donnerstag
Hi, no specific reason I think. So far nobody ask for it with a good use case. I think it's ok to change the order. -Juergen On Mon, Jan 30, 2012 at 9:13 AM, Martin Grigorov mgrigo...@apache.org wrote: Hi, What is the reason the (more static, auto) ComponentTag's behaviors to be executed

Re: [vote] release wicket 1.5.4 take 3

2012-01-21 Thread Juergen Donnerstag
+1 On Fri, Jan 20, 2012 at 6:49 PM, Sven Meier s...@meiers.net wrote: +1 On 01/19/2012 06:04 PM, Jeremy Thomerson wrote: +1 On Thu, Jan 19, 2012 at 11:47 AM, Igor Vaynbergigor.vaynb...@gmail.comwrote: +1 -igor On Tue, Jan 17, 2012 at 8:34 PM, Igor Vaynbergigor.vaynb...@gmail.com

Re: overriding getNamespace won't work

2012-01-03 Thread Juergen Donnerstag
There are working examples in our test suite. Please have a look their. They exist since the first days of Wicket. Juergen On Tue, Jan 3, 2012 at 10:05 PM, YK linux_2...@yahoo.fr wrote: Hi, sorry this does not work... I suspect it's feasable now thanks anyway -- View this message in

Re: Please welcome Emond Papegaaij as a committer for Wicket

2012-01-02 Thread Juergen Donnerstag
Welcome Emond -Juergen On Tue, Jan 3, 2012 at 3:57 AM, Jeremy Thomerson jer...@wickettraining.com wrote: Welcome aboard! On Fri, Dec 30, 2011 at 10:26 AM, Emond Papegaaij emond.papega...@topicus.nl wrote: Thank you all for the confidence you have in my work! I'm really proud to be a

Re: overriding getNamespace won't work

2011-12-31 Thread Juergen Donnerstag
please see MarkupParserTest.java. The following is a partial copy: @Test public void tagParsing() throws Exception { final MarkupParser parser = new MarkupParser( This is a test a componentName:id=\a\ href=\foo.html\ b

Re: overriding getNamespace won't work

2011-12-30 Thread Juergen Donnerstag
I don't think it has changed in 1.5 compared to 1.4, but feel free to open a jira ticket and attach a quickstart -Juergen On Fri, Dec 30, 2011 at 9:44 PM, YK linux_2...@yahoo.fr wrote: hi, I'm playing with wicket 1.5.3 and I discovered that overriding getNamespace method does not work! In

Re: [vote] release wicket 1.5.2 take 3

2011-10-23 Thread Juergen Donnerstag
+1 Juergen On Sun, Oct 23, 2011 at 3:17 PM, Andrea Del Bene an.delb...@gmail.com wrote: +1 to release +1 On Thu, Oct 20, 2011 at 6:34 PM, Igor Vaynbergigor.vaynb...@gmail.com  wrote: This vote is to release wicket 1.5.2 (take 3) Branch

Re: [vote] promote 1.5-RC7 to 1.5.0

2011-08-30 Thread Juergen Donnerstag
+1 Juergen

Re: Spliting packages/modules and deploy

2011-08-18 Thread Juergen Donnerstag
I missed some of the discussions on mail list on this topic. To me it sounds like what we were always after: separate (sub-)projects for internal development purposes and a single wicket.jar in maven's public repo. If finally somebody found a way to achieve this with maven, the better. Juergen

Re: Restructure Packaging for OSGi

2011-08-16 Thread Juergen Donnerstag
If I recall correctly than we split the sources into -core, -util and -request for development reasons. To keep our internal architecture clean and identify possibly unwanted dependencies between them early and easy. I thought because Maven does not support (internal) subprojects, we ended up

Re: wicket 2.0 ideas

2011-07-22 Thread Juergen Donnerstag
url to the commit(s) so we can see the diffs ? On Thu, Jul 21, 2011 at 11:29 PM, Juergen Donnerstag juergen.donners...@gmail.com wrote: Just uploaded it to  https://github.com/jdonnerstag/wicket/tree/autoadd Juergen On Thu, Jul 21, 2011 at 9:48 AM, Juergen Donnerstag juergen.donners

Re: wicket 2.0 ideas

2011-07-21 Thread Juergen Donnerstag
I gave the idea to resolve components after onInitalize() a try by re-using ComponentResolvers to resolve the auto-components. They are added (not queued) at the right place in the hierarchy. Component's queued will be added to the auto-components as well, so that the hierarchies (markup and

Re: [jira] [Reopened] (WICKET-3878) When base markup file has been removed from the cache, the the derived markup should be removed as well

2011-07-08 Thread Juergen Donnerstag
         Components: wicket-core    Affects Versions: 1.5-RC5.1            Reporter: Robert McGuinness            Assignee: Juergen Donnerstag            Priority: Minor             Fix For: 1.5-RC6         Attachments: fix-WICKET-3878.patch, test-WICKET-3878.patch Making updates to the base

Re: build failing on localized (German) laptop (windows)

2011-07-06 Thread Juergen Donnerstag
:12 PM, Juergen Donnerstag wrote: Hi, though jenkins seems to be fine, maven build is failing on my (German) laptop. ValueMapTest:testGetAs():237:expected 1 Stunde but was null DurationTest:operations:74:expected 1,5 minutes but was 1,5 Minuten DurationTest:locale:108:expected 1 hour but was 1

Re: svn commit: r1138873 - /wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/tree/AbstractTree.java

2011-06-23 Thread Juergen Donnerstag
this method outside Ajax response. Now it is not safe. I think the problem in this ticket is that until today a wrong way to get the ART was used. Now it is better. Otherwise the method's javadoc explains it: if this is not Ajax request it is no-op. On Thu, Jun 23, 2011 at 5:37 PM, Juergen

Re: [vote] release Wicket 1.5-RC5.1

2011-06-21 Thread Juergen Donnerstag
+1 Juergen On Tue, Jun 21, 2011 at 8:48 AM, Martin Grigorov mgrigo...@apache.org wrote: +1 re-tested my application On Tue, Jun 21, 2011 at 1:29 AM, Igor Vaynberg igor.vaynb...@gmail.com wrote: This vote is to release wicket 1.5-RC5.1 Branch:

Re: Feature suggestion: fallback style

2011-06-16 Thread Juergen Donnerstag
Hi Bruno, please open a jira feature/improvement request. I'll have a look. Thanks. -Juergen On Thu, Jun 16, 2011 at 10:20 PM, Bruno Borges bruno.bor...@gmail.com wrote: I came once with this but I don't remember what happend. Anyway, I want to share the idea with you again: We are

Re: Eclipse running out-of-memory

2011-05-12 Thread Juergen Donnerstag
By now I also tested eclipse 3.7 M7 and several more combinations of jre's for eclipse and test itself. I also installed yourkit to dig a bit deeper. The problem remains irrespective of the jvm or eclipse. Using yourkit for testing I became aware that at the moment mem consumption increases, also

Test failure probably due to locale

2011-05-08 Thread Juergen Donnerstag
Hi, on my (german) laptop testComponentAttributesNotDoubleEscaped is failing. junit.framework.AssertionFailedError: One of the pound entity representations is missing: pound; or #163; at

Disable ModificationWatcher for WicketTester

2011-05-08 Thread Juergen Donnerstag
I'd like to disable ModificationWatcher for WicketTester. Any objections? -Juergen

Re: Test failure probably due to locale

2011-05-08 Thread Juergen Donnerstag
is fine. My Maven setup uses bg_BG and again all is fine. Just verified. Igor mentioned that this test started to fail at his machine yesterday, but I guess his setup completely is en_US. On Sun, May 8, 2011 at 11:13 AM, Juergen Donnerstag juergen.donners...@gmail.com wrote: Hi, on my (german

Re: Test failure probably due to locale

2011-05-08 Thread Juergen Donnerstag
/ComponentTagAttributeEscapingTest.java?view=markup On Sun, May 8, 2011 at 11:43 AM, Juergen Donnerstag juergen.donners...@gmail.com wrote: The *root* cause seems to be obvious. Instead of changing any eclipse settings, the assert statement must be changed. Replace ££ with a properly encoded

Re: [osgi] package org.apache.wicket.request exported either from core and request packages

2011-05-07 Thread Juergen Donnerstag
take a look? -igor On Sun, May 1, 2011 at 8:20 AM, Juergen Donnerstag juergen.donners...@gmail.com wrote: I'm not a gradle expert which is why I had to try this and that. But my initial tests to create the ueber jars have now been successful. -Juergen On Fri, Apr 29, 2011

Re: [osgi] package org.apache.wicket.request exported either from core and request packages

2011-04-29 Thread Juergen Donnerstag
I played a bit with gradle recently. - Transfered Wicket's build process which was fairly straight forward; compile, test, install. jetty:run etc. - eclipse project files generated seem to be ok - maven repositories to get artifacts - successfully installed a new snapshot in my local repo I

Re: Missing XML declaration in error page.

2011-04-23 Thread Juergen Donnerstag
at 10:10 AM, Juergen Donnerstag juergen.donners...@gmail.com wrote: the setting/exception is to make sure that all markup files have proper encoding. Think about moving markup files from your local latop onto a production server. Who guarantees that in your markup are only ascii chars? Who

Re: Missing XML declaration in error page.

2011-04-22 Thread Juergen Donnerstag
the setting/exception is to make sure that all markup files have proper encoding. Think about moving markup files from your local latop onto a production server. Who guarantees that in your markup are only ascii chars? Who guarantees the prod server has the same default encoding than your devs

Re: Wicket Markup questions to wicket developers

2011-04-14 Thread Juergen Donnerstag
please see http://wicket.apache.org/apidocs/1.4/org/apache/wicket/settings/IMarkupSettings.html#setStripWicketTags(boolean) on how to remove all wicket:id attributes and wicket:xx tags from output On Thu, Apr 14, 2011 at 6:21 PM, jcgarciam jcgarc...@gmail.com wrote: When running the

Re: [vote] release wicket 1.4.17

2011-03-30 Thread Juergen Donnerstag
+1 Juergen On Wed, Mar 30, 2011 at 6:40 PM, Jan Kriesten kries...@mail.footprint.de wrote: This vote is to release wicket 1.4.17. This is a bugfix release on the 1.4.x (stable) branch. +1 Best regards, --- Jan.

Re: [vote] release wicket 1.5-RC3

2011-03-30 Thread Juergen Donnerstag
+1 Juergen On Wed, Mar 30, 2011 at 6:41 PM, Jan Kriesten kries...@mail.footprint.de wrote: This vote is to release wicket 1.5-RC3 +1 Best regards, --- Jan.

Re: WicketFilter works with only one filterPath

2011-03-05 Thread Juergen Donnerstag
I don't know. May be too long ago. -Juergen On Fri, Mar 4, 2011 at 4:49 PM, Martin Grigorov mgrigo...@apache.org wrote: Hi, In the context of https://issues.apache.org/jira/browse/WICKET-3497 I want to ask other Wicket devs whether WicketFilter parses only one filter-mapping and ignores

auto-components

2011-03-05 Thread Juergen Donnerstag
Hi, I try to get rid of auto-components. The main reason why we introduced it was that it should not be allowed to make changes to the hierarchy during the render phase. I wonder if that assumption is still true. Any idea? -Juergen

Re: [vote] release wicket 1.5-rc2

2011-02-21 Thread Juergen Donnerstag
+1 Juergen On Mon, Feb 21, 2011 at 5:01 PM, Peter Ertl pe...@gmx.org wrote: +1 Am 21.02.2011 um 16:03 schrieb Francisco Diaz Trepat - gmail: +1 Also some quick testing on wicket-examples On Mon, Feb 21, 2011 at 11:58 AM, Martin Grigorov mgrigo...@apache.orgwrote: +1 to release it

Re: How to streamline ajax page region toggle

2011-02-20 Thread Juergen Donnerstag
...@gmail.comwrote: On Sat, Feb 19, 2011 at 2:20 PM, Juergen Donnerstag juergen.donners...@gmail.com wrote: A couple of comments on previous posts - you can always assign your own wicket:id like wicket:enclosure wicket:id=myEnclosure child=label1 - yes, wicket:enclosure creates an auto

Re: How to streamline ajax page region toggle

2011-02-20 Thread Juergen Donnerstag
said, just a thought. -Juergen On Sun, Feb 20, 2011 at 5:16 PM, Juergen Donnerstag juergen.donners...@gmail.com wrote: I did a first review. - EnclosureHandler: A variable to increment the id postfix will not work. A fresh copy of MarkupParser and all its handlers is created for every markup

Re: How to streamline ajax page region toggle

2011-02-19 Thread Juergen Donnerstag
A couple of comments on previous posts - you can always assign your own wicket:id like wicket:enclosure wicket:id=myEnclosure child=label1 - yes, wicket:enclosure creates an auto component (no java code necessary) that is auto-added to the container which at that point in time gets rendered, when

Re: [vote] retry: release wicket 1.5-rc1

2011-01-20 Thread Juergen Donnerstag
Findings (I can also create jira issues for all of them, just let me know): 1) based on Migration Guide 1.5, TabbedPanel improvement: 'ITab.getPanel() now returns WebMarkupContainerWithAssociatedMarkup instead of Panel so it is now possible to create tabs using Fragments or Panels rather then

Re: More flexible Panel, Fragment, etc.

2011-01-13 Thread Juergen Donnerstag
An initial version went into rc1 though we are still discussing minor changes. The API might change slighty. -Juergen On Thu, Jan 13, 2011 at 11:49 AM, Martijn Dashorst martijn.dasho...@gmail.com wrote: On Thu, Jan 13, 2011 at 11:42 AM, Daniel Soneira daniel.sone...@joyn-it.at wrote: Since

Re: [vote] release wicket-1.5-rc1

2011-01-13 Thread Juergen Donnerstag
could we please add testcases if applicable. thanks. Juergen 2011/1/13 Major Péter majorpe...@sch.bme.hu: Sadly I have a -1 for this, because of https://issues.apache.org/jira/browse/WICKET-3329 and https://issues.apache.org/jira/browse/WICKET-3330 3329 is almost a don't care, but 3330

maven clean is failing as well as AjaxFormSubmitTest.testEventJavaScriptEscaped

2011-01-11 Thread Juergen Donnerstag
-Juergen

Re: AbstractRequestWrapperFactory?

2011-01-09 Thread Juergen Donnerstag
I had that idea as well. My initial commit actually included such a hook. But I removed it again. Though wrappers are registered with filters/servlets in the servlet world, wicket already provides a very very easy way by subclassung Application.newRequestxx(). IMO the problem is, and here I agree

More flexible Panel, Fragment, etc.

2011-01-08 Thread Juergen Donnerstag
Hi, currently every component that requires the markup to be in an associated file must be derived from Panel. Every component that want it's markup inline must be derived from Fragment. I've changed that and moved the respective source code into something I called markup sourcing strategy. I'm

Re: Scala-Wicket Help and Advice

2011-01-05 Thread Juergen Donnerstag
Cool. May I ask which tools (IDE) you've been using and what your experience with these tools has been. -Juergen On Wed, Jan 5, 2011 at 2:34 AM, Jeremy Thomerson jer...@wickettraining.com wrote: On Tue, Jan 4, 2011 at 5:15 PM, richard emberson richard.ember...@gmail.com wrote: Dev Wicketers,

Re: date/time conversion on hudson server

2010-12-30 Thread Juergen Donnerstag
Juergen Donnerstag juergen.donners...@gmail.com though you are right in what you are saying about joda caching the timezone, I don't think it is the root cause. Looking at the logs everything is fine until step 4 (actually 5) when the hour is set based on the input provided. It is set to 0 which

automatically open tags for all Components

2010-12-30 Thread Juergen Donnerstag
we have several components which use @Override protected void onComponentTag(final ComponentTag tag) { if (tag.isOpenClose()) { tag.setType(TagType.OPEN); } super.onComponentTag(tag);

Re: date/time conversion on hudson server

2010-12-30 Thread Juergen Donnerstag
good point. I took a look at DateConverter and actually the ctor has an attribute applyTimeZoneDifference. DateTextField gets initialized with a StyleDateConverter with applyTimeZoneDifference = true. DateConverter#convertObject actually uses it, but I think - based on what I learnt the last

Re: automatically open tags for all Components

2010-12-30 Thread Juergen Donnerstag
through true, most components already do it anyway. There is almost no effect on our test cases On Thu, Dec 30, 2010 at 11:27 PM, Jeremy Thomerson jer...@wickettraining.com wrote: On Thu, Dec 30, 2010 at 9:46 AM, Juergen Donnerstag juergen.donners...@gmail.com wrote: we have several

Re: automatically open tags for all Components

2010-12-30 Thread Juergen Donnerstag
. On Thu, Dec 30, 2010 at 5:51 PM, Juergen Donnerstag juergen.donners...@gmail.com wrote: through true, most components already do it anyway. There is almost no effect on our test cases On Thu, Dec 30, 2010 at 11:27 PM, Jeremy Thomerson jer...@wickettraining.com wrote: On Thu, Dec 30, 2010 at 9

WebSession dirty()

2010-12-29 Thread Juergen Donnerstag
In 1.5 trunk WebSession has a transient variable dirty which is set to true when dirty() is called. But I don't see that the dirty variable is used anywhere. Is that by purpose? How does it work? -Juergen

date/time conversion on hudson server

2010-12-29 Thread Juergen Donnerstag
has anybody an idea why date/time conversion on our hudson server works different than on my windows box? Is there any know incompatibility across different OSes? -Juergen

Re: date/time conversion on hudson server

2010-12-29 Thread Juergen Donnerstag
though you are right in what you are saying about joda caching the timezone, I don't think it is the root cause. Looking at the logs everything is fine until step 4 (actually 5) when the hour is set based on the input provided. It is set to 0 which is what I provided. The problem is that the

Re: svn commit: r1053027 - /wicket/trunk/pom.xml

2010-12-27 Thread Juergen Donnerstag
maven 3.x complained about an error in pom.xml (did a clean checkout). maven did nothing. Not even clean or eclipse:eclipse did work. Juergen On Mon, Dec 27, 2010 at 10:24 AM, Martin Grigorov mgrigo...@apache.org wrote: Hi Juergen, What was the problem before this change ? The build was OK

Re: svn commit: r1053027 - /wicket/trunk/pom.xml

2010-12-27 Thread Juergen Donnerstag
I'll try it again -Juergen On Mon, Dec 27, 2010 at 10:36 AM, Martin Grigorov mgrigo...@apache.org wrote: weird... I just reverted your change locally and both Maven 2.2.1 and Maven 3.0.1 work without problems On Mon, Dec 27, 2010 at 10:27 AM, Juergen Donnerstag juergen.donners

Re: svn commit: r1053027 - /wicket/trunk/pom.xml

2010-12-27 Thread Juergen Donnerstag
my mistake. Don't know what happend, but it's working now (with your original version). I'll revert. Juergen On Mon, Dec 27, 2010 at 10:38 AM, Juergen Donnerstag juergen.donners...@gmail.com wrote: I'll try it again -Juergen On Mon, Dec 27, 2010 at 10:36 AM, Martin Grigorov mgrigo

setResponsePage in Component constructor

2010-12-26 Thread Juergen Donnerstag
Hi, quick question. I have an 1.4 app which uses setResponsePage(getApplication().getHomePage()); in a Component's contructor and it works even if the Component is not yet fully configured (not all children created and added). In 1.5 the same page throws a MarkupException. In 1.5 Pages obviously

Re: WICKET-3261

2010-12-22 Thread Juergen Donnerstag
+1 Juergen On Wed, Dec 22, 2010 at 11:59 AM, Martin Grigorov mgrigo...@apache.org wrote: +1 to rename current wicket to wicket-core On Tue, Dec 21, 2010 at 5:58 PM, Igor Vaynberg igor.vaynb...@gmail.comwrote: +1 to rename current wicket into wicket-core -igor On Tue, Dec 21, 2010 at

Re: [DISCUSS 1.5] Rename IHeaderResponse to IResourceResponse (or similar)?

2010-12-18 Thread Juergen Donnerstag
I understand that IHeaderResponse is no longer accurate, but IResourceResponse IMO would simply be wrong: it's not a response to a resource. It contributes to a specific section of a response such as Header or Footer Juergen On Sat, Dec 18, 2010 at 6:56 AM, Jeremy Thomerson

Re: MarkupUtil.isMarkupHtml5Compliant() bug ?!

2010-12-09 Thread Juergen Donnerstag
() returned the page's markup, i.e. all html, and its markupstream had 'null' doctype. I'll investigate further but you can also take a look at the application. It is in wicketstuff's SVN repo (link below). On Wed, Dec 8, 2010 at 5:41 PM, Juergen Donnerstag juergen.donners...@gmail.com wrote

Re: MarkupUtil.isMarkupHtml5Compliant() bug ?!

2010-12-08 Thread Juergen Donnerstag
Interesting. I thought I had a testcase with exactly that DOCTYPE. In any case it returns the DOCTYPE of the page only, irrespective of Panel or Border etc. getMarkup() returning null means no markup found which would explain the NPE as well. You are sure about your source code and markup?

rename classes and methods from *Javascript* to *JavaScript*

2010-12-07 Thread Juergen Donnerstag
what shall we do with http://issues.apache.org/jira/browse/WICKET-715? If we want to change it / make it consistent, we should change it anytime soon -Juergen

Re: [vote] switch 1.5.x releases from milestones to RCs

2010-12-05 Thread Juergen Donnerstag
+1 Juergen On Sun, Dec 5, 2010 at 3:54 PM, Martin Grigorov mgrigo...@apache.org wrote: +1 On Sun, Dec 5, 2010 at 3:52 PM, Igor Vaynberg igor.vaynb...@gmail.comwrote: i think 1.5.x branch is stable enough to release RCs. this vote is to make the next release RC1. vote ends Wednesday 5pm

Re: getMarkupIdFromMarkup problem

2010-12-04 Thread Juergen Donnerstag
://issues.apache.org/jira/browse/WICKET-3197have fun ;-) On Thu, Nov 25, 2010 at 4:58 PM, Juergen Donnerstag juergen.donners...@gmail.com wrote: This means .addOrReplace() cannot be used in Page constructor, even indirectly. Please provide a test case and I'll have a look. Can we add some check

Re: overriding isVisible bad?

2010-11-29 Thread Juergen Donnerstag
I'm curious. Which ideas would you steal from SiteBricks and JaxRS? Juergen On Tue, Nov 30, 2010 at 5:51 AM, Eelco Hillenius eelco.hillen...@gmail.com wrote: On Mon, Nov 29, 2010 at 7:45 PM, richard emberson richard.ember...@gmail.com wrote: If wicket was going to be coded over again, would

Re: [jira] Resolved: (WICKET-1214) WicketTester#startPanel does not work (correctly)

2010-11-27 Thread Juergen Donnerstag
done On Sat, Nov 27, 2010 at 6:37 PM, Martin Grigorov mgrigo...@apache.org wrote: I think this one deserves an entry in the migration page. It will break some tests in the users' applications. On Sat, Nov 27, 2010 at 3:47 PM, Juergen Donnerstag (JIRA) j...@apache.orgwrote:     [ https

several tests are failing on trunk

2010-11-24 Thread Juergen Donnerstag
is it just me were several tests on trunk are failing? Juergen

Re: getMarkupIdFromMarkup problem

2010-11-24 Thread Juergen Donnerstag
Excepted is: - if a component provides its own markup either via subclassing getMarkup() or is expected to have associated markup (e.g. Panel) = markup available in ctor - Component.onMarkupAttached() is invoked as soon as the markup is available. E.g. a child to a Panel. child.onMarkupAttached()

Re: svn commit: r1037902 - in /wicket/trunk/wicket/src: main/java/org/apache/wicket/markup/resolver/ test/java/org/apache/wicket/markup/html/basic/ test/java/org/apache/wicket/markup/resolver/

2010-11-23 Thread Juergen Donnerstag
I don't think it's necessary to provide users the option to change the warning if a key was not found. If you really want to, use a property. IMO that would be overkill. Juergen

Re: svn commit: r1037902 - in /wicket/trunk/wicket/src: main/java/org/apache/wicket/markup/resolver/ test/java/org/apache/wicket/markup/html/basic/ test/java/org/apache/wicket/markup/resolver/

2010-11-23 Thread Juergen Donnerstag
)); so it will become the correct one: [Warning: Property for 'any key name' not found]; What do you think ? On Tue, Nov 23, 2010 at 9:56 AM, Juergen Donnerstag juergen.donners...@gmail.com wrote: I don't think it's necessary to provide users the option to change the warning if a key

Re: Maven license header plugin

2010-11-16 Thread Juergen Donnerstag
Does it work for HTML files as well? Might be even more files are included in the test. -Juergen On Tue, Nov 16, 2010 at 3:44 PM, James Carman ja...@carmanconsulting.com wrote: +1 to the maven plugin.  And, yes IDEA does it too. On Tue, Nov 16, 2010 at 8:15 AM, Martin Grigorov

strange URL

2010-10-16 Thread Juergen Donnerstag
Just stumbled upon link href=../resource/org.apache.wicket.markup.html.link.AutolinkPage_1/test2.css?-myStyle/ link href=../resource/org.apache.wicket.markup.html.link.AutolinkPage_1/test3.css?de_DE/ in AutolinkPageExpectedResult_1.html (wicket 1.5). Are these URLs really correct? Juergen

Re: Request for input: resource loading search pattern flowchart

2010-09-25 Thread Juergen Donnerstag
may be that is of help as well: https://issues.apache.org/jira/browse/WICKET-2713 regards Juergen On Wed, Sep 22, 2010 at 1:14 PM, Clint Checketts checke...@gmail.com wrote: Jeremy, If possible you may try color coding the different sections of the file name:

Re: Inmethod-grid, 1.5, MarkupStream problems

2010-09-18 Thread Juergen Donnerstag
The javadoc for Component.getMarkup() and MarkupContainer.getMarkup(Component child) might give you a hint. Unfortunately I have very little time this weekend. In general, instead of setting the markup, components shall subclass getMarkup() or getMarkup(Component) and provide the markup. Compared

Re: remove AbstractResource#isCacheable - do you agree?

2010-09-11 Thread Juergen Donnerstag
I do -Juergen On Sat, Sep 11, 2010 at 11:34 AM, Peter Ertl pe...@gmx.org wrote: Hi wicket devs, in 1.5... I would to remove AbstractResource#isCacheable() and give AbstractResource#getCacheDuration() the meaning  0  = no caching   0 = duration in milliseconds for caching This would

Re: [vote] release wicket 1.4.11

2010-09-07 Thread Juergen Donnerstag
+1 Juergen

testRenderClientSideImageMapPage fails (1.5)

2010-08-28 Thread Juergen Donnerstag
Hi, I think I recently saw a change to image maps. On my machine the junit testRenderClientSideImageMapPage_1() fails. Compared to before the change, the locale is added to URL. was: img wicket:id=image src=../resource/org.apache.wicket.markup.html.image.ImageTest/Beer.gif usemap=#map1/ now:

Re: testRenderClientSideImageMapPage fails (1.5)

2010-08-28 Thread Juergen Donnerstag
I know, but is that change by purpose? What if the locale changes before the next request. With the current implementation the German image is retrieved, ignoring a possible locale change. -Juergen

Re: svn commit: r985696 - in /wicket/trunk: wicket-examples/src/main/java/org/apache/wicket/examples/hellobrowser/ wicket-request/src/main/java/org/apache/wicket/request/ wicket/src/main/java/org/apac

2010-08-15 Thread Juergen Donnerstag
ClientInfo and newBrowserInfoPage have been added to Session though they are web related. IMO they belong into WebSession. -Juergen On Sun, Aug 15, 2010 at 5:57 PM, mgrigo...@apache.org wrote: Author: mgrigorov Date: Sun Aug 15 15:57:41 2010 New Revision: 985696 URL:

Re: [vote] release wicket 1.4.10

2010-08-09 Thread Juergen Donnerstag
+1 - release Juergen

Re: [vote] release wicket 1.5-M1

2010-08-09 Thread Juergen Donnerstag
+1 - release Juergen

Re: svn commit: r981169 - in /wicket/trunk: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/ wicket-extensions/src/main/java/org/apache/wicket/extensions/aj

2010-08-01 Thread Juergen Donnerstag
fixed it and added a test case. Tested it against a quickstart. It should now be ok. Could you please check. Thanks Juergen On Sun, Aug 1, 2010 at 3:37 PM, Martin Grigorov mgrigo...@apache.org wrote: Still there is something wrong with WicketFilter. I have a simple application with mapping to

Re: svn commit: r981169 - in /wicket/trunk: wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/ wicket-extensions/src/main/java/org/apache/wicket/extensions/aj

2010-08-01 Thread Juergen Donnerstag
/testCheckRedirect_1/ On Sun, Aug 1, 2010 at 6:36 PM, Martin Grigorov mgrigo...@apache.orgwrote: The regression is fixed. Thanks On Sun, Aug 1, 2010 at 6:24 PM, Juergen Donnerstag juergen.donners...@gmail.com wrote: fixed it and added a test case. Tested it against a quickstart. It should now be ok

Re: Consistent ue of generics etc in Wicket

2010-07-26 Thread Juergen Donnerstag
In 1.5 (which is trunk) everything can be changed/improved. 1.4 is a drop-in replacement for 1.3 - no changes to the API - except for adding generics. 1.4 is recommended for production. Juergen On Mon, Jul 26, 2010 at 11:08 AM, Erich W Schreiner eschrei...@yahoo.com wrote: Dear Wicket team,

Re: Please apply patch of WICKET-1974

2010-07-25 Thread Juergen Donnerstag
I'll do. I'd also like to add a testcase. Could you please provide one. Thanks. Juergen On Sun, Jul 25, 2010 at 9:19 PM, Erik van Oosten e.vanoos...@grons.nl wrote: Hello, Could anyone apply the patch in WICKET-1974? Even though its been there for some time, it is still relevant. Thanks

Re: wicket 1.4.6 released

2010-02-11 Thread Juergen Donnerstag
please see https://issues.apache.org/jira/browse/WICKET-1292 Juergen On Thu, Feb 11, 2010 at 4:41 PM, rball2 roger.b...@creoss.com wrote: Does this fix the issue in thread JIRA WICKET-1292 fix ? igor.vaynberg wrote: Wicket 1.4.6 is released! This is the sixths maintenance release of

Re: Ajax request bug?

2010-01-27 Thread Juergen Donnerstag
I understand the explanation why it is like it is, but I can imagine this question will be raised again, since at first the request returns an error, that is reported by various dev tools and that triggers some uncertainties in every developers mind. In order to give devs the correct feeling

Re: [vote] release wicket 1.4.6

2010-01-26 Thread Juergen Donnerstag
+1 - release Juergen

devutils write protected?

2009-12-28 Thread Juergen Donnerstag
Hi, it seems as if devutils is write protected. Any idea why? Anyone able to remove that protection? -Juergen

Re: Ideas for 1.5

2009-12-24 Thread Juergen Donnerstag
Hi Marat, 1. org.apache.wicket.util.upload looks like a copypasted contents of commons-fileupload. Why not just depend on commons-fileupload? Because it is just a little bit of source code we decided for copying it and against adding a dependency to wicket core. We tried to keep the number of

Re: [vote] release wicket 1.4.5

2009-12-16 Thread Juergen Donnerstag
+1 Juergen

  1   2   >