Hello All,
While reviewing WICKET-6544 Martin propose to use JS library for this task
Here are some examples:
https://github.com/pieroxy/java-user-agent-detection or
https://github.com/HaraldWalker/user-agent-utils
WDYT
--
WBR
Maxim aka solomax
ses -> last release
from september 2017...
- Ursprüngliche Mail -
> Von: "Maxim Solodovnik"
> An: dev@wicket.apache.org
> Gesendet: Mittwoch, 28. März 2018 18:04:03
> Betreff: [DISCUSSION] WICKET-6544 mobile browser detection
> Hello All,
>
> While reviewing
y/java-user-agent-detection/releases -> last release
> from september 2017...
>
>
> - Ursprüngliche Mail -
>> Von: "Maxim Solodovnik"
>> An: dev@wicket.apache.org
>> Gesendet: Mittwoch, 28. März 2018 18:04:03
>> Betreff: [DISCUSSION] WICKET-654
; this is EOL, guess why...
https://github.com/pieroxy/java-user-agent-detection/releases -> last release
from september 2017...
- Ursprüngliche Mail -
Von: "Maxim Solodovnik"
An: dev@wicket.apache.org
Gesendet: Mittwoch, 28. März 2018 18:04:03
Betreff: [DISCUSSION]
t;>> https://github.com/HaraldWalker/user-agent-utils -> this is EOL, guess
>>> why...
>>> https://github.com/pieroxy/java-user-agent-detection/releases -> last
>>> release from september 2017...
>>>
>>>
>>> - Ursprüngliche Mail -
>>>&
r 2017...
>
>
Sep 2017 is like yesterday
>
> - Ursprüngliche Mail -
> > Von: "Maxim Solodovnik"
> > An: dev@wicket.apache.org
> > Gesendet: Mittwoch, 28. März 2018 18:04:03
> > Betreff: [DISCUSSION] WICKET-6544 mobile browser detection
>
> >
- Ursprüngliche Mail -
>> even in 2009 it was considered bad: https://www.sitepoint.com/why-
>> browser-sniffing-stinks/
>> and in case that is not enough, read what the guy that invented modernizr
>> has to say:
>> http://farukat.es/journal/2011/02/499-lest-we-forget-or-
>> how-i-learned
"you would use feature detection" - unfortunately it doesn't work
Good real-life example is WebRtc: you can check it is supported,
then you need to know which browser your client is using (Plan A,
Plan B, Universal, "Safari way")
Another example wmode for , FF acts differently,
so I really m
It's perfectly fine to use whatever tool gets the job done. People say how to
do it instead, but no one has to follow the advice.
IMHO it's something different for a framework to offer an API on top of a
something that doesn't even work reliably:
Wicket's browser detection is using regex-matchin
BTW I'd rather keep the current solution as it is and discuss releasing Wicket
8 :)
Sven
Am 29. März 2018 07:49:02 MESZ schrieb Sven Meier :
>It's perfectly fine to use whatever tool gets the job done. People say
>how to do it instead, but no one has to follow the advice.
>
>IMHO it's something
Should I close my PR and start new discussion? :))
On Thu, Mar 29, 2018 at 12:52 PM, Sven Meier wrote:
> BTW I'd rather keep the current solution as it is and discuss releasing
> Wicket 8 :)
>
> Sven
>
> Am 29. März 2018 07:49:02 MESZ schrieb Sven Meier :
>>It's perfectly fine to use whatever to
Let's keep this topics separate.
Any improvements to browser detection would be backwards compatible, right?
Sven
Am 29. März 2018 11:10:55 MESZ schrieb Maxim Solodovnik :
>Should I close my PR and start new discussion? :))
>
>On Thu, Mar 29, 2018 at 12:52 PM, Sven Meier wrote:
>> BTW I'd rathe
All tests are passed
So I believe so
WBR, Maxim
(from mobile, sorry for the typos)
On Thu, Mar 29, 2018, 20:55 Sven Meier wrote:
> Let's keep this topics separate.
>
> Any improvements to browser detection would be backwards compatible, right?
>
> Sven
>
> Am 29. März 2018 11:10:55 MESZ schrieb
I'll better double-check
Tests were slightly changed.
WBR, Maxim
(from mobile, sorry for the typos)
On Thu, Mar 29, 2018, 20:59 Maxim Solodovnik wrote:
> All tests are passed
> So I believe so
>
> WBR, Maxim
> (from mobile, sorry for the typos)
>
> On Thu, Mar 29, 2018, 20:55 Sven Meier wrote:
Just have checked
All previous tests works as before
On Thu, Mar 29, 2018 at 9:01 PM, Maxim Solodovnik wrote:
> I'll better double-check
> Tests were slightly changed.
>
> WBR, Maxim
> (from mobile, sorry for the typos)
>
> On Thu, Mar 29, 2018, 20:59 Maxim Solodovnik wrote:
>>
>> All tests are
On Thu, Mar 29, 2018 at 1:31 AM, Korbinian Bachl <
korbinian.ba...@whiskyworld.de> wrote:
>
>
> - Ursprüngliche Mail -
> >> even in 2009 it was considered bad: https://www.sitepoint.com/why-
> >> browser-sniffing-stinks/
> >> and in case that is not enough, read what the guy that invented
It seems the discussion is spread between this thread and the JIRA
https://issues.apache.org/jira/browse/WICKET-6544?focusedCommentId=16423835&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16423835
As far as I can see we don't have consensus if this feature should
+1 for 2) from me
Martin Grigorov
Wicket Training and Consulting
Looking for a remote position with Wicket ? Contact me!
https://twitter.com/mtgrigorov
On Tue, Apr 3, 2018 at 5:34 PM, Maxim Solodovnik
wrote:
> It seems the discussion is spread between this thread and the JIRA
> https://issues.
+0 for dropping agent detection (3)
-1 for adding a dependency to an external library
Sven
Am 3. April 2018 16:34:15 MESZ schrieb Maxim Solodovnik :
>It seems the discussion is spread between this thread and the JIRA
>https://issues.apache.org/jira/browse/WICKET-6544?focusedCommentId=16423835&pag
-1 for dropping agent detection
+1 for adding a dependency to an external library (because of the big pool of
browsers - which might increase in future)
kind regards
Tobias
> Am 05.04.2018 um 13:44 schrieb Sven Meier :
>
> +0 for dropping agent detection (3)
> -1 for adding a dependency to an
This topic is more active than the release one :)
On Thu, Apr 5, 2018 at 7:22 PM, Tobias Soloschenko
wrote:
> -1 for dropping agent detection
> +1 for adding a dependency to an external library (because of the big pool of
> browsers - which might increase in future)
>
> kind regards
>
> Tobias
>
bike shed :P
Sven
Am 09.04.2018 um 18:12 schrieb Maxim Solodovnik:
This topic is more active than the release one :)
On Thu, Apr 5, 2018 at 7:22 PM, Tobias Soloschenko
wrote:
-1 for dropping agent detection
+1 for adding a dependency to an external library (because of the big pool of
brows
:-D
kind regards
Tobias
> Am 09.04.2018 um 19:14 schrieb Sven Meier :
>
> bike shed :P
>
> Sven
>
>
>> Am 09.04.2018 um 18:12 schrieb Maxim Solodovnik:
>> This topic is more active than the release one :)
>>
>> On Thu, Apr 5, 2018 at 7:22 PM, Tobias Soloschenko
>> wrote:
>>> -1 for droppin
Is it time to resume this discussion?
We still have PR unmerged, and don't have agreement what to do next :(
On Tue, Apr 10, 2018 at 3:08 AM Tobias Soloschenko <
tobiassolosche...@googlemail.com> wrote:
> :-D
>
> kind regards
>
> Tobias
>
> > Am 09.04.2018 um 19:14 schrieb Sven Meier :
> >
> > bi
I think we should turn off the gatherExtendedBrowserInformation by default and
give a hint that there is a synchronisation point of 0,011 ms when turned on,
but the detection is much more reliable with the new implementation.
kind regards
Tobias
> Am 22.06.2018 um 11:49 schrieb Maxim Solodovni
Hi,
my stance hasn't changed:
I'm not in favor to add a dependency to a library which
- updates frequently to adjust to browser developments
- introduces a singleton bottleneck
- can't be excluded from dependencies
- is hidden behind an age-old API Wicket API (UserAgent) ...
- ... which won't b
Then maybe we should deprecate the user agent related code in Wicket 8/9
and drop it later ?
... and show the users how they can use 3rd party libs like this one for
such needs.
On Sat, Jun 23, 2018 at 3:57 PM Sven Meier wrote:
> Hi,
>
> my stance hasn't changed:
>
> I'm not in favor to add a de
+1 for deprecating
On Sat, Jun 23, 2018 at 8:07 PM Martin Grigorov
wrote:
> Then maybe we should deprecate the user agent related code in Wicket 8/9
> and drop it later ?
> ... and show the users how they can use 3rd party libs like this one for
> such needs.
>
> On Sat, Jun 23, 2018 at 3:57 PM
okay no problem - lets set it to deprecated.
+1
kind regards
Tobias
> Am 23.06.2018 um 18:11 schrieb Maxim Solodovnik :
>
> +1 for deprecating
>
> On Sat, Jun 23, 2018 at 8:07 PM Martin Grigorov
> wrote:
>
>> Then maybe we should deprecate the user agent related code in Wicket 8/9
>> and dr
+1 remove it
Martijn
On Sat, Jun 23, 2018 at 3:07 PM Martin Grigorov wrote:
>
> Then maybe we should deprecate the user agent related code in Wicket 8/9
> and drop it later ?
> ... and show the users how they can use 3rd party libs like this one for
> such needs.
>
> On Sat, Jun 23, 2018 at 3:57
30 matches
Mail list logo
