Hi Asela,
Applied patches , Committed revision 206380, please send pull request to
4.3.0 git repo too.
Thanks,
Shameera.
On Wed, Aug 6, 2014 at 7:45 PM, Afkham Azeez wrote:
> Here is the new patch with eviction made a private package, and also
> removing API additions in CacheImpl. Asela, we
On Wed, Aug 6, 2014 at 5:35 PM, Shameera Rathnayaka
wrote:
> Hi Azeez,
>
> On Wed, Aug 6, 2014 at 5:11 PM, Afkham Azeez wrote:
>
>> Yes, ideally we should have exported only javax.cache.*. However, I think
>> one of Asela's patch has a coupling to CacheImpl since caching API does not
>> provide
Hi Azeez,
On Wed, Aug 6, 2014 at 5:11 PM, Afkham Azeez wrote:
> Yes, ideally we should have exported only javax.cache.*. However, I think
> one of Asela's patch has a coupling to CacheImpl since caching API does not
> provide a way to set the cache capacity. However, there are no API changes
> i
Yes, ideally we should have exported only javax.cache.*. However, I think
one of Asela's patch has a coupling to CacheImpl since caching API does not
provide a way to set the cache capacity. However, there are no API changes
in CacheImpl. The only API changes are in
the org.wso2.carbon.caching.impl
Hi Azeez,
Saw that "org.wso2.carbon.caching.impl.*, " is there under export packages,
should this expose the latest API addition to the outside at runtime?. My
understand is this can be an issue in future. WDYT? if this is the only
way to patch this, isn't it better we make all new API private t
There are API changes within java.cache, but all of those changes affect
only that bundle, and are internal to that bundle, and don't affect the
bundles outside it. Hence, there is no issue in committing the caching fix.
On Wed, Aug 6, 2014 at 2:28 PM, Asela Pathberiya wrote:
> Hi Shameera,
>
>
Hi Shameera,
There is no any API in user core patch... We have only added a
private method. As i got to know, It is not allowed to add even
private method. Therefore i modified the code and attached the patch
in to the jira.
AFAIK, there is no any caching API changes in caching.core as well..
Hi Asela,
As we discussed, it is not allowed to do any API changes to 4.2.0 patches.
So please reattached the patch removing all API changes. And the already
attached patch can be applied to 4.3.0 git repo. So please send those as
pull request.
Thanks,
Shameera.
On Wed, Aug 6, 2014 at 1:02 PM,
Hi All,
Please commit following
https://wso2.org/jira/browse/CARBON-14891
https://wso2.org/jira/browse/CARBON-14905
Thanks,
Asela.
--
Thanks & Regards,
Asela
ATL
Mobile : +94 777 625 933
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mail
