[Dev] Review and merge PR

2018-11-06 Thread Rukshan Premathunga
Hi All, Can you please review and merge following PR[1]. [1] https://github.com/wso2/carbon-business-messaging/pull/660 Thanks and Regards -- Rukshan Chathuranga. WSO2, Inc. +94711822074 ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailma

[Dev] Review and merge following PRs

2018-11-05 Thread Rukshan Premathunga
Hi All, Can you please review and merge the following PRs. Which contain 3rd party dependency upgrade fixes including solr and lucence. [1] https://github.com/wso2/carbon-registry/pull/292 [2] https://github.com/wso2/carbon-governance/pull/315 Thanks and Regards -- Rukshan Chathuranga. WSO2, I

Re: [Dev] Review and merge PR for reading conf folder path by carbon

2018-03-13 Thread SajithAR Ariyarathna
PR is merged. Fix will be available in carbon-analytics v1.3.22 version. Thanks. On Tue, Mar 13, 2018 at 7:56 PM, Lasantha Dharmakeerthi wrote: > Hi all, > > Spark Analytics Executor read the conf folder path as following way. Since > IoT server has changed the folder structure it is causing an

[Dev] Review and merge PR for reading conf folder path by carbon

2018-03-13 Thread Lasantha Dharmakeerthi
Hi all, Spark Analytics Executor read the conf folder path as following way. Since IoT server has changed the folder structure it is causing an issue. carbonConfDir = carbonHome + File.separator + "repository" + File.separator + "conf"; Therefore I think the correct way is to get the path as fol

Re: [Dev] Review and merge PR for logs required for message roundtrip analysis

2018-03-09 Thread Mushthaq Rumy
Hi Dushani, Added some comments to the carbon-apimgt PR. Please fix those. Thanks & Regards, Mushthaq On Fri, Mar 9, 2018 at 6:57 PM, Dushani Wellappili wrote: > Hi APIM team and IS team, > > Highly appreciate if you can review the two PRs [1] and [2] which include > the newly added logs which

[Dev] Review and merge PR for logs required for message roundtrip analysis

2018-03-09 Thread Dushani Wellappili
Hi APIM team and IS team, Highly appreciate if you can review the two PRs [1] and [2] which include the newly added logs which are used to identify the message hops and their latencies in each node during an API invocation in WSO2 APIM. Please refer [3] for documentation and mail thread [4] for mo

Re: [Dev] Review and Merge PR

2015-08-15 Thread Malaka Silva
Merged. Pls re-upload the connector. On Fri, Aug 14, 2015 at 4:20 PM, Sriashalya Srivathsan wrote: > Hi Malaka, > Find the pull request for Flicker below.. which is changed according to > the test failure. > > https://github.com/wso2/esb-connectors/pull/268 > > > Thanks. > -- > Regards > S.Srias

[Dev] Review and Merge PR

2015-08-14 Thread Sriashalya Srivathsan
Hi Malaka, Find the pull request for Flicker below.. which is changed according to the test failure. https://github.com/wso2/esb-connectors/pull/268 Thanks. -- Regards S.Sriashalya, WSO2 *Inc*. lean . enterprise . middleware ___ Dev mailing list Dev@w

Re: [Dev] Review and Merge PR

2015-08-12 Thread Malaka Silva
Merged Pls re upload the connector. On Thu, Aug 13, 2015 at 9:58 AM, Sriashalya Srivathsan wrote: > Hi Malaka, > Please find the PR for yelp connector changes. > > https://github.com/wso2/esb-connectors/pull/265 > > Thank you > > -- > Regards > S.Sriashalya, > WSO2 *Inc*. > lean . enterprise . m

[Dev] Review and Merge PR

2015-08-12 Thread Sriashalya Srivathsan
Hi Malaka, Please find the PR for yelp connector changes. https://github.com/wso2/esb-connectors/pull/265 Thank you -- Regards S.Sriashalya, WSO2 *Inc*. lean . enterprise . middleware ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/l

[Dev] Review and Merge the PR

2015-08-05 Thread Hasanthi Purnima Dissanayake
Hi, $subject please for [1]. [1] https://github.com/wso2/carbon-identity/pull/749/ Thanks, Hasanthi Dissanayake Software Engineer | WSO2 E: hasan...@wso2.com M :0718407133| http://wso2.com ___ Dev mailing list Dev@wso2.org http://w

[Dev] Review and Merge the PR

2015-08-04 Thread Hasanthi Purnima Dissanayake
Hi, $subject please for [1] which fixes public jira [2]. [1]https://github.com/wso2/carbon-identity/pull/739 [2]https://wso2.org/jira/browse/IDENTITY-3422 Thanks, Hasanthi Dissanayake Software Engineer | WSO2 E: hasan...@wso2.com M :0718407133| http://wso2.com __

Re: [Dev] Review and Merge PR for ESB Jira 3619

2015-07-28 Thread Malaka Silva
Merged please resolve the jira On Tue, Jul 28, 2015 at 6:20 PM, Sriashalya Srivathsan wrote: > $subject for following > https://github.com/wso2/wso2-synapse/pull/292 > > -- > Regards > S.Sriashalya, > WSO2 *Inc*. > lean . enterprise . middleware > -- Best Regards, Malaka Silva Senior Tech

[Dev] Review and Merge PR for ESB Jira 3619

2015-07-28 Thread Sriashalya Srivathsan
$subject for following https://github.com/wso2/wso2-synapse/pull/292 -- Regards S.Sriashalya, WSO2 *Inc*. lean . enterprise . middleware ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev

[Dev] Review and Merge the PR

2015-07-15 Thread Hasanthi Purnima Dissanayake
Hi, Please review and merge the PR [1] for public jira [2]. [1] https://github.com/wso2/carbon-identity/pull/623 [2] https://wso2.org/jira/browse/IDENTITY-3253 Thanks, Hasanthi Dissanayake Software Engineer | WSO2 E: hasan...@wso2.com M :0718407133| http://wso2.com

[Dev] Review and Merge the PR

2015-07-13 Thread Hasanthi Purnima Dissanayake
Hi, Please review and merge the fix [1] for public jira [2]. [1]https://github.com/wso2/product-is/pull/146 [2]https://wso2.org/jira/browse/IDENTITY-3220 Thanks, Hasanthi Dissanayake Software Engineer | WSO2 E: hasan...@wso2.com M :0718407133| http://wso2.com ___

[Dev] Review and Merge the PR

2015-07-07 Thread Hasanthi Purnima Dissanayake
Please review and merge the fix [1] for public jira [2]. [1] https://github.com/wso2/product-is/pull/142 [2] https://wso2.org/jira/browse/IDENTITY-2541 Thanks, Hasanthi Dissanayake Software Engineer | WSO2 E: hasan...@wso2.com M :0718407133| http://wso2.com _

Re: [Dev] Review and Merge PR

2015-07-07 Thread Malaka Silva
Merged On Tue, Jul 7, 2015 at 1:53 PM, Sriashalya Srivathsan wrote: > Hi Malaka, > As we discussed in the review the mandatory parameters like host name,port > and client Id are added in the axis2.xml. topic name and other optional > parameters added in the proxy. > > thank you. > > On Tue, Jul

Re: [Dev] Review and Merge PR

2015-07-07 Thread Sriashalya Srivathsan
Hi Malaka, As we discussed in the review the mandatory parameters like host name,port and client Id are added in the axis2.xml. topic name and other optional parameters added in the proxy. thank you. On Tue, Jul 7, 2015 at 1:37 PM, Sriashalya Srivathsan wrote: > Hi Malaka, > I changed the sampl

Re: [Dev] Review and Merge PR

2015-07-07 Thread Sriashalya Srivathsan
Hi Malaka, I changed the sample number in the Doc and Pull request. On Tue, Jul 7, 2015 at 1:20 PM, Malaka Silva wrote: > Sorry got the sample link. It's Sample 907 right? > > I think we can can have number 272 since 9xx is for inbound. > > On Tue, Jul 7, 2015 at 1:18 PM, Malaka Silva wrote: >

Re: [Dev] Review and Merge PR

2015-07-07 Thread Malaka Silva
Sorry got the sample link. It's Sample 907 right? I think we can can have number 272 since 9xx is for inbound. On Tue, Jul 7, 2015 at 1:18 PM, Malaka Silva wrote: > Hi Sriashalya, > > In the given sample only mqtt.connection.factory is specified. > > What about the other mandatory parameters? >

Re: [Dev] Review and Merge PR

2015-07-07 Thread Malaka Silva
Hi Sriashalya, In the given sample only mqtt.connection.factory is specified. What about the other mandatory parameters? Also what is the doc link for this sample? On Tue, Jul 7, 2015 at 12:20 PM, Sriashalya Srivathsan wrote: > Hi, > Please find the PR below > https://github.com/wso2/product-

Re: [Dev] Review and Merge PR

2015-07-06 Thread Sriashalya Srivathsan
Hi, Please find the PR below https://github.com/wso2/product-esb/pull/210 On Tue, Jul 7, 2015 at 12:18 PM, Sriashalya Srivathsan wrote: > Please $ subject for synapse_sample 907 > > Thank you. > > -- > Regards > S.Sriashalya, > WSO2 *Inc*. > lean . enterprise . middleware > -- Regards S.Sria

[Dev] Review and Merge PR

2015-07-06 Thread Sriashalya Srivathsan
Please $ subject for synapse_sample 907 Thank you. -- Regards S.Sriashalya, WSO2 *Inc*. lean . enterprise . middleware ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev

[Dev] Review and Merge PR

2015-07-01 Thread Chamalee De Silva
Please $Subject the fix [1] for Public Jira [2]. Tested and verified with shared subscriptions as well. Created Doc JIRA at [3] to update the documentation. [1] https://github.com/wso2/carbon-apimgt/pull/803 [2] https://wso2.org/jira/browse/APIMANAGER-3945 [3] https://wso2.org/jira/browse/DOCUME

Re: [Dev] Review and merge the PR

2015-06-27 Thread Malaka Silva
Merged On Sat, Jun 27, 2015 at 2:46 PM, Naasheer Ali wrote: > Hi Malaka, > > $subject for Googlecalendar connector. Please find the PR[1]. > > [1]- https://github.com/wso2/esb-connectors/pull/211 > > Regards, > -- > > *Naasheer Ali* | Associate Software Engineer > > WSO2, Inc |#218, Stanley Road

[Dev] Review and merge the PR

2015-06-27 Thread Naasheer Ali
Hi Malaka, $subject for Googlecalendar connector. Please find the PR[1]. [1]- https://github.com/wso2/esb-connectors/pull/211 Regards, -- *Naasheer Ali* | Associate Software Engineer WSO2, Inc |#218, Stanley Road, Jaffna, Sri Lanka Email: naashe...@wso2.com lean . enterprise . middleware __

[Dev] Review and merge the PR

2015-06-25 Thread Naasheer Ali
Hi Malaka, $subject for verticalresponse connector. Please find the PR[1]. [1]- https://github.com/wso2/esb-connectors/pull/202 Regards, -- *Naasheer Ali* | Associate Software Engineer WSO2, Inc |#20, Palm Grove, Colombo 03, Sri Lanka Email: naashe...@wso2.com ___

Re: [Dev] Review and Merge the PR

2015-06-24 Thread Hasanthi Purnima Dissanayake
Correcting the web address: [2] https://wso2.org/jira/browse/IDENTITY-3364 Thanks Hasanthi Dissanayake Software Engineer | WSO2 E: hasan...@wso2.com M :0718407133| http://wso2.com On Wed, Jun 24, 2015 at 5:38 PM, Hasanthi Purnima Dissanayake < hasan...@wso2.com> wrote: > H

[Dev] Review and Merge the PR

2015-06-24 Thread Hasanthi Purnima Dissanayake
Hi , This is the fix [1] for Public JIRA issue [2]. $subject please. [1] https://github.com/wso2/carbon-identity/pull/475 [2] https://wso2.org/jira/browse/IDENTITY-3364 Thanks, Hasanthi Dissanayake Software Engineer | WSO2 E: hasan...@wso2.com M :0

Re: [Dev] Review and Merge PR

2015-06-21 Thread Malaka Silva
Merged On Fri, Jun 19, 2015 at 7:22 PM, Shakila Sivagnanarajah wrote: > Hi Malaka, > > Please find the PR > > https://github.com/wso2/esb-connectors/pull/177 > > Thank you > -- > Shakila Sivagnanarajah > Associate Software Engineer > Mobile :+94 (0) 770 760240 > shak...@wso2.com > -- Best R

[Dev] Review and Merge PR

2015-06-19 Thread Shakila Sivagnanarajah
Hi Malaka, Please find the PR https://github.com/wso2/esb-connectors/pull/177 Thank you -- Shakila Sivagnanarajah Associate Software Engineer Mobile :+94 (0) 770 760240 shak...@wso2.com ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman

Re: [Dev] Review and merge PR

2015-06-19 Thread Malaka Silva
Done On Fri, Jun 19, 2015 at 5:29 PM, Naasheer Ali wrote: > Hi Malaka, > > The connector has been uploaded to store please merge the PR > > Regards, > -- > > *Naasheer Ali* | Associate Software Engineer > > WSO2, Inc |#20, Palm Grove, Colombo 03, Sri Lanka > > Email: naashe...@wso2.com > > On Fr

Re: [Dev] Review and merge PR

2015-06-19 Thread Naasheer Ali
Hi Malaka, The connector has been uploaded to store please merge the PR Regards, -- *Naasheer Ali* | Associate Software Engineer WSO2, Inc |#20, Palm Grove, Colombo 03, Sri Lanka Email: naashe...@wso2.com On Fri, Jun 19, 2015 at 3:36 PM, Malaka Silva wrote: > Once you upload I'll merge > >

Re: [Dev] Review and merge PR

2015-06-19 Thread Malaka Silva
Once you upload I'll merge https://github.com/wso2/esb-connectors/pull/167 On Fri, Jun 19, 2015 at 3:29 PM, Naasheer Ali wrote: > Hi Malaka, > > I tested after the folder change it works. I'll update to store. > > Regards, > -- > > *Naasheer Ali* | Associate Software Engineer > > WSO2, Inc |#2

Re: [Dev] Review and merge PR

2015-06-19 Thread Naasheer Ali
Hi Malaka, I tested after the folder change it works. I'll update to store. Regards, -- *Naasheer Ali* | Associate Software Engineer WSO2, Inc |#20, Palm Grove, Colombo 03, Sri Lanka Email: naashe...@wso2.com On Fri, Jun 19, 2015 at 11:35 AM, Malaka Silva wrote: > Tests ran after the struc

[Dev] Review and merge the PR

2015-06-19 Thread Naasheer Ali
Hi Malaka, $Subject for Twitter connector. Please find PR below[1]. Tested manually for some random methods. [1]- https://github.com/wso2/esb-connectors/pull/175 Regards, -- *Naasheer Ali* | Associate Software Engineer WSO2, Inc |#20, Palm Grove, Colombo 03, Sri Lanka Email: naashe...@wso2.c

Re: [Dev] Review and Merge PR

2015-06-19 Thread Malaka Silva
Merged On Fri, Jun 19, 2015 at 2:15 PM, Elilmatha Sivanesan wrote: > Hi Malaka, > > Please review and merge the PR for eventbrite and yammer. > > https://github.com/wso2/esb-connectors/pull/173 > > Thank you. > > > -- > *S.Elilmatha* > Associate

[Dev] Review and Merge PR

2015-06-19 Thread Elilmatha Sivanesan
Hi Malaka, Please review and merge the PR for eventbrite and yammer. https://github.com/wso2/esb-connectors/pull/173 Thank you. -- *S.Elilmatha* Associate Software Engineer, WSO2 Inc.; http://wso2.com lean.enterprise.middleware Mobile 077984

Re: [Dev] Review and Merge PR

2015-06-19 Thread Malaka Silva
Can we also move the folders to a proper structure with the same. On Fri, Jun 19, 2015 at 1:45 PM, Sriashalya Srivathsan wrote: > Hi Malaka, > Please $subject for nest. > > https://github.com/wso2/esb-connectors/pull/174 > > -- > Regards > S.Sriashalya, > WSO2 *Inc*. > lean . enterprise . middle

[Dev] Review and Merge PR

2015-06-19 Thread Sriashalya Srivathsan
Hi Malaka, Please $subject for nest. https://github.com/wso2/esb-connectors/pull/174 -- Regards S.Sriashalya, WSO2 *Inc*. lean . enterprise . middleware ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev

[Dev] Review and merge the PR

2015-06-19 Thread Naasheer Ali
Hi Malaka, $Subject for Youtube connector. Please find the PR below[1]. This connector has folder change and usual pom change. I've tested manually for some methods randomly. [1]- https://github.com/wso2/esb-connectors/pull/172 Regards, -- *Naasheer Ali* | Associate Software Engineer WSO2, In

Re: [Dev] Review and merge the PR

2015-06-18 Thread Malaka Silva
thx Merged On Fri, Jun 19, 2015 at 11:57 AM, Naasheer Ali wrote: > Hi Malaka, > > Previous folder structure was : > {esb-connectors}/googlecalendar/src/main.. > > After the folder structure changed(like common folder structure of > connector) the structure is : > > > {esb-connectors}/goog

Re: [Dev] Review and merge the PR

2015-06-18 Thread Naasheer Ali
Hi Malaka, Previous folder structure was : {esb-connectors}/googlecalendar/src/main.. After the folder structure changed(like common folder structure of connector) the structure is : {esb-connectors}/googlecalendar/googlecalendar-connector/googlecalendar-connector-1.0.0/org.wso2.carbon.co

Re: [Dev] Review and merge the PR

2015-06-18 Thread Malaka Silva
What exactly is the folder change. Please provide some details. On Fri, Jun 19, 2015 at 11:19 AM, Naasheer Ali wrote: > Hi Malaka. > > Yes. there is a folder structure change and I tested manually it works. > > Regards, > -- > > *Naasheer Ali* | Associate Software Engineer > > WSO2, Inc |#20, Pa

Re: [Dev] Review and merge PR

2015-06-18 Thread Malaka Silva
Tests ran after the structural change? Is the new connector is uploaded to store? On Fri, Jun 19, 2015 at 11:16 AM, Naasheer Ali wrote: > Hi Malaka, > > Yes, since the folder structure is not properly set and I've tested some > methods randomly it works. > > Regards, > -- > > *Naasheer Ali* | A

Re: [Dev] Review and merge the PR

2015-06-18 Thread Naasheer Ali
Hi Malaka. Yes. there is a folder structure change and I tested manually it works. Regards, -- *Naasheer Ali* | Associate Software Engineer WSO2, Inc |#20, Palm Grove, Colombo 03, Sri Lanka Email: naashe...@wso2.com On Fri, Jun 19, 2015 at 11:14 AM, Malaka Silva wrote: > Why there is a fol

Re: [Dev] Review and merge PR

2015-06-18 Thread Naasheer Ali
Hi Malaka, Yes, since the folder structure is not properly set and I've tested some methods randomly it works. Regards, -- *Naasheer Ali* | Associate Software Engineer WSO2, Inc |#20, Palm Grove, Colombo 03, Sri Lanka Email: naashe...@wso2.com On Fri, Jun 19, 2015 at 11:13 AM, Malaka Silva

Re: [Dev] Review and merge the PR

2015-06-18 Thread Malaka Silva
Why there is a folder structure change? On Thu, Jun 18, 2015 at 6:18 PM, Naasheer Ali wrote: > Hi Malaka, > > $Subject for Jira connector. Please fine the PR below[1]. > > [1] - https://github.com/wso2/esb-connectors/pull/168 > > Regards, > -- > > *Naasheer Ali* | Associate Software Engineer > >

Re: [Dev] Review and merge PR

2015-06-18 Thread Malaka Silva
Did you change the folder structure? On Thu, Jun 18, 2015 at 5:35 PM, Naasheer Ali wrote: > Hi Malaka, > > $Subject for Google Calendar connector. Please find the PR below[1]. > > [1]- https://github.com/wso2/esb-connectors/pull/167 > > Regards, > -- > > *Naasheer Ali* | Associate Software Engin

[Dev] Review and merge the PR

2015-06-18 Thread Naasheer Ali
Hi Malaka, $Subject for Jira connector. Please fine the PR below[1]. [1] - https://github.com/wso2/esb-connectors/pull/168 Regards, -- *Naasheer Ali* | Associate Software Engineer WSO2, Inc |#20, Palm Grove, Colombo 03, Sri Lanka Email: naashe...@wso2.com

[Dev] Review and merge PR

2015-06-18 Thread Naasheer Ali
Hi Malaka, $Subject for Google Calendar connector. Please find the PR below[1]. [1]- https://github.com/wso2/esb-connectors/pull/167 Regards, -- *Naasheer Ali* | Associate Software Engineer WSO2, Inc |#20, Palm Grove, Colombo 03, Sri Lanka Email: naashe...@wso2.com __

Re: [Dev] Review and merge the PR for Shippo connector

2015-06-18 Thread Naasheer Ali
Hi Malaka, I have removed the certificate and added the default Keystore and Truststore since those were empty. Regards, -- *Naasheer Ali* | Associate Software Engineer WSO2, Inc |#20, Palm Grove, Colombo 03, Sri Lanka Email: naashe...@wso2.com On Thu, Jun 18, 2015 at 4:51 PM, Malaka Silva

Re: [Dev] Review and merge the PR for Shippo connector

2015-06-18 Thread Malaka Silva
Please remove the certificate, Keystore and Truststore On Thu, Jun 18, 2015 at 11:56 AM, Naasheer Ali wrote: > Hi Malaka, > > Please find the PR for shippo connector[1]. > > [1]- https://github.com/wso2/esb-connectors/pull/162 > > Regards, > -- > > *Naasheer Ali* | Associate Software Engineer >

[Dev] " Review and merge PR"

2015-06-18 Thread Sriashalya Srivathsan
Hi Malaka, Please find the following PR for Redmine https://github.com/wso2/esb-connectors/pull/164 -- Regards S.Sriashalya, WSO2 *Inc*. lean . enterprise . middleware ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev

[Dev] Review and merge the PR for Shippo connector

2015-06-17 Thread Naasheer Ali
Hi Malaka, Please find the PR for shippo connector[1]. [1]- https://github.com/wso2/esb-connectors/pull/162 Regards, -- *Naasheer Ali* | Associate Software Engineer WSO2, Inc |#20, Palm Grove, Colombo 03, Sri Lanka Email: naashe...@wso2.com ___ Dev

Re: [Dev] Review and merge for ESBJAVA-3766 and ESBJAVA-3733

2015-06-12 Thread Maheeka Jayasuriya
Correction : ESBJAVA-3766 and ESBJAVA-3773 Maheeka Jayasuriya Software Engineer Mobile : +9450661 On Fri, Jun 12, 2015 at 4:51 PM, Maheeka Jayasuriya wrote: > Hi, > > $subject please. > > [2] also contains serialization tests. > > [1] https://github.com/wso2/carbon-mediation/pull/214 > [2]

[Dev] Review and merge for ESBJAVA-3766 and ESBJAVA-3733

2015-06-12 Thread Maheeka Jayasuriya
Hi, $subject please. [2] also contains serialization tests. [1] https://github.com/wso2/carbon-mediation/pull/214 [2] https://github.com/wso2/wso2-synapse/pull/228 Thanks, Maheeka Jayasuriya Software Engineer Mobile : +9450661 ___ Dev mailing lis

Re: [Dev] Review and merge JSON Parser in Jaggery

2015-06-08 Thread Ruchira Wageesha
Done. /Ruchira On Mon, Jun 8, 2015 at 4:41 PM, Charitha Goonetilleke wrote: > Hi, > > Please review and merge fix[1] for integer parsing issue in Jaggery HTTP > client. > > [1]https://github.com/wso2/jaggery/pull/123 > > Thanks, > /charithag > > -- > *Charitha Goonetilleke* > Software Engineer

[Dev] Review and merge JSON Parser in Jaggery

2015-06-08 Thread Charitha Goonetilleke
Hi, Please review and merge fix[1] for integer parsing issue in Jaggery HTTP client. [1]https://github.com/wso2/jaggery/pull/123 Thanks, /charithag -- *Charitha Goonetilleke* Software Engineer WSO2 Inc.; http://wso2.com lean.enterprise.middleware mobile: +94 77 751 3669 <%2B94777513669> Twitt

Re: [Dev] Review and merge PR for integration test

2015-06-08 Thread Kalpa Welivitigoda
Thanks Malaka. On Mon, Jun 8, 2015 at 3:55 PM, Malaka Silva wrote: > Merged > > On Mon, Jun 8, 2015 at 1:59 PM, Kalpa Welivitigoda > wrote: > >> Hi ESB team, >> >> Please review and merge the integration test [1] for [2]. >> >> [1] https://github.com/wso2/product-esb/pull/181 >> [2] https://wso

Re: [Dev] Review and merge PR for integration test

2015-06-08 Thread Malaka Silva
Merged On Mon, Jun 8, 2015 at 1:59 PM, Kalpa Welivitigoda wrote: > Hi ESB team, > > Please review and merge the integration test [1] for [2]. > > [1] https://github.com/wso2/product-esb/pull/181 > [2] https://wso2.org/jira/browse/CARBON-15119 > > -- > Best Regards, > > Kalpa Welivitigoda > Softw

[Dev] Review and merge PR for integration test

2015-06-08 Thread Kalpa Welivitigoda
Hi ESB team, Please review and merge the integration test [1] for [2]. [1] https://github.com/wso2/product-esb/pull/181 [2] https://wso2.org/jira/browse/CARBON-15119 -- Best Regards, Kalpa Welivitigoda Software Engineer, WSO2 Inc. http://wso2.com Email: kal...@wso2.com Mobile: +94776509215 ___

[Dev] Review and merge PR for APIMANAGER-3663

2015-05-28 Thread Kasun Gunasekara
Hi, Please review and merge PR [1] for Jira [2] [1] https://github.com/wso2/carbon-apimgt/pull/529 [2] https://wso2.org/jira/browse/APIMANAGER-3663 Regards. Kasun Gunasekara Software Engineering Intern - WSO2 Mobile : +94 77 6986482 Twitter | Google+

[Dev] Review and Merge PR

2015-05-27 Thread Shiva Balachandran
Hi, Please review and merge PR[1] for JIRA[2]. [1] - https://github.com/wso2/carbon-business-process/pull/58 [2] - https://wso2.org/jira/browse/BPS-656 Thank you. Regards, -- Shiva Balachandran Software Engineer WSO2 Inc. Mobile - +94 774445788 Blog - https://shivabalachandran.wordpress.com/

Re: [Dev] Review and Merge PR

2015-05-27 Thread Shiva Balachandran
On Wed, May 27, 2015 at 5:10 PM, Shiva Balachandran wrote: > Hi, > > Please review and merge PR[1] for JIRA[2]. > > [1] - https://github.com/wso2/carbon-business-process/pull/58 > [2] - https://wso2.org/jira/browse/BPS-656 > > > Thank you. > > Regards, > -- > Shiva Balachandran > Software Enginee

[Dev] Review and Merge the PRs

2015-05-20 Thread Chamalee De Silva
Hi, The JIRA issue [1] is fixed. The PRs for carbon-apimgt and product-apim are in [2] and [3] respectively. Please $Subject. [1]https://wso2.org/jira/browse/APIMANAGER-2854 [2] https://github.com/wso2/carbon-apimgt/pull/445 [3] https://github.com/wso2/product-apim/pull/175 -- Thanks & Regar

Re: [Dev] Review and merge PR APIMANAGER-3550

2015-05-19 Thread Abimaran Kugathasan
Then fine. I haven't tested this. On Tue, May 19, 2015 at 12:19 PM, Kasun Gunasekara wrote: > "Block" is un-clickable in API Publisher when a subscription is in ON_HOLD > state. So the subscription is only allowed to be blocked if approved by the > admin-workflow. If rejected it'll be disappeare

Re: [Dev] Review and merge PR APIMANAGER-3550

2015-05-18 Thread Kasun Gunasekara
"Block" is un-clickable in API Publisher when a subscription is in ON_HOLD state. So the subscription is only allowed to be blocked if approved by the admin-workflow. If rejected it'll be disappeared from the publisher. Kasun Gunasekara Software Engineering Intern - WSO2 Mobile : +94 77 6986482 T

Re: [Dev] Review and merge PR APIMANAGER-3550

2015-05-18 Thread Abimaran Kugathasan
OK, What if ON_HOLD subscription was blocked through API Publisher before it get approved via admin-workflow? Even it's blocked, I guess, admin can approve or reject the subscription. That will be the staus of the subscription. Depends on the order of execution whether admin-workflow or API publis

Re: [Dev] Review and merge PR APIMANAGER-3550

2015-05-18 Thread Kasun Gunasekara
Hi Abimaran, I noticed that earlier. But ON_HOLD status is already handled in API Publisher using a tip saying that the subscription is pending for approval. Does it still has to be removed? If yes I will do the necessary changes. Kasun Gunasekara Software Engineering Intern - WSO2 Mobile : +94

Re: [Dev] Review and merge PR APIMANAGER-3550

2015-05-18 Thread Abimaran Kugathasan
Hi Kasun, Following are status' of API subscription public static class SubscriptionStatus { public static final String BLOCKED = "BLOCKED"; public static final String PROD_ONLY_BLOCKED = "PROD_ONLY_BLOCKED"; public static final String UNBLOCKED = "UNBLOCKED"; public static final

Re: [Dev] Review and merge PR APIMANAGER-3550

2015-05-15 Thread Kasun Gunasekara
Hi Abimaran, I had some misunderstanding about the issue and the earlier PR was for the API Store. Did revert the earlier commit and updated the PR with relevant changes to the API Publisher. Please review and merge PR[1] [1] https://github.com/wso2/carbon-apimgt/pull/383 Kasun Gunasekara Sof

Re: [Dev] Review and merge PR APIMANAGER-3550

2015-05-15 Thread Abimaran Kugathasan
Hi Kasun, What is the status of this issue? On Wed, May 13, 2015 at 4:55 PM, Kasun Gunasekara wrote: > Hi Abimaran, > > I checked on this and found out that API Provider's Subscriptions page > uses getAllAPIUsageByProvider() to load subscriptions and I have only > changed getPaginatedSubscribed

Re: [Dev] Review and merge PR APIMANAGER-3550

2015-05-13 Thread Kasun Gunasekara
Hi Abimaran, I checked on this and found out that API Provider's Subscriptions page uses getAllAPIUsageByProvider() to load subscriptions and I have only changed getPaginatedSubscribedAPIs() which is used by API Store. This change doesn't affect API Provider as far as I understand. Kasun Gunase

Re: [Dev] Review and merge PR APIMANAGER-3550

2015-05-13 Thread Abimaran Kugathasan
Hi Kasun, In the Subscription page of the API Publisher, We have to show, BLOCKED, UNBLOCKED API Subscription. But, with this pull request, you made changes to list on the UNBLOCKED API Subscription. It we don't show the BLOCKED API Subscription, we won't be able to unblock them through the publi

[Dev] Review and merge PR APIMANAGER-3550

2015-05-13 Thread Kasun Gunasekara
Hi, Please review and merge PR [1] for jira [2]. [1] https://github.com/wso2/carbon-apimgt/pull/383 [2] https://wso2.org/jira/browse/APIMANAGER-3550 Regards. Kasun Gunasekara Software Engineering Intern - WSO2 Mobile : +94 77 6986482 Twitter | Google+

[Dev] Review and merge the pull request

2015-05-05 Thread Vinod Kavinda
Hi, Please $subject [1] for the Jira [2]. [1] - https://github.com/wso2/carbon-business-process/pull/41 [2] - https://wso2.org/jira/browse/BPS-470 -- Vinod Kavinda Software Engineer, *WSO2, Inc .* Mobile : +94 (0) 712 415544 vi...@wso2.com _

[Dev] Review and merge

2015-04-24 Thread Damith Senanayake
Hi, A fix for https://wso2.org/jira/browse/IDENTITY-3105 is available at https://github.com/wso2/carbon-commons/pull/81. Please review and merge the request. -- *-Damith Senanayake-* +94712205272 ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bi

[Dev] Review and merge

2015-04-17 Thread Godwin Amila Shrimal
Hi Please review and merge the PR[1] [1] https://github.com/wso2/carbon-identity/pull/203 Thanks Godwin -- *Godwin Amila Shrimal* Senior Software Engineer WSO2 Inc.; http://wso2.com lean.enterprise.middleware mobile: *+94772264165* linkedin: *http://lnkd.in/KUum6D * tw

Re: [Dev] Review and merge

2015-03-08 Thread Abimaran Kugathasan
Hi Madusanka, It's merged. On Mon, Mar 9, 2015 at 9:57 AM, Madusanka Premaratne wrote: > Hi Abimaran, > Please $subject for the PR[1] for the issue[2] > [1] - https://github.com/wso2/carbon-apimgt/pull/54/ > [2] - https://wso2.org/jira/browse/APIMANAGER-3281 > > ​Thanks,​ > > -- > *Madusanka Pr

[Dev] Review and merge

2015-03-08 Thread Madusanka Premaratne
Hi Abimaran, Please $subject for the PR[1] for the issue[2] [1] - https://github.com/wso2/carbon-apimgt/pull/54/ [2] - https://wso2.org/jira/browse/APIMANAGER-3281 ​Thanks,​ -- *Madusanka Premaratne* | Associate Software Engineer WSO2, Inc | lean. enterprise. middleware. #20, Palm Grove, Colombo

Re: [Dev] Review and merge the PR for WSAS-1907

2015-03-05 Thread Supun Malinga
Merged the PR. thanks, On Thu, Mar 5, 2015 at 12:26 PM, Shashika Karunatilaka wrote: > Hi Supun > > Updated the PR[1] accordingly > > [1] https://github.com/wso2/product-as/pull/49 > > On Wed, Mar 4, 2015 at 8:02 PM, Supun Malinga wrote: > >> Hi Shashika, >> >> Let's add the features into defa

Re: [Dev] Review and merge the PR for WSAS-1907

2015-03-04 Thread Shashika Karunatilaka
Hi Supun Updated the PR[1] accordingly [1] https://github.com/wso2/product-as/pull/49 On Wed, Mar 4, 2015 at 8:02 PM, Supun Malinga wrote: > Hi Shashika, > > Let's add the features into default and worker profile as well.. > > thanks, > > On Wed, Mar 4, 2015 at 5:03 PM, Shashika Karunatilaka

Re: [Dev] Review and merge the PR for WSAS-1907

2015-03-04 Thread Supun Malinga
Hi Shashika, Let's add the features into default and worker profile as well.. thanks, On Wed, Mar 4, 2015 at 5:03 PM, Shashika Karunatilaka wrote: > Hi, > > Please review and merge the PR [1] for [2]. > > [1] https://github.com/wso2/product-as/pull/49 > [2] https://wso2.org/jira/browse/WSAS-19

[Dev] Review and merge the PR for WSAS-1907

2015-03-04 Thread Shashika Karunatilaka
Hi, Please review and merge the PR [1] for [2]. [1] https://github.com/wso2/product-as/pull/49 [2] https://wso2.org/jira/browse/WSAS-1907 -- Shashika Prabath Karunatilaka, Software Engineer, WSO2, Inc: http://wso2.com/ mobile : +94 77 7487792 ___ Dev

[Dev] Review and merge the PR for IDENTITY-2036

2015-03-04 Thread Lasitha Wattaladeniya
Hi team, $subject please for Jira [1]. PR [2]. [1]. https://wso2.org/jira/browse/IDENTITY-2036 [2]. https://github.com/wso2/carbon-identity/pull/121 Thanks. -- Lasitha Wattaladeniya Software Engineer WSO2, Inc. | http://wso2.com lean. enterprise. middleware Mobile : +94719397528 Blog : techr

[Dev] Review and merge the PR for CARBON-15119

2015-03-03 Thread Kalpa Welivitigoda
Hi Carbon team, Please review and merge the PR [1] for [2]. [1] https://github.com/wso2/wso2-axis2/pull/26 [2] https://wso2.org/jira/browse/CARBON-15119 -- Best Regards, Kalpa Welivitigoda Software Engineer, WSO2 Inc. http://wso2.com Email: kal...@wso2.com Mobile: +94776509215

Re: [Dev] - Review and merge the pull request - Removed duplicated dependencies in product -greg 5.0.0-SNAPSHOT pom file

2015-01-10 Thread Pulasthi Supun
Hi, Done, Regards, Pulasthi On Sat, Jan 10, 2015 at 7:16 PM, Prasanna Dangalla wrote: > Hi, > > Please merge the pull request [1]. > JIRA - https://wso2.org/jira/browse/REGISTRY-2376 > > [1] - https://github.com/wso2-dev/product-greg/pull/61 > > Thanks > -- > Prasanna Dangalla > Software Engin

[Dev] - Review and merge the pull request - Removed duplicated dependencies in product -greg 5.0.0-SNAPSHOT pom file

2015-01-10 Thread Prasanna Dangalla
Hi, Please merge the pull request [1]. JIRA - https://wso2.org/jira/browse/REGISTRY-2376 [1] - https://github.com/wso2-dev/product-greg/pull/61 Thanks -- Prasanna Dangalla Software Engineer, WSO2, Inc.; http://wso2.com/ lean.enterprise.middleware cell: +94 777 55 80 30 | +94 718 11 27 51 twitt

[Dev] Review and merge the pull request - Changed 4.3.0 management console documentation link from 4.2.0 to 4.3.0

2014-12-25 Thread Prasanna Dangalla
Hi Carbon team, Please merge the pull request [1]. JIRA - https://wso2.org/jira/browse/CARBON-15120 [1] - https://github.com/wso2/carbon4-kernel/pull/126 Thanks -- Prasanna Dangalla Software Engineer, WSO2, Inc.; http://wso2.com/ lean.enterprise.middleware cell: +94 777 55 80 30 | +94 718 11

Re: [Dev] Review and merge carbon business process #21

2014-11-10 Thread Firzhan Naqash
Hi Akalanka, I have updated the pull request with your suggestions. Regards, Firzhan On Tue, Nov 11, 2014 at 8:33 AM, Akalanka Pagoda Arachchi < darsha...@wso2.com> wrote: > Hi Firzhan, > > Isn't it a good idea to completely delete the lines you have commented out > in > 'components/bpmn/org.

Re: [Dev] Review and merge carbon business process #21

2014-11-10 Thread Akalanka Pagoda Arachchi
Hi Firzhan, Isn't it a good idea to completely delete the lines you have commented out in 'components/bpmn/org.wso2.carbon.bpmn/src/main/java/org/wso2/carbon/bpmn/core/db/Database.java' file if they are not necessary? Or else I think it's better to add a comment why you have commented out those,

[Dev] Review and merge carbon business process #21

2014-11-10 Thread Firzhan Naqash
Hi, Please commit the pull request [1] . The changes are related on updating the activiti version. [1] https://github.com/wso2-dev/carbon-business-process/pull/21 Regards, Firzhan ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinf

[Dev] [DEV] Review and Merge Orbit #33

2014-11-10 Thread Firzhan Naqash
Hi Nandika, Can you please merge pull request[1]. This exposes additional packages of activiti engine. This packages are used to manage activiti sessions with in BPMN. [1] https://github.com/wso2/orbit/pull/33 Regards, Firzhan ___ Dev mailing list Dev

[Dev] Review and merge orbit #17

2014-08-06 Thread Waruna Jayaweera
Hi Nandika, Can you please merge pull request[1].This contains the orbit bundles for Activiti Engine and Activiti Rest API. [1] https://github.com/wso2/orbit/pull/17 Thanks Waruna -- Regards, Waruna Lakshitha Jayaweera Software Engineer WSO2 Inc; http://wso2.com phone: +94713255198 __

Re: [Dev] Review and merge the pull request for carbon-utils and carbon-storage-management

2014-06-06 Thread Rajith Vitharana
adding Prabath On Wed, Jun 4, 2014 at 3:30 PM, Rajith Vitharana wrote: > H, > > Although repo maintainers receive email when ever pull request is sent, I > think it would be great if we can maintain a document for this. > > Thanks, > > > On Wed, Jun 4, 2014 at 11:30 AM, Kasun Gajasinghe wrote:

Re: [Dev] Review and merge the pull request for carbon-utils and carbon-storage-management

2014-06-04 Thread Rajith Vitharana
H, Although repo maintainers receive email when ever pull request is sent, I think it would be great if we can maintain a document for this. Thanks, On Wed, Jun 4, 2014 at 11:30 AM, Kasun Gajasinghe wrote: > > > > On Wed, Jun 4, 2014 at 8:56 AM, Rajith Vitharana wrote: > >> Hi Kasun, >> >> S

Re: [Dev] Review and merge the pull request for carbon-utils and carbon-storage-management

2014-06-03 Thread Kasun Gajasinghe
On Wed, Jun 4, 2014 at 8:56 AM, Rajith Vitharana wrote: > Hi Kasun, > > Sorry for the inconvenience. Is there any document stating the relevant > repo maintainers for each Git repo? > > Not as I know of. But we should create one. Whenever you send a pull request, the repo maintainers receive an

Re: [Dev] Review and merge the pull request for carbon-utils and carbon-storage-management

2014-06-03 Thread Rajith Vitharana
Hi Kasun, Sorry for the inconvenience. Is there any document stating the relevant repo maintainers for each Git repo? The PR [1] is there because "org.wso2.carbon.reporting.feature" is needed in BAM. Thanks, On Tue, Jun 3, 2014 at 7:24 PM, Kasun Gajasinghe wrote: > Hi Rajith, > > I cannot me

  1   2   >