[GitHub] zeppelin issue #1757: [ZEPPELIN-1074] Enhance SSL Support

2016-12-18 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1757 Sorry for my late blocking, but actually I even didn't know that there is `README.md` under `conf/`. Maybe many ppl are same with me I guess. Seems there is already some duplicated information

[GitHub] zeppelin issue #1781: Followup for ZEPPELIN-1785

2016-12-18 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1781 @Leemoonsoo @jongyoul --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin pull request #1781: Followup for ZEPPELIN-1785

2016-12-18 Thread zjffdu
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/1781 Followup for ZEPPELIN-1785 ### What is this PR for? After #1745, zeppelin fail to launch in windows.

Re: Re: Build error on windows

2016-12-18 Thread Jeff Zhang
Thanks, This PR resolve my issue. zjp_j...@163.com 于2016年12月19日周一 上午10:21写道: > I think the following issue can help u. > - JIRA : https://issues.apache.org/jira/browse/ZEPPELIN-1239 > - PR : https://github.com/apache/zeppelin/pull/1731 > > -- >

[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...

2016-12-18 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1730 @tae-jun It works well as described and here are two things to consider. 1. Trash is represented in `~Trash` in the Navbar.

[GitHub] zeppelin pull request #1734: [ZEPPELIN-1766] Improve Interpreter Binding UI ...

2016-12-18 Thread 1ambda
Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/1734 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin issue #1734: [ZEPPELIN-1766] Improve Interpreter Binding UI better ...

2016-12-18 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1734 Hi all, This PR looks like unbacked from the point of view design. I will close this issue. :) --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] zeppelin pull request #1689: [ZEPPELIN-1709] Update checkstyle rule file, pl...

2016-12-18 Thread 1ambda
GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/1689 [ZEPPELIN-1709] Update checkstyle rule file, plugin ### What is this PR for? We have - outdated checkstyle.xml - old maven checkstyle plugin - no detailed style plugin

[GitHub] zeppelin pull request #1689: [ZEPPELIN-1709] Update checkstyle rule file, pl...

2016-12-18 Thread 1ambda
Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/1689 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin issue #1689: [ZEPPELIN-1709] Update checkstyle rule file, plugin

2016-12-18 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1689 Hi all, This PR looks like unpopular from the point of view design. I will close this issue. :) --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...

2016-12-18 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1730 Hi all, This PR looks like unpopular from the point of view design. I will close this issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] zeppelin pull request #1694: [ZEPPELIN-1718] Prevent anonymous user to set n...

2016-12-18 Thread AhyoungRyu
GitHub user AhyoungRyu reopened a pull request: https://github.com/apache/zeppelin/pull/1694 [ZEPPELIN-1718] Prevent anonymous user to set note permission ### What is this PR for? Currently anonymous user can open the notebook permission page and type sth in `Owner`/ `Reader` /

[GitHub] zeppelin pull request #1694: [ZEPPELIN-1718] Prevent anonymous user to set n...

2016-12-18 Thread AhyoungRyu
Github user AhyoungRyu closed the pull request at: https://github.com/apache/zeppelin/pull/1694 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin issue #1694: [ZEPPELIN-1718] Prevent anonymous user to set note per...

2016-12-18 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1694 @prabhjyotsingh @cloverhearts @astroshim Sorry for my late response. I added checking anonymous user by using websocket and updated PR description \w new UI screenshot image. Please take a

[GitHub] zeppelin issue #1750: [ZEPPELIN-1796] Add 'copy to clipboard' next to the pa...

2016-12-18 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1750 Will merge into master if there are no more comments then --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #1731: [ZEPPELIN-1239] Google WebFont: goog-webfont-dl Grunt ...

2016-12-18 Thread bzz
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1731 @cuspymd please let me know you ASF JIRA user or email and I'll be happy to assign [ZEPPELIN-1239](https://issues.apache.org/jira/browse/ZEPPELIN-1239) so attribution is keept for release notes ---

[GitHub] zeppelin issue #1731: [ZEPPELIN-1239] Google WebFont: goog-webfont-dl Grunt ...

2016-12-18 Thread bzz
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1731 Looks great to me. Merging to master if there is no further discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

Re: Re: Build error on windows

2016-12-18 Thread zjp_j...@163.com
I think the following issue can help u. - JIRA : https://issues.apache.org/jira/browse/ZEPPELIN-1239 - PR : https://github.com/apache/zeppelin/pull/1731 zjp_j...@163.com From: Jeff Zhang Date: 2016-12-19 09:27 To: users; dev Subject: Re: Build error on windows Attach npm-debug.log Alexander

[GitHub] zeppelin issue #1776: [ZEPPELIN-1824] Add MetaData exploration to JDBC Inter...

2016-12-18 Thread pmccaffrey6
Github user pmccaffrey6 commented on the issue: https://github.com/apache/zeppelin/pull/1776 I went ahead and changed parsing of the "explore" keyword to use `split(" +")` instead of substring so that it wasn't tied to any particular word length etc.. and the `METADATA_KEYWORD` can

[GitHub] zeppelin issue #1750: [ZEPPELIN-1796] Add 'copy to clipboard' next to the pa...

2016-12-18 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1750 @felixcheung Yeah that's my plan :D --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Re: Build error on windows

2016-12-18 Thread Jeff Zhang
Attach npm-debug.log Alexander Bezzubov 于2016年12月18日周日 下午10:34写道: Hi Jeff, looks like something failed during `grunt build`. Could you also show the content of `C:\Users\jzhang\zeppelin\zeppelin-web\npm-debug.log`? It might have some details to give a hint on the issue. --

[GitHub] zeppelin pull request #1765: [WIP] ZEPPELIN-1761. CI: ZeppelinSparkClusterTe...

2016-12-18 Thread zjffdu
GitHub user zjffdu reopened a pull request: https://github.com/apache/zeppelin/pull/1765 [WIP] ZEPPELIN-1761. CI: ZeppelinSparkClusterTest .pySpark* fail the build ### What is this PR for? Add more logging as I could not reproduce it locally. ### What type of PR

[GitHub] zeppelin pull request #1765: [WIP] ZEPPELIN-1761. CI: ZeppelinSparkClusterTe...

2016-12-18 Thread zjffdu
Github user zjffdu closed the pull request at: https://github.com/apache/zeppelin/pull/1765 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin issue #1751: ZEPPELIN-1786. Refactor LivyHelper

2016-12-18 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/1751 LGTM CI was passing, merging if no more comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] zeppelin issue #1755: [ZEPPELIN-1801] To force end table - append %text

2016-12-18 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/1755 @ravwojdyla feel free to ping me directly for scio changes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #1755: [ZEPPELIN-1801] To force end table - append %text

2016-12-18 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/1755 LGTM, CI good, merging if no more discussions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1757: [ZEPPELIN-1074] Enhance SSL Support

2016-12-18 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/1757 merging if no more comment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #1757: [ZEPPELIN-1074] Enhance SSL Support

2016-12-18 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/1757 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] zeppelin issue #1765: ZEPPELIN-1761. CI: ZeppelinSparkClusterTest .pySpark* ...

2016-12-18 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/1765 could you mark the title with [WIP]? let me know when this is ready! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] zeppelin issue #1750: [ZEPPELIN-1796] Add 'copy to clipboard' next to the pa...

2016-12-18 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/1750 LGTM! Maybe we can leverage this for more copy to clipboard features? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] zeppelin pull request #1763: [MINOR] Add trivial cosmetic changes on STYLE.m...

2016-12-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1763 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin issue #1763: [MINOR] Add trivial cosmetic changes on STYLE.md

2016-12-18 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/1763 merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] zeppelin issue #1779: [ZEPPELIN-1835] Upgrade ElasticSearch to version 2.4.3

2016-12-18 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/1779 LGTM. I guess next would be to support ES 5.x? :) merging if no more comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

Re: Build error on windows

2016-12-18 Thread Alexander Bezzubov
Hi Jeff, looks like something failed during `grunt build`. Could you also show the content of `C:\Users\jzhang\zeppelin\zeppelin-web\npm-debug.log`? It might have some details to give a hint on the issue. -- Alex On Sun, Dec 18, 2016 at 10:46 PM, Jeff Zhang wrote: > I try

Build error on windows

2016-12-18 Thread Jeff Zhang
I try to build zeppelin on windows, but hit the following error. Does anyone know how to address this ? Thanks [ERROR] npm ERR! Windows_NT 6.1.7601 [ERROR] npm ERR! argv "C:\\Users\\jzhang\\zeppelin\\zeppelin-web\\node\\node.exe" "C:\\Users\\jzhang\\zeppelin\\zeppelin

[GitHub] zeppelin pull request #1765: ZEPPELIN-1761. CI: ZeppelinSparkClusterTest .py...

2016-12-18 Thread zjffdu
Github user zjffdu closed the pull request at: https://github.com/apache/zeppelin/pull/1765 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin pull request #1765: ZEPPELIN-1761. CI: ZeppelinSparkClusterTest .py...

2016-12-18 Thread zjffdu
GitHub user zjffdu reopened a pull request: https://github.com/apache/zeppelin/pull/1765 ZEPPELIN-1761. CI: ZeppelinSparkClusterTest .pySpark* fail the build ### What is this PR for? Add more logging as I could not reproduce it locally. ### What type of PR is it?