[GitHub] [zeppelin] infoankitp commented on a diff in pull request #4524: [ZEPPELIN-5859] Upgrading alluxio client library to latest stable release 2.9.0

2022-12-01 Thread GitBox
infoankitp commented on code in PR #4524: URL: https://github.com/apache/zeppelin/pull/4524#discussion_r1037294160 ## alluxio/src/main/java/org/apache/zeppelin/alluxio/AlluxioInterpreter.java: ## @@ -19,10 +19,7 @@ package org.apache.zeppelin.alluxio; import

[GitHub] [zeppelin] infoankitp commented on a diff in pull request #4524: [ZEPPELIN-5859] Upgrading alluxio client library to latest stable release 2.9.0

2022-12-01 Thread GitBox
infoankitp commented on code in PR #4524: URL: https://github.com/apache/zeppelin/pull/4524#discussion_r1037290777 ## alluxio/src/main/java/org/apache/zeppelin/alluxio/AlluxioInterpreter.java: ## @@ -19,10 +19,7 @@ package org.apache.zeppelin.alluxio; import

[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4524: [ZEPPELIN-5859] Upgrading alluxio client library to latest stable release 2.9.0

2022-12-01 Thread GitBox
jongyoul commented on code in PR #4524: URL: https://github.com/apache/zeppelin/pull/4524#discussion_r1037283827 ## alluxio/src/main/java/org/apache/zeppelin/alluxio/AlluxioInterpreter.java: ## @@ -19,10 +19,7 @@ package org.apache.zeppelin.alluxio; import

[GitHub] [zeppelin] infoankitp opened a new pull request, #4524: [ZEPPELIN-5859] Upgrading alluxio client library to latest stable release 2.9.0

2022-12-01 Thread GitBox
infoankitp opened a new pull request, #4524: URL: https://github.com/apache/zeppelin/pull/4524 [ZEPPELIN-5859] Upgrading alluxio client library to latest stable release 2.9.0 ### What is this PR for? A few sentences describing the overall goals of the pull request's commits.

[GitHub] [zeppelin] jongyoul commented on pull request #4522: [ZEPPELIN-5856] Bump bouncycastle 1.70

2022-12-01 Thread GitBox
jongyoul commented on PR #4522: URL: https://github.com/apache/zeppelin/pull/4522#issuecomment-1333620239 > I use the M1 mac, may be related (not sure), I can not compile the project, I'm going to fix it one by one Yep. I also use m1 mac. BTW, I appreciate your interest for Zeppelin.

[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4520: [MINOR] Fix Appveyor error

2022-12-01 Thread GitBox
jongyoul commented on code in PR #4520: URL: https://github.com/apache/zeppelin/pull/4520#discussion_r1036799642 ## .appveyor.yml: ## @@ -31,4 +31,4 @@ install: build_script: - echo "Build" - - ps: ./mvnw clean package -DskipTests + - ps: ./mvnw clean package

[GitHub] [zeppelin] jongyoul commented on pull request #4523: [ZEPPELIN-5857] Bump gRPC and protobuf to support build on macOS M1 chips

2022-11-30 Thread GitBox
jongyoul commented on PR #4523: URL: https://github.com/apache/zeppelin/pull/4523#issuecomment-147661 I've checked the link you added but it's a bit different because we are using another maven plugin so I cannot reproduce the error like you. Could you please check it? BTW, I like the

[GitHub] [zeppelin] pan3793 commented on pull request #4522: [ZEPPELIN-5856] Bump bouncycastle 1.70

2022-11-30 Thread GitBox
pan3793 commented on PR #4522: URL: https://github.com/apache/zeppelin/pull/4522#issuecomment-1333282244 > Hello, thank you for checking it. BTW, I cannot reproduce this issue on my local machine. could you please let me know how to make an error? > > ``` > [INFO]

[GitHub] [zeppelin] jongyoul merged pull request #4518: [MINOR] Remove `maven-eclipse-plugin`

2022-11-30 Thread GitBox
jongyoul merged PR #4518: URL: https://github.com/apache/zeppelin/pull/4518 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] jongyoul commented on pull request #4518: [MINOR] Remove `maven-eclipse-plugin`

2022-11-30 Thread GitBox
jongyoul commented on PR #4518: URL: https://github.com/apache/zeppelin/pull/4518#issuecomment-1333170807 Two timeout tests might not be related to this issue directly as I saw the same error in another PR. I'll investigate it but let me merge this pr anyway. -- This is an automated

[GitHub] [zeppelin] jongyoul commented on pull request #4522: [ZEPPELIN-5856] Bump bouncycastle 1.70

2022-11-30 Thread GitBox
jongyoul commented on PR #4522: URL: https://github.com/apache/zeppelin/pull/4522#issuecomment-1333141421 Hello, thank you for checking it. BTW, I cannot reproduce this issue on my local machine. could you please let me know how to make an error? ``` [INFO]

[GitHub] [zeppelin] pan3793 opened a new pull request, #4523: [ZEPPELIN-5857] Bump gRPC and protobuf to support build on macOS M1 chips

2022-11-30 Thread GitBox
pan3793 opened a new pull request, #4523: URL: https://github.com/apache/zeppelin/pull/4523 ### What is this PR for? I suppose this upgrade will not introduce compatibility issue, see details discussion about version requirements and compatibility

[GitHub] [zeppelin] pan3793 opened a new pull request, #4522: [ZEPPELIN-5856] Bump bouncycastle 1.70

2022-11-30 Thread GitBox
pan3793 opened a new pull request, #4522: URL: https://github.com/apache/zeppelin/pull/4522 ### What is this PR for? Bump bouncycastle 1.70. ``` ➜ apache-zeppelin git:(master) java -version openjdk version "1.8.0_332" OpenJDK Runtime Environment (Zulu

[GitHub] [zeppelin] Reamer opened a new pull request, #4521: [MINOR] Use Maven CLI option instead of a logger adjustment.

2022-11-30 Thread GitBox
Reamer opened a new pull request, #4521: URL: https://github.com/apache/zeppelin/pull/4521 ### What is this PR for? This small PR uses a Maven CLI option instead of a logger adjustment to suppress download output. ### What type of PR is it? - Refactoring ### How should

[GitHub] [zeppelin] jongyoul commented on pull request #4520: [MINOR] Fix Appveyor error

2022-11-29 Thread GitBox
jongyoul commented on PR #4520: URL: https://github.com/apache/zeppelin/pull/4520#issuecomment-1331767226 Yes, sometimes quite annoying when we see the logs :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [zeppelin] Reamer commented on pull request #4520: [MINOR] Fix Appveyor error

2022-11-29 Thread GitBox
Reamer commented on PR #4520: URL: https://github.com/apache/zeppelin/pull/4520#issuecomment-1331765400 Nice Maven option that I didn't know about until now. It would be very elegant if we also changed

[GitHub] [zeppelin] jongyoul opened a new pull request, #4520: [MINOR] Fix Appveyor error

2022-11-29 Thread GitBox
jongyoul opened a new pull request, #4520: URL: https://github.com/apache/zeppelin/pull/4520 ### What is this PR for? Fix the issue for appveyor which has an error result. ### What type of PR is it? Bug Fix ### Todos * [x] - Fix .appveyor.yml ### What is the

[GitHub] [zeppelin] Reamer opened a new pull request, #4519: [ZEPPELIN-5855] Refactor docker plugin and remove powermock

2022-11-29 Thread GitBox
Reamer opened a new pull request, #4519: URL: https://github.com/apache/zeppelin/pull/4519 ### What is this PR for? [Powermock](https://github.com/powermock/powermock/issues/929) is not supported in JUnit5. We should not be dependent on Powermock. This PR removes the Powermock

[GitHub] [zeppelin] jongyoul opened a new pull request, #4518: [MINOR] Remove `maven-eclipse-plugin`

2022-11-27 Thread GitBox
jongyoul opened a new pull request, #4518: URL: https://github.com/apache/zeppelin/pull/4518 ### What is this PR for? Remove the elicpse-related maven plugin which was retired 7 years ago. ### What type of PR is it? Improvement ### Todos * [x] - Remove

[GitHub] [zeppelin] jongyoul merged pull request #4517: Bump postgresql from 42.4.1 to 42.4.3 in /jdbc

2022-11-25 Thread GitBox
jongyoul merged PR #4517: URL: https://github.com/apache/zeppelin/pull/4517 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] jongyoul merged pull request #4516: [ZEPPELIN-5830] Zeppelin Security page header styling

2022-11-23 Thread GitBox
jongyoul merged PR #4516: URL: https://github.com/apache/zeppelin/pull/4516 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] dependabot[bot] opened a new pull request, #4517: Bump postgresql from 42.4.1 to 42.4.3 in /jdbc

2022-11-23 Thread GitBox
dependabot[bot] opened a new pull request, #4517: URL: https://github.com/apache/zeppelin/pull/4517 Bumps [postgresql](https://github.com/pgjdbc/pgjdbc) from 42.4.1 to 42.4.3. Changelog Sourced from https://github.com/pgjdbc/pgjdbc/blob/master/CHANGELOG.md;>postgresql's changelog.

[GitHub] [zeppelin] raboof opened a new pull request, #4516: [ZEPPELIN-5830] Zeppelin Security page header styling

2022-11-23 Thread GitBox
raboof opened a new pull request, #4516: URL: https://github.com/apache/zeppelin/pull/4516 ### What is this PR for? When creating #4478 I ran into trouble running jekyll so I couldn't test the output. I have since tested the output and made some updates accordingly. I have also

[GitHub] [zeppelin] jongyoul merged pull request #4512: [MINOR] Polish maven plugins for root pom

2022-11-23 Thread GitBox
jongyoul merged PR #4512: URL: https://github.com/apache/zeppelin/pull/4512 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] dependabot[bot] closed pull request #4449: Bump engine.io and karma in /zeppelin-web

2022-11-23 Thread GitBox
dependabot[bot] closed pull request #4449: Bump engine.io and karma in /zeppelin-web URL: https://github.com/apache/zeppelin/pull/4449 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [zeppelin] dependabot[bot] closed pull request #4451: Bump engine.io and karma in /zeppelin-web-angular

2022-11-23 Thread GitBox
dependabot[bot] closed pull request #4451: Bump engine.io and karma in /zeppelin-web-angular URL: https://github.com/apache/zeppelin/pull/4451 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [zeppelin] dependabot[bot] commented on pull request #4449: Bump engine.io and karma in /zeppelin-web

2022-11-23 Thread GitBox
dependabot[bot] commented on PR #4449: URL: https://github.com/apache/zeppelin/pull/4449#issuecomment-1324988052 Superseded by #4515. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [zeppelin] dependabot[bot] commented on pull request #4451: Bump engine.io and karma in /zeppelin-web-angular

2022-11-23 Thread GitBox
dependabot[bot] commented on PR #4451: URL: https://github.com/apache/zeppelin/pull/4451#issuecomment-1324988035 Superseded by #4514. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [zeppelin] dependabot[bot] opened a new pull request, #4515: Bump engine.io and karma in /zeppelin-web

2022-11-23 Thread GitBox
dependabot[bot] opened a new pull request, #4515: URL: https://github.com/apache/zeppelin/pull/4515 Bumps [engine.io](https://github.com/socketio/engine.io) to 6.2.1 and updates ancestor dependency [karma](https://github.com/karma-runner/karma). These dependencies need to be updated

[GitHub] [zeppelin] dependabot[bot] opened a new pull request, #4514: Bump engine.io and karma in /zeppelin-web-angular

2022-11-23 Thread GitBox
dependabot[bot] opened a new pull request, #4514: URL: https://github.com/apache/zeppelin/pull/4514 Bumps [engine.io](https://github.com/socketio/engine.io) to 6.2.1 and updates ancestor dependency [karma](https://github.com/karma-runner/karma). These dependencies need to be updated

[GitHub] [zeppelin] jongyoul merged pull request #4509: [ZEPPELIN-5847] Polish Maven tasks

2022-11-23 Thread GitBox
jongyoul merged PR #4509: URL: https://github.com/apache/zeppelin/pull/4509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4509: [ZEPPELIN-5847] Polish Maven tasks

2022-11-23 Thread GitBox
jongyoul commented on code in PR #4509: URL: https://github.com/apache/zeppelin/pull/4509#discussion_r1030382818 ## pom.xml: ## @@ -1432,24 +1431,6 @@ - -org.apache.maven.plugins -maven-remote-resources-plugin - - -

[GitHub] [zeppelin] jongyoul merged pull request #4513: [MINOR] Remove warnning

2022-11-23 Thread GitBox
jongyoul merged PR #4513: URL: https://github.com/apache/zeppelin/pull/4513 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] jongyoul commented on pull request #4512: [MINOR] Polish maven plugins for root pom

2022-11-23 Thread GitBox
jongyoul commented on PR #4512: URL: https://github.com/apache/zeppelin/pull/4512#issuecomment-1324983609 > Currently I see for zeppelin-common only the following information inside MANIFEST.MF. Is this information sufficient? I meant the name of jars like

[GitHub] [zeppelin] jongyoul commented on pull request #4512: [MINOR] Polish maven plugins for root pom

2022-11-23 Thread GitBox
jongyoul commented on PR #4512: URL: https://github.com/apache/zeppelin/pull/4512#issuecomment-1324978426 >I have not seen the use of the file for the API yet. I'll have a look right now to see if I can find the post. Here is the code.

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4509: [ZEPPELIN-5847] Polish Maven tasks

2022-11-23 Thread GitBox
Reamer commented on code in PR #4509: URL: https://github.com/apache/zeppelin/pull/4509#discussion_r1030374864 ## pom.xml: ## @@ -1432,24 +1431,6 @@ - -org.apache.maven.plugins -maven-remote-resources-plugin - - -

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4509: [ZEPPELIN-5847] Polish Maven tasks

2022-11-23 Thread GitBox
Reamer commented on code in PR #4509: URL: https://github.com/apache/zeppelin/pull/4509#discussion_r1030321400 ## pom.xml: ## @@ -1432,24 +1431,6 @@ - -org.apache.maven.plugins -maven-remote-resources-plugin - - -

[GitHub] [zeppelin] Reamer commented on pull request #4512: [MINOR] Polish maven plugins for root pom

2022-11-23 Thread GitBox
Reamer commented on PR #4512: URL: https://github.com/apache/zeppelin/pull/4512#issuecomment-1324873754 > I think we already have a version number in our jars. Currently I see for zeppelin-common only the following information inside `MANIFEST.MF`. Is this information sufficient?

[GitHub] [zeppelin] jongyoul opened a new pull request, #4513: [MINOR] Remove warnning

2022-11-22 Thread GitBox
jongyoul opened a new pull request, #4513: URL: https://github.com/apache/zeppelin/pull/4513 ### What is this PR for? Remove outdated maven plugin setting. I saw some warnings when I check some maven logs. ``` [WARNING] The POM for org.eclipse.m2e:lifecycle-mapping:jar:1.0.0

[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4509: [ZEPPELIN-5847] Polish Maven tasks

2022-11-22 Thread GitBox
jongyoul commented on code in PR #4509: URL: https://github.com/apache/zeppelin/pull/4509#discussion_r1029422618 ## pom.xml: ## @@ -1432,24 +1431,6 @@ - -org.apache.maven.plugins -maven-remote-resources-plugin - - -

[GitHub] [zeppelin] jongyoul commented on pull request #4512: [MINOR] Polish maven plugins for root pom

2022-11-22 Thread GitBox
jongyoul commented on PR #4512: URL: https://github.com/apache/zeppelin/pull/4512#issuecomment-1323780292 > Why the change with the git plugin? Basically, I would like not to create `target` directory of the root directory. And I thought the `git.properties` is being only in some API

[GitHub] [zeppelin] Reamer commented on pull request #4512: [MINOR] Polish maven plugins for root pom

2022-11-22 Thread GitBox
Reamer commented on PR #4512: URL: https://github.com/apache/zeppelin/pull/4512#issuecomment-1323628934 I find the change regarding rat very good. Why the change with the git plugin? It can be useful that the Git information is in each artifact of Zeppelin. -- This is an automated

[GitHub] [zeppelin] Reamer merged pull request #4511: [ZEPPELIN-5849][JUnit 5 Migration] Module: JDBC

2022-11-22 Thread GitBox
Reamer merged PR #4511: URL: https://github.com/apache/zeppelin/pull/4511 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] jongyoul commented on pull request #4512: [MINOR] Polish maven plugins for root pom

2022-11-21 Thread GitBox
jongyoul commented on PR #4512: URL: https://github.com/apache/zeppelin/pull/4512#issuecomment-1322320800 We already have the `apache-rat:check` job with the proper profile option. https://github.com/apache/zeppelin/actions/runs/3516132806/jobs/5892289394 -- This is an automated message

[GitHub] [zeppelin] jongyoul opened a new pull request, #4512: [MINOR] Polish maven plugins for root pom

2022-11-21 Thread GitBox
jongyoul opened a new pull request, #4512: URL: https://github.com/apache/zeppelin/pull/4512 ### What is this PR for? * Deactivate apache-rat by default and change some CI settings * Move git-commit-id-plugin under `zeppelin-interpreter` ### What type of PR is it?

[GitHub] [zeppelin] huage1994 opened a new pull request, #4511: [ZEPPELIN-5849][JUnit 5 Migration] Module: JDBC

2022-11-20 Thread GitBox
huage1994 opened a new pull request, #4511: URL: https://github.com/apache/zeppelin/pull/4511 ### What is this PR for? This PR is to migrate the tests in JDBC module from JUnit 4 to JUnit 5, which is a part of [JUnit 5 Migration Plan](https://issues.apache.org/jira/browse/ZEPPELIN-5848)

[GitHub] [zeppelin] zjffdu commented on pull request #4497: [ZEPPELIN-5207] Build with JDK 11 in CI

2022-11-18 Thread GitBox
zjffdu commented on PR #4497: URL: https://github.com/apache/zeppelin/pull/4497#issuecomment-1320823452 @Reamer Spark 2.4 doesn't support JDK 11, Spark 2.4 related test should be disabled on JDK 11 test. This is the ticket for supporting JDK 11 in Spark

[GitHub] [zeppelin] Reamer merged pull request #4321: [ZEPPELIN-5612] Upgrade junit 4 to 5

2022-11-14 Thread GitBox
Reamer merged PR #4321: URL: https://github.com/apache/zeppelin/pull/4321 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] zjffdu commented on pull request #4497: [ZEPPELIN-5207] Build with JDK 11 in CI

2022-11-14 Thread GitBox
zjffdu commented on PR #4497: URL: https://github.com/apache/zeppelin/pull/4497#issuecomment-1313903203 > @zjffdu Can you support me to move this issue forward. What are your thoughts to make the tests go through successfully? I'm struggling with Spark and Flink interpreter tests in

[GitHub] [zeppelin] dependabot[bot] opened a new pull request, #4510: Bump loader-utils and @angular-devkit/build-angular in /zeppelin-web-angular

2022-11-14 Thread GitBox
dependabot[bot] opened a new pull request, #4510: URL: https://github.com/apache/zeppelin/pull/4510 Bumps [loader-utils](https://github.com/webpack/loader-utils) to 1.4.2 and updates ancestor dependency [@angular-devkit/build-angular](https://github.com/angular/angular-cli). These

[GitHub] [zeppelin] Reamer opened a new pull request, #4509: [ZEPPELIN-5847] Polish Maven tasks

2022-11-14 Thread GitBox
Reamer opened a new pull request, #4509: URL: https://github.com/apache/zeppelin/pull/4509 ### What is this PR for? This pull request removes unnecessary Maven calls, which are already configured from the apache parent pom. enforcer maven-version goal:

[GitHub] [zeppelin] zjffdu commented on pull request #4506: [ZEPPELIN-5844] Support flink 1.16

2022-11-14 Thread GitBox
zjffdu commented on PR #4506: URL: https://github.com/apache/zeppelin/pull/4506#issuecomment-1313401152 > BTW, a test related to this change failed. Is it fine? https://github.com/apache/zeppelin/actions/runs/3448729205/jobs/5755992907 I will fix it -- This is an automated message

[GitHub] [zeppelin] jongyoul commented on pull request #4506: [ZEPPELIN-5844] Support flink 1.16

2022-11-14 Thread GitBox
jongyoul commented on PR #4506: URL: https://github.com/apache/zeppelin/pull/4506#issuecomment-1313399654 BTW, a test related to this change failed. Is it fine? https://github.com/apache/zeppelin/actions/runs/3448729205/jobs/5755992907 -- This is an automated message from the Apache Git

[GitHub] [zeppelin] Reamer merged pull request #4503: [ZEPPELIN-5842] Maven-Plugin management

2022-11-14 Thread GitBox
Reamer merged PR #4503: URL: https://github.com/apache/zeppelin/pull/4503 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] huage1994 commented on pull request #4321: [ZEPPELIN-5612] Upgrade junit 4 to 5

2022-11-12 Thread GitBox
huage1994 commented on PR #4321: URL: https://github.com/apache/zeppelin/pull/4321#issuecomment-1312635695 > I think it looks good overall. Just a few minor issues. Hi @Reamer, really thanks for your useful advice. I've update my code and waiting for the CI result. -- This is

[GitHub] [zeppelin] zjffdu commented on pull request #4506: [ZEPPELIN-5844] Support flink 1.16

2022-11-11 Thread GitBox
zjffdu commented on PR #4506: URL: https://github.com/apache/zeppelin/pull/4506#issuecomment-1311634940 > > Will merge if no more comments > > No automated tests? Oops, missing in the commit, let me add it. -- This is an automated message from the Apache Git Service. To

[GitHub] [zeppelin] Reamer commented on pull request #4506: [ZEPPELIN-5844] Support flink 1.16

2022-11-11 Thread GitBox
Reamer commented on PR #4506: URL: https://github.com/apache/zeppelin/pull/4506#issuecomment-1311633222 > Will merge if no more comments No automated tests? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [zeppelin] zjffdu commented on pull request #4506: [ZEPPELIN-5844] Support flink 1.16

2022-11-11 Thread GitBox
zjffdu commented on PR #4506: URL: https://github.com/apache/zeppelin/pull/4506#issuecomment-1311620071 Will merge if no more comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4321: [ZEPPELIN-5612] Upgrade junit 4 to 5

2022-11-11 Thread GitBox
Reamer commented on code in PR #4321: URL: https://github.com/apache/zeppelin/pull/4321#discussion_r1020028572 ## hbase/pom.xml: ## @@ -75,11 +75,23 @@ org.apache.hbase hbase-client ${hbase.hbase.version} + Review Comment: This is not a test

[GitHub] [zeppelin] Reamer merged pull request #4505: [ZEPPELIN-5845] polish Cluster classes

2022-11-10 Thread GitBox
Reamer merged PR #4505: URL: https://github.com/apache/zeppelin/pull/4505 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4503: [ZEPPELIN-5842] Maven-Plugin management

2022-11-10 Thread GitBox
Reamer commented on code in PR #4503: URL: https://github.com/apache/zeppelin/pull/4503#discussion_r1018923993 ## zeppelin-integration/pom.xml: ## @@ -37,14 +37,9 @@ -UTF-8 Review Comment: You are right, we should add `project.build.sourceEncoding` in root

[GitHub] [zeppelin] zjffdu merged pull request #4501: [ZEPPELIN-5763] NoClassDefFoundError in spark interpreter: org/apache/commons/lang/StringUtils

2022-11-07 Thread GitBox
zjffdu merged PR #4501: URL: https://github.com/apache/zeppelin/pull/4501 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] dependabot[bot] opened a new pull request, #4508: Bump ivy from 2.4.0 to 2.5.1 in /flink/flink-scala-parent

2022-11-07 Thread GitBox
dependabot[bot] opened a new pull request, #4508: URL: https://github.com/apache/zeppelin/pull/4508 Bumps ivy from 2.4.0 to 2.5.1. [![Dependabot compatibility

[GitHub] [zeppelin] zjffdu opened a new pull request, #4506: [ZEPPELIN-5844] Support flink 1.16

2022-11-06 Thread GitBox
zjffdu opened a new pull request, #4506: URL: https://github.com/apache/zeppelin/pull/4506 ### What is this PR for? Introduce new module `flink1.16-shims` to support flink 1.16. Because the api incompatability of flink 1.16, abstract class FlinkShims changed some interfaces.

[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4503: [ZEPPELIN-5842] Maven-Plugin management

2022-11-06 Thread GitBox
jongyoul commented on code in PR #4503: URL: https://github.com/apache/zeppelin/pull/4503#discussion_r1014779148 ## zeppelin-integration/pom.xml: ## @@ -37,14 +37,9 @@ -UTF-8 Review Comment: I read

[GitHub] [zeppelin] Reamer opened a new pull request, #4505: Cluster polish

2022-11-04 Thread GitBox
Reamer opened a new pull request, #4505: URL: https://github.com/apache/zeppelin/pull/4505 ### What is this PR for? This PR polishes the cluster code. ### What type of PR is it? - Refactoring ### What is the Jira issue? *

[GitHub] [zeppelin] Reamer merged pull request #4504: [ZEPPELIN-5843] Miscellaneous polishing

2022-11-04 Thread GitBox
Reamer merged PR #4504: URL: https://github.com/apache/zeppelin/pull/4504 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] Reamer opened a new pull request, #4504: [ZEPPELIN-5843] Miscellaneous polishing

2022-11-03 Thread GitBox
Reamer opened a new pull request, #4504: URL: https://github.com/apache/zeppelin/pull/4504 ### What is this PR for? This PR removes unnecessary Maven dependency calls and deposits the same NPM library as dependency, which is also used to build Zeppelin NPM projects. ### What

[GitHub] [zeppelin] Reamer closed pull request #3930: [ZEPPELIN-5076] Update to Apache Software Foundation Parent POM

2022-11-02 Thread GitBox
Reamer closed pull request #3930: [ZEPPELIN-5076] Update to Apache Software Foundation Parent POM URL: https://github.com/apache/zeppelin/pull/3930 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [zeppelin] Reamer commented on pull request #3930: [ZEPPELIN-5076] Update to Apache Software Foundation Parent POM

2022-11-02 Thread GitBox
Reamer commented on PR #3930: URL: https://github.com/apache/zeppelin/pull/3930#issuecomment-1300437316 Closing, I will add changes in other PRs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [zeppelin] jongyoul merged pull request #4498: [ZEPPELIN-5815] Frontend CI jobs improvement

2022-11-01 Thread GitBox
jongyoul merged PR #4498: URL: https://github.com/apache/zeppelin/pull/4498 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] sveryovka commented on pull request #4497: [ZEPPELIN-5207] Build with JDK 11 in CI

2022-11-01 Thread GitBox
sveryovka commented on PR #4497: URL: https://github.com/apache/zeppelin/pull/4497#issuecomment-1298805443 @Reamer in the last build of this branch following test are failing zeppelin-integration-test spark-integration-test (2,11) spark-integration-test (3,11) spark-test (3.7,

[GitHub] [zeppelin] pellmont closed pull request #2891: ZEPPELIN-1070: Inject Credentials in any Interpreter-Code

2022-11-01 Thread GitBox
pellmont closed pull request #2891: ZEPPELIN-1070: Inject Credentials in any Interpreter-Code URL: https://github.com/apache/zeppelin/pull/2891 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [zeppelin] Reamer commented on pull request #4497: [ZEPPELIN-5207] Build with JDK 11 in CI

2022-11-01 Thread GitBox
Reamer commented on PR #4497: URL: https://github.com/apache/zeppelin/pull/4497#issuecomment-1298339523 @zjffdu Can you support me to move this issue forward. What are your thoughts to make the tests go through successfully? I'm struggling with Spark and Flink interpreter tests in

[GitHub] [zeppelin] dependabot[bot] opened a new pull request, #4502: Bump socket.io-parser and karma in /zeppelin-web-angular

2022-11-01 Thread GitBox
dependabot[bot] opened a new pull request, #4502: URL: https://github.com/apache/zeppelin/pull/4502 Bumps [socket.io-parser](https://github.com/socketio/socket.io-parser) to 4.2.1 and updates ancestor dependency [karma](https://github.com/karma-runner/karma). These dependencies need to be

[GitHub] [zeppelin] Reamer merged pull request #4480: [ZEPPELIN-5832] Use protoc-jar-maven-plugin, which has a good IDE support

2022-11-01 Thread GitBox
Reamer merged PR #4480: URL: https://github.com/apache/zeppelin/pull/4480 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] jongyoul commented on pull request #4480: [ZEPPELIN-5832] Use protoc-jar-maven-plugin, which has a good IDE support

2022-11-01 Thread GitBox
jongyoul commented on PR #4480: URL: https://github.com/apache/zeppelin/pull/4480#issuecomment-1298234563 I think it's good! I don't do anything but it's compiled automatically and there are no red lines for the related classes -- This is an automated message from the Apache Git Service.

[GitHub] [zeppelin] Reamer commented on pull request #4480: [ZEPPELIN-5832] Use protoc-jar-maven-plugin, which has a good IDE support

2022-11-01 Thread GitBox
Reamer commented on PR #4480: URL: https://github.com/apache/zeppelin/pull/4480#issuecomment-1298216568 @jongyoul Can you test this with another IDE? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [zeppelin] Reamer merged pull request #4295: [ZEPPELIN-5123] Add an example grafana dashboard

2022-11-01 Thread GitBox
Reamer merged PR #4295: URL: https://github.com/apache/zeppelin/pull/4295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] zjffdu opened a new pull request, #4501: [Draft] [ZEPPELIN-5763] NoClassDefFoundError in spark interpreter: org/apache/commons/lang/StringUtils

2022-10-31 Thread GitBox
zjffdu opened a new pull request, #4501: URL: https://github.com/apache/zeppelin/pull/4501 ### What is this PR for? A few sentences describing the overall goals of the pull request's commits. First time? Check out the contributing guide -

[GitHub] [zeppelin] Reamer commented on pull request #4498: [ZEPPELIN-5815] Frontend CI jobs improvement

2022-10-31 Thread GitBox
Reamer commented on PR #4498: URL: https://github.com/apache/zeppelin/pull/4498#issuecomment-1296772904 I have opened a small PR to use the scala profile. https://github.com/huage1994/zeppelin/pull/1 Let's wait for the CI. -- This is an automated message from the Apache Git Service.

[GitHub] [zeppelin] huage1994 commented on pull request #4498: [ZEPPELIN-5815] Frontend CI jobs improvement

2022-10-31 Thread GitBox
huage1994 commented on PR #4498: URL: https://github.com/apache/zeppelin/pull/4498#issuecomment-1296597025 Thanks a lot for your review @Reamer @jongyoul . [Now the CI seems OK in my forked repo. ](https://github.com/huage1994/zeppelin/actions/runs/3355638130) -- This is an automated

[GitHub] [zeppelin] dependabot[bot] opened a new pull request, #4500: Bump socket.io-parser and karma in /zeppelin-web

2022-10-30 Thread GitBox
dependabot[bot] opened a new pull request, #4500: URL: https://github.com/apache/zeppelin/pull/4500 Bumps [socket.io-parser](https://github.com/socketio/socket.io-parser) to 4.2.1 and updates ancestor dependency [karma](https://github.com/karma-runner/karma). These dependencies need to be

[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4498: [ZEPPELIN-5815] Frontend CI jobs improvement

2022-10-30 Thread GitBox
jongyoul commented on code in PR #4498: URL: https://github.com/apache/zeppelin/pull/4498#discussion_r1008831252 ## .github/workflows/frontend.yml: ## @@ -49,9 +49,9 @@ jobs: restore-keys: | ${{ runner.os }}-zeppelin- - name: Install application -

[GitHub] [zeppelin] Reamer commented on pull request #4497: [ZEPPELIN-5207] Build with JDK 11 in CI

2022-10-28 Thread GitBox
Reamer commented on PR #4497: URL: https://github.com/apache/zeppelin/pull/4497#issuecomment-1295050167 @sveryovka Thank you for working with me on this change. I have included your commit. If you have any other useful commits, let me know. -- This is an automated message from the

[GitHub] [zeppelin] jongyoul commented on pull request #4497: [ZEPPELIN-5207] Build with JDK 11 in CI

2022-10-28 Thread GitBox
jongyoul commented on PR #4497: URL: https://github.com/apache/zeppelin/pull/4497#issuecomment-1294759463 > In my opinion this pretty much overloads the CI system, we should go for one JDK version for most of the testing. The default-build job could be done with "all" JDKs. How do you guys

[GitHub] [zeppelin] sveryovka commented on pull request #4497: [ZEPPELIN-5207] Build with JDK 11 in CI

2022-10-28 Thread GitBox
sveryovka commented on PR #4497: URL: https://github.com/apache/zeppelin/pull/4497#issuecomment-1294714056 Hello, I was trying to update zeppelin to jdk 11 but unfortunately have not finished the task completely yet. However, I can help at least with some small things.

[GitHub] [zeppelin] zjffdu merged pull request #4463: [ZEPPELIN-5493] Remove prefix in jdbc interpreter

2022-10-28 Thread GitBox
zjffdu merged PR #4463: URL: https://github.com/apache/zeppelin/pull/4463 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4498: [ZEPPELIN-5815] Frontend CI jobs improvement

2022-10-28 Thread GitBox
Reamer commented on code in PR #4498: URL: https://github.com/apache/zeppelin/pull/4498#discussion_r1007741613 ## zeppelin-integration/pom.xml: ## @@ -94,21 +110,55 @@ test - + - org.apache.commons - commons-lang3 +

[GitHub] [zeppelin] huage1994 commented on pull request #4498: [ZEPPELIN-5815] Frontend CI jobs improvement

2022-10-28 Thread GitBox
huage1994 commented on PR #4498: URL: https://github.com/apache/zeppelin/pull/4498#issuecomment-1294532929 The CI seems to run well. I would appreciate it if anyone help review it.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [zeppelin] Reamer merged pull request #4499: [ZEPPELIN-5839] Update mockito and powermock

2022-10-27 Thread GitBox
Reamer merged PR #4499: URL: https://github.com/apache/zeppelin/pull/4499 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [zeppelin] huage1994 commented on pull request #4498: [ZEPPELIN-5815] Frontend CI jobs improvement

2022-10-26 Thread GitBox
huage1994 commented on PR #4498: URL: https://github.com/apache/zeppelin/pull/4498#issuecomment-1292001355 > > But in the other frontend Job `run-e2e-tests-in-zeppelin-web`, I think it is inappropriate to add test dependencies in pom.xml of `zeppelin-web` , so I use `./mvnw clean package

[GitHub] [zeppelin] Reamer commented on pull request #4498: [ZEPPELIN-5815] Frontend CI jobs improvement

2022-10-26 Thread GitBox
Reamer commented on PR #4498: URL: https://github.com/apache/zeppelin/pull/4498#issuecomment-1291985709 > But in the other frontend Job `run-e2e-tests-in-zeppelin-web`, I think it is inappropriate to add test dependencies in pom.xml of `zeppelin-web` , so I use `./mvnw clean package -pl

[GitHub] [zeppelin] Reamer opened a new pull request, #4499: [ZEPPELIN-5839] Update mockito and powermock

2022-10-26 Thread GitBox
Reamer opened a new pull request, #4499: URL: https://github.com/apache/zeppelin/pull/4499 ### What is this PR for? This PR updates mockito and powermock. My goal with this PR is to correct the unit tests in PR #4497. ### What type of PR is it? Improvement ### What is

[GitHub] [zeppelin] huage1994 commented on pull request #4498: [ZEPPELIN-5815] Frontend CI jobs improvement

2022-10-26 Thread GitBox
huage1994 commented on PR #4498: URL: https://github.com/apache/zeppelin/pull/4498#issuecomment-1291561298 > Sorry if I was vague here. Let me describe it in a little more detail. During the tests the project `zeppelin-integration` is executed. In my opinion this sub-module has to define

[GitHub] [zeppelin] huage1994 commented on pull request #4463: [ZEPPELIN-5493] Remove prefix in jdbc interpreter

2022-10-25 Thread GitBox
huage1994 commented on PR #4463: URL: https://github.com/apache/zeppelin/pull/4463#issuecomment-1291490814 Hi @jongyoul , thanks a lot for your review! Is there any code I need to change? `Merging can be performed automatically once the requested changes are addressed.` It seems

[GitHub] [zeppelin] huage1994 commented on pull request #4498: [ZEPPELIN-5815] Frontend CI jobs improvement

2022-10-25 Thread GitBox
huage1994 commented on PR #4498: URL: https://github.com/apache/zeppelin/pull/4498#issuecomment-1291459698 The code branch of the previous PR #4459 was accidentally deleted by me, so it cannot be reopen now. But you can see the past discussion #4459. -- This is an automated message

[GitHub] [zeppelin] huage1994 opened a new pull request, #4498: [ZEPPELIN-5815] Frontend CI jobs improvement

2022-10-25 Thread GitBox
huage1994 opened a new pull request, #4498: URL: https://github.com/apache/zeppelin/pull/4498 ### What is this PR for? This PR is to improve a some step in Frontend CI jobs. There are two command in this step in file `frontend.yml` as follow:

[GitHub] [zeppelin] huage1994 commented on pull request #4459: [ZEPPELIN-5815] Frontend CI jobs improvement

2022-10-25 Thread GitBox
huage1994 commented on PR #4459: URL: https://github.com/apache/zeppelin/pull/4459#issuecomment-1291453956 Hi @Reamer @jongyoul , I'm sorry I deleted this branch by mistake,I would submit a new PR -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [zeppelin] huage1994 closed pull request #4459: [ZEPPELIN-5815] Frontend CI jobs improvement

2022-10-25 Thread GitBox
huage1994 closed pull request #4459: [ZEPPELIN-5815] Frontend CI jobs improvement URL: https://github.com/apache/zeppelin/pull/4459 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

<    1   2   3   4   5   6   7   8   9   10   >