[GitHub] incubator-zeppelin pull request: ZEPPELIN-885 Add option to send e...

2016-05-30 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/918#issuecomment-222587470 @vgmartinez I think move email facilities from `Notebook.java` to new class, like @bzz mentioned, would be the first step to generalize it. Doesn't need t

[GitHub] incubator-zeppelin pull request: ZEPPELIN-885 Add option to send e...

2016-05-30 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/918#issuecomment-222578818 @vgmartinez thank you for explaining the use case, it makes perfect sense and is not covered by the case I was referring to. May it's worth putting it in JIRA\PR

[GitHub] incubator-zeppelin pull request: ZEPPELIN-885 Add option to send e...

2016-05-29 Thread vgmartinez
Github user vgmartinez commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/918#issuecomment-222380608 Hi @Leemoonsoo, I totally agree with you. I'll think a bit about this topic, if you already have some idea we can debate. thanks for the suggestio

[GitHub] incubator-zeppelin pull request: ZEPPELIN-885 Add option to send e...

2016-05-26 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/918#issuecomment-222009584 @vgmartinez Thanks for contribution. @vgmartinez and folks, how about having generalized event hook instead of just handling email after scheduler

[GitHub] incubator-zeppelin pull request: ZEPPELIN-885 Add option to send e...

2016-05-26 Thread vgmartinez
Github user vgmartinez commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/918#issuecomment-221804094 @cloverhearts @astroshim @felixcheung thks, add more info and doc ASAP. hi @bzz, I think having the option to send an email when you finish execut

[GitHub] incubator-zeppelin pull request: ZEPPELIN-885 Add option to send e...

2016-05-26 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/918#issuecomment-221800802 @vgmartinez Thank you for contribution! Befor deep dive into the code, I have a question - could you pelase explain the use-case you have in mind for th

[GitHub] incubator-zeppelin pull request: ZEPPELIN-885 Add option to send e...

2016-05-25 Thread cloverhearts
Github user cloverhearts commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/918#issuecomment-221791051 @astroshim Oh, I see. Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] incubator-zeppelin pull request: ZEPPELIN-885 Add option to send e...

2016-05-25 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/918#issuecomment-221789778 cool - should we have the info in documentation? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] incubator-zeppelin pull request: ZEPPELIN-885 Add option to send e...

2016-05-25 Thread astroshim
Github user astroshim commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/918#issuecomment-221772165 @cloverhearts maybe you need to set up the smtp informations. you can set the variables in the "conf/zeppelin-site.xml". --- If your project is set up for

[GitHub] incubator-zeppelin pull request: ZEPPELIN-885 Add option to send e...

2016-05-25 Thread cloverhearts
Github user cloverhearts commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/918#issuecomment-221763611 Thank you for good feature. I like this feature. but, i got following problem. Zeppelin Server log. ``` ERROR [2016-05-26 11

[GitHub] incubator-zeppelin pull request: ZEPPELIN-885 Add option to send e...

2016-05-25 Thread vgmartinez
GitHub user vgmartinez opened a pull request: https://github.com/apache/incubator-zeppelin/pull/918 ZEPPELIN-885 Add option to send email in scheduler execution ### What is this PR for? Add the option to send email when a note is runing using the scheduler ### What