Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/369#issuecomment-153715600
Update ListNotebook API to match and use same code as socket implementation
Ready for review
---
If your project is set up for it, you can reply to
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/369#issuecomment-153138378
Hi,
Sorry for the late response, if I implement the list based on NoteInfo it
means that we only publish Note id and Note Name as implemented in
GitHub user eranwitkon opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/369
[Zeppelin-354] - List notebooks REST API
replacing PR #367
This is the implementation, test and documentation of List notebooks REST
API.
The documentation include sample
Github user eranwitkon closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/367
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user eranwitkon opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/367
List Notebook REST API implementation, Test & documentation
Implementation of List Notebook REST API including JUnit and documentation.
The return JSON object include only
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-147162051
Does someone has more comments on this one, or can we merge it?
On Wed, Oct 7, 2015 at 8:09 AM CORNEAU Damien
wrote
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-146519919
@corneadoug as for the CORS question, cors filter is added on the server
level see
[this](https://github.com/apache/incubator-zeppelin/blob
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-146074254
I agree that we shouldn't expose just random API but these are not just any
utility functions, this is working with notebooks from ext
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-145960012
Ok, let's review this PR and merge it. I will open an additional JIRA issue
for the content of the notebook and we will discuss options in it.
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-145936956
First, I agree that if it is ok with you we should merge this one and have
another one for the paragraph requirement. As I understand, you are OK
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-145831974
I just re-based on latest master and run test again.
Ready for merge.
---
If your project is set up for it, you can reply to this email and have your
GitHub user eranwitkon reopened a pull request:
https://github.com/apache/incubator-zeppelin/pull/334
zeppelin-333:Notebook create delete & clone REST API
Initial implementation of createNote REST API.
implementation overlap socket implementation, to minimal the effect
Github user eranwitkon closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/334
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-145817699
The above commit was already merged . I will remove it and rebase on latest.
Tnx,
×ת×ר×× ××× ×׳, 6 ×××ק׳ 2015, 13:31 ××ת
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-145636200
merged with update flik docs from [this
commit](https://github.com/apache/incubator-zeppelin/commit/82ea80dc6a320a7d7e400495afa3cd97f1c523eb)
---
If
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-145629683
This PR includes the following:
- [x] Support for Create, Delete, Clone REST API.
- [x] implementation of clone on zengine notebook
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-145550489
We can technically we can add this but I am intersted of what is the use
case, zepplin is about interaction which means submitting a query and using
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-145296249
@nberserk please feel free to review and contribute...
@vmakhaev please review and comment if this meets your request
---
If your project is set up
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/334#issuecomment-145296134
This PR includes the following:
- [x] Support for Create, Delete, Clone REST API.
- [x] implementation of clone on zengine notebook.
- [x
GitHub user eranwitkon opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/334
zeppelin-333: [WIP] Notebook create delete & clone REST API
Initial implementation of createNote REST API.
implementation overlap socket implementation to minimal the effect
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/332#issuecomment-145060183
@nberserk No problem, it wasn't my intention to hijack this PR.
Can you open a JIRA ticket for this and we will start the work from it.
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/332#issuecomment-145045031
I don't know what was the original intent for separating the API between
socket API and REST API but to me socket API are more internal and
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/226#issuecomment-138806182
+1 from me. merged, build and tested.
On Wed, Sep 9, 2015 at 9:11 AM Rohit Agarwal
wrote:
> @Leemoonsoo <https://gith
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/277#issuecomment-138220260
Just closed the PR and opened a new one PR #286.
Hope it will pass CI and ready for merge.
Eran
On Mon, Sep 7, 2015 at 7:35 AM Alexander
GitHub user eranwitkon opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/286
Zeppelin - 241: Add REST API Setting CRUD tests
This PR adds tests for create, Update Delete settings operations using REST
API.
You can merge this pull request into a Git
Github user eranwitkon closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/277
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/277#issuecomment-138206642
Unneeded commits in the PR, closing and re-creating from master.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/277#issuecomment-138158057
This wasn't my intention, I am only changing 2 files but this was probebly
due to rebase on master. I will try and see how to fix it.
Sorry.
-
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/277#issuecomment-138046469
Fixed and ready for review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user eranwitkon opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/277
adds test for the create, Update & delete REST API
This PR add the required tests for REST API CRUD operation.
This replace previous PR's which where closed due to mer
Github user eranwitkon closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/268
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user eranwitkon opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/271
Zeppelin interpreter documentation and interpreter REST API documentation
This PR updates the JSON sample in the documentation to match the new JSON
format (omit the option section
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/268#issuecomment-136814507
This PR is ready for merge with pr #266.
CI is completed successfully but the status is not showing.
---
If your project is set up for it, you can
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/266#issuecomment-136810321
I will have a look at this as well although the PR is about the REST API
and as much as I tested this controller is not part of it.
×ת
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/226#issuecomment-136647780
I think we should merge PR #266 which touches the same files and PR #268
which adds the REST API test and the re-base this one and merge.
---
If your
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/266#issuecomment-136645152
Fixed RAT issue.
Ready for merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/268#issuecomment-136343589
This PR is dependent on PR #266 and should be merged after it.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user eranwitkon opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/268
Zeppelin-241: Add Setting CRUD Rest API tests
This PR adds test for the create, Update & delete REST API
You can merge this pull request into a Git repository by running:
$
Github user eranwitkon closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/258
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/258#issuecomment-136342308
This PR is integrated into PR #266
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user eranwitkon closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/254
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user eranwitkon opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/266
Zeppelin-272: Remove option part from REST API
This PR remove the option part from the Interpreter setting REST API
[x] Remove option from list settings
[x] Remove option
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/256#issuecomment-135871193
Docs fixed abd ready for merge.
×ת×ר×× ××× ×׳, 28 ××××׳ 2015, 09:21 ××ת Lee moon soo <
notificati...@github.
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/256#issuecomment-135728980
Docs fixed according to comments.
Ready for merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user eranwitkon closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/242
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/242#issuecomment-135522508
@Leemoonsoo I have PR #242 and PR #254 both opened.
#242 is the fix for the InterpreterFactory I will close it.
#254 is new REST API test - can
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/242#issuecomment-135517008
Sorry for that, I had 241 based on 242. Since I did not know if you are
going to accept both.
If #241 is merged then the fix is already in
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/242#issuecomment-135295501
Thus is not different, 240 is closed due to a problem I had with push.
This replace 240.
Thanks
×ת×ר×× ××× ×׳, 26
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/242#issuecomment-134949085
This PR fix a bug in the getRegisteredInterpreterList.
Ready to review and merge, please.
---
If your project is set up for it, you can reply to this
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/258#issuecomment-134948895
CI failed due to a download problem:
```Failed to execute goal
com.github.eirslett:frontend-maven-plugin:0.0.23:install-node-and-npm (install
node
GitHub user eranwitkon opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/258
Return the new setting ID in the response call in the REST API
This PR changes the JSON body of the create setting REST api to return the
new created setting ID.
the new return
GitHub user eranwitkon opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/256
Zeppelin interpreter documentation and interpreter REST API documentation
Add documentation about the role of Interpreters, interpreters group and
interpreters settings in Zeppelin
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/242#issuecomment-134504419
Ready for review\merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user eranwitkon opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/254
ZEPPELIN-241- Add tests for REST API
Can someone help in this one?
```
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 9.18 sec
<<< FAIL
Github user eranwitkon closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/243
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/242#issuecomment-133584373
I noticed this PR failed on CI. based on the log the InterpreterFactory
JUnit failed.
Not sure what to do with it as the unit test pass locally
GitHub user eranwitkon opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/243
Zeppelin-241 Add test for REST API
Add tests for all REST API
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/eranwitkon
GitHub user eranwitkon opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/242
Fix getRegisteredInterpreterList to avoid adding null to the list
This PR fix the getRegisteredInterpreterList
InterpreterFactory is looping through the interpreters class
GitHub user eranwitkon opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/241
Add argument check for option and properties to protect from NPE
Here is the repro steps:
1) run zeppelin
2) using some REST client call the update settings with the
Github user eranwitkon closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/223
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user eranwitkon closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/240
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user eranwitkon opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/240
[Zeppelin-254] getRegisteredInterpreterList add NULL to the list
InterpreterFactory register all interpreters by looping through the config
interpreter class list and looking for
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-133525197
Did you see my comment from 5 days ago?
Now that I can run the code I found this behavior :
Try the following code:
%sql
select
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/223#issuecomment-133038636
Fixed CI problem.
Ready for review\merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user eranwitkon closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/232
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user eranwitkon opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/232
Zeppelin-241 Improve REST API code and documentation
The goal of this PR is to improve the accessbility of the REST API and the
REST documentation
- [ ] Move the base parameters
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/226#issuecomment-132560195
I think having an updated Swagger information including swagger.json for
swagger UI is a good thing for zeppelin as it allows developers to integrate
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/223#issuecomment-132481889
I updated the code based on the comments above and committed again.
Ready for review...
Eran
On Wed, Aug 19, 2015 at 9:17 AM IT CTO wrote
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/223#issuecomment-132458954
Here is the repro steps:
1) run zeppelin
2) using some REST client call the update settings with the following JSON
{"id":"2
GitHub user eranwitkon opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/223
Protect from NPE when creating Interpreter Group
When creating Interpreter group using missing data from REST call a NPE
accrues. this fix protect from that and add some test cases
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-131536089
Cool that did the trick.
Now that I can run the code I found this behavior :
Try the following code:
%sql
select Name from myMap
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-131438629
Hi,
I tried testing your PR (152) but I could not see the map icon on the
output page.
 So any
user using it in report mode need to run it in startup, (right
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/191#issuecomment-130760983
Yes, do we dupport this feature? 'Run at startup?'
×ת×ר×× ××× ×׳, 13 ××××׳ 2015, 19:54 ××ת Lee moon soo <
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/191#issuecomment-130754464
I would expect that if we set a page as home page we need to execute it
automaticly on load, right?
×ת×ר×× ××× ×׳, 13
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/191#issuecomment-130184141
Here is what I see when I set a a spesific notebook as homepage
 I can set the variable both in the *-env and *-site and get it to work
2) hide the
GitHub user eranwitkon opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/195
ZEPPELIN213: Notebook toggleAllTable and toggleAllEditor does not matâ¦
This fix match the notebook buttons (code & output) behavior to the
paragraph behavior (code &
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/191#issuecomment-129227208
I tested this feature but could not get it to work.
1) we should add the property place holder to zeppelin-site.xml.template
and env variable to
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/164#issuecomment-129221434
I hope we are going to merge this one before moving to the list
implementation. Eran
×ת×ר×× ××× ×׳, 9 ××××׳ 2015, 20:36 ××ת
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/164#issuecomment-128366820
I agree that in the long run this could be a better solution but I believe
that making small steps here is important and solve current problems
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/164#issuecomment-128293669
I changed the implementation according to the new rule:
"paragraph type will be set by the first magic word in the paragraph" this
allow
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/164#issuecomment-126936773
I see, this changes the rule we thought of but it needs to be fixed.
I suggest the new rule: paragraph type will be set by the first magic word
in
91 matches
Mail list logo
