Review Request: The jute parser should get generated from the jj files instead of checking in the generated sources

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1711/ --- Review request for zookeeper. Summary --- The patch seems large since it

[jira] [Commented] (ZOOKEEPER-96) The jute parser should get generated from the jj files instead of checking in the generated sources

[ https://issues.apache.org/jira/browse/ZOOKEEPER-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13097051#comment-13097051 ] jirapos...@reviews.apache.org commented on ZOOKEEPER-96:

[jira] [Commented] (ZOOKEEPER-851) ZK lets any node to become an observer

[ https://issues.apache.org/jira/browse/ZOOKEEPER-851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13097061#comment-13097061 ] Laxman commented on ZOOKEEPER-851: -- Thanks for all your inputs. Initially I looked at

RE: 3.4 update.

While submitting the patch, I marked ZK-851 as 3.4 as the patch looks trivial. This can be moved out of 3.4 as the approach is not yet finalized and this is not a blocker for 3.4 if no other objections. -Laxman -Original Message- From: Benjamin Reed [mailto:br...@apache.org] Sent:

[jira] [Commented] (ZOOKEEPER-1008) ZK should give more specific error on missing myid

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13097128#comment-13097128 ] Thomas Koch commented on ZOOKEEPER-1008: Hi, as you can see below, the

[jira] [Commented] (ZOOKEEPER-974) Configurable listen socket backlog for the client port

[ https://issues.apache.org/jira/browse/ZOOKEEPER-974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13097129#comment-13097129 ] Thomas Koch commented on ZOOKEEPER-974: --- Could you add some documentation so that

[jira] [Commented] (ZOOKEEPER-1053) PurgeTxnLog only take relative path

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13097173#comment-13097173 ] Thomas Koch commented on ZOOKEEPER-1053: Hi, I don't understand your problem.

[jira] [Updated] (ZOOKEEPER-786) Exception in ZooKeeper.toString

[ https://issues.apache.org/jira/browse/ZOOKEEPER-786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Koch updated ZOOKEEPER-786: -- Attachment: ZOOKEEPER-786.patch This patch introduces caching of

Review Request: Exception in ZooKeeper.toString

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1714/ --- Review request for zookeeper. Summary --- . This addresses bug

[jira] [Commented] (ZOOKEEPER-786) Exception in ZooKeeper.toString

[ https://issues.apache.org/jira/browse/ZOOKEEPER-786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13097179#comment-13097179 ] jirapos...@reviews.apache.org commented on ZOOKEEPER-786: -

Failed: ZOOKEEPER-786 PreCommit Build #500

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-786 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/500/ ### ## LAST 60 LINES OF THE CONSOLE ###

Review Request: Zookeeper#delete , #create - async versions miss a verb in the javadoc

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1715/ --- Review request for zookeeper. Summary --- . This addresses bug

[jira] [Commented] (ZOOKEEPER-731) Zookeeper#delete , #create - async versions miss a verb in the javadoc

[ https://issues.apache.org/jira/browse/ZOOKEEPER-731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13097200#comment-13097200 ] Hadoop QA commented on ZOOKEEPER-731: - +1 overall. Here are the results of testing

Re: ZooKeeper cleanup / refactoring / scala migration

+1, having sonar would be nice although I've found that having tools that no one pays attention to is not useful. The best way to combat that is to integrate it into the build (e.g. hadoop QA bot). On Mon, Sep 5, 2011 at 1:27 AM, Thomas Koch tho...@koch.ro wrote: Hi Camille, We already have a

[jira] [Commented] (ZOOKEEPER-1158) C# client

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13097228#comment-13097228 ] Patrick Hunt commented on ZOOKEEPER-1158: - it might be the some of the files

Failed: ZOOKEEPER-899 PreCommit Build #502

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-899 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/502/ ### ## LAST 60 LINES OF THE CONSOLE ###

[jira] [Commented] (ZOOKEEPER-899) Update Netty version in trunk to 3.2.2

[ https://issues.apache.org/jira/browse/ZOOKEEPER-899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13097238#comment-13097238 ] Hadoop QA commented on ZOOKEEPER-899: - -1 overall. Here are the results of testing

[jira] [Commented] (ZOOKEEPER-731) Zookeeper#delete , #create - async versions miss a verb in the javadoc

[ https://issues.apache.org/jira/browse/ZOOKEEPER-731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13097269#comment-13097269 ] jirapos...@reviews.apache.org commented on ZOOKEEPER-731: -

Re: Review Request: Zookeeper#delete , #create - async versions miss a verb in the javadoc

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1715/#review1751 --- src/java/main/org/apache/zookeeper/ZooKeeper.java

[jira] [Commented] (ZOOKEEPER-1159) ClientCnxn does not propagate session expiration indication

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13097285#comment-13097285 ] Camille Fournier commented on ZOOKEEPER-1159: - Now I remember my own

[jira] [Commented] (ZOOKEEPER-731) Zookeeper#delete , #create - async versions miss a verb in the javadoc

[ https://issues.apache.org/jira/browse/ZOOKEEPER-731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13097286#comment-13097286 ] jirapos...@reviews.apache.org commented on ZOOKEEPER-731: -

[jira] [Commented] (ZOOKEEPER-939) the threads number of a zookeeper is increased all the time

[ https://issues.apache.org/jira/browse/ZOOKEEPER-939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13097289#comment-13097289 ] Thomas Koch commented on ZOOKEEPER-939: --- Since ZOOKEEPER-880 has been fixed, this

[jira] [Commented] (ZOOKEEPER-833) Attachments in the wiki do not work (so no presentations)

[ https://issues.apache.org/jira/browse/ZOOKEEPER-833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13097296#comment-13097296 ] Thomas Koch commented on ZOOKEEPER-833: --- I've tested now that I can download

[jira] [Resolved] (ZOOKEEPER-833) Attachments in the wiki do not work (so no presentations)

[ https://issues.apache.org/jira/browse/ZOOKEEPER-833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Koch resolved ZOOKEEPER-833. --- Resolution: Fixed Assignee: Thomas Koch Attachments in the wiki do not work (so no

Re: Review Request: Zookeeper#delete , #create - async versions miss a verb in the javadoc

On 2011-09-05 19:43:32, Thomas Koch wrote: src/java/main/org/apache/zookeeper/ZooKeeper.java, line 90 https://reviews.apache.org/r/1715/diff/1/?file=37951#file37951line90 it is unrelated to the rest of the patch, but I touched the file anyway and it's an obvious clean up that

[jira] [Commented] (ZOOKEEPER-731) Zookeeper#delete , #create - async versions miss a verb in the javadoc

[ https://issues.apache.org/jira/browse/ZOOKEEPER-731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13097300#comment-13097300 ] jirapos...@reviews.apache.org commented on ZOOKEEPER-731: -

Re: Review Request: Zookeeper#delete , #create - async versions miss a verb in the javadoc

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1715/#review1753 --- src/java/main/org/apache/zookeeper/ZooKeeper.java

[jira] [Assigned] (ZOOKEEPER-731) Zookeeper#delete , #create - async versions miss a verb in the javadoc

[ https://issues.apache.org/jira/browse/ZOOKEEPER-731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Camille Fournier reassigned ZOOKEEPER-731: -- Assignee: Thomas Koch Zookeeper#delete , #create - async versions miss a

[jira] [Commented] (ZOOKEEPER-731) Zookeeper#delete , #create - async versions miss a verb in the javadoc

[ https://issues.apache.org/jira/browse/ZOOKEEPER-731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13097304#comment-13097304 ] jirapos...@reviews.apache.org commented on ZOOKEEPER-731: -

Review Request: ZookeeperServer does not close zk database on shutdwon

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1718/ --- Review request for zookeeper. Summary --- . This addresses bug

[jira] [Commented] (ZOOKEEPER-978) ZookeeperServer does not close zk database on shutdwon

[ https://issues.apache.org/jira/browse/ZOOKEEPER-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13097306#comment-13097306 ] jirapos...@reviews.apache.org commented on ZOOKEEPER-978: -

Failed: ZOOKEEPER-978 PreCommit Build #503

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-978 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/503/ ### ## LAST 60 LINES OF THE CONSOLE ###

[jira] [Commented] (ZOOKEEPER-978) ZookeeperServer does not close zk database on shutdwon

[ https://issues.apache.org/jira/browse/ZOOKEEPER-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13097310#comment-13097310 ] Hadoop QA commented on ZOOKEEPER-978: - -1 overall. Here are the results of testing

Re: Review Request: Zookeeper#delete , #create - async versions miss a verb in the javadoc

On 2011-09-05 20:04:12, Patrick Hunt wrote: src/java/main/org/apache/zookeeper/ZooKeeper.java, lines 90-94 https://reviews.apache.org/r/1715/diff/1/?file=37951#file37951line90 I suspect LOG is initialized in the static to make initialization explicit - given logEnv uses LOG as an

[jira] [Commented] (ZOOKEEPER-731) Zookeeper#delete , #create - async versions miss a verb in the javadoc

[ https://issues.apache.org/jira/browse/ZOOKEEPER-731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13097610#comment-13097610 ] jirapos...@reviews.apache.org commented on ZOOKEEPER-731: -

Re: Review Request: Zookeeper#delete , #create - async versions miss a verb in the javadoc

On 2011-09-05 20:04:12, Patrick Hunt wrote: src/java/main/org/apache/zookeeper/ZooKeeper.java, lines 90-94 https://reviews.apache.org/r/1715/diff/1/?file=37951#file37951line90 I suspect LOG is initialized in the static to make initialization explicit - given logEnv uses LOG as an

[jira] [Commented] (ZOOKEEPER-731) Zookeeper#delete , #create - async versions miss a verb in the javadoc

[ https://issues.apache.org/jira/browse/ZOOKEEPER-731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13097613#comment-13097613 ] jirapos...@reviews.apache.org commented on ZOOKEEPER-731: -

Re: Review Request: Zookeeper#delete , #create - async versions miss a verb in the javadoc

On 2011-09-05 20:04:12, Patrick Hunt wrote: src/java/main/org/apache/zookeeper/ZooKeeper.java, lines 90-94 https://reviews.apache.org/r/1715/diff/1/?file=37951#file37951line90 I suspect LOG is initialized in the static to make initialization explicit - given logEnv uses LOG as an

[jira] [Updated] (ZOOKEEPER-731) Zookeeper#delete , #create - async versions miss a verb in the javadoc

[ https://issues.apache.org/jira/browse/ZOOKEEPER-731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Camille Fournier updated ZOOKEEPER-731: --- Attachment: ZOOKEEPER-731-fix.patch Zookeeper#delete , #create - async versions

[jira] [Commented] (ZOOKEEPER-731) Zookeeper#delete , #create - async versions miss a verb in the javadoc

[ https://issues.apache.org/jira/browse/ZOOKEEPER-731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13097616#comment-13097616 ] jirapos...@reviews.apache.org commented on ZOOKEEPER-731: -

Re: Review Request: Zookeeper#delete , #create - async versions miss a verb in the javadoc

On 2011-09-05 20:04:12, Patrick Hunt wrote: src/java/main/org/apache/zookeeper/ZooKeeper.java, lines 90-94 https://reviews.apache.org/r/1715/diff/1/?file=37951#file37951line90 I suspect LOG is initialized in the static to make initialization explicit - given logEnv uses LOG as an

[jira] [Updated] (ZOOKEEPER-731) Zookeeper#delete , #create - async versions miss a verb in the javadoc

[ https://issues.apache.org/jira/browse/ZOOKEEPER-731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Camille Fournier updated ZOOKEEPER-731: --- Attachment: ZOOKEEPER-731-fix2.patch Zookeeper#delete , #create - async

[jira] [Commented] (ZOOKEEPER-731) Zookeeper#delete , #create - async versions miss a verb in the javadoc

[ https://issues.apache.org/jira/browse/ZOOKEEPER-731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13097618#comment-13097618 ] jirapos...@reviews.apache.org commented on ZOOKEEPER-731: -

Failed: ZOOKEEPER-731 PreCommit Build #504

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-731 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/504/ ### ## LAST 60 LINES OF THE CONSOLE ###

[jira] [Commented] (ZOOKEEPER-731) Zookeeper#delete , #create - async versions miss a verb in the javadoc

[ https://issues.apache.org/jira/browse/ZOOKEEPER-731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13097619#comment-13097619 ] Hadoop QA commented on ZOOKEEPER-731: - -1 overall. Here are the results of testing

[jira] [Resolved] (ZOOKEEPER-939) the threads number of a zookeeper is increased all the time

[ https://issues.apache.org/jira/browse/ZOOKEEPER-939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar resolved ZOOKEEPER-939. - Resolution: Duplicate Resolving as duplicate of ZOOKEEPER-880. thanks for pointing

[jira] [Updated] (BOOKKEEPER-63) Hedwig PubSubServer must wait for its Zookeeper client to be connected upon startup

[ https://issues.apache.org/jira/browse/BOOKKEEPER-63?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthieu Morel updated BOOKKEEPER-63: - Attachment: BOOKKEEPER-63.patch new patch taking into account tests with standalone

[jira] [Updated] (BOOKKEEPER-63) Hedwig PubSubServer must wait for its Zookeeper client to be connected upon startup

[ https://issues.apache.org/jira/browse/BOOKKEEPER-63?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthieu Morel updated BOOKKEEPER-63: - Attachment: BOOKKEEPER-63.patch new patch with wait code moved to

[jira] [Updated] (BOOKKEEPER-59) Race condition in netty code allocates and orphans resources (BK-5 revisited)

[ https://issues.apache.org/jira/browse/BOOKKEEPER-59?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Junqueira updated BOOKKEEPER-59: --- Assignee: Ivan Kelly Race condition in netty code allocates and orphans

[jira] [Assigned] (BOOKKEEPER-55) SubscribeReconnectRetryTask might retry subscription endlessly when another subscription is already successfully created previously

[ https://issues.apache.org/jira/browse/BOOKKEEPER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Junqueira reassigned BOOKKEEPER-55: -- Assignee: Gavin Li SubscribeReconnectRetryTask might retry subscription

[jira] [Updated] (BOOKKEEPER-26) Indentation is all messed up in the BookKeeper code

[ https://issues.apache.org/jira/browse/BOOKKEEPER-26?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated BOOKKEEPER-26: - Attachment: BOOKKEEPER-26.against_r1165231.patch Generated using astyle against r1165231 of

[jira] [Updated] (BOOKKEEPER-26) Indentation is all messed up in the BookKeeper code

[ https://issues.apache.org/jira/browse/BOOKKEEPER-26?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated BOOKKEEPER-26: - Attachment: BOOKKEEPER-26.against_r1165231.patch Fixed 'throws' on new lines. Indentation