[jira] [Commented] (ZOOKEEPER-2627) Remove ZRWSERVERFOUND from C client and replace handle_error with something more semantically explicit for r/w server reconnect.

2016-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15641257#comment-15641257 ] ASF GitHub Bot commented on ZOOKEEPER-2627: --- Github user hanm commented on t

[GitHub] zookeeper issue #100: ZOOKEEPER-2627:Remove ZRWSERVERFOUND from C client.

2016-11-05 Thread hanm
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/100 @rgs1 Sure, no need to rush this in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[jira] [Commented] (ZOOKEEPER-2627) Remove ZRWSERVERFOUND from C client and replace handle_error with something more semantically explicit for r/w server reconnect.

2016-11-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15641224#comment-15641224 ] Hadoop QA commented on ZOOKEEPER-2627: -- -1 overall. Here are the results of test

Failed: ZOOKEEPER-2627 PreCommit Build #3523

2016-11-05 Thread Apache Jenkins Server
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2627 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3523/ ### ## LAST 60 LINES OF THE CONSOLE ### [

[jira] [Commented] (ZOOKEEPER-2014) Only admin should be allowed to reconfig a cluster

2016-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15641216#comment-15641216 ] ASF GitHub Bot commented on ZOOKEEPER-2014: --- Github user breed commented on

[jira] [Commented] (ZOOKEEPER-2014) Only admin should be allowed to reconfig a cluster

2016-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15641220#comment-15641220 ] ASF GitHub Bot commented on ZOOKEEPER-2014: --- Github user breed commented on

[jira] [Commented] (ZOOKEEPER-2014) Only admin should be allowed to reconfig a cluster

2016-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15641217#comment-15641217 ] ASF GitHub Bot commented on ZOOKEEPER-2014: --- Github user breed commented on

[jira] [Commented] (ZOOKEEPER-2014) Only admin should be allowed to reconfig a cluster

2016-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15641218#comment-15641218 ] ASF GitHub Bot commented on ZOOKEEPER-2014: --- Github user breed commented on

[jira] [Commented] (ZOOKEEPER-2014) Only admin should be allowed to reconfig a cluster

2016-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15641219#comment-15641219 ] ASF GitHub Bot commented on ZOOKEEPER-2014: --- Github user breed commented on

[jira] [Commented] (ZOOKEEPER-2014) Only admin should be allowed to reconfig a cluster

2016-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15641215#comment-15641215 ] ASF GitHub Bot commented on ZOOKEEPER-2014: --- Github user breed commented on

[GitHub] zookeeper pull request #96: ZOOKEEPER-2014: Only admin should be allowed to ...

2016-11-05 Thread breed
Github user breed commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/96#discussion_r86679058 --- Diff: src/java/test/org/apache/zookeeper/server/DataTreeTest.java --- @@ -200,29 +198,34 @@ public void testSerializeDoesntLockDataNodeWhileWriting() thro

[GitHub] zookeeper pull request #96: ZOOKEEPER-2014: Only admin should be allowed to ...

2016-11-05 Thread breed
Github user breed commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/96#discussion_r86678939 --- Diff: src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml --- @@ -1108,6 +1109,42 @@ server.3=zoo3:2888:3888

[GitHub] zookeeper pull request #96: ZOOKEEPER-2014: Only admin should be allowed to ...

2016-11-05 Thread breed
Github user breed commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/96#discussion_r86679094 --- Diff: src/java/test/org/apache/zookeeper/test/ReconfigExceptionTest.java --- @@ -0,0 +1,220 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] zookeeper pull request #96: ZOOKEEPER-2014: Only admin should be allowed to ...

2016-11-05 Thread breed
Github user breed commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/96#discussion_r86679075 --- Diff: src/java/test/org/apache/zookeeper/test/ClientBase.java --- @@ -356,7 +356,7 @@ private static int getPort(String hostPort) { */ p

[GitHub] zookeeper pull request #96: ZOOKEEPER-2014: Only admin should be allowed to ...

2016-11-05 Thread breed
Github user breed commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/96#discussion_r86679106 --- Diff: src/java/test/org/apache/zookeeper/test/ReconfigExceptionTest.java --- @@ -0,0 +1,220 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] zookeeper pull request #96: ZOOKEEPER-2014: Only admin should be allowed to ...

2016-11-05 Thread breed
Github user breed commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/96#discussion_r86679034 --- Diff: src/java/main/org/apache/zookeeper/server/DataTree.java --- @@ -245,15 +245,25 @@ public DataTree() { addConfigNode(); }

[jira] [Commented] (ZOOKEEPER-2624) Add test script for pull requests

2016-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15641205#comment-15641205 ] ASF GitHub Bot commented on ZOOKEEPER-2624: --- Github user breed commented on

[GitHub] zookeeper pull request #97: ZOOKEEPER-2624: Add test script for pull request...

2016-11-05 Thread breed
Github user breed commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/97#discussion_r86679336 --- Diff: src/java/test/bin/test-github-pr.sh --- @@ -0,0 +1,612 @@ +#!/usr/bin/env bash +# Licensed under the Apache License, Version 2.0 (the "Lice

[GitHub] zookeeper pull request #97: ZOOKEEPER-2624: Add test script for pull request...

2016-11-05 Thread breed
Github user breed commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/97#discussion_r86679319 --- Diff: src/java/test/bin/test-github-pr.sh --- @@ -0,0 +1,612 @@ +#!/usr/bin/env bash +# Licensed under the Apache License, Version 2.0 (the "Lice

[jira] [Commented] (ZOOKEEPER-2624) Add test script for pull requests

2016-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15641206#comment-15641206 ] ASF GitHub Bot commented on ZOOKEEPER-2624: --- Github user breed commented on

[jira] [Commented] (ZOOKEEPER-2624) Add test script for pull requests

2016-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15641204#comment-15641204 ] ASF GitHub Bot commented on ZOOKEEPER-2624: --- Github user breed commented on

[GitHub] zookeeper pull request #97: ZOOKEEPER-2624: Add test script for pull request...

2016-11-05 Thread breed
Github user breed commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/97#discussion_r86679330 --- Diff: src/java/test/bin/test-github-pr.sh --- @@ -0,0 +1,612 @@ +#!/usr/bin/env bash +# Licensed under the Apache License, Version 2.0 (the "Lice

[jira] [Commented] (ZOOKEEPER-2624) Add test script for pull requests

2016-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15641203#comment-15641203 ] ASF GitHub Bot commented on ZOOKEEPER-2624: --- Github user breed commented on

[GitHub] zookeeper pull request #97: ZOOKEEPER-2624: Add test script for pull request...

2016-11-05 Thread breed
Github user breed commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/97#discussion_r86679277 --- Diff: src/java/test/bin/test-github-pr.sh --- @@ -0,0 +1,612 @@ +#!/usr/bin/env bash +# Licensed under the Apache License, Version 2.0 (the "Lice

[GitHub] zookeeper issue #100: ZOOKEEPER-2627:Remove ZRWSERVERFOUND from C client.

2016-11-05 Thread rgs1
Github user rgs1 commented on the issue: https://github.com/apache/zookeeper/pull/100 Thanks @hanm ! Lets wait until Monday to see what @breed thinks and then I am happy to merge this. What do you think? --- If your project is set up for it, you can reply to this email and have your

[jira] [Commented] (ZOOKEEPER-2627) Remove ZRWSERVERFOUND from C client and replace handle_error with something more semantically explicit for r/w server reconnect.

2016-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15641191#comment-15641191 ] ASF GitHub Bot commented on ZOOKEEPER-2627: --- Github user rgs1 commented on t

ZooKeeper-trunk-WinVS2008 - Build # 2315 - Still Failing

2016-11-05 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008/2315/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 78 lines...] ivy-retrieve: [ivy:retrieve] :: Apa

[jira] [Commented] (ZOOKEEPER-2627) Remove ZRWSERVERFOUND from C client and replace handle_error with something more semantically explicit for r/w server reconnect.

2016-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15641182#comment-15641182 ] ASF GitHub Bot commented on ZOOKEEPER-2627: --- Github user hanm commented on t

[GitHub] zookeeper issue #100: ZOOKEEPER-2627:Remove ZRWSERVERFOUND from C client.

2016-11-05 Thread hanm
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/100 Thanks for the review, @rgs1. Patch and PR is updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[jira] [Updated] (ZOOKEEPER-2627) Remove ZRWSERVERFOUND from C client and replace handle_error with something more semantically explicit for r/w server reconnect.

2016-11-05 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han updated ZOOKEEPER-2627: --- Attachment: ZOOKEEPER-2627.patch > Remove ZRWSERVERFOUND from C client and replace handle_

Failed: ZOOKEEPER- PreCommit Build #41

2016-11-05 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/41/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 25 lines...] Getting sizes Done:

[GitHub] zookeeper pull request #99: ZOOKEEPER-2549 Add exception handling to sendRes...

2016-11-05 Thread rgs1
Github user rgs1 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/99#discussion_r86679205 --- Diff: src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java --- @@ -842,7 +868,26 @@ private void addCnxn(NIOServerCnxn cnxn) {

[jira] [Commented] (ZOOKEEPER-2549) As NettyServerCnxn.sendResponse() allows all the exception to bubble up it can stop main ZK requests processing thread

2016-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15641172#comment-15641172 ] ASF GitHub Bot commented on ZOOKEEPER-2549: --- Github user rgs1 commented on a

[GitHub] zookeeper pull request #99: ZOOKEEPER-2549 Add exception handling to sendRes...

2016-11-05 Thread rgs1
Github user rgs1 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/99#discussion_r86679164 --- Diff: src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java --- @@ -716,7 +716,12 @@ public void process(WatchedEvent event) { // Conver

[jira] [Commented] (ZOOKEEPER-2549) As NettyServerCnxn.sendResponse() allows all the exception to bubble up it can stop main ZK requests processing thread

2016-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15641168#comment-15641168 ] ASF GitHub Bot commented on ZOOKEEPER-2549: --- Github user rgs1 commented on a

[jira] [Commented] (ZOOKEEPER-2624) Add test script for pull requests

2016-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15641162#comment-15641162 ] ASF GitHub Bot commented on ZOOKEEPER-2624: --- Github user rgs1 commented on t

[GitHub] zookeeper issue #97: ZOOKEEPER-2624: Add test script for pull requests

2016-11-05 Thread rgs1
Github user rgs1 commented on the issue: https://github.com/apache/zookeeper/pull/97 @hanm @fpj i say we merge it and keep iterating; it'll be easier to get it right once we are using it. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] zookeeper pull request #97: ZOOKEEPER-2624: Add test script for pull request...

2016-11-05 Thread rgs1
Github user rgs1 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/97#discussion_r86679093 --- Diff: src/java/test/bin/test-github-pr.sh --- @@ -0,0 +1,605 @@ +#!/usr/bin/env bash +# Licensed under the Apache License, Version 2.0 (the "Licen

[jira] [Commented] (ZOOKEEPER-2624) Add test script for pull requests

2016-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15641159#comment-15641159 ] ASF GitHub Bot commented on ZOOKEEPER-2624: --- Github user rgs1 commented on a

ZooKeeper_branch34 - Build # 1711 - Still Failing

2016-11-05 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch34/1711/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 1471 lines...] [mkdir] Created dir: /home/jenkins/j

ZooKeeper-trunk - Build # 3145 - Failure

2016-11-05 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk/3145/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 467957 lines...] [junit] 2016-11-05 23:29:41,534 [myid:

[jira] [Commented] (ZOOKEEPER-2549) As NettyServerCnxn.sendResponse() allows all the exception to bubble up it can stop main ZK requests processing thread

2016-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15640683#comment-15640683 ] ASF GitHub Bot commented on ZOOKEEPER-2549: --- Github user yufeldman commented

[jira] [Commented] (ZOOKEEPER-2549) As NettyServerCnxn.sendResponse() allows all the exception to bubble up it can stop main ZK requests processing thread

2016-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15640685#comment-15640685 ] ASF GitHub Bot commented on ZOOKEEPER-2549: --- Github user yufeldman commented

[jira] [Commented] (ZOOKEEPER-2549) As NettyServerCnxn.sendResponse() allows all the exception to bubble up it can stop main ZK requests processing thread

2016-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15640684#comment-15640684 ] ASF GitHub Bot commented on ZOOKEEPER-2549: --- Github user yufeldman commented

[GitHub] zookeeper pull request #99: ZOOKEEPER-2549 Add exception handling to sendRes...

2016-11-05 Thread yufeldman
Github user yufeldman commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/99#discussion_r86673997 --- Diff: src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java --- @@ -716,7 +716,12 @@ public void process(WatchedEvent event) { // C

[GitHub] zookeeper pull request #99: ZOOKEEPER-2549 Add exception handling to sendRes...

2016-11-05 Thread yufeldman
Github user yufeldman commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/99#discussion_r86674430 --- Diff: src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java --- @@ -716,7 +716,12 @@ public void process(WatchedEvent event) { // C

[GitHub] zookeeper pull request #99: ZOOKEEPER-2549 Add exception handling to sendRes...

2016-11-05 Thread yufeldman
Github user yufeldman commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/99#discussion_r86674332 --- Diff: src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java --- @@ -842,7 +868,26 @@ private void addCnxn(NIOServerCnxn cnxn) {

[jira] [Commented] (ZOOKEEPER-2014) Only admin should be allowed to reconfig a cluster

2016-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15640611#comment-15640611 ] ASF GitHub Bot commented on ZOOKEEPER-2014: --- Github user rgs1 commented on a

[jira] [Commented] (ZOOKEEPER-2014) Only admin should be allowed to reconfig a cluster

2016-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15640612#comment-15640612 ] ASF GitHub Bot commented on ZOOKEEPER-2014: --- Github user rgs1 commented on a

[jira] [Commented] (ZOOKEEPER-2014) Only admin should be allowed to reconfig a cluster

2016-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15640613#comment-15640613 ] ASF GitHub Bot commented on ZOOKEEPER-2014: --- Github user rgs1 commented on a

[GitHub] zookeeper pull request #96: ZOOKEEPER-2014: Only admin should be allowed to ...

2016-11-05 Thread rgs1
Github user rgs1 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/96#discussion_r86673489 --- Diff: src/java/main/org/apache/zookeeper/server/DataTree.java --- @@ -245,15 +245,25 @@ public DataTree() { addConfigNode(); }

[GitHub] zookeeper pull request #96: ZOOKEEPER-2014: Only admin should be allowed to ...

2016-11-05 Thread rgs1
Github user rgs1 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/96#discussion_r86673398 --- Diff: src/c/tests/TestReconfigServer.cc --- @@ -324,4 +336,109 @@ testRemoveConnectedFollower() { zookeeper_close(zk); } +/** +

[GitHub] zookeeper pull request #96: ZOOKEEPER-2014: Only admin should be allowed to ...

2016-11-05 Thread rgs1
Github user rgs1 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/96#discussion_r86673475 --- Diff: src/java/main/org/apache/zookeeper/server/DataTree.java --- @@ -245,15 +245,25 @@ public DataTree() { addConfigNode(); }

[jira] [Commented] (ZOOKEEPER-2627) Remove ZRWSERVERFOUND from C client and replace handle_error with something more semantically explicit for r/w server reconnect.

2016-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15640588#comment-15640588 ] ASF GitHub Bot commented on ZOOKEEPER-2627: --- Github user rgs1 commented on a

[jira] [Commented] (ZOOKEEPER-2627) Remove ZRWSERVERFOUND from C client and replace handle_error with something more semantically explicit for r/w server reconnect.

2016-11-05 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15640591#comment-15640591 ] Raul Gutierrez Segales commented on ZOOKEEPER-2627: --- Thanks for clea

[jira] [Commented] (ZOOKEEPER-2627) Remove ZRWSERVERFOUND from C client and replace handle_error with something more semantically explicit for r/w server reconnect.

2016-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15640589#comment-15640589 ] ASF GitHub Bot commented on ZOOKEEPER-2627: --- Github user rgs1 commented on a

[GitHub] zookeeper pull request #100: ZOOKEEPER-2627:Remove ZRWSERVERFOUND from C cli...

2016-11-05 Thread rgs1
Github user rgs1 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/100#discussion_r86673221 --- Diff: src/c/src/zookeeper.c --- @@ -1702,15 +1703,9 @@ static void handle_error(zhandle_t *zh,int rc) } cleanup_bufs(zh,1,rc); z

[GitHub] zookeeper pull request #100: ZOOKEEPER-2627:Remove ZRWSERVERFOUND from C cli...

2016-11-05 Thread rgs1
Github user rgs1 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/100#discussion_r86673245 --- Diff: src/c/src/zookeeper.c --- @@ -2072,6 +2076,11 @@ static int ping_rw_server(zhandle_t* zh) out: close(sock); +if (!rc) {

[jira] [Commented] (ZOOKEEPER-2549) As NettyServerCnxn.sendResponse() allows all the exception to bubble up it can stop main ZK requests processing thread

2016-11-05 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15640557#comment-15640557 ] Raul Gutierrez Segales commented on ZOOKEEPER-2549: --- [~yufeldman]: t

[jira] [Commented] (ZOOKEEPER-2549) As NettyServerCnxn.sendResponse() allows all the exception to bubble up it can stop main ZK requests processing thread

2016-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15640551#comment-15640551 ] ASF GitHub Bot commented on ZOOKEEPER-2549: --- Github user rgs1 commented on a

[jira] [Commented] (ZOOKEEPER-2549) As NettyServerCnxn.sendResponse() allows all the exception to bubble up it can stop main ZK requests processing thread

2016-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15640553#comment-15640553 ] ASF GitHub Bot commented on ZOOKEEPER-2549: --- Github user rgs1 commented on a

[jira] [Commented] (ZOOKEEPER-2549) As NettyServerCnxn.sendResponse() allows all the exception to bubble up it can stop main ZK requests processing thread

2016-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15640555#comment-15640555 ] ASF GitHub Bot commented on ZOOKEEPER-2549: --- Github user rgs1 commented on a

[jira] [Commented] (ZOOKEEPER-2549) As NettyServerCnxn.sendResponse() allows all the exception to bubble up it can stop main ZK requests processing thread

2016-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15640554#comment-15640554 ] ASF GitHub Bot commented on ZOOKEEPER-2549: --- Github user rgs1 commented on a

[jira] [Commented] (ZOOKEEPER-2549) As NettyServerCnxn.sendResponse() allows all the exception to bubble up it can stop main ZK requests processing thread

2016-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15640552#comment-15640552 ] ASF GitHub Bot commented on ZOOKEEPER-2549: --- Github user rgs1 commented on a

[GitHub] zookeeper pull request #99: ZOOKEEPER-2549 Add exception handling to sendRes...

2016-11-05 Thread rgs1
Github user rgs1 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/99#discussion_r86672337 --- Diff: src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java --- @@ -716,7 +716,12 @@ public void process(WatchedEvent event) { // Conver

[GitHub] zookeeper pull request #99: ZOOKEEPER-2549 Add exception handling to sendRes...

2016-11-05 Thread rgs1
Github user rgs1 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/99#discussion_r86672419 --- Diff: src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java --- @@ -105,8 +115,26 @@ public void channelConnected(ChannelHandlerContext ctx

[GitHub] zookeeper pull request #99: ZOOKEEPER-2549 Add exception handling to sendRes...

2016-11-05 Thread rgs1
Github user rgs1 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/99#discussion_r86672349 --- Diff: src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java --- @@ -630,6 +640,22 @@ public static ByteBuffer getDirectBuffer() { *

[GitHub] zookeeper pull request #99: ZOOKEEPER-2549 Add exception handling to sendRes...

2016-11-05 Thread rgs1
Github user rgs1 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/99#discussion_r86672326 --- Diff: src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java --- @@ -716,7 +716,12 @@ public void process(WatchedEvent event) { // Conver

[GitHub] zookeeper pull request #99: ZOOKEEPER-2549 Add exception handling to sendRes...

2016-11-05 Thread rgs1
Github user rgs1 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/99#discussion_r86672385 --- Diff: src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java --- @@ -842,7 +868,26 @@ private void addCnxn(NIOServerCnxn cnxn) {

ZooKeeper-trunk-openjdk7 - Build # 1228 - Failure

2016-11-05 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk-openjdk7/1228/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 459298 lines...] [junit] 2016-11-05 20:02:45,2

Re: Jenkins issue

2016-11-05 Thread Raúl Gutiérrez Segalés
On 5 November 2016 at 10:21, Michael Han wrote: > >> Might as well fix the issues > +1. Created ZOOKEEPER-2628 for this task. > thanks Michael! -rgs

[jira] [Commented] (ZOOKEEPER-2549) As NettyServerCnxn.sendResponse() allows all the exception to bubble up it can stop main ZK requests processing thread

2016-11-05 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15640362#comment-15640362 ] Raul Gutierrez Segales commented on ZOOKEEPER-2549: --- we can ignore t

[jira] [Resolved] (ZOOKEEPER-1594) TestReconfig intermittently fails

2016-11-05 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han resolved ZOOKEEPER-1594. Resolution: Duplicate > TestReconfig intermittently fails >

[jira] [Commented] (ZOOKEEPER-1594) TestReconfig intermittently fails

2016-11-05 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15640175#comment-15640175 ] Michael Han commented on ZOOKEEPER-1594: This issue should be a duplicate of Z

Re: Jenkins issue

2016-11-05 Thread Michael Han
>> Might as well fix the issues +1. Created ZOOKEEPER-2628 for this task. On Sat, Nov 5, 2016 at 9:01 AM, Jordan Zimmerman wrote: > Might as well fix the issues, merge to master and merge into the existing > PRs. Then it will be done. Thoughts? > > -Jordan > > > On Nov 5, 2016, at 10:46 AM, Flav

ZooKeeper_branch35_solaris - Build # 307 - Still Failing

2016-11-05 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch35_solaris/307/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 438923 lines...] [junit] 2016-11-05 17:13:26,

[jira] [Commented] (ZOOKEEPER-2384) Support atomic increment / decrement of znode value

2016-11-05 Thread Jordan Zimmerman (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15639919#comment-15639919 ] Jordan Zimmerman commented on ZOOKEEPER-2384: - FYI - Curator has a recipe

Re: Jenkins issue

2016-11-05 Thread Jordan Zimmerman
Might as well fix the issues, merge to master and merge into the existing PRs. Then it will be done. Thoughts? -Jordan > On Nov 5, 2016, at 10:46 AM, Flavio P JUNQUEIRA wrote: > > What do you people think we should do, try the earlier version or try to > fix the issues with the latest findbugs

Re: Jenkins issue

2016-11-05 Thread Flavio P JUNQUEIRA
What do you people think we should do, try the earlier version or try to fix the issues with the latest findbugs? -Flavio On 4 Nov 2016 22:34, "Flavio Junqueira" wrote: > Got a response on the builds list: > > > Ok yes I upgraded Findbugs to 3.0.1 > > > > Latest symlink was changed to point to

ZooKeeper-trunk-jdk8 - Build # 808 - Still Failing

2016-11-05 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk-jdk8/808/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 464467 lines...] [junit] 2016-11-05 11:54:55,342 [m

ZooKeeper_branch35_openjdk7 - Build # 287 - Failure

2016-11-05 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch35_openjdk7/287/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 454976 lines...] [junit] 2016-11-05 10:08:37

ZooKeeper-trunk-solaris - Build # 1373 - Still Failing

2016-11-05 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk-solaris/1373/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 442551 lines...] [junit] 2016-11-05 08:36:09,80

[jira] [Commented] (ZOOKEEPER-1594) TestReconfig intermittently fails

2016-11-05 Thread James Brower (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15638970#comment-15638970 ] James Brower commented on ZOOKEEPER-1594: - Hi, I am bringing this up 3 years a

[jira] [Commented] (ZOOKEEPER-2549) As NettyServerCnxn.sendResponse() allows all the exception to bubble up it can stop main ZK requests processing thread

2016-11-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15638838#comment-15638838 ] Hadoop QA commented on ZOOKEEPER-2549: -- -1 overall. Here are the results of test

Failed: ZOOKEEPER-2549 PreCommit Build #3522

2016-11-05 Thread Apache Jenkins Server
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2549 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3522/ ### ## LAST 60 LINES OF THE CONSOLE ### [