Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/137
Right. Thanks for the explanation, @rakeshadr!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/247/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 479740 lines...]
[exec]
[e
Github user hanm commented on the pull request:
https://github.com/apache/zookeeper/commit/de367bf0694ba8adb11d42b4fc07f6e6a851b782#commitcomment-20585960
In src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java:
In src/java/main/org/apache/zookeeper/server/quorum/
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/137
@eribeiro, Earlier with svn revision(integer value), if there is NFE while
parsing arg[1] then it suppress this exception and returns -1. The outer
try-catch block guards the from #parseVersionS
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/246/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 478775 lines...]
[exec]
[e
See https://builds.apache.org/job/ZooKeeper_branch34/1807/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 245954 lines...]
[junit] 2017-01-24 00:50:44,849 [my
Github user hanm commented on the pull request:
https://github.com/apache/zookeeper/commit/de367bf0694ba8adb11d42b4fc07f6e6a851b782#commitcomment-20584729
In src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java:
In src/java/main/org/apache/zookeeper/server/quorum/
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/92#discussion_r97451441
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -434,6 +434,10 @@ public int getQuorumSize(){
//last proposed quorum
Github user shralex commented on the pull request:
https://github.com/apache/zookeeper/commit/de367bf0694ba8adb11d42b4fc07f6e6a851b782#commitcomment-20584642
In src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java:
In src/java/main/org/apache/zookeeper/server/quor
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/92#discussion_r97451281
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -468,31 +469,33 @@ synchronized private boolean connectOne(long sid,
I
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/245/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 25 lines...]
Getting sizes
Done
Github user fpj commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/150#discussion_r97446760
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -87,15 +73,69 @@ public StaticHostProvider(Collection
serverAddresses)
See https://builds.apache.org/job/ZooKeeper_branch35_solaris/407/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 467962 lines...]
[junit] 2017-01-23 23:16:22,
Github user fpj commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/150#discussion_r97437693
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -87,15 +86,69 @@ public StaticHostProvider(Collection
serverAddresses)
Github user fpj commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/150#discussion_r97436370
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -87,15 +73,69 @@ public StaticHostProvider(Collection
serverAddresses)
Github user fpj commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/150#discussion_r97436195
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -57,26 +62,20 @@
public StaticHostProvider(Collection
serverAddres
Github user fpj commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/150#discussion_r97435427
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -57,26 +62,20 @@
public StaticHostProvider(Collection
serverAddres
Oh, got it!
If I run
ant -Dtestcase=WatchManagerPerf test-core-java
it will work as yours. :D
But if I add a "test" word, like
ant test -Dtestcase=CreateTest
or
ant -Dtestcase=CreateTest test
then it will execute the 'CreateTest' only for the java code, but then will
execute the C tests. Ev
See https://builds.apache.org/job/ZooKeeper_branch35_openjdk7/385/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 481714 lines...]
[junit] 2017-01-23 21:52:14
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/389/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 480333 lines...]
[junit] at
org.apache.zook
>> Only that the C tests
run afterwards in spite of the "test-core-java" switch option.
This sounds odd. I just did a test:
1. Sync latest master branch.
2. ant -Dtestcase=WatchManagerPerf test-core-java
I got what I expected.
*junit.run-single:*
*junit.run-concurrent:*
* [echo] Running
+1 about moving ZK-2223 to branch-3.4.
Some context about my particular question: I am able to run a single test
case and a single unit test method in a test class. Only that the C tests
run afterwards in spite of the "test-core-java" switch option. But it's a
minor annoyance, not a real problem.
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/244/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 25 lines...]
Getting sizes
Done
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/243/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 25 lines...]
Getting sizes
Done
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/137
Thanks @arshadmohammad, gonna do that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
More info
https://issues.apache.org/jira/browse/ZOOKEEPER-2223
We might want to get this in branch-3.4 as well - it is a useful feature
for tests.
On Mon, Jan 23, 2017 at 11:39 AM, Michael Han wrote:
> Maybe for Java test
> ant -Dtestcase=case -Dtestmethod=method ? I at least used it successfu
Maybe for Java test
ant -Dtestcase=case -Dtestmethod=method ? I at least used it successfully
on master for a couple of times.
I am not sure how to run a single C test though through ant - I ended up
modifying makefile / test driver to do that instead.
On Mon, Jan 23, 2017 at 11:31 AM, Edward Rib
Github user arshadmohammad commented on the issue:
https://github.com/apache/zookeeper/pull/137
I think we should handle it in the VerGen. Can we trim and then assign the
value to rev variable
As:
rev=rev.trim()
---
If your project is set up for it, you can reply to this emai
Github user arshadmohammad commented on the issue:
https://github.com/apache/zookeeper/pull/137
I verified on windows. Other than one minor problem the current changes
look good to me.
commit hash is getting added with one extra space at the end.
here is srvr command output
Nope. :(
For what is worst: I remember it being able to run *only* a single test
many years ago (~ 2012/2013).
On Mon, Jan 23, 2017 at 5:16 PM, Michael Han wrote:
> ant -Dtestcase=foobar test-core-java ?
>
> On Mon, Jan 23, 2017 at 11:04 AM, Edward Ribeiro >
> wrote:
>
> > Hello community,
> >
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/242/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 474050 lines...]
[exec]
[e
ant -Dtestcase=foobar test-core-java ?
On Mon, Jan 23, 2017 at 11:04 AM, Edward Ribeiro
wrote:
> Hello community,
>
> I am used to run a single unit test with the following command:
>
> ant -Dtestcase=CreateTest test
>
> where "-Dtestcase" especifies the test class name as described here:
> http
Hello community,
I am used to run a single unit test with the following command:
ant -Dtestcase=CreateTest test
where "-Dtestcase" especifies the test class name as described here:
https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute
But for many months, I have seen that, after
See https://builds.apache.org/job/ZooKeeper_branch34_solaris/1443/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 194475 lines...]
[junit] 2017-01-23 18:53:20
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/137
lgtm, though I don't have a windows box to test changes on lastRevision.bat.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
GitHub user hanm opened a pull request:
https://github.com/apache/zookeeper/pull/154
ZOOKEEPER-2672: Remove CHANGE.txt.
The CHANGE.txt is already not the source of truth of what's changed after
we migrating to git - most of the git commits in recent couple of months don't
update CH
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/241/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 30 lines...]
at hudson.remoti
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/240/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 896 lines...]
warning: Cannot merge b
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/239/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 34 lines...]
at hudson.remoti
Kudos Arshad!
Patrick
On Sat, Jan 21, 2017 at 9:05 PM, Rakesh Radhakrishnan
wrote:
> Congratulations, Arshad!
>
> Rakesh
>
> On Sun, Jan 22, 2017 at 4:29 AM, Michael Han wrote:
>
> > Congratulations and welcome aboard, Arshad!
> >
> > On Sat, Jan 21, 2017 at 5:34 AM, Edward Ribeiro <
> edward.
See https://builds.apache.org/job/ZooKeeper_branch35_solaris/406/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 484532 lines...]
[junit] 2017-01-23 17:20:19,
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1360/
###
## LAST 60 LINES OF THE CONSOLE
###
Started by timer
[EnvInject] - Loading node environment varia
See https://builds.apache.org/job/ZooKeeper_branch34_solaris/1442/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 196872 lines...]
[junit] 2017-01-23 13:54:10
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15834470#comment-15834470
]
Thomas Hamm commented on ZOOKEEPER-1736:
[~apurtell], I'm curious about if the
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/388/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 475481 lines...]
[junit] 2017-01-23 12:14:04,675
See https://builds.apache.org/job/ZooKeeper-trunk-jdk8/911/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 461438 lines...]
[junit] at
org.jboss.netty.ch
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/153
Closing the PR manually as this is merged to b-3.4
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15834111#comment-15834111
]
ASF GitHub Bot commented on ZOOKEEPER-2671:
---
Github user rakeshadr closed th
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15834110#comment-15834110
]
ASF GitHub Bot commented on ZOOKEEPER-2671:
---
Github user rakeshadr commented
Github user rakeshadr closed the pull request at:
https://github.com/apache/zookeeper/pull/153
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
See https://builds.apache.org/job/ZooKeeper_branch34_solaris/1441/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 194950 lines...]
[junit] 2017-01-23 08:56:45
See https://builds.apache.org/job/ZooKeeper-trunk-solaris/1476/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 471867 lines...]
[junit] 2017-01-23 08:24:47,07
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15834049#comment-15834049
]
ASF GitHub Bot commented on ZOOKEEPER-2080:
---
Github user shralex commented o
Github user shralex commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/92#discussion_r97266698
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -468,31 +469,33 @@ synchronized private boolean connectOne(long sid,
54 matches
Mail list logo
