[GitHub] zookeeper issue #582: ZOOKEEPER-3103 Pluggable metrics system for ZooKeeper ...

Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/582 thanks for quick work @eolivelli . I'll have a more close look on this tomorrow. Just quick comment - I am not sure if you can kick off jenkins by just add a comment. You can kick jenkins

[GitHub] zookeeper pull request #119: ZOOKEEPER-2251:Add Client side packet response ...

Github user hanm commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/119#discussion_r204984357 --- Diff: src/java/main/org/apache/zookeeper/client/ZKClientConfig.java --- @@ -56,9 +56,15 @@ @SuppressWarnings("deprecation") public

[GitHub] zookeeper pull request #119: ZOOKEEPER-2251:Add Client side packet response ...

Github user hanm commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/119#discussion_r204983836 --- Diff: src/java/main/org/apache/zookeeper/KeeperException.java --- @@ -387,6 +389,8 @@ public void setCode(int code) {

Re: Trying to find pattern in Flaky Tests

FYI, there's also this which I just reported: https://issues.apache.org/jira/browse/INFRA-16808 Patrick On Fri, Jul 20, 2018 at 12:01 AM Patrick Hunt wrote: > Something that's significantly different about the 3.4 and 3.5/master > Jenkins jobs is that 3.5/master has > > test.junit.threads=8 >

ZooKeeper_branch34_jdk8 - Build # 1471 - Still Failing

See https://builds.apache.org/job/ZooKeeper_branch34_jdk8/1471/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 9.82 KB...] at

[GitHub] zookeeper pull request #119: ZOOKEEPER-2251:Add Client side packet response ...

Github user eolivelli commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/119#discussion_r204899777 --- Diff: src/java/main/org/apache/zookeeper/client/ZKClientConfig.java --- @@ -56,9 +56,15 @@ @SuppressWarnings("deprecation") public

Failed: ZOOKEEPER- PreCommit Build #1991

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1991/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 11.94 KB...] > git checkout -f

[GitHub] zookeeper pull request #119: ZOOKEEPER-2251:Add Client side packet response ...

Github user arshadmohammad commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/119#discussion_r204885587 --- Diff: src/java/main/org/apache/zookeeper/client/ZKClientConfig.java --- @@ -56,9 +56,15 @@ @SuppressWarnings("deprecation")

[GitHub] zookeeper pull request #119: ZOOKEEPER-2251:Add Client side packet response ...

Github user arshadmohammad commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/119#discussion_r204881819 --- Diff: src/java/main/org/apache/zookeeper/KeeperException.java --- @@ -387,6 +389,8 @@ public void setCode(int code) {

[GitHub] zookeeper issue #565: ZOOKEEPER-3067: Optionally disable client environment ...

Github user jpeach commented on the issue: https://github.com/apache/zookeeper/pull/565 Is this ready to merge? ---

[GitHub] zookeeper issue #581: ZOOKEEPER-3101: add reminder to ZOO_ERRORS

Github user sl4mmy commented on the issue: https://github.com/apache/zookeeper/pull/581 @nkalmar Thanks, I just pushed a new commit (slightly reworded the commit message) but the Jenkins build failed again for the same reason:

Failed: ZOOKEEPER- PreCommit Build #1990

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1990/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 11.94 KB...] > git checkout -f

Failed: ZOOKEEPER- PreCommit Build #1989

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1989/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 11.94 KB...] > git checkout -f

A new Pluggable Metrics System for ZooKeeper

Hi, I have started drafting an API for the new Metrics system. The idea is to design a common API to be implemented by a "Metrics Provider". This way we will instrument ZooKeeper code only once and the user will be able to publish metrics to his preferred system. This is the umbrella issue:

[GitHub] zookeeper issue #582: ZOOKEEPER-3103 Pluggable metrics system for ZooKeeper ...

Github user eolivelli commented on the issue: https://github.com/apache/zookeeper/pull/582 retest this please ---

Failed: ZOOKEEPER- PreCommit Build #1988

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1988/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 11.94 KB...] > git checkout -f

[jira] [Updated] (ZOOKEEPER-3103) Pluggable metrics system for ZooKeeper - MetricsProvider API definition

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3103: -- Labels: pull-request-available (was: ) > Pluggable metrics system for ZooKeeper -

[GitHub] zookeeper pull request #582: ZOOKEEPER-3103 Pluggable metrics system for Zoo...

GitHub user eolivelli opened a pull request: https://github.com/apache/zookeeper/pull/582 ZOOKEEPER-3103 Pluggable metrics system for ZooKeeper - MetricsProvider API definition Define the API which must be implemented by a Metrics Provider. a MetricsProvider is a pluggable

[jira] [Created] (ZOOKEEPER-3103) Pluggable metrics system for ZooKeeper - MetricsProvider API definition

Enrico Olivelli created ZOOKEEPER-3103: -- Summary: Pluggable metrics system for ZooKeeper - MetricsProvider API definition Key: ZOOKEEPER-3103 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3103

[jira] [Assigned] (ZOOKEEPER-3092) Pluggable metrics system for ZooKeeper

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli reassigned ZOOKEEPER-3092: -- Assignee: Enrico Olivelli > Pluggable metrics system for ZooKeeper >

Jenkins build is back to normal : ZooKeeper-trunk-owasp #59

See

[GitHub] zookeeper issue #581: ZOOKEEPER-3101: add reminder to ZOO_ERRORS

Github user nkalmar commented on the issue: https://github.com/apache/zookeeper/pull/581 Looks to me jenkins was simply overloaded. You can re-run the jenkins job by doing an empty --amend commit and pushing it to your PR branch. ---

[jira] [Created] (ZOOKEEPER-3102) Potential race condition when create ephemeral nodes

LuoFucong created ZOOKEEPER-3102: Summary: Potential race condition when create ephemeral nodes Key: ZOOKEEPER-3102 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3102 Project: ZooKeeper