Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/119#discussion_r204899777
--- Diff: src/java/main/org/apache/zookeeper/client/ZKClientConfig.java ---
@@ -56,9 +56,15 @@
@SuppressWarnings("deprecation")
public static final String SECURE_CLIENT = ZooKeeper.SECURE_CLIENT;
public static final int CLIENT_MAX_PACKET_LENGTH_DEFAULT = 4096 *
1024; /* 4 MB */
+ public static final String ZOOKEEPER_REQUEST_TIMEOUT =
"zookeeper.request.timeout";
+ /**
+ * Feature is disabled by default.
--- End diff --
Totally agree, they are very different things. I mentioned it because
configured session timeout is like a client side hint about how much time you
can tolerate to be disconnected/not responsive, but it is better to keep it
separate from this low level knob.
Anyway I wonder if it would be better to set a default timeout.
If there is a chance of infinite wait maybe it can be worth.
We can use a very large timeout, in the order of minutes.
Tipical session timeout is in the order of seconds
---
