Github user arshadmohammad commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/119#discussion_r204881819
  
    --- Diff: src/java/main/org/apache/zookeeper/KeeperException.java ---
    @@ -387,6 +389,8 @@ public void setCode(int code) {
             EPHEMERALONLOCALSESSION (EphemeralOnLocalSession),
             /** Attempts to remove a non-existing watcher */
             NOWATCHER (-121),
    +        /** Not received packet timely */
    +        TIMEOUT (-122),
    --- End diff --
    
    Good catch. Request time out is also a kind of operation time out.  
OPERATIONTIMEOUT, I think it is not used any where in the  java client code or 
server code, not sure about other client codes. leaving OPERATIONTIMEOUT as it 
is.
    Changing TIMEOUT to SERVERRESPONSETIMEOUT is OK but I do not want to change 
property name.  Can we use REQUESTTIMEOUT.



---

Reply via email to