[
https://issues.apache.org/jira/browse/ZOOKEEPER-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589732#comment-16589732
]
Hadoop QA commented on ZOOKEEPER-3109:
--
-1 overall. GitHub Pull Request Build
+1
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2079/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 80.13 MB...]
[exec]
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/594
@anmolnar the updated code has passed all the tests and no Findbugs warning.
---
See https://builds.apache.org/job/ZooKeeper-trunk/161/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 282.69 KB...]
[exec] : elapsed 1001 : OK
[exec]
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589477#comment-16589477
]
Michael Han edited comment on ZOOKEEPER-3124 at 8/22/18 11:33 PM:
--
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589477#comment-16589477
]
Michael Han edited comment on ZOOKEEPER-3124 at 8/22/18 11:32 PM:
--
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589477#comment-16589477
]
Michael Han commented on ZOOKEEPER-3124:
[~lvfangmin] That code was actually added
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589337#comment-16589337
]
Fangmin Lv commented on ZOOKEEPER-3124:
---
[~hanm] do you have any idea why we need to keep these
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/580
Thanks @anmolnar, I've answered some of the questions here.
@jtuple can you resolve some of these comments and the conflict, we might
ready to go now, this will unblock other patches
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/580#discussion_r212104426
--- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java ---
@@ -33,17 +34,17 @@
public class ServerStats {
private static
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/580#discussion_r212103989
--- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java ---
@@ -127,36 +129,45 @@ public String toString(){
sb.append("Mode: "
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/601
@eolivelli I'll take a look and reply by EOD.
---
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2078/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 79.90 MB...]
[exec] +1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589269#comment-16589269
]
Hadoop QA commented on ZOOKEEPER-3116:
--
+1 overall. GitHub Pull Request Build
+1
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/588#discussion_r212073403
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java ---
@@ -1172,6 +1172,58 @@ synchronized public long
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/588#discussion_r212074255
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java ---
@@ -1172,6 +1172,58 @@ synchronized public long
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/588#discussion_r212071527
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java ---
@@ -1165,6 +1165,58 @@ synchronized public long
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/588#discussion_r212071584
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java ---
@@ -1172,6 +1172,58 @@ synchronized public long
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/593
@maoling thanks for providing the reference to KAFKA-200, it's very useful.
---
See https://builds.apache.org/job/ZooKeeper-trunk-windows-cmake/2903/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 9.68 KB...]
[ivy:retrieve] confs: [javacc]
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/593#discussion_r212070585
--- Diff: src/java/test/org/apache/zookeeper/server/SocketUtilTest.java ---
@@ -0,0 +1,46 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/593#discussion_r212070271
--- Diff: src/java/main/org/apache/zookeeper/server/SocketUtil.java ---
@@ -0,0 +1,63 @@
+package org.apache.zookeeper.server;
--- End diff --
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/593#discussion_r212069968
--- Diff: src/java/main/org/apache/zookeeper/server/SocketUtil.java ---
@@ -0,0 +1,63 @@
+package org.apache.zookeeper.server;
+
+import
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/594
Thanks @anmolnar, I've updated the code to read the node.data inside the
synchronized section. I'll check the Findbugs result for the updated patch.
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588973#comment-16588973
]
sujay paranjape commented on ZOOKEEPER-706:
---
Looks like patch has fix only for JAVA client.
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/601
@anmolnar @lvfangmin please take a look to my questions , so that we can
move forward.
---
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2077/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 7.60 KB...]
at
Github user jeremywangjun closed the pull request at:
https://github.com/apache/zookeeper/pull/604
---
GitHub user jeremywangjun reopened a pull request:
https://github.com/apache/zookeeper/pull/604
sync with master
sync with master
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeremywangjun/zookeeper trunk
Alternatively you
Github user jeremywangjun closed the pull request at:
https://github.com/apache/zookeeper/pull/604
---
GitHub user jeremywangjun opened a pull request:
https://github.com/apache/zookeeper/pull/604
sync with master
sync with master
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeremywangjun/zookeeper trunk
Alternatively you can
Github user maoling commented on the issue:
https://github.com/apache/zookeeper/pull/587
bump @anmolnar
---
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2076/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 41.38 MB...]
[exec]
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588588#comment-16588588
]
Hadoop QA commented on ZOOKEEPER-3031:
--
-1 overall. GitHub Pull Request Build
+1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588546#comment-16588546
]
Norbert Kalmar commented on ZOOKEEPER-1990:
---
Hi [~eribeiro], thanks for the update.
Yes, it
Github user nkalmar closed the pull request at:
https://github.com/apache/zookeeper/pull/602
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/602
Committed to branch-3.5. Thanks @nkalmar !
---
37 matches
Mail list logo
