[GitHub] zookeeper pull request #602: ZOOKEEPER-3031 3.5: MAVEN MIGRATION - move clie...

2018-08-22 Thread nkalmar
Github user nkalmar closed the pull request at: https://github.com/apache/zookeeper/pull/602 ---

[jira] [Commented] (ZOOKEEPER-1990) suspicious instantiation of java Random instances

2018-08-22 Thread Norbert Kalmar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16588546#comment-16588546 ] Norbert Kalmar commented on ZOOKEEPER-1990: --- Hi [~eribeiro], thanks for the

[jira] [Commented] (ZOOKEEPER-3031) Step 1.4 - Create zk-client maven structure

2018-08-22 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16588588#comment-16588588 ] Hadoop QA commented on ZOOKEEPER-3031: -- -1 overall. GitHub Pull Request Build

Failed: ZOOKEEPER- PreCommit Build #2076

2018-08-22 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2076/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 41.38 MB...] [exec] [exec

[GitHub] zookeeper issue #587: ZOOKEEPER-3106: Zookeeper client supports IPv6 address...

2018-08-22 Thread maoling
Github user maoling commented on the issue: https://github.com/apache/zookeeper/pull/587 bump @anmolnar ---

[GitHub] zookeeper pull request #604: sync with master

2018-08-22 Thread jeremywangjun
GitHub user jeremywangjun opened a pull request: https://github.com/apache/zookeeper/pull/604 sync with master sync with master You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeremywangjun/zookeeper trunk Alternatively you can r

[GitHub] zookeeper pull request #604: sync with master

2018-08-22 Thread jeremywangjun
Github user jeremywangjun closed the pull request at: https://github.com/apache/zookeeper/pull/604 ---

[GitHub] zookeeper pull request #604: sync with master

2018-08-22 Thread jeremywangjun
GitHub user jeremywangjun reopened a pull request: https://github.com/apache/zookeeper/pull/604 sync with master sync with master You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeremywangjun/zookeeper trunk Alternatively you can

[GitHub] zookeeper pull request #604: sync with master

2018-08-22 Thread jeremywangjun
Github user jeremywangjun closed the pull request at: https://github.com/apache/zookeeper/pull/604 ---

Failed: ZOOKEEPER- PreCommit Build #2077

2018-08-22 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2077/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 7.60 KB...] at hudson.model

[GitHub] zookeeper issue #601: WIP - ZOOKEEPER-3123 MetricsProvider Lifecycle in ZooK...

2018-08-22 Thread eolivelli
Github user eolivelli commented on the issue: https://github.com/apache/zookeeper/pull/601 @anmolnar @lvfangmin please take a look to my questions , so that we can move forward. ---

[jira] [Commented] (ZOOKEEPER-706) large numbers of watches can cause session re-establishment to fail

2018-08-22 Thread sujay paranjape (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16588973#comment-16588973 ] sujay paranjape commented on ZOOKEEPER-706: --- Looks like patch has fix only f

[GitHub] zookeeper issue #594: [ZOOKEEPER-3116] Make the DataTree.approximateDataSize...

2018-08-22 Thread lvfangmin
Github user lvfangmin commented on the issue: https://github.com/apache/zookeeper/pull/594 Thanks @anmolnar, I've updated the code to read the node.data inside the synchronized section. I'll check the Findbugs result for the updated patch. ---

[GitHub] zookeeper pull request #593: [ZOOKEEPER-3111] Add socket buffer size option ...

2018-08-22 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/593#discussion_r212069968 --- Diff: src/java/main/org/apache/zookeeper/server/SocketUtil.java --- @@ -0,0 +1,63 @@ +package org.apache.zookeeper.server; + +import java

[GitHub] zookeeper pull request #593: [ZOOKEEPER-3111] Add socket buffer size option ...

2018-08-22 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/593#discussion_r212070271 --- Diff: src/java/main/org/apache/zookeeper/server/SocketUtil.java --- @@ -0,0 +1,63 @@ +package org.apache.zookeeper.server; --- End diff --

[GitHub] zookeeper pull request #593: [ZOOKEEPER-3111] Add socket buffer size option ...

2018-08-22 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/593#discussion_r212070585 --- Diff: src/java/test/org/apache/zookeeper/server/SocketUtilTest.java --- @@ -0,0 +1,46 @@ +/** + * Licensed to the Apache Software Foundation

ZooKeeper-trunk-windows-cmake - Build # 2903 - Still Failing

2018-08-22 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk-windows-cmake/2903/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 9.68 KB...] [ivy:retrieve] confs: [javacc] [

[GitHub] zookeeper issue #593: [ZOOKEEPER-3111] Add socket buffer size option to tune...

2018-08-22 Thread lvfangmin
Github user lvfangmin commented on the issue: https://github.com/apache/zookeeper/pull/593 @maoling thanks for providing the reference to KAFKA-200, it's very useful. ---

[GitHub] zookeeper pull request #588: [ZOOKEEPER-3109] Avoid long unavailable time du...

2018-08-22 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/588#discussion_r212071527 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java --- @@ -1165,6 +1165,58 @@ synchronized public long startForwarding(LearnerHandle

[GitHub] zookeeper pull request #588: [ZOOKEEPER-3109] Avoid long unavailable time du...

2018-08-22 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/588#discussion_r212071584 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java --- @@ -1172,6 +1172,58 @@ synchronized public long startForwarding(LearnerHandle

[GitHub] zookeeper pull request #588: [ZOOKEEPER-3109] Avoid long unavailable time du...

2018-08-22 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/588#discussion_r212073403 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java --- @@ -1172,6 +1172,58 @@ synchronized public long startForwarding(LearnerHandle

[GitHub] zookeeper pull request #588: [ZOOKEEPER-3109] Avoid long unavailable time du...

2018-08-22 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/588#discussion_r212074255 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java --- @@ -1172,6 +1172,58 @@ synchronized public long startForwarding(LearnerHandle

[jira] [Commented] (ZOOKEEPER-3116) Make the DataTree.approximateDataSize more efficient

2018-08-22 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589269#comment-16589269 ] Hadoop QA commented on ZOOKEEPER-3116: -- +1 overall. GitHub Pull Request Build

Success: ZOOKEEPER- PreCommit Build #2078

2018-08-22 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2078/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 79.90 MB...] [exec] +1 @aut

[GitHub] zookeeper issue #601: WIP - ZOOKEEPER-3123 MetricsProvider Lifecycle in ZooK...

2018-08-22 Thread lvfangmin
Github user lvfangmin commented on the issue: https://github.com/apache/zookeeper/pull/601 @eolivelli I'll take a look and reply by EOD. ---

[GitHub] zookeeper pull request #580: ZOOKEEPER-3098: Add additional server metrics

2018-08-22 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/580#discussion_r212103989 --- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java --- @@ -127,36 +129,45 @@ public String toString(){ sb.append("Mode: "

[GitHub] zookeeper pull request #580: ZOOKEEPER-3098: Add additional server metrics

2018-08-22 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/580#discussion_r212104426 --- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java --- @@ -33,17 +34,17 @@ public class ServerStats { private static fina

[GitHub] zookeeper issue #580: ZOOKEEPER-3098: Add additional server metrics

2018-08-22 Thread lvfangmin
Github user lvfangmin commented on the issue: https://github.com/apache/zookeeper/pull/580 Thanks @anmolnar, I've answered some of the questions here. @jtuple can you resolve some of these comments and the conflict, we might ready to go now, this will unblock other patches we'

[jira] [Commented] (ZOOKEEPER-3124) Remove special logic to handle cversion and pzxid in DataTree.processTxn

2018-08-22 Thread Fangmin Lv (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589337#comment-16589337 ] Fangmin Lv commented on ZOOKEEPER-3124: --- [~hanm] do you have any idea why we ne

[jira] [Commented] (ZOOKEEPER-3124) Remove special logic to handle cversion and pzxid in DataTree.processTxn

2018-08-22 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589477#comment-16589477 ] Michael Han commented on ZOOKEEPER-3124: [~lvfangmin] That code was actually

[jira] [Comment Edited] (ZOOKEEPER-3124) Remove special logic to handle cversion and pzxid in DataTree.processTxn

2018-08-22 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589477#comment-16589477 ] Michael Han edited comment on ZOOKEEPER-3124 at 8/22/18 11:32 PM: -

[jira] [Comment Edited] (ZOOKEEPER-3124) Remove special logic to handle cversion and pzxid in DataTree.processTxn

2018-08-22 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589477#comment-16589477 ] Michael Han edited comment on ZOOKEEPER-3124 at 8/22/18 11:33 PM: -

ZooKeeper-trunk - Build # 161 - Failure

2018-08-22 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk/161/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 282.69 KB...] [exec] : elapsed 1001 : OK [exec] Z

[GitHub] zookeeper issue #594: [ZOOKEEPER-3116] Make the DataTree.approximateDataSize...

2018-08-22 Thread lvfangmin
Github user lvfangmin commented on the issue: https://github.com/apache/zookeeper/pull/594 @anmolnar the updated code has passed all the tests and no Findbugs warning. ---

Failed: ZOOKEEPER- PreCommit Build #2079

2018-08-22 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2079/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 80.13 MB...] [exec] [exec

[jira] [Commented] (ZOOKEEPER-3109) Avoid long unavailable time due to voter changed mind when activating the leader during election

2018-08-22 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589732#comment-16589732 ] Hadoop QA commented on ZOOKEEPER-3109: -- -1 overall. GitHub Pull Request Build

[jira] [Updated] (ZOOKEEPER-3125) Pzxid inconsistent issue when replaying a txn for a deleted node

2018-08-22 Thread Fangmin Lv (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fangmin Lv updated ZOOKEEPER-3125: -- Summary: Pzxid inconsistent issue when replaying a txn for a deleted node (was: Pzxid inco

[jira] [Commented] (ZOOKEEPER-3109) Avoid long unavailable time due to voter changed mind when activating the leader during election

2018-08-22 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589756#comment-16589756 ] Hadoop QA commented on ZOOKEEPER-3109: -- +1 overall. GitHub Pull Request Build

Success: ZOOKEEPER- PreCommit Build #2080

2018-08-22 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2080/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 85.64 MB...] [exec] +1 @aut

[GitHub] zookeeper pull request #605: [ZOOKEEPER-3125] Fix pzxid consistent issue whe...

2018-08-22 Thread lvfangmin
GitHub user lvfangmin opened a pull request: https://github.com/apache/zookeeper/pull/605 [ZOOKEEPER-3125] Fix pzxid consistent issue when replaying a txn for a deleted node You can merge this pull request into a Git repository by running: $ git pull https://github.com/lvfang

[jira] [Updated] (ZOOKEEPER-3125) Pzxid inconsistent issue when replaying a txn for a deleted node

2018-08-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3125: -- Labels: pull-request-available (was: ) > Pzxid inconsistent issue when replaying a

[jira] [Created] (ZOOKEEPER-3127) Fixing potential data inconsistency due to update last processed zxid with partial multi-op txn

2018-08-22 Thread Fangmin Lv (JIRA)
Fangmin Lv created ZOOKEEPER-3127: - Summary: Fixing potential data inconsistency due to update last processed zxid with partial multi-op txn Key: ZOOKEEPER-3127 URL: https://issues.apache.org/jira/browse/ZOOKEEPER

[jira] [Commented] (ZOOKEEPER-3111) Add socket buffer size option to tune the TCP throughput between leader and learner

2018-08-22 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589766#comment-16589766 ] Hadoop QA commented on ZOOKEEPER-3111: -- -1 overall. GitHub Pull Request Build

Failed: ZOOKEEPER- PreCommit Build #2082

2018-08-22 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2082/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 79.61 MB...] [exec] [exec

[jira] [Commented] (ZOOKEEPER-3111) Add socket buffer size option to tune the TCP throughput between leader and learner

2018-08-22 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589770#comment-16589770 ] Hadoop QA commented on ZOOKEEPER-3111: -- -1 overall. GitHub Pull Request Build

Failed: ZOOKEEPER- PreCommit Build #2081

2018-08-22 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2081/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 81.00 MB...] [exec] [exec

[GitHub] zookeeper pull request #606: [ZOOKEEPER-3127] Fixing potential data inconsis...

2018-08-22 Thread lvfangmin
GitHub user lvfangmin opened a pull request: https://github.com/apache/zookeeper/pull/606 [ZOOKEEPER-3127] Fixing potential data inconsistency due to update last processed zxid with partial multi-op txn You can merge this pull request into a Git repository by running: $ git p

[jira] [Updated] (ZOOKEEPER-3127) Fixing potential data inconsistency due to update last processed zxid with partial multi-op txn

2018-08-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3127: -- Labels: pull-request-available (was: ) > Fixing potential data inconsistency due t

[jira] [Commented] (ZOOKEEPER-3125) Pzxid inconsistent issue when replaying a txn for a deleted node

2018-08-22 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589794#comment-16589794 ] Hadoop QA commented on ZOOKEEPER-3125: -- +1 overall. GitHub Pull Request Build

Success: ZOOKEEPER- PreCommit Build #2083

2018-08-22 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2083/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 81.57 MB...] [exec] +1 @aut