[GitHub] [zookeeper] anmolnar commented on issue #949: ZOOKEEPER-3396: Flaky test in RestoreCommittedLogTest

anmolnar commented on issue #949: ZOOKEEPER-3396: Flaky test in RestoreCommittedLogTest URL: https://github.com/apache/zookeeper/pull/949#issuecomment-493928910 Committed to master branch. Thanks @enixon ! Btw @enixon you don't assign Jiras to yourself. Is that because you don't have

[GitHub] [zookeeper] asfgit closed pull request #949: ZOOKEEPER-3396: Flaky test in RestoreCommittedLogTest

asfgit closed pull request #949: ZOOKEEPER-3396: Flaky test in RestoreCommittedLogTest URL: https://github.com/apache/zookeeper/pull/949 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [zookeeper] eolivelli commented on issue #952: ZOOKEEPER-3364: Compile with strict options in order to check code quality

eolivelli commented on issue #952: ZOOKEEPER-3364: Compile with strict options in order to check code quality URL: https://github.com/apache/zookeeper/pull/952#issuecomment-493840020 @anmolnar This is the port for 3.5 I want to do the same for 3.4. The goal is to drop ant based

[GitHub] [zookeeper] eolivelli opened a new pull request #952: ZOOKEEPER-3364: Compile with strict options in order to check code quality

eolivelli opened a new pull request #952: ZOOKEEPER-3364: Compile with strict options in order to check code quality URL: https://github.com/apache/zookeeper/pull/952 This is the port of ZOOKEEPER-3364 to branch-3.5 - Add extra compiler arguments in order to achieve better code

[GitHub] [zookeeper] maoling closed pull request #951: Zookeeper 3301

maoling closed pull request #951: Zookeeper 3301 URL: https://github.com/apache/zookeeper/pull/951 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [zookeeper] maoling opened a new pull request #951: Zookeeper 3301

maoling opened a new pull request #951: Zookeeper 3301 URL: https://github.com/apache/zookeeper/pull/951 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [zookeeper] eolivelli commented on issue #950: ZOOKEEPER-3263. JAVA9/11 Warnings: Illegal reflective access in zookeer's kerberosUtil

eolivelli commented on issue #950: ZOOKEEPER-3263. JAVA9/11 Warnings: Illegal reflective access in zookeer's kerberosUtil URL: https://github.com/apache/zookeeper/pull/950#issuecomment-493597736 @anmolnar the result is the same, still the same warning. I feel we can live with it.

[GitHub] [zookeeper] eolivelli edited a comment on issue #949: ZOOKEEPER-3396: Flaky test in RestoreCommittedLogTest

eolivelli edited a comment on issue #949: ZOOKEEPER-3396: Flaky test in RestoreCommittedLogTest URL: https://github.com/apache/zookeeper/pull/949#issuecomment-493594696 @anmolnar can you please commit this one ? that test is very annoying on CI

[GitHub] [zookeeper] eolivelli commented on issue #949: ZOOKEEPER-3396: Flaky test in RestoreCommittedLogTest

eolivelli commented on issue #949: ZOOKEEPER-3396: Flaky test in RestoreCommittedLogTest URL: https://github.com/apache/zookeeper/pull/949#issuecomment-493594696 @anmolnar can you commit this one ? that test is very annoying on CI

[GitHub] [zookeeper] anmolnar commented on issue #950: ZOOKEEPER-3263. JAVA9/11 Warnings: Illegal reflective access in zookeer's kerberosUtil

anmolnar commented on issue #950: ZOOKEEPER-3263. JAVA9/11 Warnings: Illegal reflective access in zookeer's kerberosUtil URL: https://github.com/apache/zookeeper/pull/950#issuecomment-493474795 retest this please This is an

[GitHub] [zookeeper] anmolnar commented on issue #950: ZOOKEEPER-3263. JAVA9/11 Warnings: Illegal reflective access in zookeer's kerberosUtil

anmolnar commented on issue #950: ZOOKEEPER-3263. JAVA9/11 Warnings: Illegal reflective access in zookeer's kerberosUtil URL: https://github.com/apache/zookeeper/pull/950#issuecomment-493459800 Updated. Please check. This is

[GitHub] [zookeeper] eolivelli commented on issue #950: ZOOKEEPER-3263. JAVA9/11 Warnings: Illegal reflective access in zookeer's kerberosUtil

eolivelli commented on issue #950: ZOOKEEPER-3263. JAVA9/11 Warnings: Illegal reflective access in zookeer's kerberosUtil URL: https://github.com/apache/zookeeper/pull/950#issuecomment-493453739 @anmolnar maybe it helps, I don't know. Please try

[GitHub] [zookeeper] anmolnar commented on issue #950: ZOOKEEPER-3263. JAVA9/11 Warnings: Illegal reflective access in zookeer's kerberosUtil

anmolnar commented on issue #950: ZOOKEEPER-3263. JAVA9/11 Warnings: Illegal reflective access in zookeer's kerberosUtil URL: https://github.com/apache/zookeeper/pull/950#issuecomment-493453441 @eolivelli shall we upgrade BouncyCastle?

[GitHub] [zookeeper] eolivelli commented on issue #950: ZOOKEEPER-3263. JAVA9/11 Warnings: Illegal reflective access in zookeer's kerberosUtil

eolivelli commented on issue #950: ZOOKEEPER-3263. JAVA9/11 Warnings: Illegal reflective access in zookeer's kerberosUtil URL: https://github.com/apache/zookeeper/pull/950#issuecomment-493429920 @anmolnar the issue you are trying to fix is fixed with this patch. I am seeing errors

[GitHub] [zookeeper] eolivelli commented on a change in pull request #923: ZOOKEEPER-1426: add version command to the zookeeper server

eolivelli commented on a change in pull request #923: ZOOKEEPER-1426: add version command to the zookeeper server URL: https://github.com/apache/zookeeper/pull/923#discussion_r285089642 ## File path: zookeeper-server/src/test/resources/test-scripts.sh ## @@ -217,6 +217,9

[GitHub] [zookeeper] anmolnar commented on a change in pull request #899: ZOOKEEPER-3354: Improve efficiency of DeleteAllCommand

anmolnar commented on a change in pull request #899: ZOOKEEPER-3354: Improve efficiency of DeleteAllCommand URL: https://github.com/apache/zookeeper/pull/899#discussion_r284974888 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ZKUtil.java ## @@ -45,20

[GitHub] [zookeeper] anmolnar commented on a change in pull request #899: ZOOKEEPER-3354: Improve efficiency of DeleteAllCommand

anmolnar commented on a change in pull request #899: ZOOKEEPER-3354: Improve efficiency of DeleteAllCommand URL: https://github.com/apache/zookeeper/pull/899#discussion_r284974695 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ZKUtil.java ## @@ -45,20

[GitHub] [zookeeper] elireisman commented on issue #923: ZOOKEEPER-1426: add version command to the zookeeper server

elireisman commented on issue #923: ZOOKEEPER-1426: add version command to the zookeeper server URL: https://github.com/apache/zookeeper/pull/923#issuecomment-493230356 Yay! Been a while (!!!) but happy to chime in if you need me, thanks for rebasing this 

[GitHub] [zookeeper] enixon commented on issue #939: ZOOKEEPER-3385: Add admin command to display leader

enixon commented on issue #939: ZOOKEEPER-3385: Add admin command to display leader URL: https://github.com/apache/zookeeper/pull/939#issuecomment-493187070 retest this please This is an automated message from the Apache Git

[GitHub] [zookeeper] enixon commented on issue #947: ZOOKEEPER-3392: Add admin command to display last snapshot information

enixon commented on issue #947: ZOOKEEPER-3392: Add admin command to display last snapshot information URL: https://github.com/apache/zookeeper/pull/947#issuecomment-493186770 retest ant build This is an automated message

[GitHub] [zookeeper] enixon commented on issue #851: ZOOKEEPER-3311: Allow a delay to the transaction log flush

enixon commented on issue #851: ZOOKEEPER-3311: Allow a delay to the transaction log flush URL: https://github.com/apache/zookeeper/pull/851#issuecomment-493186586 retest maven build This is an automated message from the

[GitHub] [zookeeper] eolivelli commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for ZooKeeper - move remaining metrics to MetricsProvider

eolivelli commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for ZooKeeper - move remaining metrics to MetricsProvider URL: https://github.com/apache/zookeeper/pull/918#issuecomment-493170070 @lvfangmin do you have time to finish your review? Thanks

[GitHub] [zookeeper] anmolnar commented on issue #923: ZOOKEEPER-1426: add version command to the zookeeper server

anmolnar commented on issue #923: ZOOKEEPER-1426: add version command to the zookeeper server URL: https://github.com/apache/zookeeper/pull/923#issuecomment-493161575 @nkalmar I don't think those error messages are related to this patch. That's basically the expected behaviour of this

[GitHub] [zookeeper] anmolnar commented on issue #761: ZOOKEEPER-3237: Allow IPv6 wildcard address in peer config

anmolnar commented on issue #761: ZOOKEEPER-3237: Allow IPv6 wildcard address in peer config URL: https://github.com/apache/zookeeper/pull/761#issuecomment-493090307 Committed to master branch. Thanks @enixon ! This is an

[GitHub] [zookeeper] asfgit closed pull request #761: ZOOKEEPER-3237: Allow IPv6 wildcard address in peer config

asfgit closed pull request #761: ZOOKEEPER-3237: Allow IPv6 wildcard address in peer config URL: https://github.com/apache/zookeeper/pull/761 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [zookeeper] anmolnar commented on issue #915: ZOOKEEPER-3370 Remove SVN specific revision generation

anmolnar commented on issue #915: ZOOKEEPER-3370 Remove SVN specific revision generation URL: https://github.com/apache/zookeeper/pull/915#issuecomment-493085224 retest this please This is an automated message from the

[GitHub] [zookeeper] anmolnar closed pull request #592: ZOOKEEPER-3112: fix fd leak due to UnresolvedAddressException on conn…

anmolnar closed pull request #592: ZOOKEEPER-3112: fix fd leak due to UnresolvedAddressException on conn… URL: https://github.com/apache/zookeeper/pull/592 This is an automated message from the Apache Git Service. To

[GitHub] [zookeeper] anmolnar commented on issue #592: ZOOKEEPER-3112: fix fd leak due to UnresolvedAddressException on conn…

anmolnar commented on issue #592: ZOOKEEPER-3112: fix fd leak due to UnresolvedAddressException on conn… URL: https://github.com/apache/zookeeper/pull/592#issuecomment-493084748 Due to @PhantomThief 's comment, I'm closing this PR.

[GitHub] [zookeeper] JiriOndrusek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)

JiriOndrusek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-493061694 @nkalmar Solution #2 seems to be feasible - I've just tried simple prototype in

[GitHub] [zookeeper] anmolnar opened a new pull request #950: ZOOKEEPER-3263. Illegal reflective access in zookeer's kerberosUtil

anmolnar opened a new pull request #950: ZOOKEEPER-3263. Illegal reflective access in zookeer's kerberosUtil URL: https://github.com/apache/zookeeper/pull/950 Fixes warning messages of JDK 9/11 by upgrading libraries and refactoring `KerberosUtils` based on experiences of

[GitHub] [zookeeper] JiriOndrusek edited a comment on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)

JiriOndrusek edited a comment on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-493025000 I've sent email to zookeeper-dev mailing list: ZooKeeper and OSGi

[GitHub] [zookeeper] JiriOndrusek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)

JiriOndrusek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-493025000 I've sent email to zookeeper-dev mailing list: > ZooKeeper and OSGi (maven)

[GitHub] [zookeeper] JiriOndrusek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)

JiriOndrusek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-493017349 @nkalmar I've just asked for subscription to dev mailing list, then I'd be able to

[GitHub] [zookeeper] nkalmar edited a comment on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)

nkalmar edited a comment on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-493015133 We would still need to solve it for 3.5 branch. So, for me, creating a

[GitHub] [zookeeper] nkalmar commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)

nkalmar commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-493015133 We would still need to solve it for 3.5 branch. So, for me, creating a zookeeper-osgi

[GitHub] [zookeeper] JiriOndrusek edited a comment on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)

JiriOndrusek edited a comment on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-493012808 @eolivelli @nkalmar I've found problem with current approach (2 bundles,

[GitHub] [zookeeper] JiriOndrusek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)

JiriOndrusek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-493012808 @eolivelli @nkalmar I've found problem with current approach (2 bundles, one is

[GitHub] [zookeeper] anmolnar commented on a change in pull request #899: ZOOKEEPER-3354: Improve efficiency of DeleteAllCommand

anmolnar commented on a change in pull request #899: ZOOKEEPER-3354: Improve efficiency of DeleteAllCommand URL: https://github.com/apache/zookeeper/pull/899#discussion_r284615207 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ZKUtil.java ## @@ -45,20

[GitHub] [zookeeper] JiriOndrusek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)

JiriOndrusek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-492984271 I was able to install manually zookeeper with curator. But I had to change a little

[GitHub] [zookeeper] JiriOndrusek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)

JiriOndrusek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-492974467 @nkalmar I've added OSGi support to zookeeper-jute. I had to change pockaging to

[GitHub] [zookeeper] nkalmar commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)

nkalmar commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-492971219 What I meant in "private package" is that we do not expose any of this to clients. Jute

[GitHub] [zookeeper] JiriOndrusek edited a comment on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)

JiriOndrusek edited a comment on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-492933860 @eolivelli Ok, i'll continue with osgi packaging. I'll apply this also to

[GitHub] [zookeeper] JiriOndrusek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)

JiriOndrusek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-492933860 @eolivelli Ok, i'll continue with osgi packaging. I'll apply this also to

[GitHub] [zookeeper] anmolnar commented on issue #770: ZOOKEEPER-3244: Add option to snapshot based on log size

anmolnar commented on issue #770: ZOOKEEPER-3244: Add option to snapshot based on log size URL: https://github.com/apache/zookeeper/pull/770#issuecomment-492824563 @enixon Thanks, it's great you already have a fix in mind. No worries and no rush, just take your time.

[GitHub] [zookeeper] anmolnar edited a comment on issue #770: ZOOKEEPER-3244: Add option to snapshot based on log size

anmolnar edited a comment on issue #770: ZOOKEEPER-3244: Add option to snapshot based on log size URL: https://github.com/apache/zookeeper/pull/770#issuecomment-492824563 @enixon Thanks, it's great you already have a fix. No worries and no rush, just take your time.

[GitHub] [zookeeper] eolivelli commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)

eolivelli commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-492824404 It would be great to have some integration test which loads zookeeper client with osgi

[GitHub] [zookeeper] enixon commented on issue #770: ZOOKEEPER-3244: Add option to snapshot based on log size

enixon commented on issue #770: ZOOKEEPER-3244: Add option to snapshot based on log size URL: https://github.com/apache/zookeeper/pull/770#issuecomment-492812456 Created a new ticket (3396) and opened #949 to resolve (cc @anmolnar - sorry for the trouble!)

[GitHub] [zookeeper] enixon opened a new pull request #949: ZOOKEEPER-3396: Flaky test in RestoreCommittedLogTest

enixon opened a new pull request #949: ZOOKEEPER-3396: Flaky test in RestoreCommittedLogTest URL: https://github.com/apache/zookeeper/pull/949 Adjusting parameters of RestoreCommittedLogTest to avoid failures caused by threshold configured to be below the minimum allowed file size

[GitHub] [zookeeper] enixon commented on issue #770: ZOOKEEPER-3244: Add option to snapshot based on log size

enixon commented on issue #770: ZOOKEEPER-3244: Add option to snapshot based on log size URL: https://github.com/apache/zookeeper/pull/770#issuecomment-492804816 @anmolnar It looks like the issue is FileTxnLog::getCurrentLogSize returns a multiple of a high number that is dependent on the

[GitHub] [zookeeper] JiriOndrusek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)

JiriOndrusek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-492796520 Hi @nkalmar @eolivelli, let me introduce "a better solution" for the problem

[GitHub] [zookeeper] enixon commented on a change in pull request #899: ZOOKEEPER-3354: Improve efficiency of DeleteAllCommand

enixon commented on a change in pull request #899: ZOOKEEPER-3354: Improve efficiency of DeleteAllCommand URL: https://github.com/apache/zookeeper/pull/899#discussion_r284359820 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ZKUtil.java ## @@ -45,20

[GitHub] [zookeeper] eolivelli commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)

eolivelli commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-492714723 Maybe you can simply add raw entries to the manifest in the jar plugin configuration

[GitHub] [zookeeper] JiriOndrusek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)

JiriOndrusek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-492704512 @nkalmar @eolivelli I'll continue with this tomorrow. I see in your comment:

[GitHub] [zookeeper] eolivelli commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)

eolivelli commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-492683153 Yes changing the package name is feasible but only for 3.6+.

[GitHub] [zookeeper] nkalmar commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)

nkalmar commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-492680330 I see you changed zookeeper-server packaging from jar to bundle. Yeah... I will check up

[GitHub] [zookeeper] nkalmar edited a comment on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)

nkalmar edited a comment on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-492677907 There will be 2 jars upon release, zookeeper-jute and zookeeper-server.

[GitHub] [zookeeper] nkalmar commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)

nkalmar commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-492677907 There will be 2 jars upon release, zookeeper-jute and zookeeper-server. zookeeper-jute is

[GitHub] [zookeeper] JiriOndrusek edited a comment on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)

JiriOndrusek edited a comment on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-492672683 @nkalmar @eolivelli I'm getting close to the finishing. I just want to

[GitHub] [zookeeper] JiriOndrusek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)

JiriOndrusek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-492672683 @nkalmar @eolivelli I'm getting close to the finishing. I just want to clarify

[GitHub] [zookeeper] anmolnar commented on a change in pull request #899: ZOOKEEPER-3354: Improve efficiency of DeleteAllCommand

anmolnar commented on a change in pull request #899: ZOOKEEPER-3354: Improve efficiency of DeleteAllCommand URL: https://github.com/apache/zookeeper/pull/899#discussion_r284260180 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ZKUtil.java ## @@ -45,20

[GitHub] [zookeeper] anmolnar commented on issue #898: ZOOKEEPER-3353: Admin commands for showing initial settings

anmolnar commented on issue #898: ZOOKEEPER-3353: Admin commands for showing initial settings URL: https://github.com/apache/zookeeper/pull/898#issuecomment-492604226 Committed to master branch. Thanks @enixon ! This is an

[GitHub] [zookeeper] anmolnar commented on issue #770: ZOOKEEPER-3244: Add option to snapshot based on log size

anmolnar commented on issue #770: ZOOKEEPER-3244: Add option to snapshot based on log size URL: https://github.com/apache/zookeeper/pull/770#issuecomment-492603934 @enixon Please double check your test code, it looks like this patch has introduced a flaky test:

[GitHub] [zookeeper] asfgit closed pull request #898: ZOOKEEPER-3353: Admin commands for showing initial settings

asfgit closed pull request #898: ZOOKEEPER-3353: Admin commands for showing initial settings URL: https://github.com/apache/zookeeper/pull/898 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [zookeeper] nkalmar commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)

nkalmar commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-492587354 I agree with Enrico, please just continue on this branch, as maven will be used to

[GitHub] [zookeeper] eolivelli commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)

eolivelli commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-492569164 @JiriOndrusek I feel you can continue on this branch, we can merge all this OSGI stuff

[GitHub] [zookeeper] JiriOndrusek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)

JiriOndrusek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-492561609 Hi @nkalmar , I've started with osgification of maven build, so far in my branch

[GitHub] [zookeeper] enixon commented on issue #898: ZOOKEEPER-3353: Admin commands for showing initial settings

enixon commented on issue #898: ZOOKEEPER-3353: Admin commands for showing initial settings URL: https://github.com/apache/zookeeper/pull/898#issuecomment-492516231 retest maven build This is an automated message from the

[GitHub] [zookeeper] enixon commented on issue #761: ZOOKEEPER-3237: Allow IPv6 wildcard address in peer config

enixon commented on issue #761: ZOOKEEPER-3237: Allow IPv6 wildcard address in peer config URL: https://github.com/apache/zookeeper/pull/761#issuecomment-492443350 retest maven build This is an automated message from the

[GitHub] [zookeeper] enixon commented on issue #898: ZOOKEEPER-3353: Admin commands for showing initial settings

enixon commented on issue #898: ZOOKEEPER-3353: Admin commands for showing initial settings URL: https://github.com/apache/zookeeper/pull/898#issuecomment-492442399 retest this please This is an automated message from the

[GitHub] [zookeeper] enixon commented on issue #948: ZOOKEEPER-3394: Delay observer reconnect when all learner masters hav…

enixon commented on issue #948: ZOOKEEPER-3394: Delay observer reconnect when all learner masters hav… URL: https://github.com/apache/zookeeper/pull/948#issuecomment-492394603 retest maven build This is an automated message

[GitHub] [zookeeper] enixon commented on issue #898: ZOOKEEPER-3353: Admin commands for showing initial settings

enixon commented on issue #898: ZOOKEEPER-3353: Admin commands for showing initial settings URL: https://github.com/apache/zookeeper/pull/898#issuecomment-492394459 retest this please This is an automated message from the

[GitHub] [zookeeper] enixon commented on issue #761: ZOOKEEPER-3237: Allow IPv6 wildcard address in peer config

enixon commented on issue #761: ZOOKEEPER-3237: Allow IPv6 wildcard address in peer config URL: https://github.com/apache/zookeeper/pull/761#issuecomment-492394550 retest this please This is an automated message from the

[GitHub] [zookeeper] enixon commented on a change in pull request #898: ZOOKEEPER-3353: Admin commands for showing initial settings

enixon commented on a change in pull request #898: ZOOKEEPER-3353: Admin commands for showing initial settings URL: https://github.com/apache/zookeeper/pull/898#discussion_r283982376 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/admin/Commands.java

[GitHub] [zookeeper] eolivelli commented on a change in pull request #898: ZOOKEEPER-3353: Admin commands for showing initial settings

eolivelli commented on a change in pull request #898: ZOOKEEPER-3353: Admin commands for showing initial settings URL: https://github.com/apache/zookeeper/pull/898#discussion_r283979799 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/admin/Commands.java

[GitHub] [zookeeper] enixon commented on issue #898: ZOOKEEPER-3353: Admin commands for showing initial settings

enixon commented on issue #898: ZOOKEEPER-3353: Admin commands for showing initial settings URL: https://github.com/apache/zookeeper/pull/898#issuecomment-492366498 ZOOKEEPER-3395 for documentation. This is an automated

[GitHub] [zookeeper] enixon commented on issue #948: ZOOKEEPER-3394: Delay observer reconnect when all learner masters hav…

enixon commented on issue #948: ZOOKEEPER-3394: Delay observer reconnect when all learner masters hav… URL: https://github.com/apache/zookeeper/pull/948#issuecomment-492361876 retest maven build This is an automated message

[GitHub] [zookeeper] enixon commented on issue #898: ZOOKEEPER-3353: Admin commands for showing initial settings

enixon commented on issue #898: ZOOKEEPER-3353: Admin commands for showing initial settings URL: https://github.com/apache/zookeeper/pull/898#issuecomment-492361481 @anmolnar I've performed a basic refactor to capture my understanding of your nit, let me know if that's not what you were

[GitHub] [zookeeper] anmolnar commented on a change in pull request #850: ZOOKEEPER-3309: Add sync processor metrics

anmolnar commented on a change in pull request #850: ZOOKEEPER-3309: Add sync processor metrics URL: https://github.com/apache/zookeeper/pull/850#discussion_r283857589 ## File path:

[GitHub] [zookeeper] anmolnar commented on issue #622: [ZOOKEEPER-3145] Fix potential watch missing issue due to stale pzxid when replaying CloseSession txn with fuzzy snapshot

anmolnar commented on issue #622: [ZOOKEEPER-3145] Fix potential watch missing issue due to stale pzxid when replaying CloseSession txn with fuzzy snapshot URL: https://github.com/apache/zookeeper/pull/622#issuecomment-492282970 @lvfangmin This patch broke

[GitHub] [zookeeper] anmolnar commented on issue #770: ZOOKEEPER-3244: Add option to snapshot based on log size

anmolnar commented on issue #770: ZOOKEEPER-3244: Add option to snapshot based on log size URL: https://github.com/apache/zookeeper/pull/770#issuecomment-492280588 Committed to master branch. Thanks @enixon ! This is an

[GitHub] [zookeeper] asfgit closed pull request #770: ZOOKEEPER-3244: Add option to snapshot based on log size

asfgit closed pull request #770: ZOOKEEPER-3244: Add option to snapshot based on log size URL: https://github.com/apache/zookeeper/pull/770 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [zookeeper] anmolnar commented on a change in pull request #898: ZOOKEEPER-3353: Admin commands for showing initial settings

anmolnar commented on a change in pull request #898: ZOOKEEPER-3353: Admin commands for showing initial settings URL: https://github.com/apache/zookeeper/pull/898#discussion_r283848928 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/admin/Commands.java

[GitHub] [zookeeper] anmolnar commented on issue #898: ZOOKEEPER-3353: Admin commands for showing initial settings

anmolnar commented on issue #898: ZOOKEEPER-3353: Admin commands for showing initial settings URL: https://github.com/apache/zookeeper/pull/898#issuecomment-492276446 Setting up the admin server is already documented. We should only have a detailed list of available admin commands to be

[GitHub] [zookeeper] anmolnar commented on issue #898: ZOOKEEPER-3353: Admin commands for showing initial settings

anmolnar commented on issue #898: ZOOKEEPER-3353: Admin commands for showing initial settings URL: https://github.com/apache/zookeeper/pull/898#issuecomment-492275063 @enixon Sorry for the delay. Unfortunately there's no plan to deprecate 4LW commands, but we already have the

[GitHub] [zookeeper] anmolnar commented on a change in pull request #761: ZOOKEEPER-3237: Allow IPv6 wildcard address in peer config

anmolnar commented on a change in pull request #761: ZOOKEEPER-3237: Allow IPv6 wildcard address in peer config URL: https://github.com/apache/zookeeper/pull/761#discussion_r283836766 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/test/ServerDuplicateTest.java

[GitHub] [zookeeper] anmolnar commented on a change in pull request #761: ZOOKEEPER-3237: Allow IPv6 wildcard address in peer config

anmolnar commented on a change in pull request #761: ZOOKEEPER-3237: Allow IPv6 wildcard address in peer config URL: https://github.com/apache/zookeeper/pull/761#discussion_r283835507 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/test/ServerDuplicateTest.java

[GitHub] [zookeeper] anmolnar closed pull request #943: Merge pull request #1 from apache/master

anmolnar closed pull request #943: Merge pull request #1 from apache/master URL: https://github.com/apache/zookeeper/pull/943 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [zookeeper] anmolnar commented on issue #943: Merge pull request #1 from apache/master

anmolnar commented on issue #943: Merge pull request #1 from apache/master URL: https://github.com/apache/zookeeper/pull/943#issuecomment-492265897 I think this has been opened by mistake. Closing. This is an automated

[GitHub] [zookeeper] nkalmar commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)

nkalmar commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-492236889 Hi @JiriOndrusek , Thanks for this patch and looking into this. Unfortunately there

[GitHub] [zookeeper] JiriOndrusek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)

JiriOndrusek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-492213488 @eolivelli Hi, I've checked history of build.xml and it is not a regression. Just

[GitHub] [zookeeper] anmolnar commented on issue #622: [ZOOKEEPER-3145] Fix potential watch missing issue due to stale pzxid when replaying CloseSession txn with fuzzy snapshot

anmolnar commented on issue #622: [ZOOKEEPER-3145] Fix potential watch missing issue due to stale pzxid when replaying CloseSession txn with fuzzy snapshot URL: https://github.com/apache/zookeeper/pull/622#issuecomment-492211073 retest this please

[GitHub] [zookeeper] nkalmar edited a comment on issue #946: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (for Curator)

nkalmar edited a comment on issue #946: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (for Curator) URL: https://github.com/apache/zookeeper/pull/946#issuecomment-492154707 Less of an importance on branch 3.4 to fix it on maven (we do not plan to release with

[GitHub] [zookeeper] nkalmar commented on issue #946: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (for Curator)

nkalmar commented on issue #946: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (for Curator) URL: https://github.com/apache/zookeeper/pull/946#issuecomment-492154707 Less of an importance on branch 3.4 to fix it on maven (we do not plan to release with maven on

[GitHub] [zookeeper] eolivelli commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)

eolivelli commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-492130327 Is this @JiriOndrusek a "regression" ? As you are adding the manifest lines on ANT

[GitHub] [zookeeper] eolivelli commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)

eolivelli commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-492130477 Can you please try to add a fix even for the maven build ?

[GitHub] [zookeeper] eolivelli commented on a change in pull request #948: ZOOKEEPER-3394: Delay observer reconnect when all learner masters hav…

eolivelli commented on a change in pull request #948: ZOOKEEPER-3394: Delay observer reconnect when all learner masters hav… URL: https://github.com/apache/zookeeper/pull/948#discussion_r283656398 ## File path:

[GitHub] [zookeeper] enixon opened a new pull request #948: ZOOKEEPER-3394: Delay observer reconnect when all learner masters hav…

enixon opened a new pull request #948: ZOOKEEPER-3394: Delay observer reconnect when all learner masters hav… URL: https://github.com/apache/zookeeper/pull/948 …e been tried This is an automated message from the Apache Git

[GitHub] [zookeeper] enixon opened a new pull request #947: ZOOKEEPER-3392: Add admin command to display last snapshot information

enixon opened a new pull request #947: ZOOKEEPER-3392: Add admin command to display last snapshot information URL: https://github.com/apache/zookeeper/pull/947 This is an automated message from the Apache Git Service. To

[GitHub] [zookeeper] enixon commented on issue #944: ZOOKEEPER-3388: Allow client port to support plaintext and encrypted …

enixon commented on issue #944: ZOOKEEPER-3388: Allow client port to support plaintext and encrypted … URL: https://github.com/apache/zookeeper/pull/944#issuecomment-492012054 I know that @ivmaykov has been experimenting with openssl so you may see him put up a pr in the near future for

[GitHub] [zookeeper] enixon commented on issue #917: ZOOKEEPER-3318:Add a complete backup mechanism for zookeeper internal

enixon commented on issue #917: ZOOKEEPER-3318:Add a complete backup mechanism for zookeeper internal URL: https://github.com/apache/zookeeper/pull/917#issuecomment-491919486 Directed snapshots seem useful to me; I have reservations about snapshot taking being triggered by the ZooKeeper

<    1   2   3   4   5   6   7   8   9   10   >