[
https://issues.apache.org/jira/browse/ZOOKEEPER-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Skye Wanderman-Milne updated ZOOKEEPER-1495:
Attachment: ZOOKEEPER-1495_branch34.patch
Patch that can be applied to
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Skye Wanderman-Milne updated ZOOKEEPER-1495:
Attachment: ZOOKEEPER-1495.patch
It looks like we don't need to
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Skye Wanderman-Milne updated ZOOKEEPER-1346:
Attachment: ZOOKEEPER-1346.8.patch
Added license to
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Skye Wanderman-Milne updated ZOOKEEPER-1346:
Attachment: ZOOKEEPER-1346.7.patch
Added JettyAdminServerTest. This
server is
started for a quorum and for a standalone server.
- Skye
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8094/#review15205
-------
tests
Ran in standalone mode (only option right now) and manually tried out all the
commands/links
Thanks,
Skye Wanderman-Milne
> On Jan. 16, 2013, 2:50 a.m., Edward Ribeiro wrote:
> > src/java/main/org/apache/zookeeper/server/WatchManager.java, line 177
> > <https://reviews.apache.org/r/8094/diff/4/?file=244387#file244387line177>
> >
> > Replace "that that" by "whos
rc/java/test/org/apache/zookeeper/ZKTestCase.java 6ecfe8f
> src/java/test/org/apache/zookeeper/server/PrepRequestProcessorTest.java
> 8665bac
> src/java/test/org/apache/zookeeper/server/admin/CommandsTest.java
> PRE-CREATION
> src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java 370e7bb
>
> Diff: https://reviews.apache.org/r/8094/diff/
>
>
> Testing
> ---
>
> unit tests
>
> Ran in standalone mode (only option right now) and manually tried out all the
> commands/links
>
>
> Thanks,
>
> Skye Wanderman-Milne
>
>
r instanceof LeaderZooKeeperServer)" (the
two conditions should be equivalent...)
- Skye
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8094/#review15373
----
t solution.
- Skye
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8094/#review15204
-------
On Jan. 4, 2013, 2:17 a.m., Skye Wanderman-Milne wrote
ps://reviews.apache.org/r/8094/#review15204
-------
On Jan. 4, 2013, 2:17 a.m., Skye Wanderman-Milne wrote:
>
> ---
> This is an automatically generated e-mail.
n altogether and only have the command URL
option for simplicity.
- Skye
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8094/#review15204
-
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Skye Wanderman-Milne updated ZOOKEEPER-1346:
Attachment: ZOOKEEPER-1346.6.patch
Oops, sorry about that Edward, I
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Skye Wanderman-Milne updated ZOOKEEPER-1346:
Attachment: ZOOKEEPER-1346.4.patch
Rebased on trunk again
sting
---
unit tests
Ran in standalone mode (only option right now) and manually tried out all the
commands/links
Thanks,
Skye Wanderman-Milne
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Skye Wanderman-Milne updated ZOOKEEPER-1346:
Attachment: ZOOKEEPER-1346.3.patch
Added CommandsTest, documentation
ht now) and manually tried out all the
commands/links
Thanks,
Skye Wanderman-Milne
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534481#comment-13534481
]
Skye Wanderman-Milne commented on ZOOKEEPER-1346:
-
Oops, hav
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534427#comment-13534427
]
Skye Wanderman-Milne commented on ZOOKEEPER-1495:
-
This overall l
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13533597#comment-13533597
]
Skye Wanderman-Milne commented on ZOOKEEPER-1599:
-
A 3.4 leader
ttps://reviews.apache.org/r/8094/#review14507
---
On Nov. 30, 2012, 9:01 p.m., Skye Wanderman-Milne wrote:
>
> ---
> This is an automatically generated e-mail
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13531332#comment-13531332
]
Skye Wanderman-Milne commented on ZOOKEEPER-1599:
-
I actually f
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13530211#comment-13530211
]
Skye Wanderman-Milne commented on ZOOKEEPER-1599:
-
A 3.3 se
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Skye Wanderman-Milne updated ZOOKEEPER-1599:
Attachment: ZOOKEEPER-1599.patch
Here's a potential fix, but I
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13526921#comment-13526921
]
Skye Wanderman-Milne commented on ZOOKEEPER-1599:
-
I think I f
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13526670#comment-13526670
]
Skye Wanderman-Milne commented on ZOOKEEPER-1599:
-
It looks like
Skye Wanderman-Milne created ZOOKEEPER-1599:
---
Summary: 3.3 server cannot join 3.4 quorum
Key: ZOOKEEPER-1599
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1599
Project: ZooKeeper
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Skye Wanderman-Milne updated ZOOKEEPER-1346:
Attachment: ZOOKEEPER-1346.2.patch
New patch that includes many minor
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13509437#comment-13509437
]
Skye Wanderman-Milne commented on ZOOKEEPER-1346:
-
Nikita, thank
> On Nov. 18, 2012, 4:10 p.m., Camille Fournier wrote:
> > src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java, line
> > 306
> > <https://reviews.apache.org/r/8094/diff/1/?file=190875#file190875line306>
> >
> > Why make this a more rest
> On Nov. 28, 2012, 6:19 p.m., Patrick Hunt wrote:
> > src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java, line 111
> > <https://reviews.apache.org/r/8094/diff/1/?file=190885#file190885line111>
> >
> > This needs to be configurable from the
okeeper/server/admin/AdminServer.java, line 72
> > <https://reviews.apache.org/r/8094/diff/1/?file=190887#file190887line72>
> >
> > LOG.warn("Problem starting AdminServer", e);
> >
> > Why don't you want to throw the except
ied out all the
commands/links
Thanks,
Skye Wanderman-Milne
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8094/#review13824
---
On Nov. 16, 2012, 11:25 p.m., Skye Wanderman-Milne wrote:
>
> --
> On Nov. 18, 2012, 4:10 p.m., Camille Fournier wrote:
> > src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java, line
> > 306
> > <https://reviews.apache.org/r/8094/diff/1/?file=190875#file190875line306>
> >
> > Why make this a more rest
sit:
https://reviews.apache.org/r/8094/#review13548
---
On Nov. 16, 2012, 11:25 p.m., Skye Wanderman-Milne wrote:
>
> ---
> This is an automatically generated e-mail. To re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8094/#review13547
---
On Nov. 16, 2012, 11:25 p.m., Skye Wanderman-Milne wrote:
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13499296#comment-13499296
]
Skye Wanderman-Milne commented on ZOOKEEPER-1346:
-
The javadoc
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Skye Wanderman-Milne updated ZOOKEEPER-1346:
Attachment: ZOOKEEPER-1346.patch
This patch implements the main
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13499239#comment-13499239
]
Skye Wanderman-Milne commented on ZOOKEEPER-1346:
-
rb: h
src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java 42207e1
Diff: https://reviews.apache.org/r/8094/diff/
Testing
---
unit tests
Ran in standalone mode (only option right now) and manually tried out all the
commands/links
Thanks,
Skye Wanderman-Milne
+1, ran tests and basic operations over a 3-node cluster with Oracle JDK
6+7 and OpenJDK 6.
On Wed, Nov 7, 2012 at 12:43 PM, Patrick Hunt wrote:
> +1, verified the sigs/xsum, all the tests are passing for me on both jdk6
> and jdk7 (oracle). I see that jenkins is also passing consistently. I ran
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488025#comment-13488025
]
Skye Wanderman-Milne commented on ZOOKEEPER-1560:
-
Can anyone fi
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Skye Wanderman-Milne updated ZOOKEEPER-1560:
Attachment: ZOOKEEPER-1560-v8_r4.patch
Add
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487332#comment-13487332
]
Skye Wanderman-Milne commented on ZOOKEEPER-1560:
-
Rather
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Skye Wanderman-Milne updated ZOOKEEPER-1560:
Attachment: ZOOKEEPER-1560-v8_r3.patch
syncing with review board
7;s already protected by outgoingQueue,
> > is this not enough? (it was only protected by outgoingQueue in 3.3 branch,
> > why did it change?)
>
> Skye Wanderman-Milne wrote:
> pendingQueue is not always protected by outgoingQueue (see
> ClientCnxn.SendThread.readResponse
> On Oct. 25, 2012, 11:33 p.m., Skye Wanderman-Milne wrote:
> > Looks like I'm no longer passing unit tests, please hold off on further
> > reviews for now...
Just kidding, I was testing the wrong branch :)
- Skye
--
ff on further reviews
for now...
- Skye Wanderman-Milne
On Oct. 25, 2012, 10:51 p.m., Skye Wanderman-Milne wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
7;s already protected by outgoingQueue,
> > is this not enough? (it was only protected by outgoingQueue in 3.3 branch,
> > why did it change?)
>
> Skye Wanderman-Milne wrote:
> pendingQueue is not always protected by outgoingQueue (see
> ClientCnxn.SendThread.readResponse
packet to the front of the queue anyway.
- Skye
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7730/#review12794
-------
On Oct. 25, 2012, 10:51 p.m., Skye Wanderman-Milne wrote:
>
> --
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7730/#review12792
---
On Oct. 25, 2012, 10:51 p.m., Skye Wanderman-Milne wrote:
>
> ---
70d8538
Diff: https://reviews.apache.org/r/7730/diff/
Testing
---
unit tests (including testLargeNodeData from ZOOKEEPER-1560 JIRA)
Thanks,
Skye Wanderman-Milne
/
Testing
---
unit tests (including testLargeNodeData from ZOOKEEPER-1560 JIRA)
Thanks,
Skye Wanderman-Milne
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Skye Wanderman-Milne updated ZOOKEEPER-1560:
Attachment: ZOOKEEPER-1560-v8.patch
I've created a new
pick first packet if we already started writing it so we finished
writing it
- Skye Wanderman-Milne
On Oct. 25, 2012, 12:50 a.m., Skye Wanderman-Milne wrote:
>
> ---
> This is an automatically generated e-mail. To
testLargeNodeData from ZOOKEEPER-1560 JIRA)
Thanks,
Skye Wanderman-Milne
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483544#comment-13483544
]
Skye Wanderman-Milne commented on ZOOKEEPER-1560:
-
The benefit of
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483426#comment-13483426
]
Skye Wanderman-Milne commented on ZOOKEEPER-1560:
-
A couple quest
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Skye Wanderman-Milne updated ZOOKEEPER-1513:
Attachment: ZOOKEEPER-1513_2012.10.17_take2.tar.gz
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Skye Wanderman-Milne updated ZOOKEEPER-1513:
Attachment: ZOOKEEPER-1513_2012.10.17.patch
simpler patch (includes
a/test/org/apache/zookeeper/test/BufferSizeTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/7603/diff/
Testing
---
ant test (new junit tests test issuing creates/sets and reading large
creates/sets/znodes from disk)
Thanks,
Skye Wanderman-Milne
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Skye Wanderman-Milne updated ZOOKEEPER-1513:
Attachment: ZOOKEEPER-1513.patch
see review board: https
ing/setting nodes above/below/equal to the maxbuffer
limit, and also starting a server with create/set records above/below/equal to
the limit.
Thanks,
Skye Wanderman-Milne
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Skye Wanderman-Milne updated ZOOKEEPER-1513:
Assignee: Skye Wanderman-Milne
> "Unreasonable length&qu
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467265#comment-13467265
]
Skye Wanderman-Milne commented on ZOOKEEPER-1197:
-
Based on
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Skye Wanderman-Milne updated ZOOKEEPER-1197:
Attachment: long_4lw.patch
ZOOKEEPER
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Skye Wanderman-Milne updated ZOOKEEPER-1346:
Attachment: ZOOKEEPER-1346_jetty.patch
> Handle 4lws
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466957#comment-13466957
]
Skye Wanderman-Milne commented on ZOOKEEPER-1346:
-
What if we rep
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Skye Wanderman-Milne updated ZOOKEEPER-1238:
Attachment: ZOOKEEPER-1238.patch
> when the linger time
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Skye Wanderman-Milne updated ZOOKEEPER-1376:
Attachment: ZOOKEEPER-1376.patch
> zkServer.sh does not correc
71 matches
Mail list logo
