Github user arshadmohammad commented on the issue:
https://github.com/apache/zookeeper/pull/338
@pmoust I was pointing to comments:
[1](https://issues.apache.org/jira/browse/ZOOKEEPER-1260?focusedCommentId=16612302=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel
Github user arshadmohammad commented on the issue:
https://github.com/apache/zookeeper/pull/338
Hi all, please find performance impact analysis in jira comments.
---
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r218073947
--- Diff: src/java/main/org/apache/zookeeper/audit/AuditConstants.java ---
@@ -0,0 +1,37 @@
+/**
+ * Licensed to the Apache Software
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r218068308
--- Diff: conf/log4j.properties ---
@@ -63,3 +63,20 @@
log4j.appender.TRACEFILE.File=${zookeeper.tracelog.dir}/${zookeeper.tracelog.fil
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r218067686
--- Diff: conf/log4j.properties ---
@@ -63,3 +63,20 @@
log4j.appender.TRACEFILE.File=${zookeeper.tracelog.dir}/${zookeeper.tracelog.fil
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r218066854
--- Diff: src/java/main/org/apache/zookeeper/ZKUtil.java ---
@@ -168,4 +169,41 @@ private static void visitSubTreeDFSHelper(ZooKeeper
zk, final
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r217179715
--- Diff:
src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java ---
@@ -465,6 +488,127 @@ public void processRequest(Request
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r217179644
--- Diff: src/java/main/org/apache/zookeeper/audit/ZKAuditLogger.java ---
@@ -0,0 +1,117 @@
+/**
+ * Licensed to the Apache Software
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r217179296
--- Diff:
src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java ---
@@ -465,6 +488,127 @@ public void processRequest(Request
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r217179236
--- Diff:
src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java ---
@@ -250,30 +267,36 @@ public void processRequest(Request
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/119#discussion_r204885587
--- Diff: src/java/main/org/apache/zookeeper/client/ZKClientConfig.java ---
@@ -56,9 +56,15 @@
@SuppressWarnings("deprec
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/119#discussion_r204881819
--- Diff: src/java/main/org/apache/zookeeper/KeeperException.java ---
@@ -387,6 +389,8 @@ public void setCode(int code
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/119#discussion_r203928468
--- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java ---
@@ -1495,10 +1504,21 @@ public ReplyHeader submitRequest(RequestHeader h,
Record
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/119#discussion_r203928395
--- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java ---
@@ -1495,10 +1504,21 @@ public ReplyHeader submitRequest(RequestHeader h,
Record
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/119#discussion_r203928289
--- Diff: src/java/main/org/apache/zookeeper/KeeperException.java ---
@@ -387,6 +389,8 @@ public void setCode(int code
Github user arshadmohammad commented on the issue:
https://github.com/apache/zookeeper/pull/119
Thanks @anmolnar @hanm for your reviews, I will address the comments and
update MR.
---
Github user arshadmohammad commented on the issue:
https://github.com/apache/zookeeper/pull/338
Thanks @hanm @afine for reviewing this feature. I have addressed all the
comments, Please have a look.
---
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136866016
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAuditLogs.xml
---
@@ -0,0 +1,205 @@
+
+
+http://www.oasis-open.org/docbook
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136865979
--- Diff: src/java/main/org/apache/zookeeper/audit/AuditConstants.java ---
@@ -0,0 +1,37 @@
+/**
+ * Licensed to the Apache Software
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136865485
--- Diff: src/java/main/org/apache/zookeeper/server/ServerCnxnFactory.java
---
@@ -54,6 +54,7 @@
*/
static final ByteBuffer
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136176181
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAuditLogs.xml
---
@@ -0,0 +1,205 @@
+
+
+http://www.oasis-open.org/docbook
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136175120
--- Diff: src/java/test/org/apache/zookeeper/server/util/AuthUtilTest.java
---
@@ -0,0 +1,58 @@
+/**
+ * Licensed to the Apache Software
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136173824
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAuditLogs.xml
---
@@ -0,0 +1,205 @@
+
+
+http://www.oasis-open.org/docbook
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136172475
--- Diff: src/java/test/org/apache/zookeeper/audit/ZKAuditLoggerTest.java
---
@@ -0,0 +1,377 @@
+/**
+ * Licensed to the Apache Software
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136169721
--- Diff: src/java/test/org/apache/zookeeper/server/util/AuthUtilTest.java
---
@@ -0,0 +1,58 @@
+/**
+ * Licensed to the Apache Software
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136168432
--- Diff: src/java/main/org/apache/zookeeper/server/ServerCnxnFactory.java
---
@@ -54,6 +54,7 @@
*/
static final ByteBuffer
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136166969
--- Diff:
src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java ---
@@ -476,6 +624,33 @@ private boolean connClosedByClient(Request
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136166929
--- Diff:
src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java ---
@@ -476,6 +624,33 @@ private boolean connClosedByClient(Request
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136162453
--- Diff:
src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java ---
@@ -465,6 +490,129 @@ public void processRequest(Request
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136161116
--- Diff: src/java/main/org/apache/zookeeper/audit/ZKAuditLogger.java ---
@@ -0,0 +1,118 @@
+/**
+ * Licensed to the Apache Software
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136158981
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAuditLogs.xml
---
@@ -0,0 +1,205 @@
+
+
+http://www.oasis-open.org/docbook
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136158827
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAuditLogs.xml
---
@@ -0,0 +1,205 @@
+
+
+http://www.oasis-open.org/docbook
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136157705
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAuditLogs.xml
---
@@ -0,0 +1,205 @@
+
+
+http://www.oasis-open.org/docbook
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136157257
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAuditLogs.xml
---
@@ -0,0 +1,205 @@
+
+
+http://www.oasis-open.org/docbook
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136157192
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAuditLogs.xml
---
@@ -0,0 +1,205 @@
+
+
+http://www.oasis-open.org/docbook
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136155728
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAuditLogs.xml
---
@@ -0,0 +1,205 @@
+
+
+http://www.oasis-open.org/docbook
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136154783
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAuditLogs.xml
---
@@ -0,0 +1,205 @@
+
+
+http://www.oasis-open.org/docbook
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136154472
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAuditLogs.xml
---
@@ -0,0 +1,205 @@
+
+
+http://www.oasis-open.org/docbook
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136150114
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml ---
@@ -931,7 +931,19 @@ server.3=zoo3:2888:3888
feature
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136150155
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAuditLogs.xml
---
@@ -0,0 +1,205 @@
+
+
+http://www.oasis-open.org/docbook
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136149088
--- Diff: src/docs/src/documentation/content/xdocs/index.xml ---
@@ -66,6 +66,7 @@
Hierarchical
quorums
Observers - non
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136146630
--- Diff: conf/log4j.properties ---
@@ -63,3 +63,20 @@
log4j.appender.TRACEFILE.File=${zookeeper.tracelog.dir}/${zookeeper.tracelog.fil
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136144283
--- Diff: conf/log4j.properties ---
@@ -63,3 +63,20 @@
log4j.appender.TRACEFILE.File=${zookeeper.tracelog.dir}/${zookeeper.tracelog.fil
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r134566240
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAuditLogs.xml
---
@@ -0,0 +1,205 @@
+
+
+http://www.oasis-open.org/docbook
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r134566167
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml ---
@@ -931,7 +931,19 @@ server.3=zoo3:2888:3888
feature
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r134566109
--- Diff: src/docs/src/documentation/content/xdocs/site.xml ---
@@ -52,6 +52,7 @@ See http://forrest.apache.org/docs/linking.html for more
info
GitHub user arshadmohammad opened a pull request:
https://github.com/apache/zookeeper/pull/338
ZOOKEEPER-1260:Audit logging in ZooKeeper servers.
Audit logging in ZooKeeper Servers.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user arshadmohammad commented on the issue:
https://github.com/apache/zookeeper/pull/304
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/279#discussion_r128291070
--- Diff: src/java/main/org/apache/zookeeper/ZooKeeper.java ---
@@ -1436,7 +1436,7 @@ public String create(final String path, byte data[],
List
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/279#discussion_r126482088
--- Diff: src/java/main/org/apache/zookeeper/ZooKeeper.java ---
@@ -1535,7 +1535,7 @@ public String create(final String path, byte data[],
List
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/279#discussion_r126481060
--- Diff: src/java/main/org/apache/zookeeper/ZooKeeper.java ---
@@ -1436,7 +1436,7 @@ public String create(final String path, byte data[],
List
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/282#discussion_r123329247
--- Diff:
src/java/main/org/apache/zookeeper/server/auth/SASLAuthenticationProvider.java
---
@@ -38,11 +38,6 @@ public String getScheme
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/282#discussion_r122586475
--- Diff: src/java/test/org/apache/zookeeper/test/SaslSuperUserTest.java ---
@@ -0,0 +1,118 @@
+/**
+ * Licensed to the Apache Software
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/282#discussion_r122586398
--- Diff: src/java/test/org/apache/zookeeper/test/SaslSuperUserTest.java ---
@@ -0,0 +1,118 @@
+/**
+ * Licensed to the Apache Software
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/282#discussion_r122586367
--- Diff:
src/java/main/org/apache/zookeeper/server/auth/SASLAuthenticationProvider.java
---
@@ -38,11 +38,6 @@ public String getScheme
Github user arshadmohammad closed the pull request at:
https://github.com/apache/zookeeper/pull/278
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user arshadmohammad opened a pull request:
https://github.com/apache/zookeeper/pull/278
ZOOKEEPER-2775: ZK Client not able to connect with Xid out of order error
Same as PR https://github.com/apache/zookeeper/pull/254 but this is for
branch-3.4
You can merge this pull
Github user arshadmohammad commented on the issue:
https://github.com/apache/zookeeper/pull/254
This PR can be merged to master and branch-3.5 only. I will raise another
pull request for branch-3.4
---
If your project is set up for it, you can reply to this email and have your
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/254#discussion_r117021379
--- Diff: src/java/test/org/apache/zookeeper/SaslAuthTest.java ---
@@ -16,54 +16,58 @@
* limitations under the License
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/254#discussion_r117016986
--- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java ---
@@ -1054,6 +1054,8 @@ private void sendPing() {
private boolean
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/254#discussion_r117014954
--- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java ---
@@ -1054,6 +1054,8 @@ private void sendPing() {
private boolean
Github user arshadmohammad commented on the issue:
https://github.com/apache/zookeeper/pull/254
Thanks @afine @hanm for the reviews. Addressed the comments, Please have a
look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user arshadmohammad commented on the issue:
https://github.com/apache/zookeeper/pull/254
zooKeeperSaslClient == null is already used in tunnelAuthInProgress()
which is quite different from saslLoginFailed being false. So I think we can
not do above change.
---
If your
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/254#discussion_r116872750
--- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java ---
@@ -1080,6 +1080,8 @@ private void startConnect() throws IOException
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/254#discussion_r116871534
--- Diff: src/java/test/org/apache/zookeeper/SaslAuthTest.java ---
@@ -0,0 +1,187 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/254#discussion_r116871274
--- Diff: src/java/test/org/apache/zookeeper/SaslAuthTest.java ---
@@ -0,0 +1,187 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/254#discussion_r116871380
--- Diff: src/java/test/org/apache/zookeeper/SaslAuthTest.java ---
@@ -0,0 +1,187 @@
+/**
+ * Licensed to the Apache Software Foundation
GitHub user arshadmohammad opened a pull request:
https://github.com/apache/zookeeper/pull/254
ZOOKEEPER-2775: ZK Client not able to connect with Xid out of order error
Once client enters into Xid out of order issue, It never comes to normal
state. It keeps trying to connect
Github user arshadmohammad commented on the issue:
https://github.com/apache/zookeeper/pull/106
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/106#discussion_r115111872
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml ---
@@ -948,15 +948,14 @@ server.3=zoo3:2888:3888
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/106#discussion_r115111914
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -930,39 +918,36 @@ protected Election createElectionAlgorithm
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/106#discussion_r115111921
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -809,28 +809,16 @@ synchronized public void stopLeaderElection
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/106#discussion_r115112178
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -930,39 +918,36 @@ protected Election createElectionAlgorithm
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/106#discussion_r115112169
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -930,39 +918,36 @@ protected Election createElectionAlgorithm
Github user arshadmohammad commented on the issue:
https://github.com/apache/zookeeper/pull/106
Jira ZOOKEEPER-1932 title is completely different from what is being done
in its MR. It think we should change the title as well as the description
---
If your project is set up
Github user arshadmohammad commented on the issue:
https://github.com/apache/zookeeper/pull/106
I will review it soon
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user arshadmohammad commented on the issue:
https://github.com/apache/zookeeper/pull/237
LGTM, +1
I will commit it soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user arshadmohammad commented on the issue:
https://github.com/apache/zookeeper/pull/116
LGTM, +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user arshadmohammad commented on the issue:
https://github.com/apache/zookeeper/pull/116
Now after this fix, javacc jar is not present in the zookeeper tar ball. So
javacc.LICENSE.txt also should not be present. Can you delete
javacc.LICENSE.txt from the src\java\lib
Github user arshadmohammad commented on the issue:
https://github.com/apache/zookeeper/pull/179
Thanks @hanm for working on this issue. +1 LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/179#discussion_r104198451
--- Diff: src/java/test/org/apache/zookeeper/ZKTestCase.java ---
@@ -51,6 +51,12 @@ public void starting(FrameworkMethod method
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/179#discussion_r104092982
--- Diff:
src/java/test/org/apache/zookeeper/test/FourLetterWordsWhiteListTest.java ---
@@ -0,0 +1,151 @@
+/**
+ * Licensed to the Apache
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/179#discussion_r104092091
--- Diff: src/java/test/org/apache/zookeeper/ZKTestCase.java ---
@@ -51,6 +51,12 @@ public void starting(FrameworkMethod method
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/179#discussion_r104016184
--- Diff:
src/java/main/org/apache/zookeeper/server/command/FourLetterCommands.java ---
@@ -18,10 +18,16 @@
package
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/179#discussion_r104015988
--- Diff:
src/java/test/org/apache/zookeeper/test/FourLetterWordsWhiteListTest.java ---
@@ -0,0 +1,163 @@
+/**
+ * Licensed to the Apache
Github user arshadmohammad commented on the issue:
https://github.com/apache/zookeeper/pull/179
Currently enabling all the 4lw commands is little inconvenient. We have to
put all the commands one by one to enable all the commands. Given the fact that
ZooKeeper is generally installed
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/179#discussion_r102126647
--- Diff: src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java ---
@@ -267,10 +267,17 @@ private boolean checkFourLetterWord(final
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/179#discussion_r101964775
--- Diff: src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java ---
@@ -267,10 +267,17 @@ private boolean checkFourLetterWord(final
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/179#discussion_r101824634
--- Diff:
src/java/test/org/apache/zookeeper/test/FourLetterWordsWhiteListTest.java ---
@@ -0,0 +1,123 @@
+/**
+ * Licensed to the Apache
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/179#discussion_r101824558
--- Diff:
src/java/test/org/apache/zookeeper/test/FourLetterWordsWhiteListTest.java ---
@@ -0,0 +1,123 @@
+/**
+ * Licensed to the Apache
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/179#discussion_r101821552
--- Diff:
src/java/test/org/apache/zookeeper/server/ZooKeeperServerStartupTest.java ---
@@ -167,6 +167,7 @@ public void
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/179#discussion_r101819637
--- Diff:
src/java/main/org/apache/zookeeper/server/command/FourLetterCommands.java ---
@@ -153,13 +159,50 @@
*/
public final
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/179#discussion_r101819527
--- Diff:
src/java/main/org/apache/zookeeper/server/command/FourLetterCommands.java ---
@@ -153,13 +159,50 @@
*/
public final
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/179#discussion_r101818968
--- Diff:
src/java/main/org/apache/zookeeper/server/command/FourLetterCommands.java ---
@@ -153,13 +159,50 @@
*/
public final
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/179#discussion_r101818408
--- Diff: src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java ---
@@ -268,7 +268,7 @@ private boolean checkFourLetterWord(final Channel
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/179#discussion_r101818292
--- Diff: src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java ---
@@ -479,7 +479,7 @@ private boolean checkFourLetterWord(final
Github user arshadmohammad commented on the issue:
https://github.com/apache/zookeeper/pull/176
There is not test case, as the change is very simple and understandable and
the test will complicate the overall fix.
---
If your project is set up for it, you can reply to this email
GitHub user arshadmohammad opened a pull request:
https://github.com/apache/zookeeper/pull/176
ZOOKEEPER-2687:Deadlock while shutting down the Leader server.
Leader server enters into deadlock while shutting down itself. Shutdown of
the leader server is called from the synchronized
GitHub user arshadmohammad opened a pull request:
https://github.com/apache/zookeeper/pull/175
ZOOKEEPER-2683: RaceConditionTest is flaky
RaceConditionTest assertion is wrong, It fails when old leader becomes
leader again.
You can merge this pull request into a Git repository
Github user arshadmohammad commented on the issue:
https://github.com/apache/zookeeper/pull/170
Thanks @eribeiro for the review,
Sorry, I saw you comment just now after committing this PR, missed you in
the reviewers list.
---
If your project is set up for it, you can reply
1 - 100 of 130 matches
Mail list logo
