Github user rgs1 commented on the issue:
https://github.com/apache/zookeeper/pull/522
lgtm, r+. thanks!
---
Github user rgs1 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/522#discussion_r189469574
--- Diff: src/c/src/zookeeper.c ---
@@ -4502,6 +4532,30 @@ static void process_sync_completion(zhandle_t *zh,
}
}
+static int
Github user rgs1 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/522#discussion_r189469556
--- Diff: src/c/src/zookeeper.c ---
@@ -4056,22 +4075,33 @@ int zoo_aremove_watchers(zhandle_t *zh, const char
*path, ZooWatcherType wtype
Github user rgs1 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/522#discussion_r189469546
--- Diff: src/c/src/zookeeper.c ---
@@ -4056,22 +4075,33 @@ int zoo_aremove_watchers(zhandle_t *zh, const char
*path, ZooWatcherType wtype
Github user rgs1 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/131#discussion_r93572633
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumAuthTestBase.java
---
@@ -78,15 +78,73 @@ protected String startQuorum(final int
Github user rgs1 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/131#discussion_r93572708
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumAuthTestBase.java
---
@@ -78,15 +78,73 @@ protected String startQuorum(final int
Github user rgs1 commented on the issue:
https://github.com/apache/zookeeper/pull/132
r+ â merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user rgs1 commented on the issue:
https://github.com/apache/zookeeper/pull/99
@fpj, @hanm could you take a look? I am +1, but another look would be nice.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rgs1 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/117#discussion_r90761121
--- Diff:
src/java/test/org/apache/zookeeper/test/EmptiedSnapshotRecoveryTest.java ---
@@ -0,0 +1,134 @@
+/**
+ * Licensed to the Apache Software
Github user rgs1 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/117#discussion_r90491384
--- Diff:
src/java/test/org/apache/zookeeper/test/EmptiedSnapshotRecoveryTest.java ---
@@ -0,0 +1,134 @@
+/**
+ * Licensed to the Apache Software
Github user rgs1 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/117#discussion_r90490925
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java ---
@@ -165,8 +165,22 @@ public File getSnapDir
Github user rgs1 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/98#discussion_r88602850
--- Diff: src/java/test/org/apache/zookeeper/test/QuorumMajorityTest.java
---
@@ -36,7 +38,30
Github user rgs1 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/98#discussion_r88602842
--- Diff: src/java/test/org/apache/zookeeper/test/QuorumMajorityTest.java
---
@@ -36,7 +38,30
Github user rgs1 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/90#discussion_r88183747
--- Diff: src/c/src/zookeeper.c ---
@@ -4052,6 +3958,76 @@ int zoo_amulti(zhandle_t *zh, int count, const
zoo_op_t *ops,
return (rc <
Github user rgs1 commented on the issue:
https://github.com/apache/zookeeper/pull/100
Thanks @hanm ! Lets wait until Monday to see what @breed thinks and then I
am happy to merge this. What do you think?
---
If your project is set up for it, you can reply to this email and have your
Github user rgs1 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r86679205
--- Diff:
src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java ---
@@ -842,7 +868,26 @@ private void addCnxn(NIOServerCnxn cnxn
Github user rgs1 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r86679164
--- Diff: src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java ---
@@ -716,7 +716,12 @@ public void process(WatchedEvent event
Github user rgs1 commented on the issue:
https://github.com/apache/zookeeper/pull/97
@hanm @fpj i say we merge it and keep iterating; it'll be easier to get it
right once we are using it.
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user rgs1 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/97#discussion_r86679093
--- Diff: src/java/test/bin/test-github-pr.sh ---
@@ -0,0 +1,605 @@
+#!/usr/bin/env bash
+# Licensed under the Apache License, Version 2.0 (the
Github user rgs1 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/96#discussion_r86673489
--- Diff: src/java/main/org/apache/zookeeper/server/DataTree.java ---
@@ -245,15 +245,25 @@ public DataTree() {
addConfigNode
Github user rgs1 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/96#discussion_r86673398
--- Diff: src/c/tests/TestReconfigServer.cc ---
@@ -324,4 +336,109 @@ testRemoveConnectedFollower() {
zookeeper_close(zk
Github user rgs1 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/96#discussion_r86673475
--- Diff: src/java/main/org/apache/zookeeper/server/DataTree.java ---
@@ -245,15 +245,25 @@ public DataTree() {
addConfigNode
Github user rgs1 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/100#discussion_r86673221
--- Diff: src/c/src/zookeeper.c ---
@@ -1702,15 +1703,9 @@ static void handle_error(zhandle_t *zh,int rc)
}
cleanup_bufs(zh,1,rc
Github user rgs1 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/100#discussion_r86673245
--- Diff: src/c/src/zookeeper.c ---
@@ -2072,6 +2076,11 @@ static int ping_rw_server(zhandle_t* zh)
out:
close(sock);
+if (!rc
Github user rgs1 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r86672337
--- Diff: src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java ---
@@ -716,7 +716,12 @@ public void process(WatchedEvent event
Github user rgs1 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r86672419
--- Diff:
src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java ---
@@ -105,8 +115,26 @@ public void channelConnected(ChannelHandlerContext
Github user rgs1 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r86672349
--- Diff:
src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java ---
@@ -630,6 +640,22 @@ public static ByteBuffer getDirectBuffer
Github user rgs1 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r86672326
--- Diff: src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java ---
@@ -716,7 +716,12 @@ public void process(WatchedEvent event
Github user rgs1 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r86672385
--- Diff:
src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java ---
@@ -842,7 +868,26 @@ private void addCnxn(NIOServerCnxn cnxn
Github user rgs1 closed the pull request at:
https://github.com/apache/zookeeper/pull/38
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user rgs1 opened a pull request:
https://github.com/apache/zookeeper/pull/38
refactor(ClientCnxn): no need to gate cheap LOG.debug calls
If building the parameters for LOG.debug is cheap, there is
no point in cluttering the code with if (LOG.isDebugEnabled)
gates
Github user rgs1 closed the pull request at:
https://github.com/apache/zookeeper/pull/30
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user rgs1 opened a pull request:
https://github.com/apache/zookeeper/pull/30
ZOOKEEPER-2186: QuorumCnxManager#receiveConnection may crash with ranâ¦
â¦dom input
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rgs1
33 matches
Mail list logo
