Re: [VOTE] Apache ZooKeeper release 3.9.3 candidate 0

2024-10-07 Thread tison
play with binary doesn't fail Best, tison. Andor Molnar 于2024年10月7日周一 16:08写道: > > +1 (binding) > > - release notes looks good > - signatures and checksum OK > - Java and CPP build and unit tests passed on Ubuntu 24.04 with OpenJDK > version "11.0.12" >

[ANNOUNCE] New ZooKeeper committer: Kezhu Wang (@kezhuw)

2024-08-02 Thread tison
Hello, everyone On behalf of the Apache ZooKeeper PMC, I'm happy to announce that Kezhu Wang has accepted an invitation to become a committer on Apache ZooKeeper. Welcome, and thank you for your contributions! Best, tison.

Re: Tentative Date for ZooKeeper next release

2024-07-05 Thread tison
Hi, Do you wait for 3.10.0 and you can upgrade to this version, or you need a patch version for other maintained series? Best, tison. Christopher 于2024年7月5日周五 11:13写道: > I don't know the answer, but I wouldn't think that issue is important > enough to warrant a change in rel

Re: [DISCUSS] Introducing Typo CI Check to Apache ZooKeeper

2024-05-19 Thread tison
proto/Controller.proto#L35-L37 Best, tison. ZhangJian He 于2024年5月19日周日 15:28写道: > Hi, I want to introduce new lint tools: typos[1]. This tool is designed to > automatically detect and correct typographical errors in our codebase, > documentation, and comments. It’s a valuable addition to

Re: 3.9.2 is our latest stable version, or 3.8.4?

2024-05-14 Thread tison
Thank you! I should read the obvious "Release strategy" session 🤣 Best, tison. Andor Molnar 于2024年5月15日周三 08:30写道: > We have stable and current version pointers. Current points to 3.9.2 > while stable points to 3.8.4 now. > > As soon as we release 3.10 and EoL 3.7.

3.9.2 is our latest stable version, or 3.8.4?

2024-05-14 Thread tison
Hi, Our download page [1] states that 3.8.4 is our latest stable version. [1] https://zookeeper.apache.org/releases.html According to the X.Y.Z semver pattern, I'd regard 3.9.2 as the latest stable version instead. Is there any certain reason we point to 3.8.4? Best, tison.

Re: Contributing to Zookeeper as a newbie

2024-04-11 Thread tison
ticket on JIRA, or want to comment on a JIRA ticket for further discussion, you can re-request a JIRA ID with that concrete reason and I suppose we can approve such requests. Best, tison. Vivek S 于2024年4月11日周四 23:00写道: > Hi all, > > Hope all of you are doing good. I am new to Zooke

Re: [RESULT] [VOTE] Apache ZooKeeper release 3.9.2 candidate 0

2024-03-11 Thread tison
Cool. Sorry to miss this vote. And thank you for driving this release :D Best, tison. Damien Diederen 于2024年3月11日周一 21:13写道: > > I'm happy to announce that we have unanimously approved this release. > > There are 3 approving votes, all of which are binding: > > - Sz

Re: [VOTE] Apache ZooKeeper release 3.8.4 candidate 0

2024-03-04 Thread tison
belongs to the owner. Primary key fingerprint: AF3D 175E C05D B249 738D 01AC 8D8C 3C3E D0B0 2E66 * Build from source on macOS ARM64 with JDK 21 * Extra binary, start the server, and run some simple commands * Run the same for the binary built from the source * LICENSE and NOTICE exist for both t

Re: Moving 3.7 to End-of-Life

2024-01-31 Thread tison
Curator versions maintain compatibility. Best, tison. [1] https://github.com/apache/curator/pull/496 Andor Molnar 于2024年1月31日周三 16:57写道: > > Hi all, > > We didn't get any negative feedback, so I think we're good to proceed > with the EoL process. > > Bit confused - since

Re: New merge script with GH api

2023-12-01 Thread tison
Hi Andor, Thanks for driving this effort. And Thank Szucs Villo for implementing. I like this improvement :D Best, tison. Andor Molnar 于2023年12月1日周五 21:12写道: > > Hi folks, > > We've just submitted > https://issues.apache.org/jira/browse/ZOOKEEPER-4756 to all active >

Jump from -2 to 0 when zookeeper increments znode dataVersion

2023-09-15 Thread tison
Hi, I'd like to prioritize this issue[1] for pre discussion so that we can determine whether or not it's a good direction to improve set data with version experience. The title is as email title and please check the JIRA ticket for details. Best, tison. [1] https://issues.apach

Re: Remove Watcher only remove client-side watcher and remain server-side watcher leak

2023-09-13 Thread tison
I found that I asked once at https://lists.apache.org/thread/0kcnklcxs0s5656c1sbh3crgdodbb0qg. And there is a pending issue https://issues.apache.org/jira/browse/ZOOKEEPER-4625 Best, tison. tison 于2023年9月13日周三 22:15写道: > See https://issues.apache.org/jira/browse/FLINK-33053. > &

Remove Watcher only remove client-side watcher and remain server-side watcher leak

2023-09-13 Thread tison
it by design or we can make some better solution? Best, tison.

Re: [PROPOSAL] Timeout to expire session in client side to avoid endless connection loss

2023-09-01 Thread tison
above. However, Curator has done this client-side expiration with a similar algorithm for a long time and I didn't hear any issues reported. So such a solution can be battle-tested. Best, tison. Kezhu Wang 于2023年9月1日周五 16:24写道: > Hi all, > > ZooKeeper session will expire appro

Re: [ANNOUNCE] Apache ZooKeeper 3.9.0

2023-08-05 Thread tison
Great job! Thank you and everyone to make this release happen :D Best, tison. Szalay-Bekő Máté 于2023年8月5日周六 18:59写道: > Great job indeed, thanks to everyone!! :) > Máté > > On Fri, Aug 4, 2023 at 6:24 PM Li Wang wrote: > > > Congrats! Thanks Andor and Enrico for lea

Re: ZooKeeper release 3.9.0

2023-07-07 Thread tison
Ack. Thank you! Best, tison. Andor Molnar 于2023年7月7日周五 23:00写道: > Hi tison, > > No need for new version yet, I still haven't cut 3.9.0 yet and probably > won't get there this week. Quite busy. > > Please continue fileing patches for 3.9.0 until I send a notificati

Re: ZooKeeper release 3.9.0

2023-07-06 Thread tison
/browse/ZOOKEEPER-4715 Best, tison. Andor Molnar 于2023年7月1日周六 21:41写道: > I'm fine with that. Thanks Damien. > > Andor > > > > On Wed, 2023-06-21 at 14:53 +0200, Damien Diederen wrote: > > Hi Andor, Máté, All, > > > > > There're 64 open ticket

Re: zk-merge-pr.py

2023-06-16 Thread tison
... and this is the related API endpoint https://docs.github.com/en/rest/pulls/pulls?apiVersion=2022-11-28#merge-a-pull-request Best, tison. tison 于2023年6月17日周六 04:09写道: > For issuing GitHub API calls, I use https://github.com/yanyongyu/githubkit > that generated from GitHub API defin

Re: zk-merge-pr.py

2023-06-16 Thread tison
For issuing GitHub API calls, I use https://github.com/yanyongyu/githubkit that generated from GitHub API definitions and the maintainer is active. Best, tison. Andor Molnar 于2023年6月17日周六 04:06写道: > Hi all, > > The greatest advantage of our merge script is the ability of > ba

Re: Current master branch is broker

2023-06-16 Thread tison
Thank you Kezhu! This case somehow indicates that we're under a "high" traffic. lol. Best, tison. Kezhu Wang 于2023年6月16日周五 19:20写道: > Hi Enrico, > > I presented a fix https://github.com/apache/zookeeper/pull/2012. > > On Fri, Jun 16, 2023 at 6:47 PM Enrico Ol

Re: So many good PRs open !

2022-12-27 Thread tison
Thank Enrico for starting this thread! I agree that there're many good patches waiting for review. Although I'm not one of the committers, I'm glad to help in reviewing if we have such a "CommitFest". Best, tison. Enrico Olivelli 于2022年12月27日周二 16:35写道: > Hel

Re: CI and Pull request validation - too many CI servers ?

2022-10-04 Thread tison
I think the Jenkins and GHA workflow can be duplicated. Although, I don't have time to work on it right now :) Best, tison. Andor Molnar 于2022年9月30日周五 22:16写道: > People was excited to try out new technologies. :) > ASF Jenkins is the "official" one, if we can say that. &

Re: CI and Pull request validation - too many CI servers ?

2022-09-29 Thread tison
IIRC GHA provides only x86_64 machines that can be an issue to use Travis _or_ Jenkins. Best, tison. Enrico Olivelli 于2022年9月29日周四 21:41写道: > Hello ZooKeepers, > Currently we are testing our PRs using: > - GitHub actions > - Travis > - ASF Jenkins > > Honestly I can'

Re: Call for reviews for ZOOKEEPER-4475 and ZOOKEEPER-4466

2022-06-29 Thread tison
Thanks for your contribution Kezhu! I've reviewed PR-1820. It looks good to me. PR-1859 seems a followup of 1820, will review 1859 after 1820 get accepted. Best, tison. Kezhu Wang 于2022年6月28日周二 23:17写道: > Hi guys, > > First, let me summarize changes of these two issues and

Re: Travis CI on s390x failed

2022-06-15 Thread tison
Bubble up this thread for one last time. Best, tison. tison 于2022年6月7日周二 14:02写道: > Hi ZooKeepers, > > After I push commits to update ZOOKEEPER-4492 PR[1] onto master, I notice > that Travis CI on s390x failed[2] due to environment issues. > > Is there someone familiar wit

Travis CI on s390x failed

2022-06-06 Thread tison
ilure. BTW, PR-1837 still wait for one more reviewer to decide whether we can merge the changes or it should be declined. Either should be better than no response :) Best, tison. [1] https://github.com/apache/zookeeper/pull/1837 [] https://app.travis-ci.com/github/apache/zookeeper/jobs/572633528

Re: Can we add the "readonly" field in ConnectRequest?

2022-03-29 Thread tison
The corresponding JIRA is filed as ZOOKEEPER-4492 and @eolivelli has given a review & approval. This patch is looking for another committers for reviewing and I'd like to bump this thread requesting for review :) Best, tison. tison 于2022年3月13日周日 11:17写道: > I'm tryin

Usage of WatchManagerOptimized

2022-03-29 Thread tison
Hi zookeepers, During code reading I notice that WatchManagerOptimized is referred in test only and never gets instantiated in production code. It confuses me. Is there some dynamically loading logic of WatchManagerOptimized? Or something wrong happens when code evolution? Best, tison.

Re: Can we add the "readonly" field in ConnectRequest?

2022-03-12 Thread tison
I'm trying to introduce an abstraction here[1]. Please review and if it's in the right direction, I'll create a ticket and move forward. Best, tison. [1] https://github.com/apache/zookeeper/pull/1837 tison 于2022年3月3日周四 11:38写道: > > if there is a way to detect ... >

Re: Can we add the "readonly" field in ConnectRequest?

2022-03-02 Thread tison
is about how to write connect {request|response}. And thus we actually do something as we do now. But if we can factor out a protocol interface it may be worth to give it a try, as if we still want to continue ZOOKEEPER-102, there will be such a protocol interface and switch abstraction. Bes

Re: Can we add the "readonly" field in ConnectRequest?

2022-03-01 Thread tison
... and this is the main PR: https://github.com/apache/zookeeper/pull/1832 However, it seems that ZK 3.3.x may be broken and the jute protocol cannot cover the case. You can review the PR and I already commented details. Best, tison. tison 于2022年2月28日周一 09:33写道: > Hi, > > T

Re: Can we add the "readonly" field in ConnectRequest?

2022-02-27 Thread tison
Hi, Thanks for eolivelli's review and approval, this PR[1] is waiting for another reviewer to proceed. I'd like to bump this thread to see if any committer could help on reviewing :) Best, tison. [1] https://github.com/apache/zookeeper/pull/1826 Enrico Olivelli 于2022年2月24日

Re: Can we add the "readonly" field in ConnectRequest?

2022-02-24 Thread tison
Here is an initial PR[1] you can give a review. I think the script is enough for the original purpose merging readOnly field. Best, tison. [1] https://github.com/apache/zookeeper/pull/1826 Enrico Olivelli 于2022年2月23日周三 20:46写道: > Il Mer 23 Feb 2022, 10:46 tison ha scritto: > > &g

Re: Can we add the "readonly" field in ConnectRequest?

2022-02-23 Thread tison
Hi Enrico, Thanks for your reply! Do we have end to end tests for the same version of client and server now? If we already have such tests, then wrapping them among different versions is possible. Otherwise, we may add such end to end tests first XD Best, tison. Enrico Olivelli 于2022年2月22日周二

Re: Can we add the "readonly" field in ConnectRequest?

2022-02-21 Thread tison
Bump the thread for one last try to see if any zookeeper is interested in this topic. Best, tison.

Can we add the "readonly" field in ConnectRequest?

2022-02-17 Thread tison
field, it seems the wire protocol won't break and we can move one step forward a separate proto module (ref ZOOKEEPER-102). I don't know whether the public interface will break in this case. Looking forward to your replies. Best, tison. -- Best, tison.

Is there an official ZooKeeper server interface definition?

2021-02-25 Thread tison
mportant procedure such a fake should simulate. Best, tison. [1] https://github.com/ClickHouse/ClickHouse/issues/17623

Re: [VOTE] Apache ZooKeeper 3.6.2 candidate 1

2020-09-05 Thread tison
Besides, shall we release the following modules? - zookeeper-contrib-rest - zookeeper-it Best, tison. tison 于2020年9月6日周日 上午10:57写道: > jump to > https://people.apache.org/~eolivelli/zookeeper-3.6.2-candidate-1/website/apidocs/zookeeper-server/index.html > > from sidebar "D

Re: [VOTE] Apache ZooKeeper 3.6.2 candidate 1

2020-09-05 Thread tison
jump to https://people.apache.org/~eolivelli/zookeeper-3.6.2-candidate-1/website/apidocs/zookeeper-server/index.html from sidebar "Developer>API Docs" returns 404, it is a testing environment issue? Best, tison. Michael Han 于2020年9月5日周六 上午5:55写道: > +1, with two minor issues:

Re: [Request for Review] ZOOKEEPER-837 Eliminate cycle dependency between ClientCnxn and ZooKeeper

2020-05-15 Thread tison
Never mind and thanks for reviewing :-) Best, tison. Andor Molnar 于2020年5月15日周五 下午9:44写道: > Apologies Tison, I’ll take a look once I have some free cycles. It’s a > very useful initiative, we’ve already tried that internally during the > Maven migration, but it turned out to b

[Request for Review] ZOOKEEPER-837 Eliminate cycle dependency between ClientCnxn and ZooKeeper

2020-05-15 Thread tison
thank eolivelli) but still wait for at least one more committer approval. The participants of the issue tend to include this patch in 3.7.0 and thus I come here requesting for review. Looking forward to hearing from you :-) Best, tison. [1] https://issues.apache.org/jira/browse/ZOOKEEPER-837 [2]

Re: Broken download page for ZK 3.6.1 binaries ?

2020-05-07 Thread tison
/zookeeper-3.6.1/apache-zookeeper-3.6.1-bin.tar.gz no https://dist.apache.org/repos/dist/release/zookeeper/zookeeper-3.6.1/ appears. Best, tison. Enrico Olivelli 于2020年5月8日周五 上午12:31写道: > Hi, > from my network it looks like that the download link for 3.6.1 is broken &

Request For Review: ZOOKEEPER-3579

2020-04-09 Thread tison
cause NPE in ClientCnxn.EventThread#processEvent Though, it stalls for quite a bit and I'd like to throw it into mailing list and request for reviews. Feedback is appreciated! Best, tison. [1] https://github.com/apache/zookeeper/pull/1120

Re: Github autolinks to JIRA issues

2020-04-09 Thread tison
Thanks! I also notice several projects enable this feature. Cross reference is convenient. Best, tison. Christopher 于2020年4月10日周五 上午11:10写道: > Is this actually enabled for ZooKeeper? My understanding is that this > was only available to certain GitHub paid products. If this is a

Re: Does ZK use protobuf?

2020-04-07 Thread tison
>From the git history I think it is just old and need to be updated. FYI, there is an ongoing effort ZOOKEEPER-102 trying to add protobuf as an option for serde and finally deprecated jute. Best, tison. Christopher 于2020年4月8日周三 上午11:25写道: > Does ZooKeeper use, or have any generate

Re: [ANNOUNCE] New ZooKeeper committer: Mate Szalay-Beko

2020-04-03 Thread tison
Kudos Mate! Best, tison. Tamas Penzes 于2020年4月3日周五 下午5:53写道: > Congrats Mate! > > On Fri, Apr 3, 2020, 10:42 Andor Molnar wrote: > > > The Apache ZooKeeper PMC recently extended committer karma to Mate and he > > has accepted. > > Mate has made some great con

Re: Keep Python 2 scripts...?

2020-04-01 Thread tison
Thanks for reporting the issue. I think it is because `filter` in Py3 returns iterator instead of list. I will check all these cases and file a ticket. Best, tison. Andor Molnar 于2020年4月1日周三 下午11:04写道: > Hey Tison, > > I’ve found a bug in the Py3 script after entering Jira fi

Re: Keep Python 2 scripts...?

2020-03-31 Thread tison
Thanks for your kind help! Best, tison. Norbert Kalmar 于2020年3月31日周二 下午7:37写道: > I know it's been only a day since the vote, but we already have multiple > +1, three of them from PMC members and no -1, so I'll commit the patch. > Thanks everyone, especially Tison f

Re: Keep Python 2 scripts...?

2020-03-30 Thread tison
Never mind. Updated pr based on the consensus. Best, tison. Enrico Olivelli 于2020年3月31日周二 上午2:10写道: > Tison, > can you please update your PR and drop the PY2 script ? > > I apologize, I asked you to keep it, we could have done it simpler :-) > > Enrico > > Il giorno

Re: Converting zk-merge-py to python3

2020-03-26 Thread tison
Hi Enrico, This sounds like a good idea. I created ZOOKEEPER-3771 and also a PR[1]. It seems to verify the patch we need a committer to go through the codepath :) Best, tison. [1] https://github.com/apache/zookeeper/pull/1295 Enrico Olivelli 于2020年3月27日周五 上午5:09写道: > Hi guys, > we ha

Re: [ANNOUNCE] Apache ZooKeeper 3.6.0 released

2020-03-08 Thread tison
Congrats! Also I notice that the pre-requirement[1] hasn't been merged yet, which previously causes release failure. Best, tison. [1] https://github.com/apache/zookeeper/pull/1280 殷芳玺 于2020年3月9日周一 下午2:37写道: > Great news! > > > But I found the releasenot

Re: Returned post for annou...@apache.org

2020-03-07 Thread tison
FYI https://github.com/apache/zookeeper/pull/1280 It would be helpful if we could invite a release manager to verify the change that avoids further reworking. Best, tison. tison 于2020年3月8日周日 上午12:44写道: > It seems like links like > https://www.apache.org/dyn/closer.lua/zookeeper/zoo

Re: Returned post for annou...@apache.org

2020-03-07 Thread tison
It seems like links like https://www.apache.org/dyn/closer.lua/zookeeper/zookeeper-3.6.0/apache-zookeeper-3.6.0-bin.tar.gz If so, let me open a pull request to update it. Though I am a bit confused then what does it mean the migration to dowloadns.a,o Best, tison. tison 于2020年3月8日周日 上午12:41写

Re: Returned post for annou...@apache.org

2020-03-07 Thread tison
I can help on adding the link to KEYS file. What does "mirror system" mean? Best, tison. Enrico Olivelli 于2020年3月8日周日 上午12:24写道: > Hi, > we are getting closer and closer...but > > Still my announce has been rejected. > > I am sorry I don't want t

Re: Returned post for annou...@apache.org

2020-03-07 Thread tison
FYI https://github.com/apache/zookeeper/pull/1279 Intuitively I resolve the direct links issue. For improve sentences or the whole page structure, mainly to emphasize which versions are under maintenance, we can have a later community discussion. Best, tison. tison 于2020年3月7日周六 下午7:59写道

Re: Returned post for annou...@apache.org

2020-03-07 Thread tison
Thanks for your information. I will look into it now. Best, tison. Enrico Olivelli 于2020年3月7日周六 下午7:52写道: > Il Sab 7 Mar 2020, 12:51 tison ha scritto: > > > Hi Enrico, > > > > I've created a corresponding JIRA[1]. I used to think that it should be > > some

Re: Returned post for annou...@apache.org

2020-03-07 Thread tison
Hi Enrico, I've created a corresponding JIRA[1]. I used to think that it should be some links in apache/zookeeper repo. But I fail to find it. Where is the entry of download page we should update? Best, tison. [1] https://issues.apache.org/jira/browse/ZOOKEEPER-3746 Enrico Olivelli 于202

Re: WebSite updates needed

2020-03-05 Thread tison
For the notice year part, here is the PR[1] with a filed JIRA ticket. For the download link part, I am a bit stuck because I cannot find the file generate release site. Does it stay in our repository apache/zookeeper? Best, tison. [1] https://github.com/apache/zookeeper/pull/1278 Enrico

Re: WebSite updates needed

2020-03-05 Thread tison
Hi Enrico, I volunteer for it. For the process it would be 1. open two JIRA tickets for them, respectively. 2. update NOTICEs for fixup1 3. move from .../dist to downloads.apache.org Best, tison. Enrico Olivelli 于2020年3月5日周四 下午3:41写道: > Hi, > We have to fix up the website: >

Re: [ANNOUNCE] Enrico Olivelli new ZooKeeper PMC Member

2020-01-21 Thread tison
Well deserved. Congrats! Best, tison. rammohan ganapavarapu 于2020年1月22日周三 上午6:15写道: > Congratulations Enrico!! > > On Tue, Jan 21, 2020 at 1:41 PM Flavio Junqueira wrote: > > > I'm pleased to announce that Enrico Olivelli recently became the newest > > Zoo

Re: ZK makes apache 2019 "top 5" projects

2019-12-11 Thread tison
Kudos! Best, tison. Patrick Hunt 于2019年12月12日周四 上午11:32写道: > This is really awesome, check it out: > https://twitter.com/phunt/status/1204966326118141952 > > Kudos ZooKeeper community on all the hard work and efforts! > > Patrick >

[jira] [Created] (ZOOKEEPER-3557) Towards a testable codebase

2019-09-25 Thread tison (Jira)
tison created ZOOKEEPER-3557: Summary: Towards a testable codebase Key: ZOOKEEPER-3557 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3557 Project: ZooKeeper Issue Type: Task