Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r110057806
--- Diff: src/java/main/org/apache/zookeeper/common/X509UtilTest.java ---
@@ -0,0 +1,231 @@
+/**
--- End diff --
This is supposed to be a tes
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r110057980
--- Diff: src/java/main/org/apache/zookeeper/common/X509UtilTest.java ---
@@ -0,0 +1,231 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r110060745
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Observer.java ---
@@ -63,10 +63,10 @@ void observeLeader() throws Exception {
zk.regis
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r110060990
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Learner.java ---
@@ -193,21 +198,18 @@ void request(Request request) throws IOException {
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r110061068
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Learner.java ---
@@ -253,7 +255,10 @@ protected void connectToLeader(InetSocketAddress addr)
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r110061229
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Learner.java ---
@@ -230,15 +232,15 @@ protected void sockConnect(Socket sock,
InetSocketAddress a
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r110068698
--- Diff: src/java/main/org/apache/zookeeper/common/X509UtilTest.java ---
@@ -0,0 +1,231 @@
+/**
--- End diff --
Whoops... Fixed.
---
If y
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r110068782
--- Diff: src/java/main/org/apache/zookeeper/common/X509UtilTest.java ---
@@ -0,0 +1,231 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r110068829
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Learner.java ---
@@ -193,21 +198,18 @@ void request(Request request) throws IOException {
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r110068870
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Learner.java ---
@@ -253,7 +255,10 @@ protected void connectToLeader(InetSocketAddress addr)
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r110070800
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Learner.java ---
@@ -230,15 +232,15 @@ protected void sockConnect(Socket sock,
InetSocketAddress
Github user geek101 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r110086744
--- Diff: ivy.xml ---
@@ -63,6 +67,9 @@
+
+
--- End diff --
is this specified twice?
---
If your project is
Github user geek101 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r110089934
--- Diff: src/java/test/org/apache/zookeeper/test/QuorumSSLTest.java ---
@@ -0,0 +1,603 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user geek101 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r110088588
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java ---
@@ -216,18 +218,35 @@ public boolean isQuorumSynced(QuorumVerifier qv) {
Github user geek101 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r110089020
--- Diff: src/java/main/org/apache/zookeeper/common/X509Util.java ---
@@ -171,21 +226,100 @@ public static X509KeyManager createKeyManager(String
keyStore
Github user geek101 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r110090086
--- Diff: src/java/main/org/apache/zookeeper/common/X509Util.java ---
@@ -18,63 +18,116 @@
package org.apache.zookeeper.common;
+impor
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r110224561
--- Diff: ivy.xml ---
@@ -63,6 +67,9 @@
+
+
--- End diff --
One is bcprov-jdk15on and the other is bcpkix-jdk15o
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r110224694
--- Diff: src/java/main/org/apache/zookeeper/common/X509Util.java ---
@@ -18,63 +18,116 @@
package org.apache.zookeeper.common;
+import
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r110224715
--- Diff: src/java/test/org/apache/zookeeper/test/QuorumSSLTest.java ---
@@ -0,0 +1,603 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r110227948
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java ---
@@ -216,18 +218,35 @@ public boolean isQuorumSynced(QuorumVerifier qv) {
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r110263282
--- Diff: src/java/main/org/apache/zookeeper/common/X509Util.java ---
@@ -171,21 +226,100 @@ public static X509KeyManager createKeyManager(String
keyStoreLo
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r111483370
--- Diff: src/java/main/org/apache/zookeeper/ClientCnxnSocketNetty.java ---
@@ -21,6 +21,7 @@
import org.apache.zookeeper.ClientCnxn.EndOfStreamException
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r111483464
--- Diff: src/java/main/org/apache/zookeeper/client/FourLetterWordMain.java
---
@@ -31,6 +31,7 @@
import javax.net.ssl.SSLSocket;
import javax.net.
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r111483819
--- Diff: src/java/main/org/apache/zookeeper/common/X509Util.java ---
@@ -18,63 +18,110 @@
package org.apache.zookeeper.common;
+import o
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r111484712
--- Diff: src/java/main/org/apache/zookeeper/common/X509Util.java ---
@@ -150,7 +196,7 @@ public static X509KeyManager createKeyManager(String
keyStoreLocati
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r111485824
--- Diff: src/java/main/org/apache/zookeeper/common/ZKTrustManager.java ---
@@ -0,0 +1,137 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r111486010
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Follower.java ---
@@ -71,7 +71,7 @@ void followLeader() throws InterruptedException {
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r111486323
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java ---
@@ -51,6 +53,8 @@
import org.slf4j.Logger;
import org.slf4j.Logg
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r111486591
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java ---
@@ -383,6 +387,7 @@ public void run() {
+ lea
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r111487159
--- Diff: src/java/test/org/apache/zookeeper/test/QuorumSSLTest.java ---
@@ -0,0 +1,668 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) u
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r111603427
--- Diff: src/java/main/org/apache/zookeeper/common/X509Util.java ---
@@ -150,7 +196,7 @@ public static X509KeyManager createKeyManager(String
keyStoreLocat
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r111604664
--- Diff: src/java/main/org/apache/zookeeper/ClientCnxnSocketNetty.java ---
@@ -21,6 +21,7 @@
import org.apache.zookeeper.ClientCnxn.EndOfStreamExceptio
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r111604682
--- Diff: src/java/main/org/apache/zookeeper/client/FourLetterWordMain.java
---
@@ -31,6 +31,7 @@
import javax.net.ssl.SSLSocket;
import javax.net
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r111605341
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java ---
@@ -383,6 +387,7 @@ public void run() {
+ le
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r111605399
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java ---
@@ -51,6 +53,8 @@
import org.slf4j.Logger;
import org.slf4j.Log
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r111605424
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Follower.java ---
@@ -71,7 +71,7 @@ void followLeader() throws InterruptedException {
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r111605464
--- Diff: src/java/main/org/apache/zookeeper/common/X509Util.java ---
@@ -18,63 +18,110 @@
package org.apache.zookeeper.common;
+import
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r111612166
--- Diff: src/java/main/org/apache/zookeeper/common/ZKTrustManager.java ---
@@ -0,0 +1,137 @@
+/**
+ * Licensed to the Apache Software Foundation (AS
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r111613841
--- Diff: src/java/main/org/apache/zookeeper/common/ZKTrustManager.java ---
@@ -0,0 +1,137 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r111656663
--- Diff: src/java/test/org/apache/zookeeper/test/QuorumSSLTest.java ---
@@ -0,0 +1,668 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r112559332
--- Diff: src/java/main/org/apache/zookeeper/common/ZKTrustManager.java ---
@@ -0,0 +1,137 @@
+/**
+ * Licensed to the Apache Software Foundation (AS
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r113276213
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java ---
@@ -63,6 +66,10 @@ public void shutdown() {
}
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r113278361
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java ---
@@ -63,6 +66,10 @@ public void shutdown() {
}
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r114086628
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java ---
@@ -64,6 +66,8 @@
protected InetSocketAddress clientPortA
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r114086635
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java ---
@@ -290,6 +294,10 @@ public void parseProperties(Properties zkProp)
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r114086663
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java ---
@@ -178,6 +178,8 @@ public void runFromConfig(QuorumPeerConfig config)
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r114086721
--- Diff: src/java/main/org/apache/zookeeper/common/ZKConfig.java ---
@@ -107,14 +99,33 @@ private void init() {
* this configuration.
*/
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r114086738
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java ---
@@ -216,18 +218,35 @@ public boolean isQuorumSynced(QuorumVerifier qv) {
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r114166007
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Learner.java ---
@@ -254,6 +260,9 @@ protected void connectToLeader(InetSocketAddress addr)
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r114166502
--- Diff: src/java/main/org/apache/zookeeper/common/X509Util.java ---
@@ -160,43 +213,120 @@ public static X509KeyManager createKeyManager(String
keyStoreLoc
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r114167558
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -438,9 +447,18 @@ synchronized private boolean connectOne(long sid,
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r114167751
--- Diff: src/java/main/org/apache/zookeeper/common/X509Util.java ---
@@ -160,43 +213,120 @@ public static X509KeyManager createKeyManager(String
keyStoreLo
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r114168758
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java ---
@@ -64,6 +66,8 @@
protected InetSocketAddress clientPort
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r114168844
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java ---
@@ -290,6 +294,10 @@ public void parseProperties(Properties zkProp)
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r114168897
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java ---
@@ -178,6 +178,8 @@ public void runFromConfig(QuorumPeerConfig config)
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r114172228
--- Diff: src/java/main/org/apache/zookeeper/common/ZKConfig.java ---
@@ -107,14 +99,33 @@ private void init() {
* this configuration.
*/
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r114175213
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -438,9 +447,18 @@ synchronized private boolean connectOne(long sid,
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r114181665
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Learner.java ---
@@ -254,6 +260,9 @@ protected void connectToLeader(InetSocketAddress addr)
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r189135140
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Learner.java ---
@@ -254,6 +260,9 @@ protected void connectToLeader(InetSocketAddress addr)
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r192157656
--- Diff: src/java/main/org/apache/zookeeper/common/X509Util.java ---
@@ -18,64 +18,119 @@
package org.apache.zookeeper.common;
+impo
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r192158182
--- Diff: src/java/main/org/apache/zookeeper/common/X509Util.java ---
@@ -160,43 +214,120 @@ public static X509KeyManager createKeyManager(String
keyStor
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r192158353
--- Diff: src/java/main/org/apache/zookeeper/common/X509Util.java ---
@@ -160,43 +214,120 @@ public static X509KeyManager createKeyManager(String
keyStor
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r192158828
--- Diff:
src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java ---
@@ -348,20 +347,20 @@ public ChannelPipeline getPipeline() throws Exc
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194233639
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Learner.java ---
@@ -292,8 +298,20 @@ protected void connectToLeader(InetSocketAddress addr,
S
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194234222
--- Diff: src/java/main/org/apache/zookeeper/common/X509Util.java ---
@@ -18,64 +18,119 @@
package org.apache.zookeeper.common;
+impo
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194234308
--- Diff: src/java/main/org/apache/zookeeper/common/X509Util.java ---
@@ -18,64 +18,119 @@
package org.apache.zookeeper.common;
+impo
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194234667
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/UnifiedServerSocket.java ---
@@ -0,0 +1,79 @@
+/**
+ * Licensed to the Apache Software
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194233492
--- Diff: src/java/main/org/apache/zookeeper/common/ZKTrustManager.java ---
@@ -0,0 +1,144 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194233692
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -632,37 +639,46 @@ synchronized private boolean connectOne(long s
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r148900246
--- Diff: src/java/main/org/apache/zookeeper/common/ClientX509Util.java ---
@@ -0,0 +1,38 @@
+/**
+ * Licensed to the Apache Software Foundation (
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194234634
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/PrependableSocket.java ---
@@ -0,0 +1,49 @@
+/**
+ * Licensed to the Apache Software F
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r148901017
--- Diff: src/java/main/org/apache/zookeeper/common/ZKTrustManager.java ---
@@ -0,0 +1,144 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194234529
--- Diff: src/java/main/org/apache/zookeeper/common/X509Util.java ---
@@ -160,43 +214,120 @@ public static X509KeyManager createKeyManager(String
keyStor
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r148901325
--- Diff: src/java/main/org/apache/zookeeper/common/ZKTrustManager.java ---
@@ -0,0 +1,144 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194234574
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java ---
@@ -227,19 +229,36 @@ public boolean isQuorumSynced(QuorumVerifier qv) {
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r148901276
--- Diff: src/java/main/org/apache/zookeeper/common/ZKTrustManager.java ---
@@ -0,0 +1,144 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194365328
--- Diff: src/java/main/org/apache/zookeeper/common/ClientX509Util.java ---
@@ -0,0 +1,38 @@
+/**
+ * Licensed to the Apache Software Foundation (
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194365379
--- Diff: src/java/main/org/apache/zookeeper/common/ZKTrustManager.java ---
@@ -0,0 +1,144 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194365408
--- Diff: src/java/main/org/apache/zookeeper/common/ZKTrustManager.java ---
@@ -0,0 +1,144 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194366505
--- Diff: src/java/main/org/apache/zookeeper/common/ZKTrustManager.java ---
@@ -0,0 +1,144 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194368166
--- Diff: src/java/main/org/apache/zookeeper/common/ZKTrustManager.java ---
@@ -0,0 +1,144 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194369924
--- Diff: src/java/main/org/apache/zookeeper/common/ZKTrustManager.java ---
@@ -0,0 +1,144 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194371329
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -632,37 +639,46 @@ synchronized private boolean connectOne(long s
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194372536
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Learner.java ---
@@ -292,8 +298,20 @@ protected void connectToLeader(InetSocketAddress addr,
S
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194378274
--- Diff: src/java/main/org/apache/zookeeper/common/X509Util.java ---
@@ -18,64 +18,119 @@
package org.apache.zookeeper.common;
+impo
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194395807
--- Diff: src/java/main/org/apache/zookeeper/common/X509Util.java ---
@@ -18,64 +18,119 @@
package org.apache.zookeeper.common;
+impo
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194404621
--- Diff: src/java/main/org/apache/zookeeper/common/X509Util.java ---
@@ -160,43 +214,120 @@ public static X509KeyManager createKeyManager(String
keyStor
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194404893
--- Diff:
src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java ---
@@ -348,20 +347,20 @@ public ChannelPipeline getPipeline() throws Exc
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194405375
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/PrependableSocket.java ---
@@ -0,0 +1,49 @@
+/**
+ * Licensed to the Apache Software F
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194437578
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Learner.java ---
@@ -292,8 +298,20 @@ protected void connectToLeader(InetSocketAddress addr,
S
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194438427
--- Diff: src/java/main/org/apache/zookeeper/common/ZKTrustManager.java ---
@@ -0,0 +1,144 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194438668
--- Diff: src/java/main/org/apache/zookeeper/common/X509Util.java ---
@@ -18,64 +18,119 @@
package org.apache.zookeeper.common;
+impo
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194441963
--- Diff: src/java/main/org/apache/zookeeper/common/ZKTrustManager.java ---
@@ -0,0 +1,144 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194442041
--- Diff: src/java/main/org/apache/zookeeper/common/X509Util.java ---
@@ -18,64 +18,119 @@
package org.apache.zookeeper.common;
+impo
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194451677
--- Diff: src/java/main/org/apache/zookeeper/common/ZKTrustManager.java ---
@@ -0,0 +1,144 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194456601
--- Diff: src/java/main/org/apache/zookeeper/common/ZKTrustManager.java ---
@@ -0,0 +1,144 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194458091
--- Diff: src/java/main/org/apache/zookeeper/common/X509Util.java ---
@@ -18,64 +18,119 @@
package org.apache.zookeeper.common;
+impo
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194460371
--- Diff: src/java/main/org/apache/zookeeper/common/X509Util.java ---
@@ -18,64 +18,119 @@
package org.apache.zookeeper.common;
+impo
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194460585
--- Diff: src/java/main/org/apache/zookeeper/common/X509Util.java ---
@@ -18,64 +18,119 @@
package org.apache.zookeeper.common;
+impo
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194461322
--- Diff: src/java/main/org/apache/zookeeper/common/X509Util.java ---
@@ -160,43 +214,120 @@ public static X509KeyManager createKeyManager(String
keyStor
1 - 100 of 177 matches
Mail list logo
