Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/549
---
Github user enixon commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/549#discussion_r198607891
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerConfigTest.java ---
@@ -103,6 +103,23 @@ public void testCustomSSLAuth()
Github user enixon commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/549#discussion_r198607295
--- Diff: src/java/test/org/apache/zookeeper/test/ReconfigTest.java ---
@@ -801,10 +801,12 @@ private void testPortChangeToBlockedPort(boolean
testLeader)
Github user enixon commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/549#discussion_r198609106
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -259,6 +259,11 @@ public QuorumServer(long sid, String addressStr)
Github user tamaashu commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/549#discussion_r198532231
--- Diff: src/java/test/org/apache/zookeeper/test/ReconfigTest.java ---
@@ -801,10 +801,12 @@ private void testPortChangeToBlockedPort(boolean
Github user nkalmar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/549#discussion_r198408262
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerConfigTest.java ---
@@ -103,6 +103,23 @@ public void testCustomSSLAuth()
Github user nkalmar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/549#discussion_r198407883
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -259,6 +259,11 @@ public QuorumServer(long sid, String addressStr)
Github user nkalmar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/549#discussion_r198405834
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerConfigTest.java ---
@@ -103,6 +103,23 @@ public void testCustomSSLAuth()
Github user nkalmar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/549#discussion_r198404697
--- Diff: src/java/test/org/apache/zookeeper/test/ReconfigTest.java ---
@@ -801,10 +801,12 @@ private void testPortChangeToBlockedPort(boolean
Github user enixon commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/549#discussion_r198339591
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -259,6 +259,11 @@ public QuorumServer(long sid, String addressStr)
Github user enixon commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/549#discussion_r198338704
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -259,6 +259,11 @@ public QuorumServer(long sid, String addressStr)
Github user enixon commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/549#discussion_r198338264
--- Diff: src/java/test/org/apache/zookeeper/test/ReconfigTest.java ---
@@ -801,10 +801,12 @@ private void testPortChangeToBlockedPort(boolean
testLeader)
Github user enixon commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/549#discussion_r198338214
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerConfigTest.java ---
@@ -103,6 +103,23 @@ public void testCustomSSLAuth()
Github user enixon commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/549#discussion_r198339563
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerConfigTest.java ---
@@ -103,6 +103,23 @@ public void testCustomSSLAuth()
GitHub user nkalmar opened a pull request:
https://github.com/apache/zookeeper/pull/549
ZOOKEEPER-2873 abort startup on invalid ports
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nkalmar/zookeeper ZOOKEEPER-2873
15 matches
Mail list logo