[GitHub] zookeeper pull request #567: ZOOKEEPER-3071: Add a config parameter to contr...

2018-11-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/567 ---

[GitHub] zookeeper pull request #567: ZOOKEEPER-3071: Add a config parameter to contr...

2018-08-17 Thread suyogmapara
Github user suyogmapara commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/567#discussion_r210988903 --- Diff: src/java/test/org/apache/zookeeper/server/persistence/FileTxnLogTest.java --- @@ -17,9 +17,13 @@ */ package

[GitHub] zookeeper pull request #567: ZOOKEEPER-3071: Add a config parameter to contr...

2018-08-13 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/567#discussion_r209526014 --- Diff: zookeeper-docs/src/documentation/content/xdocs/zookeeperAdmin.xml --- @@ -840,6 +840,26 @@ server.3=zoo3:2888:3888

[GitHub] zookeeper pull request #567: ZOOKEEPER-3071: Add a config parameter to contr...

2018-08-12 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/567#discussion_r209484474 --- Diff: src/java/test/org/apache/zookeeper/server/persistence/FileTxnLogTest.java --- @@ -17,9 +17,13 @@ */ package

[GitHub] zookeeper pull request #567: ZOOKEEPER-3071: Add a config parameter to contr...

2018-08-12 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/567#discussion_r209484281 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java --- @@ -127,14 +127,11 @@ Long logSize =

[GitHub] zookeeper pull request #567: ZOOKEEPER-3071: Add a config parameter to contr...

2018-08-12 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/567#discussion_r209484163 --- Diff: zookeeper-docs/src/documentation/content/xdocs/zookeeperAdmin.xml --- @@ -840,6 +840,26 @@ server.3=zoo3:2888:3888

[GitHub] zookeeper pull request #567: ZOOKEEPER-3071: Add a config parameter to contr...

2018-07-30 Thread suyogmapara
Github user suyogmapara commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/567#discussion_r206338732 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java --- @@ -102,6 +102,21 @@ /** Maximum time we allow for

[GitHub] zookeeper pull request #567: ZOOKEEPER-3071: Add a config parameter to contr...

2018-07-27 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/567#discussion_r205933566 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java --- @@ -102,6 +102,21 @@ /** Maximum time we allow for elapsed

[GitHub] zookeeper pull request #567: ZOOKEEPER-3071: Add a config parameter to contr...

2018-07-27 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/567#discussion_r205933558 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java --- @@ -102,6 +102,21 @@ /** Maximum time we allow for elapsed

[GitHub] zookeeper pull request #567: ZOOKEEPER-3071: Add a config parameter to contr...

2018-07-27 Thread suyogmapara
Github user suyogmapara commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/567#discussion_r205923249 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java --- @@ -102,6 +102,21 @@ /** Maximum time we allow for

[GitHub] zookeeper pull request #567: ZOOKEEPER-3071: Add a config parameter to contr...

2018-07-27 Thread suyogmapara
Github user suyogmapara commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/567#discussion_r205922930 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java --- @@ -127,14 +127,11 @@ Long logSize =

[GitHub] zookeeper pull request #567: ZOOKEEPER-3071: Add a config parameter to contr...

2018-07-27 Thread suyogmapara
Github user suyogmapara commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/567#discussion_r205897728 --- Diff: src/java/test/org/apache/zookeeper/test/TxnLogSizeLimitTest.java --- @@ -0,0 +1,173 @@ +/** + * Licensed to the Apache Software

[GitHub] zookeeper pull request #567: ZOOKEEPER-3071: Add a config parameter to contr...

2018-07-26 Thread breed
Github user breed commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/567#discussion_r205667420 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java --- @@ -102,6 +102,21 @@ /** Maximum time we allow for elapsed

[GitHub] zookeeper pull request #567: ZOOKEEPER-3071: Add a config parameter to contr...

2018-07-26 Thread breed
Github user breed commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/567#discussion_r205667343 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java --- @@ -102,6 +102,21 @@ /** Maximum time we allow for elapsed

[GitHub] zookeeper pull request #567: ZOOKEEPER-3071: Add a config parameter to contr...

2018-07-26 Thread breed
Github user breed commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/567#discussion_r205667305 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java --- @@ -102,6 +102,20 @@ /** Maximum time we allow for elapsed

[GitHub] zookeeper pull request #567: ZOOKEEPER-3071: Add a config parameter to contr...

2018-07-26 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/567#discussion_r205526853 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java --- @@ -102,6 +102,20 @@ /** Maximum time we allow for elapsed

[GitHub] zookeeper pull request #567: ZOOKEEPER-3071: Add a config parameter to contr...

2018-07-26 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/567#discussion_r205525593 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java --- @@ -109,7 +109,7 @@ * * The feature is disabled

[GitHub] zookeeper pull request #567: ZOOKEEPER-3071: Add a config parameter to contr...

2018-07-26 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/567#discussion_r205527457 --- Diff: src/java/test/org/apache/zookeeper/test/TxnLogSizeLimitTest.java --- @@ -0,0 +1,173 @@ +/** + * Licensed to the Apache Software

[GitHub] zookeeper pull request #567: ZOOKEEPER-3071: Add a config parameter to contr...

2018-07-26 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/567#discussion_r205526028 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java --- @@ -127,14 +127,11 @@ Long logSize =

[GitHub] zookeeper pull request #567: ZOOKEEPER-3071: Add a config parameter to contr...

2018-07-16 Thread suyogmapara
Github user suyogmapara commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/567#discussion_r202855015 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java --- @@ -110,6 +124,18 @@ if ((fsyncWarningThreshold =

[GitHub] zookeeper pull request #567: ZOOKEEPER-3071: Add a config parameter to contr...

2018-07-16 Thread suyogmapara
Github user suyogmapara commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/567#discussion_r202854476 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java --- @@ -110,6 +124,18 @@ if ((fsyncWarningThreshold =

[GitHub] zookeeper pull request #567: ZOOKEEPER-3071: Add a config parameter to contr...

2018-07-13 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/567#discussion_r202364176 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java --- @@ -347,6 +397,13 @@ public synchronized void commit() throws

[GitHub] zookeeper pull request #567: ZOOKEEPER-3071: Add a config parameter to contr...

2018-07-13 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/567#discussion_r202363134 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java --- @@ -102,6 +102,20 @@ /** Maximum time we allow for elapsed

[GitHub] zookeeper pull request #567: ZOOKEEPER-3071: Add a config parameter to contr...

2018-07-13 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/567#discussion_r202364713 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java --- @@ -347,6 +397,13 @@ public synchronized void commit() throws

[GitHub] zookeeper pull request #567: ZOOKEEPER-3071: Add a config parameter to contr...

2018-07-13 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/567#discussion_r202363520 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java --- @@ -110,6 +124,18 @@ if ((fsyncWarningThreshold =

[GitHub] zookeeper pull request #567: ZOOKEEPER-3071: Add a config parameter to contr...

2018-07-13 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/567#discussion_r202362761 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java --- @@ -110,6 +124,18 @@ if ((fsyncWarningThreshold =

[GitHub] zookeeper pull request #567: ZOOKEEPER-3071: Add a config parameter to contr...

2018-07-13 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/567#discussion_r202364057 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java --- @@ -347,6 +397,13 @@ public synchronized void commit() throws

[GitHub] zookeeper pull request #567: ZOOKEEPER-3071: Add a config parameter to contr...

2018-07-12 Thread suyogmapara
GitHub user suyogmapara opened a pull request: https://github.com/apache/zookeeper/pull/567 ZOOKEEPER-3071: Add a config parameter to control transaction log size You can merge this pull request into a Git repository by running: $ git pull