(See
[https://builds.apache.org/job/ZooKeeper-trunk/1771/])
ZOOKEEPER-1478. Small bug in QuorumTest.testFollowersStartAfterLeader( )
(Alexander Shraer via fpj, breed, phunt) (Revision 1421091)
Result = SUCCESS
phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1
o me!
> Small bug in QuorumTest.testFollowersStartAfterLeader( )
>
>
> Key: ZOOKEEPER-1478
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1478
> Project: ZooKeeper
>
bug in QuorumTest.testFollowersStartAfterLeader( )
>
>
> Key: ZOOKEEPER-1478
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1478
> Project: ZooKeeper
> Issue Type: Bug
> Components:
.
> Small bug in QuorumTest.testFollowersStartAfterLeader( )
>
>
> Key: ZOOKEEPER-1478
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1478
> Project: ZooKeeper
>
critical one.
> Small bug in QuorumTest.testFollowersStartAfterLeader( )
>
>
> Key: ZOOKEEPER-1478
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1478
>
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mahadev konar updated ZOOKEEPER-1478:
-
Affects Version/s: 3.4.3
> Small bug in QuorumTest.testFollowersStartAfterLea
in QuorumTest.testFollowersStartAfterLeader( )
>
>
> Key: ZOOKEEPER-1478
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1478
> Project: ZooKeeper
> Issue Type: Bug
>
but since I added code to the patch, it might be a good
idea to have someone else having a look at it too.
> Small bug in QuorumTest.testFollowersStartAfterLeader( )
>
>
> Key: ZOOKEEPER-1478
>
bug in QuorumTest.testFollowersStartAfterLeader( )
>
>
> Key: ZOOKEEPER-1478
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1478
> Project: ZooKeeper
> Issue Type: Bug
> Components:
> Small bug in QuorumTest.testFollowersStartAfterLeader( )
>
>
> Key: ZOOKEEPER-1478
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1478
> Project: ZooKeeper
>
bug in QuorumTest.testFollowersStartAfterLeader( )
>
>
> Key: ZOOKEEPER-1478
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1478
> Project: ZooKeeper
> Issue Type: Bug
> Components:
the disconnection.
> Small bug in QuorumTest.testFollowersStartAfterLeader( )
>
>
> Key: ZOOKEEPER-1478
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1478
>
. It sounds ok to remove.
> Small bug in QuorumTest.testFollowersStartAfterLeader( )
>
>
> Key: ZOOKEEPER-1478
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1478
> Pro
CONNECTION_TIMEOUT));
above your changes. Server 2 might not have been even shut down (it should be
"index" ?) and in any case your new line waitForConnected seems to be
sufficient even without the above line. right ?
> Small bug in QuorumTe
the patch you submitted looks good.
> Small bug in QuorumTest.testFollowersStartAfterLeader( )
>
>
> Key: ZOOKEEPER-1478
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-14
in QuorumTest.testFollowersStartAfterLeader( )
>
>
> Key: ZOOKEEPER-1478
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1478
> Project: ZooKeeper
> Issue Type: Bug
>
bug in QuorumTest.testFollowersStartAfterLeader( )
>
>
> Key: ZOOKEEPER-1478
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1478
> Project: ZooKeeper
> Issue Type: Bug
> Components:
in QuorumTest.testFollowersStartAfterLeader( )
>
>
> Key: ZOOKEEPER-1478
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1478
> Project: ZooKeeper
> Issue Type: Bug
>
Alexander Shraer created ZOOKEEPER-1478:
---
Summary: Small bug in QuorumTest.testFollowersStartAfterLeader( )
Key: ZOOKEEPER-1478
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1478
Project
Cool, thanks for the patch. Looks like this effects both 3.3 and trunk.
On Tue, Jun 21, 2011 at 2:37 PM, Eugene Koontz wrote:
> On 6/21/11 2:33 PM, Eugene Koontz wrote:
>>
>> On 6/21/11 2:12 PM, Patrick Hunt wrote:
>>>
>>> Hi Eugene, that looks right to me. (did that fix it for you?)
>>>
> Forgot
On 6/21/11 2:33 PM, Eugene Koontz wrote:
On 6/21/11 2:12 PM, Patrick Hunt wrote:
Hi Eugene, that looks right to me. (did that fix it for you?)
Forgot to say; yes, it does fix QuorumTest for me. I used the attached
script file to run this test repeatedly until failure, and it never exited.
-Eu
On 6/21/11 2:12 PM, Patrick Hunt wrote:
Hi Eugene, that looks right to me. (did that fix it for you?)
In addition to the anti-pattern I mentioned earlier, another one to
look for is slow running tests -- often times a test will run slowly
that could be coded in a different way to run much more q
address them before commit.
>>
>> Patrick
>
> Thanks a lot for bringing this up, Camille. I had exactly this problem
> (QuorumTest.testFollowersStartAfterLeader failing) yesterday and today .
> Would the attached patch be the fix in the spirit of the pattern you're
> describing, Patrick?
>
> -Eugene
>
>
>
like this testSessionMove pattern (retry
with a max limit that's very long). During reviews we should look for
anti-patterns like this and address them before commit.
Patrick
Thanks a lot for bringing this up, Camille. I had exactly this problem
(QuorumTest.testFollowersStartAfterLeader failing) yest
Such uses of sleep are just asking for trouble. Take a look at the use
of sleep in testSessionMove in the same class for a better way to do
this. I had gone through all the tests a while back, replacing all the
"sleep(x)" with something like this testSessionMove pattern (retry
with a max limit that
I see that this has failed a few precommit builds now, and someone reported it
failing in their local env regularly. Do we think this is just a general
transient test, or was there a change checked in recently that might related to
this code and its new transient failures? Perhaps it is just the
26 matches
Mail list logo
