Re: PSA: Please use ChromeUtils.generateQI for JS QueryInterface methods

2018-05-18 Thread Jared Wein
Great! :) On Fri, May 18, 2018 at 2:58 PM Kris Maglione wrote: > Already done. :) https://bugzil.la/1460092 > > On Fri, May 18, 2018 at 02:48:20PM -0400, Jared Wein wrote: > >Have you looked in to adding an eslint rule for this? The eslint rule[1] > >that recommends usage

Re: PSA: Please use ChromeUtils.generateQI for JS QueryInterface methods

2018-05-18 Thread Kris Maglione
Already done. :) https://bugzil.la/1460092 On Fri, May 18, 2018 at 02:48:20PM -0400, Jared Wein wrote: Have you looked in to adding an eslint rule for this? The eslint rule[1] that recommends usage of ChromeUtils.defineModuleGetter instead of XPCOMUtils.defineLazyModuleGetter has been very

Re: PSA: Please use ChromeUtils.generateQI for JS QueryInterface methods

2018-05-18 Thread Jared Wein
Have you looked in to adding an eslint rule for this? The eslint rule[1] that recommends usage of ChromeUtils.defineModuleGetter instead of XPCOMUtils.defineLazyModuleGetter has been very useful. [1]

Re: Removing tinderbox-builds from archive.mozilla.org

2018-05-18 Thread Chris AtLee
The discussion about what to do about these particular buildbot builds has naturally shifted into a discussion about what kind of retention policy is appropriate for CI builds. I believe that right now we keep all CI build artifacts for 1 year. Nightly and release builds are kept forever. There's

Re: License of test data?

2018-05-18 Thread mhoye
On 2018-05-18 3:30 AM, Henri Sivonen wrote: On Thu, May 17, 2018 at 8:31 PM, mhoye wrote: Well, more than a day or two. The MIT license is fine to include, and we have a pile of MIT-licensed code in-tree already. Other already-in-tree MPL-2.0 compatible licenses - the

Re: License of test data?

2018-05-18 Thread Henri Sivonen
On Thu, May 17, 2018 at 8:31 PM, mhoye wrote: > Well, more than a day or two. The MIT license is fine to include, and we > have a pile of MIT-licensed code in-tree already. > > Other already-in-tree MPL-2.0 compatible licenses - the "just do it" set, > basically - include