Re: Intent to unship: system SQLite support on Linux (--enable-system-sqlite)

The unship patch was just merged in mozilla-central in bug 1611386. Marco On Thu, Feb 6, 2020 at 4:11 PM Marco Bonardo wrote: > The Storage support team intends to remove support for building > Mozilla-based applications using the system provided SQLite library on > Linux (--enab

Intent to unship: system SQLite support on Linux (--enable-system-sqlite)

The Storage support team intends to remove support for building Mozilla-based applications using the system provided SQLite library on Linux (--enable-system-sqlite). When: After the next mozilla-central merge to Nightly 75, February 10th. We plan to unship support during the 75 cycle. Where:

Re: Update: m-c is now reformatted, trees will reopen shortly

Hi, the new style in some cases doesn't look more readable than before, and some files grew a lot vertically due to huge amount of added newlines. For example: Assert.equal(newPrincipalURI, originalPrincipalURI, "content has the same principal"); now has to be written as

Re: Plan for Sunsetting MozReview

sitive behaviour and this > causes cl.exe to get confused. This bit me last week. > > -Jeff > > On Fri, Jul 27, 2018 at 9:30 AM, Marco Bonardo > wrote: > > As a side note, the WSL terminal on Windows works properly with arc. The > > only downside is that you ne

Re: Plan for Sunsetting MozReview

As a side note, the WSL terminal on Windows works properly with arc. The only downside is that you need a Windows terminal to build and a separate WSL terminal to arc diff... On Fri, Jul 27, 2018 at 3:25 PM Mark Côté wrote: > I plan on updating a bunch of MDN docs within the next couple weeks. I

Re: PSA: pay attention when setting multiple reviewers in Phabricator

On Mon, Jul 2, 2018 at 5:01 PM Andreas Tolfsen wrote: > > > When asking for review to multiple reviewers, and all of them must accept > > your revision, you must mark them as blocking reviews, either in the > > Phabricator ui or appending "!" at the end of the reviewer name. > Otherwise > > it's

PSA: pay attention when setting multiple reviewers in Phabricator

TL;DR When asking for review to multiple reviewers, and all of them must accept your revision, you must mark them as blocking reviews, either in the Phabricator ui or appending "!" at the end of the reviewer name. Otherwise it's first-come-first-serve. Full details: Standard8 asked for review to b

Re: Please try out clang-cl and lld-link on Windows

It sounds cool and I'd really love to try, but: "ERROR: Found SDK version 10.0.16299.0 but clang-cl builds currently don't work with SDK version 10.0.16299.0 and later..." I know that I can set WINDOWSSDKDIR, but I'm not willing to mess too much with the env. Is there a bug tracking the update to

Re: Proposal to replace the NS_ASSERT function in JS with console.assert

On Mon, Feb 26, 2018 at 7:02 PM, Brian Grinstead wrote: > console.assert doesn't throw an exception, and neither does NS_ASSERT. So I > don’t think replacing consumers with exceptions is correct if we want to keep > the current behavior. But I guess the intent for places code in bug 1431050 > i

Re: Proposal to replace the NS_ASSERT function in JS with console.assert

We were already working with a contributor to remove NS_ASSERT and debug.js in https://bugzilla.mozilla.org/show_bug.cgi?id=1431050 and we were just replacing those few calls with simple exceptions. The usage is not particularly spread in the codebase and the benefits in ruining Nightly testers lif

Re: PSA: Changes to JSM import APIs (or, Death to Cu.import)

Hi Kris, this change is awesome. Is it ok to continue use defineLazyModuleGetters (plural), since it internally now uses chromeUtils.defineModuleGetter? Any downsides? On Fri, Feb 2, 2018 at 7:48 AM, Ed Lee wrote: > Great to see these types of broad changes getting wins, so if there's > a good w

Re: Firefox 55.* in Windows/Ubuntu - every day CPU 100%/Hangs Up. Please to do something!

Is your profile local, or do you have it on a network share? It's possible your db has some kind of corruption that causes recursive references. I'd first of all check it using sqlite3 and the PRAGMA integrity_check query. If that passes (returns "ok"), I'd also try to run the Places Maintenance f

Re: #pragma once?

See the previous pragma once proposal: https://groups.google.com/forum/#!msg/mozilla.dev.platform/PgDjWw3xp8k/PLYQc5xoWmsJ On Wed, Oct 11, 2017 at 11:45 AM, Emilio Cobos Álvarez wrote: > Hi, > > I'm adding a header to the build, and I'm wondering: Can we use pragma once? _

Re: Changes to tab min-width

On Tue, Oct 3, 2017 at 10:36 PM, Jeff Griffiths wrote: > 1. do you prefer the existing behaviour or the new behaviour? > 2. if you prefer a value for this pref different than 50 or 100, what > is it? Why? I prefer being able to see a minimum part of the title, because I very often have multiple t

Re: Intent to require `mach try` for submitting to Try

On Sun, Sep 17, 2017 at 6:05 AM, Andrew Halberstadt wrote: > Interesting, please file a bug either way and CC me. It worked > for me back when it first landed, though I haven't tried it since. > I'll see if I can reproduce sometime this week. Done: https://bugzilla.mozilla.org/show_bug.cgi?id=140

Re: Intent to require `mach try` for submitting to Try

I have a problem with try fuzzy, not sure if it's just my system, so didn't file a bug yet. On Windows it always hangs after it tries to cleanup its own stuff at the end, I must terminate it and manually uncommit and purge the config file. Does anyone have the same problem?

Re: Reminder on Try usage and infrastructure resources

On Thu, Sep 14, 2017 at 6:13 PM, Andrew Halberstadt wrote: > Yes, all mochitests except Android restart between manifests (which is > usually the same as folders). Thank you very much, that's really useful to know and will allow me to save some infra time!

Re: Reminder on Try usage and infrastructure resources

On Thu, Sep 14, 2017 at 5:56 PM, James Graham wrote: > On 14/09/17 16:48, Marco Bonardo wrote: > mach try -p linux64 Afaict, that runs a single folder, but the intermittent may be caused by interactions across different tests in different folders. I'm not up-to-date to what we do t

Re: Reminder on Try usage and infrastructure resources

When I need to retrigger a mochitest-browser test multiple times (to investigate an intermittent), often I end up running all the mochitest-browser tests, looking at every log until I find the chunk where the test is, and retrigger just that chunk. The chunk number changes based on the platform and

Re: Triage Summary 2017-08-21

I've seen you started marking unassigned P1s as "stale" and stating their priority will be reset if they stay unassigned. Please don't do that, it's a very bad idea. We are using P1s to have a list of bugs the team should be working on as soon as they have time, and there must be no strict assigne

Re: No information about the related folder in the bookmark manager screen

There's an old bug about this https://bugzilla.mozilla.org/show_bug.cgi?id=469421 but no ETA (I also suspect a Library redesign may happen after Photon) On Sun, May 14, 2017 at 10:34 AM, wrote: > Hi, > > When searching for a bookmark we don't have any information about the > folder. > It could b

Re: Rounding to the jemalloc bucket size

I'm far from being an expert here, but I seem to remember from Storage that we have malloc_good_size On Thu, Apr 27, 2017 at 9:24 AM, Henri Sivonen wrote: > For growable buffer types that internally contain the logical length > (how many slots of the buffer are in use as far as external callers

Re: windows build anti-virus exclusion list?

On Fri, Mar 17, 2017 at 7:20 PM, Ben Kelly wrote: > On Fri, Mar 17, 2017 at 1:36 PM, Ted Mielczarek > wrote: > > With defender > disabled the best I can get is 18min. This is on one of the new lenovo > p710 machines with 16 xeon cores. > Just to add one datapoint, I just replaced my desktop wi

Re: Project Stockwell (reducing intermittents) - March 2017 update

On Wed, Mar 8, 2017 at 2:12 PM, Kartikaya Gupta wrote: > What makes me sad is all the > developers in this thread trying to push back against disabling of > clearly problematic tests, asking for things like tracking bugs and > needinfos, when the reality is that the developers just don't have the

Re: Project Stockwell (reducing intermittents) - March 2017 update

On Tue, Mar 7, 2017 at 8:11 PM, wrote: > Thanks for checking up on this- there are 6 specific bugs that have this > signature in the disabled set- in this case they are all linux32-debug > devtools tests- we disabled devtools on linux32-debug because the runtime > was exceeding in many cases 90 s

Re: Is there a way to improve partial compilation times?

On Tue, Mar 7, 2017 at 8:05 PM, Mike Conley wrote: > FWIW, the MOZ_MAKE_FLAGS bit can probably be removed, as I believe mach > will just choose the optimal number based on examining your processor > cores. >From my experience the chosen value is too conservative, I think it defaults to cpu_coun

Re: Project Stockwell (reducing intermittents) - March 2017 update

On Tue, Mar 7, 2017 at 6:42 PM, Joel Maher wrote: > Thank for pointing that out. In some cases we have fixed tests that are > just timing out, in a few cases we disable because the test typically runs > much faster (i.e. <15 seconds) and is hanging/timing out. In other cases > extending the tim

Re: Project Stockwell (reducing intermittents) - March 2017 update

On Tue, Mar 7, 2017 at 6:34 PM, Marco Bonardo > > In case of mochitest browser tests failing on "This test exceeded the > timeout threshold", the temporary solution after 1 or 2 weeks should be to > add requestLongertimeout,rather than disabling them. They should still be &

Re: Project Stockwell (reducing intermittents) - March 2017 update

On Tue, Mar 7, 2017 at 3:26 PM, wrote: > In recent months we have been triaging high frequency (>=30 times/week) > failures in automated tests. We find that we are fixing 35% of the bugs > and disabling 23% of them. > In case of mochitest browser tests failing on "This test exceeded the timeout

Re: Telemetry Histogram Expiry

Bug 1334617 is taking care of FX_URLBAR_SELECTED_RESULT_INDEX FX_SANITIZE_LOADED_FLASH and FX_SANITIZE_UNLOADED_FLASH can likely be removed, also considering the future of Flash support. I'll file a bug for that. ___ dev-platform mailing list dev-platfor

Re: Visual Studio Code recommended extensions

On Mon, Feb 27, 2017 at 5:12 PM, Dan Mosedale wrote: > It sounds like you find it better than Atom. If that's true, any chance > you could elaborate on what you find particularly nicer and/or what's > missing? > Personally, I find it faster on common operations (starting up, opening documents)

Re: Visual Studio Code recommended extensions

On Thu, Feb 23, 2017 at 6:28 PM, James Graham wrote: > On 23/02/17 16:48, Marco Bonardo wrote: > > // Rust language support. >> "saviorisdead.RustyCode" >> > > I haven't used either (or VS Code much), but my understanding is that is &g

Re: Visual Studio Code recommended extensions

On Thu, Feb 23, 2017 at 5:56 PM, Jared Wein wrote: > Does the ESLint support hook in to the mozilla-eslint configuration? Can > you please update https://developer.mozilla.org/en-US/docs/ESLint or > https://wiki.mozilla.org/DevTools/CodingStandards#JS_linting_with_ESLint > with any steps required

Re: Visual Studio Code recommended extensions

On Thu, Feb 23, 2017 at 6:03 PM, Joe Hildebrand > > // Hilight trailing whitespaces. > > "ybaumes.highlight-trailing-white-spaces", > > This one seems a little aggressive. I'd use it on my code, but on old > broken code, it would be really annoying. > Well, the hilight is very li

Visual Studio Code recommended extensions

Hi, I recently started testing VS Code as a replacement for Sublime Text or Atom, and so far the experience has been better than I was expecting. I suspect others of you are doing the same. In bug 1341585, I'm adding .vscode/settings.json to the ignore lists, so that everyone can create his own wo

Re: Triage Plan for Firefox Components

On Fri, Apr 1, 2016 at 2:02 AM, Emma Humphries wrote: > Priority sounds like a great choice, but given that everyone's using the > Priority field their own way, there's enough heterogeneity in how it's used > to make it difficult. > Fwiw, we (Awesome Search Team) also use Priority for the backlo

Re: To bump mochitest's timeout from 45 seconds to 90 seconds

On Wed, Feb 10, 2016 at 10:30 AM, James Graham wrote: > FWIW I think it's closer to the truth to say that these tests are not set > up to be performance regression tests > Right, but this was just one of the aspects that was pointed out. I think the performance analysis is not much about catchin

Re: To bump mochitest's timeout from 45 seconds to 90 seconds

On Tue, Feb 9, 2016 at 6:54 PM, Ryan VanderMeulen wrote: > I'd have a much easier time accepting that argument if my experience > didn't tell me that nearly every single "Test took longer than expected" or > "Test timed out" intermittent ends with a RequestLongerTimeout as the fix this sounds e

Re: To bump mochitest's timeout from 45 seconds to 90 seconds

On Tue, Feb 9, 2016 at 8:09 PM, Gijs Kruitbosch wrote: > I concur with Ryan here, and I'd add that IME 90% if not more of these > timeouts (where they are really timeouts because the test is long, rather > than just brokenness in the test that leaves it hanging until the timeout) > happen on debu

Re: To bump mochitest's timeout from 45 seconds to 90 seconds

90 seconds for a simple test sounds like a lot of time and a huge bump from the current situation (45). The risk is people will start writing much bigger tests instead of splitting them into smaller an more manageable tests. Plus when a test depends on a long timeout in the product, developers are

Re: Bug Program Next Steps

On Sat, Jan 30, 2016 at 12:45 AM, Emma Humphries wrote: > Looking at the urgent bugs does not have to be one person’s task. You can > have a rotation of people doing this. Look at the Core::Graphics > triage wiki for an > example of what you

Re: Just Autoland It

checkin? is also used for large multi-patch bugs that land parts at different times. On Fri, Jan 22, 2016 at 3:38 PM, Paolo Amadini wrote: > On 1/22/2016 2:00 PM, Mark Hammond wrote: > >> (Hopefully) related - what exactly is the "checkin?" flag for? >> > > As far as I understand, it's used toge

Re: Migrating defaults from other browsers

On 19/01/2015 13:58, Henri Sivonen wrote: I think this leads to a more general question: Is it really a good idea that our profile migrators migrate settings from other browsers when those settings have been left to the defaults of those browsers? Note that we don't migrate IE prefs if they hav

Re: e10s is now enabled by default for Nightly!

On 07/11/2014 18:05, ch...@pointlessone.org wrote: My nightly crashes on start. Well, that's fine and is expected from unstable software. But now that I've submitted a half a dozen crash reports which pref do I flip to continue using my browser? Hold down shift when launching Firefox to ente

Re: e10s is now enabled by default for Nightly!

On 07/11/2014 10:40, Gijs Kruitbosch wrote: Where can we read about how this decision was made? On my profiles with Force RTL, e10s perma-crashes ( https://bugzilla.mozilla.org/show_bug.cgi?id=1072980 ), and in most other cases, I only ever see spinners for remote content (ie can't actually brows

Re: Announcing MozillaBuild 1.9.0 Release

On 03/04/2014 15:44, Ryan VanderMeulen wrote:> After a long delay and lots of hard work by 7 different contributors, I am pleased to announce the final release of MozillaBuild 1.9.0. Awesome, good job! I was using the pre-release from quite some time on win8.1 and VS2013, thanks for making it

Re: Too many system compartments at start-up

On 21/03/2014 15:37, Benjamin Smedberg wrote: On 3/21/2014 10:34 AM, Marco Bonardo wrote: Or directly make Cu.import act like defineLazyModuleGetter... Would that be possible? I don't think that's a good idea. It's not an uncommon pattern to try/catch around a module import i

Re: Too many system compartments at start-up

I started filing some low-hanging-fruit dependencies, though, looks like one of the main culprit is modules that are Cu.import-ed instead of defineLazyModuleGetter-ed. I wonder if we could somehow instrument Cu.import so that if a module is not used before N seconds (or M ticks?) from when it

Re: ISomething, nsISomething or mozISomething?

On 17/02/2014 15:15, David Rajchenbach-Teller wrote: Do we have naming conventions for new xpcom interfaces? I believe that I have seen all three forms on the tree. I need to pick one for my new bug. Which one should I pick? afaik there has been a period where we tried to move off of nsI prefi

Re: reminder: content processes (e10s) are now used by desktop Firefox

On 02/08/2013 03:50, Nicholas Nethercote wrote: On Thu, Aug 1, 2013 at 6:29 PM, Gavin Sharp wrote: Do you have specific issues you're worried about, or are you just speaking about issues in general? This AdBlock issue worries me specifically. And the fact that there's breakage with our #1 a

Re: Rethinking separate Mercurial repositories

On 31/07/2013 13:14, Ben Hearsum wrote: On 07/31/13 05:54 AM, Marco Bonardo wrote: Now, maybe I'm wrong, but IIRC this is what we had before the rapid release, and we switched away from that cause: Releases have always had their own repositories (see https://hg.mozilla.org/releases/mo

Re: Rethinking separate Mercurial repositories

On 29/07/2013 19:43, Gregory Szorc wrote: I'm proposing that we merge all the release repositories (central, aurora, beta, release, esr, and b2g) into a single Mercurial repository. The "default" branch/bookmark of this repository would be the equivalent of mozilla-central. At train uplift time,

Re: Possibility of replacing SQLite with LMDB from the OpenLDAP project (or replacing the SQLite backend with LMDB)

On 18/07/2013 20:34, highland...@gmail.com wrote: As for many other dbms around, comparisons are pretty much hard, just relying on microbenchmarking doesn't help much. What's best, LMDB, levelDB, kyotoCabinet, Sqlite4? It's hard to tell just by looking at these graphs, you'd need measurements don

Re: suggested reviewers for bugzilla products and components

On 18/07/2013 15:33, Byron Jones wrote: i have created an initial list on an etherpad using the module owners' wiki page as a source: https://bmo.etherpad.mozilla.org/suggested-reviewers please review and update this document where appropriate. Looks like most of Toolkit is missing. Is there

Re: Possibility of replacing SQLite with LMDB from the OpenLDAP project (or replacing the SQLite backend with LMDB)

On 06/07/2013 11:26, Philip Chee wrote: "LMDB is an ultra-fast, ultra-compact key-value data store developed by Symas for the OpenLDAP Project. It uses memory-mapped files, so it has the read performance of a pure in-memory database while still offering the persistence of standard disk-based data

Re: Storage in Gecko

On 06/05/2013 18:41, David Dahl wrote:> KyotoCabinet might make a good backend for a new storage API: http://fallabs.com/kyotocabinet/ There is also a companion indexing engine: http://fallabs.com/kyototycoon/ Regards, David SQLite4 implements something very similar (log-structured merge d

Re: Storage in Gecko

On 26/04/2013 22:18, Andrew Sutherland wrote: Specifically, it does not look like IndexedDB's model; it still does a lot of fsync's in order to maintain the requisite SQL ACID semantics. Right, we can't expect miracles just by moving from SQLite3 to SQLite4, though it still uses an enhanced WA

Re: Landing on Trunk - Target Milestone vs. Status Flag Usage vs. Tracking for Future Releases

On 11/04/2013 18:23, Steve Fink wrote: The name "target milestone" implies an aspirational landing. Should we just change the bug template to change the name of the field? It could make sense, my understanding is that we started using it in the lack of better options, and has become a de-facto

Re: Landing on Trunk - Target Milestone vs. Status Flag Usage vs. Tracking for Future Releases

On 11/04/2013 07:22, Justin Dolske wrote: > I'd question if we really need to keep Target Milestone at all (given > replacements for how it's used now). We don't have replacements for "fixed from this version on", so far, as Alex well explained. > I don't see many Firefox/Gecko > teams using

Re: Notice of browser and toolkit theme renamings

On 26/02/2013 12:58, Mounir Lamouri wrote: On 23/02/13 07:25, Jared Wein wrote: I wanted to let you all know about bug 842913, of which I just landed the patch for on mozilla-inbound. Is themes/linux/ agnostic of the library being used (aka GTK vs QT)? -- Mounir See bug 844597 (https:/

Re: mozilla-central/inbound closed -- we hit the Windows PGO memory limit

On 22/01/2013 15:36, Benjamin Smedberg wrote: On 1/22/2013 9:28 AM, Axel Hecht wrote: How are the perf numbers looking? One of the reasons for asking is that I expect RDF to be part of the startup and window-open codepaths, at least. I would not expect PGO to optimize any of the RDF code for s

Re: mozilla-central/inbound closed -- we hit the Windows PGO memory limit

On 21/01/2013 21:47, Ehsan Akhgari wrote: 1. mozilla-central/inbound will remain closed to all check-ins except the ones that do not add any code which gets linked into libxul on Windows. Both inbound and central are APPROVAL REQUIRED as of now, any patches that don't touch libxul can land wit