Re: Please don't abuse "No bug" in commit messages

2017-02-06 Thread Steve Fink
On 02/06/2017 08:19 AM, Mike Hoye wrote: On 2017-02-03 2:01 PM, Steve Fink wrote: Typo/whitespace - No bug is fine, but if it is associated with a recent landing of some bug, then you should use that bug number anyway. Makes uplifts cleaner. Whitespace errors seem like a wierd thing for an

Re: Please don't abuse "No bug" in commit messages

2017-02-06 Thread Mike Hoye
On 2017-02-03 2:01 PM, Steve Fink wrote: Typo/whitespace - No bug is fine, but if it is associated with a recent landing of some bug, then you should use that bug number anyway. Makes uplifts cleaner. Whitespace errors seem like a wierd thing for an engineer to be working on?. Code cleanup

Re: Please don't abuse "No bug" in commit messages

2017-02-03 Thread Karl Tomlinson
Gijs Kruitbosch writes: >> What if it causes a regression and a blocking bug needs to be filed? > Then you file a bug and needinfo the person who landed the commit > (which one would generally do anyway, besides just marking it > blocking the regressor). I find the association of multiple

Re: Please don't abuse "No bug" in commit messages

2017-02-03 Thread David Burns
Ideally we would be doing it in a way that we can audit things quickly in the case we think a bad actor has compromised someone's machine. While we can say what we want and how we want the process, we need to work with what we have until we have a better process. This could be between now and the

Re: Please don't abuse "No bug" in commit messages

2017-02-03 Thread Emma Humphries
Thanks for checking the developer guidelines and making sure they are consistent. I'd like to hear a little more about: branch merges - … I personally wish that especially significant merges *did* have bugs to make it a little easier to track problems back to a branch landing and have a place

Re: Please don't abuse "No bug" in commit messages

2017-02-03 Thread Steve Fink
On 02/03/2017 09:29 AM, Gijs Kruitbosch wrote: On 03/02/2017 15:11, Ryan VanderMeulen wrote: A friendly reminder that per the MDN commit rules, the use of "No bug" in the commit message is to be used sparingly - in general for minor things like whitespace changes/comment fixes/etc where

Re: Please don't abuse "No bug" in commit messages

2017-02-03 Thread Gijs Kruitbosch
On 03/02/2017 15:11, Ryan VanderMeulen wrote: A friendly reminder that per the MDN commit rules, the use of "No bug" in the commit message is to be used sparingly - in general for minor things like whitespace changes/comment fixes/etc where traceability isn't as important.

Re: Please don't abuse "No bug" in commit messages

2017-02-03 Thread Gregory Szorc
On Fri, Feb 3, 2017 at 7:11 AM, Ryan VanderMeulen wrote: > A friendly reminder that per the MDN commit rules, the use of "No bug" in > the commit message is to be used sparingly - in general for minor things > like whitespace changes/comment fixes/etc where

Re: Please don't abuse "No bug" in commit messages

2017-02-03 Thread David Burns
I have raised a bug[1] to block these types of commits in the future. This is an unnecessary risk that we are taking. I also think that we need to remove this as acceptable practice from the MDN page. David [1] https://bugzilla.mozilla.org/show_bug.cgi?id=1336459 On 3 February 2017 at 15:11,

Please don't abuse "No bug" in commit messages

2017-02-03 Thread Ryan VanderMeulen
A friendly reminder that per the MDN commit rules, the use of "No bug" in the commit message is to be used sparingly - in general for minor things like whitespace changes/comment fixes/etc where traceability isn't as important.